Re: [Mesa-dev] [PATCH] radv/nir: avoid packing vertex outputs we can eliminate

2018-11-06 Thread Timothy Arceri
On 7/11/18 7:40 am, Timothy Arceri wrote: On 7/11/18 5:00 am, Eric Anholt wrote: Timothy Arceri writes: On Mon, Nov 5, 2018, at 4:44 PM, Timothy Arceri wrote: On 6/11/18 11:30 am, Eric Anholt wrote: Timothy Arceri writes: For now I have only enabled this for RADV we can do it also for

Re: [Mesa-dev] [PATCH] radv/nir: avoid packing vertex outputs we can eliminate

2018-11-06 Thread Timothy Arceri
On 7/11/18 5:00 am, Eric Anholt wrote: Timothy Arceri writes: On Mon, Nov 5, 2018, at 4:44 PM, Timothy Arceri wrote: On 6/11/18 11:30 am, Eric Anholt wrote: Timothy Arceri writes: For now I have only enabled this for RADV we can do it also for radeonsi also but we need to add a CAP for it

Re: [Mesa-dev] [PATCH] radv/nir: avoid packing vertex outputs we can eliminate

2018-11-06 Thread Eric Anholt
Timothy Arceri writes: > On Mon, Nov 5, 2018, at 4:44 PM, Timothy Arceri wrote: >> On 6/11/18 11:30 am, Eric Anholt wrote: >> > Timothy Arceri writes: >> > >> >> For now I have only enabled this for RADV we can do it >> >> also for radeonsi also but we need to add a CAP for it. >> > >> > If we

Re: [Mesa-dev] [PATCH] radv/nir: avoid packing vertex outputs we can eliminate

2018-11-05 Thread Timothy Arceri
On Mon, Nov 5, 2018, at 4:44 PM, Timothy Arceri wrote: > On 6/11/18 11:30 am, Eric Anholt wrote: > > Timothy Arceri writes: > > > >> For now I have only enabled this for RADV we can do it > >> also for radeonsi also but we need to add a CAP for it. > > > > If we're doing this at link time, why n

Re: [Mesa-dev] [PATCH] radv/nir: avoid packing vertex outputs we can eliminate

2018-11-05 Thread Timothy Arceri
On 6/11/18 11:30 am, Eric Anholt wrote: Timothy Arceri writes: For now I have only enabled this for RADV we can do it also for radeonsi also but we need to add a CAP for it. If we're doing this at link time, why not push the constant value from the producer into the consumer shader and then

Re: [Mesa-dev] [PATCH] radv/nir: avoid packing vertex outputs we can eliminate

2018-11-05 Thread Eric Anholt
Timothy Arceri writes: > For now I have only enabled this for RADV we can do it > also for radeonsi also but we need to add a CAP for it. If we're doing this at link time, why not push the constant value from the producer into the consumer shader and then cut out the varying entirely? signatur

[Mesa-dev] [PATCH] radv/nir: avoid packing vertex outputs we can eliminate

2018-10-31 Thread Timothy Arceri
For now I have only enabled this for RADV we can do it also for radeonsi also but we need to add a CAP for it. vkpipeline-db results: Totals from affected shaders: SGPRS: 4104 -> 3728 (-9.16 %) VGPRS: 3604 -> 3472 (-3.66 %) Spilled SGPRs: 0 -> 0 (0.00 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private mem