Re: [Mesa-dev] [PATCH] radeonsi: add support for ARB_texture_view

2015-10-20 Thread Marek Olšák
On Tue, Oct 20, 2015 at 5:26 PM, Ilia Mirkin wrote: > On Sat, Oct 17, 2015 at 9:09 AM, Marek Olšák wrote: >> + /* This is not needed if state trackers set last_layer correctly. */ >> + if (state->target == PIPE_TEXTURE_1D || >> + state->target == PIPE_TEXTURE_2D || >> +

Re: [Mesa-dev] [PATCH] radeonsi: add support for ARB_texture_view

2015-10-20 Thread Ilia Mirkin
On Sat, Oct 17, 2015 at 9:09 AM, Marek Olšák wrote: > + /* This is not needed if state trackers set last_layer correctly. */ > + if (state->target == PIPE_TEXTURE_1D || > + state->target == PIPE_TEXTURE_2D || > + state->target == PIPE_TEXTURE_RECT || > + s

Re: [Mesa-dev] [PATCH] radeonsi: add support for ARB_texture_view

2015-10-20 Thread Marek Olšák
On Tue, Oct 20, 2015 at 9:42 AM, Michel Dänzer wrote: > On 17.10.2015 22:09, Marek Olšák wrote: >> From: Marek Olšák >> >> All tests pass. We don't need to do much - just set CUBE if the view >> target is CUBE or CUBE_ARRAY, otherwise set the resource target. >> >> The reason this is so simple ca

Re: [Mesa-dev] [PATCH] radeonsi: add support for ARB_texture_view

2015-10-20 Thread Michel Dänzer
On 17.10.2015 22:09, Marek Olšák wrote: > From: Marek Olšák > > All tests pass. We don't need to do much - just set CUBE if the view > target is CUBE or CUBE_ARRAY, otherwise set the resource target. > > The reason this is so simple can be that texture instructions > have a greater effect on the

Re: [Mesa-dev] [PATCH] radeonsi: add support for ARB_texture_view

2015-10-17 Thread Marek Olšák
On Sat, Oct 17, 2015 at 6:45 PM, Laurent Carlier wrote: > Le Saturday 17 October 2015, 15:09:13 Marek Olšák a écrit : >> From: Marek Olšák >> >> All tests pass. We don't need to do much - just set CUBE if the view >> target is CUBE or CUBE_ARRAY, otherwise set the resource target. >> >> The reaso

Re: [Mesa-dev] [PATCH] radeonsi: add support for ARB_texture_view

2015-10-17 Thread Laurent Carlier
Le Saturday 17 October 2015, 15:09:13 Marek Olšák a écrit : > From: Marek Olšák > > All tests pass. We don't need to do much - just set CUBE if the view > target is CUBE or CUBE_ARRAY, otherwise set the resource target. > > The reason this is so simple can be that texture instructions > have a g

[Mesa-dev] [PATCH] radeonsi: add support for ARB_texture_view

2015-10-17 Thread Marek Olšák
From: Marek Olšák All tests pass. We don't need to do much - just set CUBE if the view target is CUBE or CUBE_ARRAY, otherwise set the resource target. The reason this is so simple can be that texture instructions have a greater effect on the target than the sampler view. Thanks Glenn for the p