Re: [Mesa-dev] [PATCH] r600g: Implement GL_ARB_texture_gather

2014-07-16 Thread Ilia Mirkin
On Wed, Jul 16, 2014 at 9:53 AM, Glenn Kennard wrote: > Only supported on evergreen and later. Currently limited > to single component textures as the hardware GATHER4 > instruction ignores texture swizzles. > > Piglit quick run passes on radeon 6670 with all > applicable textureGather tests, no r

[Mesa-dev] [PATCH] r600g: Implement GL_ARB_texture_gather

2014-07-16 Thread Glenn Kennard
Only supported on evergreen and later. Currently limited to single component textures as the hardware GATHER4 instruction ignores texture swizzles. Piglit quick run passes on radeon 6670 with all applicable textureGather tests, no regressions. Signed-off-by: Glenn Kennard --- Changes from v1: R

Re: [Mesa-dev] [PATCH] r600g: Implement GL_ARB_texture_gather

2014-07-14 Thread Marek Olšák
My advice is: The shader being compiled should be analyzed before compilation and an array of bool flags (or one uint16_t for all flags) should be produced saying which sampler units use TG4. Then, you only need to set the swizzle in the key for the i-th sampler if the i-th sampler is really used b

Re: [Mesa-dev] [PATCH] r600g: Implement GL_ARB_texture_gather

2014-07-14 Thread Dave Airlie
>> Also, have you looked at Dave Airlie's impl? Not sure what's been >> going on there... >> http://cgit.freedesktop.org/~airlied/mesa/log/?h=r600g-texture-gather >> . He seemed to enable 4 components for >= CEDAR. >> > > No, didn't pop up when i searched the archives for any prior work on this. >

Re: [Mesa-dev] [PATCH] r600g: Implement GL_ARB_texture_gather

2014-07-14 Thread Glenn Kennard
On Mon, 14 Jul 2014 20:33:08 +0200, Ilia Mirkin wrote: On Mon, Jul 14, 2014 at 2:20 PM, Glenn Kennard wrote: diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index ca6399f..d967f0f 100644 --- a/src/gallium/drivers/r600/r600_pipe.c +++ b/src/gallium

Re: [Mesa-dev] [PATCH] r600g: Implement GL_ARB_texture_gather

2014-07-14 Thread Marek Olšák
Hm, indeed. PIPE_CAP_TEXTURE_GATHER_SM5 should be 0. Marek On Mon, Jul 14, 2014 at 9:10 PM, Ilia Mirkin wrote: > On Mon, Jul 14, 2014 at 3:06 PM, Marek Olšák wrote: >> Reviewed-by: Marek Olšák >> >> Yes, Dave Airlie's branch seems to support multi-component textures as >> well as texture offse

Re: [Mesa-dev] [PATCH] r600g: Implement GL_ARB_texture_gather

2014-07-14 Thread Ilia Mirkin
On Mon, Jul 14, 2014 at 3:06 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Yes, Dave Airlie's branch seems to support multi-component textures as > well as texture offsets. However, his solution triggers shader > recompilation when the format and/or swizzle is changed even if the > shader

Re: [Mesa-dev] [PATCH] r600g: Implement GL_ARB_texture_gather

2014-07-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Yes, Dave Airlie's branch seems to support multi-component textures as well as texture offsets. However, his solution triggers shader recompilation when the format and/or swizzle is changed even if the shader doesn't use GATHER4. The recompilation should only be done for

Re: [Mesa-dev] [PATCH] r600g: Implement GL_ARB_texture_gather

2014-07-14 Thread Ilia Mirkin
On Mon, Jul 14, 2014 at 2:20 PM, Glenn Kennard wrote: > Only supported on evergreen and later. Limited to > single component textures as the hardware GATHER4 > instruction ignores texture swizzles. > > Piglit quick run passes on radeon 6670 with all > applicable textureGather tests, no regressions

[Mesa-dev] [PATCH] r600g: Implement GL_ARB_texture_gather

2014-07-14 Thread Glenn Kennard
Only supported on evergreen and later. Limited to single component textures as the hardware GATHER4 instruction ignores texture swizzles. Piglit quick run passes on radeon 6670 with all applicable textureGather tests, no regressions. Signed-off-by: Glenn Kennard --- docs/GL3.txt