Re: [Mesa-dev] [PATCH] nir: remove old assert

2018-02-21 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Wed, 2018-02-21 at 14:42 +1100, Timothy Arceri wrote: > This was originally intended to make sure the remap location > was not -1. However the code has changed alot since then, > the location is now never set to -1 and we also handle > components meaning this ol

Re: [Mesa-dev] [PATCH] nir: remove old assert

2018-02-20 Thread Ian Romanick
That makes sense. I guess whoever changed that aspect didn't remove the assert. I only noticed it because I build with -Wextra, so it's not surprising that nobody else noticed. Reviewed-by: Ian Romanick On 02/20/2018 07:42 PM, Timothy Arceri wrote: > This was originally intended to make sure t

[Mesa-dev] [PATCH] nir: remove old assert

2018-02-20 Thread Timothy Arceri
This was originally intended to make sure the remap location was not -1. However the code has changed alot since then, the location is now never set to -1 and we also handle components meaning this old assert has been doing comparisions with the pointer to the array of component data. Bugzilla: ht