Re: [Mesa-dev] [PATCH] mesa: tidy up renderbuffer RefCount initialisation

2017-04-06 Thread Timothy Arceri
On 07/04/17 05:10, Bartosz Tomczyk wrote: Timothy, I observe huge memory leak after this commit: Hi, Thanks for reporting. This patch should fix the problem: https://patchwork.freedesktop.org/patch/148926/ Direct leak of 648208 byte(s) in 3683 object(s) allocated from: #0 0x7f3d7

Re: [Mesa-dev] [PATCH] mesa: tidy up renderbuffer RefCount initialisation

2017-04-06 Thread Bartosz Tomczyk
Timothy, I observe huge memory leak after this commit: Direct leak of 648208 byte(s) in 3683 object(s) allocated from: #0 0x7f3d72729800 in calloc (/usr/lib/clang/3.9.1/lib/linux/ libclang_rt.asan-x86_64.so+0xf6800) #1 0x7f3d64a4d114 in st_new_renderbuffer /home/bartek/Devel/mesa/src/mesa

Re: [Mesa-dev] [PATCH] mesa: tidy up renderbuffer RefCount initialisation

2017-04-05 Thread Brian Paul
On 04/05/2017 05:06 AM, Timothy Arceri wrote: 42aaa548 changed the renderbuffer initialisation of RefCount from 1 to 0. This is inconsitent with how we use RefCount elsewhere. Also every driver implementation of NewRenderbuffer() calls _mesa_init_renderbuffer() so its safe to set it there. ---

[Mesa-dev] [PATCH] mesa: tidy up renderbuffer RefCount initialisation

2017-04-05 Thread Timothy Arceri
42aaa548 changed the renderbuffer initialisation of RefCount from 1 to 0. This is inconsitent with how we use RefCount elsewhere. Also every driver implementation of NewRenderbuffer() calls _mesa_init_renderbuffer() so its safe to set it there. --- src/mesa/drivers/common/meta.c | 2 -- src/mesa/