Re: [Mesa-dev] [PATCH] mesa: sanitize input stencil mask values

2016-12-22 Thread Haixia Shi
Kenneth Thank you for the commit info. Please consider this patch abandoned. On Thu, Dec 22, 2016 at 11:50 AM, Kenneth Graunke wrote: > On Thursday, December 22, 2016 10:47:46 AM PST Haixia Shi wrote: > > Hello Mesa-Dev: > > > > To give you some background, we are observing that mask values get

Re: [Mesa-dev] [PATCH] mesa: sanitize input stencil mask values

2016-12-22 Thread Kenneth Graunke
On Thursday, December 22, 2016 10:47:46 AM PST Haixia Shi wrote: > Hello Mesa-Dev: > > To give you some background, we are observing that mask values getting > converted to -1 when running multiple dEQP-GLES31 tests in sequence. > > There's already a previous commit > (b8b1d83c71fd148d2fd84afdc20

Re: [Mesa-dev] [PATCH] mesa: sanitize input stencil mask values

2016-12-22 Thread Haixia Shi
Hello Mesa-Dev: To give you some background, we are observing that mask values getting converted to -1 when running multiple dEQP-GLES31 tests in sequence. There's already a previous commit (b8b1d83c71fd148d2fd84afdc20c0aa367114f92) that attempted to address the test failures by initializing all

[Mesa-dev] [PATCH] mesa: sanitize input stencil mask values

2016-12-22 Thread Haixia Shi
Since the maximum supported precision for stencil buffers is 8 bits, we should set bits 8:31 in the input mask values to zero. The problem is that dEQP tests intentionally call glStencilFunc() with mask values of ~0U (0xU) which overflows to -1 when converted to signed integer by glGet* AP