Re: [Mesa-dev] [PATCH] mesa: initialize renderbuffer fields even if AllocStorage fails

2012-05-18 Thread Brian Paul
On 05/17/2012 07:20 AM, Marek Olšák wrote: On Mon, May 14, 2012 at 6:59 PM, Brian Paul wrote: On 05/14/2012 10:44 AM, Marek Olšák wrote: On Mon, May 14, 2012 at 4:40 PM, Brian Paulwrote: On 05/12/2012 10:11 AM, Marek Olšák wrote: It may fail with an unsupported format, but that's not

Re: [Mesa-dev] [PATCH] mesa: initialize renderbuffer fields even if AllocStorage fails

2012-05-17 Thread Marek Olšák
On Thu, May 17, 2012 at 3:34 PM, Brian Paul wrote: > On 05/17/2012 07:20 AM, Marek Olšák wrote: >> >> On Mon, May 14, 2012 at 6:59 PM, Brian Paul  wrote: >>> >>> On 05/14/2012 10:44 AM, Marek Olšák wrote: On Mon, May 14, 2012 at 4:40 PM, Brian Paul    wrote: > > > On 05/

Re: [Mesa-dev] [PATCH] mesa: initialize renderbuffer fields even if AllocStorage fails

2012-05-17 Thread Brian Paul
On 05/17/2012 07:20 AM, Marek Olšák wrote: On Mon, May 14, 2012 at 6:59 PM, Brian Paul wrote: On 05/14/2012 10:44 AM, Marek Olšák wrote: On Mon, May 14, 2012 at 4:40 PM, Brian Paulwrote: On 05/12/2012 10:11 AM, Marek Olšák wrote: It may fail with an unsupported format, but that's not

Re: [Mesa-dev] [PATCH] mesa: initialize renderbuffer fields even if AllocStorage fails

2012-05-17 Thread Marek Olšák
On Mon, May 14, 2012 at 6:59 PM, Brian Paul wrote: > On 05/14/2012 10:44 AM, Marek Olšák wrote: >> >> On Mon, May 14, 2012 at 4:40 PM, Brian Paul  wrote: >>> >>> On 05/12/2012 10:11 AM, Marek Olšák wrote: It may fail with an unsupported format, but that's not an allowed case wh

Re: [Mesa-dev] [PATCH] mesa: initialize renderbuffer fields even if AllocStorage fails

2012-05-14 Thread Brian Paul
On 05/14/2012 10:59 AM, Brian Paul wrote: On 05/14/2012 10:44 AM, Marek Olšák wrote: On Mon, May 14, 2012 at 4:40 PM, Brian Paul wrote: On 05/12/2012 10:11 AM, Marek Olšák wrote: It may fail with an unsupported format, but that's not an allowed case where RenderbufferStorage may fail. I've

Re: [Mesa-dev] [PATCH] mesa: initialize renderbuffer fields even if AllocStorage fails

2012-05-14 Thread Brian Paul
On 05/14/2012 10:44 AM, Marek Olšák wrote: On Mon, May 14, 2012 at 4:40 PM, Brian Paul wrote: On 05/12/2012 10:11 AM, Marek Olšák wrote: It may fail with an unsupported format, but that's not an allowed case where RenderbufferStorage may fail. I've read your comment several times but I sti

Re: [Mesa-dev] [PATCH] mesa: initialize renderbuffer fields even if AllocStorage fails

2012-05-14 Thread Marek Olšák
On Mon, May 14, 2012 at 4:40 PM, Brian Paul wrote: > On 05/12/2012 10:11 AM, Marek Olšák wrote: >> >> It may fail with an unsupported format, but that's not an allowed case >> where >> RenderbufferStorage may fail. > > > I've read your comment several times but I still can't quite understand the >

Re: [Mesa-dev] [PATCH] mesa: initialize renderbuffer fields even if AllocStorage fails

2012-05-14 Thread Brian Paul
On 05/12/2012 10:11 AM, Marek Olšák wrote: It may fail with an unsupported format, but that's not an allowed case where RenderbufferStorage may fail. I've read your comment several times but I still can't quite understand the whole issue. The intention was that AllocStorage() should never fa

[Mesa-dev] [PATCH] mesa: initialize renderbuffer fields even if AllocStorage fails

2012-05-12 Thread Marek Olšák
It may fail with an unsupported format, but that's not an allowed case where RenderbufferStorage may fail. And on success, we should return valid values from GetRenderbufferParameteriv. This fixes piglit: get-renderbuffer-internalformat --- src/mesa/main/fbobject.c | 18 +- 1 fi