Re: [Mesa-dev] [PATCH] mesa: fix maximum allowed proxy texture size condition

2012-02-09 Thread Anuj Phogat
On Thu, Feb 9, 2012 at 1:07 PM, Brian Paul wrote: > On 02/09/2012 01:57 PM, Brian Paul wrote: > >> On 02/09/2012 12:15 PM, Anuj Phogat wrote: >> >>> On Thu, Feb 9, 2012 at 11:02 AM, Ian Romanick >> > wrote: >>> >>> On 02/09/2012 08:14 AM, Brian Paul wrote: >>> >>> Anu

Re: [Mesa-dev] [PATCH] mesa: fix maximum allowed proxy texture size condition

2012-02-09 Thread Brian Paul
On 02/09/2012 01:57 PM, Brian Paul wrote: On 02/09/2012 12:15 PM, Anuj Phogat wrote: On Thu, Feb 9, 2012 at 11:02 AM, Ian Romanick mailto:i...@freedesktop.org>> wrote: On 02/09/2012 08:14 AM, Brian Paul wrote: Anuj, The patch you committed (15986d2), the first version you posted that tests:

Re: [Mesa-dev] [PATCH] mesa: fix maximum allowed proxy texture size condition

2012-02-09 Thread Brian Paul
On 02/09/2012 12:15 PM, Anuj Phogat wrote: On Thu, Feb 9, 2012 at 11:02 AM, Ian Romanick mailto:i...@freedesktop.org>> wrote: On 02/09/2012 08:14 AM, Brian Paul wrote: Anuj, The patch you committed (15986d2), the first version you posted that tests: if (wid

Re: [Mesa-dev] [PATCH] mesa: fix maximum allowed proxy texture size condition

2012-02-09 Thread Anuj Phogat
On Thu, Feb 9, 2012 at 11:02 AM, Ian Romanick wrote: > On 02/09/2012 08:14 AM, Brian Paul wrote: > >> Anuj, >> >> The patch you committed (15986d2), the first version you posted that >> tests: >> >> if (width < 2 * border || width > maxSize) >> return GL_FALSE; >> >> causes my copy of conform (mu

Re: [Mesa-dev] [PATCH] mesa: fix maximum allowed proxy texture size condition

2012-02-09 Thread Ian Romanick
On 02/09/2012 08:14 AM, Brian Paul wrote: Anuj, The patch you committed (15986d2), the first version you posted that tests: if (width < 2 * border || width > maxSize) return GL_FALSE; causes my copy of conform (mustpass.c / proxy texture test) to fail with swrast/softpipe/llvmpipe. It passes w

Re: [Mesa-dev] [PATCH] mesa: fix maximum allowed proxy texture size condition

2012-02-09 Thread Brian Paul
Anuj, The patch you committed (15986d2), the first version you posted that tests: if (width < 2 * border || width > maxSize) return GL_FALSE; causes my copy of conform (mustpass.c / proxy texture test) to fail with swrast/softpipe/llvmpipe. It passes w/ NVIDIA's driver. I t

Re: [Mesa-dev] [PATCH] mesa: fix maximum allowed proxy texture size condition

2012-02-02 Thread Anuj Phogat
On Wed, Feb 1, 2012 at 12:52 PM, Jose Fonseca wrote: > > > - Original Message - > > On 01/28/2012 04:04 AM, Jose Fonseca wrote: > > > > > > > > > - Original Message - > > >> width, height parameter of glTexImage2D() includes: texture image > > >> width + 2 * border (if any). So wh

Re: [Mesa-dev] [PATCH] mesa: fix maximum allowed proxy texture size condition

2012-02-01 Thread Jose Fonseca
- Original Message - > On 01/28/2012 04:04 AM, Jose Fonseca wrote: > > > > > > - Original Message - > >> width, height parameter of glTexImage2D() includes: texture image > >> width + 2 * border (if any). So when doing the texture size check > >> in _mesa_test_proxy_teximage() wid

Re: [Mesa-dev] [PATCH] mesa: fix maximum allowed proxy texture size condition

2012-02-01 Thread Ian Romanick
On 01/28/2012 04:04 AM, Jose Fonseca wrote: - Original Message - width, height parameter of glTexImage2D() includes: texture image width + 2 * border (if any). So when doing the texture size check in _mesa_test_proxy_teximage() width and height should not exceed maximum supported size

Re: [Mesa-dev] [PATCH] mesa: fix maximum allowed proxy texture size condition

2012-01-30 Thread Brian Paul
On Mon, Jan 30, 2012 at 12:52 PM, Anuj Phogat wrote: > width, height parameter of glTexImage2D() includes: texture image > width + 2 * border (if any). So when doing the texture size check > in _mesa_test_proxy_teximage() width and height should not exceed > maximum supported size for target textu

[Mesa-dev] [PATCH] mesa: fix maximum allowed proxy texture size condition

2012-01-30 Thread Anuj Phogat
width, height parameter of glTexImage2D() includes: texture image width + 2 * border (if any). So when doing the texture size check in _mesa_test_proxy_teximage() width and height should not exceed maximum supported size for target texture type + 2 * border. i.e. 1 << (ctx->Const.MaxTextureLevels -

Re: [Mesa-dev] [PATCH] mesa: fix maximum allowed proxy texture size condition

2012-01-28 Thread Jose Fonseca
- Original Message - > width, height parameter of glTexImage2D() includes: texture image > width + 2 * border (if any). So when doing the texture size check > in _mesa_test_proxy_teximage() width and height should not exceed > maximum supported size for target texture type. > i.e. 1 << (c

[Mesa-dev] [PATCH] mesa: fix maximum allowed proxy texture size condition

2012-01-27 Thread Anuj Phogat
width, height parameter of glTexImage2D() includes: texture image width + 2 * border (if any). So when doing the texture size check in _mesa_test_proxy_teximage() width and height should not exceed maximum supported size for target texture type. i.e. 1 << (ctx->Const.MaxTextureLevels - 1) This pat