Re: [Mesa-dev] [PATCH] mesa: check if any of the named builtins are available first

2017-07-05 Thread Kenneth Graunke
On Monday, July 3, 2017 2:08:12 PM PDT Ilia Mirkin wrote: > _mesa_glsl_has_builtin_function is used to determine whether any variant > of a builtin are available, for the purpose of enforcing the GLSL ES > 3.00+ rule that overloads or overrides of builtins are disallowed. > > However the builtin_b

Re: [Mesa-dev] [PATCH] mesa: check if any of the named builtins are available first

2017-07-03 Thread Lionel Landwerlin
Looks good to me, but admittedly not an expert. Acked-by: Lionel Landwerlin On 03/07/17 22:08, Ilia Mirkin wrote: _mesa_glsl_has_builtin_function is used to determine whether any variant of a builtin are available, for the purpose of enforcing the GLSL ES 3.00+ rule that overloads or overrides

Re: [Mesa-dev] [PATCH] mesa: check if any of the named builtins are available first

2017-07-03 Thread Timothy Arceri
On 04/07/17 08:11, Ilia Mirkin wrote: Yeah I'll add a compiler test. Thanks :) Reviewed-by: Timothy Arceri On Mon, Jul 3, 2017 at 6:02 PM, Timothy Arceri wrote: This seems reasonable, but are there some piglit tests to go with this? I didn't see any on the list. At least one test for thi

Re: [Mesa-dev] [PATCH] mesa: check if any of the named builtins are available first

2017-07-03 Thread Ilia Mirkin
Yeah I'll add a compiler test. On Mon, Jul 3, 2017 at 6:02 PM, Timothy Arceri wrote: > This seems reasonable, but are there some piglit tests to go with this? I > didn't see any on the list. At least one test for this would be nice. > > > On 04/07/17 07:08, Ilia Mirkin wrote: >> >> _mesa_glsl_has

Re: [Mesa-dev] [PATCH] mesa: check if any of the named builtins are available first

2017-07-03 Thread Timothy Arceri
This seems reasonable, but are there some piglit tests to go with this? I didn't see any on the list. At least one test for this would be nice. On 04/07/17 07:08, Ilia Mirkin wrote: _mesa_glsl_has_builtin_function is used to determine whether any variant of a builtin are available, for the purp

[Mesa-dev] [PATCH] mesa: check if any of the named builtins are available first

2017-07-03 Thread Ilia Mirkin
_mesa_glsl_has_builtin_function is used to determine whether any variant of a builtin are available, for the purpose of enforcing the GLSL ES 3.00+ rule that overloads or overrides of builtins are disallowed. However the builtin_builder contains information on all builtins, irrespective of parse s