Re: [Mesa-dev] [PATCH] mesa: add additional checks for uniform location query

2015-10-26 Thread Tapani Pälli
On 10/26/2015 12:11 PM, Timothy Arceri wrote: On Mon, 2015-10-26 at 11:22 +0200, Tapani Pälli wrote: Patch adds additional check to make sure we don't return locations for structures or arrays of structures. From page 79 of the OpenGL 4.2 spec: "A valid name cannot be a structure, an ar

Re: [Mesa-dev] [PATCH] mesa: add additional checks for uniform location query

2015-10-26 Thread Timothy Arceri
On Mon, 2015-10-26 at 11:22 +0200, Tapani Pälli wrote: > Patch adds additional check to make sure we don't return locations > for > structures or arrays of structures. > > From page 79 of the OpenGL 4.2 spec: > "A valid name cannot be a structure, an array of structures, or > any > portion

Re: [Mesa-dev] [PATCH] mesa: add additional checks for uniform location query

2015-10-26 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez Thanks! Sam On 26/10/15 10:22, Tapani Pälli wrote: > Patch adds additional check to make sure we don't return locations for > structures or arrays of structures. > > From page 79 of the OpenGL 4.2 spec: > "A valid name cannot be a structure, an array

[Mesa-dev] [PATCH] mesa: add additional checks for uniform location query

2015-10-26 Thread Tapani Pälli
Patch adds additional check to make sure we don't return locations for structures or arrays of structures. From page 79 of the OpenGL 4.2 spec: "A valid name cannot be a structure, an array of structures, or any portion of a single vector or a matrix." No Piglit or CTS regressions observe