Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

I've got st_atom_viewport.c covered, that one is easy. Marek's comment is what I'm looking for. As I was looking at the possibility of removing the Driver::Viewport I wanted to make sure I understood possible ramifications. I will not include the removal of Driver::Viewport or Driver::Scissor in m

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

st_viewport has nothing to do with the viewport. It's used if libGL doesn't expose __DRI_USE_INVALIDATE, so I don't think it's safe to remove it. If Driver::Viewport is about to removed, the code of st_viewport should be moved somewhere else. Marek On Wed, Nov 20, 2013 at 12:53 AM, Courtney Goel

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

On 11/19/2013 04:53 PM, Courtney Goeltzenleuchter wrote: The Gallium state tracker has a st_viewport that it puts into driver->Viewport function table. It's not clear to me how _NEW_VIEWPORT replaces the function of the Driver->Viewport call. Is it really safe to remove the driver->Viewport cal

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

The Gallium state tracker has a st_viewport that it puts into driver->Viewport function table. It's not clear to me how _NEW_VIEWPORT replaces the function of the Driver->Viewport call. Is it really safe to remove the driver->Viewport call for Gallium? Courtney On Mon, Nov 4, 2013 at 12:31 PM,

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

On 11/04/2013 11:43 AM, Ian Romanick wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/01/2013 04:12 PM, Francisco Jerez wrote: Ian Romanick writes: On 11/01/2013 02:04 PM, Courtney Goeltzenleuchter wrote: [...] More often, the dd_function_table functions allow core Mesa to signal

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

Hi Ian, Gallium uses the following interface: void (*set_scissor_states)( struct pipe_context *, unsigned start_slot, unsigned num_scissors, const struct pipe_scissor_state * ); void (*set_viewport

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/01/2013 04:12 PM, Francisco Jerez wrote: > Ian Romanick writes: > >> On 11/01/2013 02:04 PM, Courtney Goeltzenleuchter wrote: >>> [...] >> More often, the dd_function_table functions allow core Mesa to >> signal the driver driver that something

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

Ian Romanick writes: > On 11/01/2013 02:04 PM, Courtney Goeltzenleuchter wrote: >>[...] > More often, the dd_function_table functions allow core Mesa to signal > the driver driver that something happened... and the driver may need to > do something in response. For DRI2 drivers, the Viewport fun

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

On 11/01/2013 02:43 PM, Ian Romanick wrote: > On 11/01/2013 02:04 PM, Courtney Goeltzenleuchter wrote: >> >> On Fri, Nov 1, 2013 at 1:51 PM, Ian Romanick > > wrote: >> >> On 10/31/2013 08:55 AM, Courtney Goeltzenleuchter wrote: >> > Add the index parameter to th

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

On 11/01/2013 02:04 PM, Courtney Goeltzenleuchter wrote: > > On Fri, Nov 1, 2013 at 1:51 PM, Ian Romanick > wrote: > > On 10/31/2013 08:55 AM, Courtney Goeltzenleuchter wrote: > > Add the index parameter to the Scissor, Viewport and > > DepthRange driver

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

On Fri, Nov 1, 2013 at 1:51 PM, Ian Romanick wrote: > On 10/31/2013 08:55 AM, Courtney Goeltzenleuchter wrote: > > Add the index parameter to the Scissor, Viewport and > > DepthRange driver methods. Update i965 and Gallium > > to the change. Index always 0. > > I just sent out a patch series that

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

On 10/31/2013 08:55 AM, Courtney Goeltzenleuchter wrote: > Add the index parameter to the Scissor, Viewport and > DepthRange driver methods. Update i965 and Gallium > to the change. Index always 0. I just sent out a patch series that cleans up a bunch of the driver implementations of dd_function_t

[Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

Start setting the stage for ARB_viewport_array extension support. Add the index parameter to the Scissor, Viewport and DepthRange driver methods. Update i965 and Gallium to match. Include change for i915, nouveau and radeon per feedback from mesa-dev. piglit quick.tests passes --- src/mesa/driver

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

On Thu, Oct 31, 2013 at 8:55 AM, Courtney Goeltzenleuchter wrote: > Add the index parameter to the Scissor, Viewport and > DepthRange driver methods. Update i965 and Gallium > to the change. Index always 0. > --- > src/mesa/drivers/common/driverfuncs.c | 2 +- > src/mesa/drivers/dri/i965/brw_c

[Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

Add the index parameter to the Scissor, Viewport and DepthRange driver methods. Update i965 and Gallium to the change. Index always 0. --- src/mesa/drivers/common/driverfuncs.c | 2 +- src/mesa/drivers/dri/i965/brw_context.c | 4 ++-- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/d