Ian Romanick <i...@freedesktop.org> writes: > On 11/01/2013 02:04 PM, Courtney Goeltzenleuchter wrote: >>[...] > More often, the dd_function_table functions allow core Mesa to signal > the driver driver that something happened... and the driver may need to > do something in response. For DRI2 drivers, the Viewport function is a > good example. DRI2 drivers use that signal as a hint that the window > may have been resized. > > Other dd_function_table functions are used by core Mesa to request the > driver create or destroy some resource (e.g., texture storage). > > If it weren't for the way nouveau used the DepthRange and Scissor hooks, > I think we could just about get rid of them altogether. I wish that > driver just used the dirty state bits like everyone else. :( >
Cases like the new dd_function_table::Scissor and ::Viewport hooks introduced in this patch series are the reason why nouveau tends to prefer overriding the dd_function_table to keep track of state changes rather than looking at the ctx->NewState bits, because the latter tend to be very coarse-grained -- e.g. there's one big _NEW_TEXTURE flag for all the state of all texture units while nouveau is able to update a subset of the texture state independently for only those texture units that have changed. With the dd_function_table interface proposed in this patch series it would be possible for the drivers to update the state of each viewport in the viewport array independently, which might be beneficial for some hardware someday, removing ::DepthRange and ::Scissor would preclude that possibility. That said, I don't think nouveau is ever going to care in this particular case, I don't mind if you want to get rid of them. The following patches: [PATCH 1/2] nouveau: Use _NEW_VIEWPORT instead of hooking through dd_function_table [PATCH 2/2] nouveau: Use _NEW_SCISSOR instead of hooking through dd_function_table are Reviewed-by: Francisco Jerez <curroje...@riseup.net>.
pgpITq4uDOzsX.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
