Re: [Mesa-dev] [PATCH] mesa/marshal: add custom BufferData/BufferSubData marshalling

2017-03-23 Thread Nicolai Hähnle
On 23.03.2017 14:07, Timothy Arceri wrote: On 23/03/17 23:51, Nicolai Hähnle wrote: On 23.03.2017 13:41, Timothy Arceri wrote: On 23/03/17 23:19, Nicolai Hähnle wrote: On 23.03.2017 13:06, Timothy Arceri wrote: On 23/03/17 22:52, Nicolai Hähnle wrote: On 23.03.2017 07:32, Timothy Arcer

Re: [Mesa-dev] [PATCH] mesa/marshal: add custom BufferData/BufferSubData marshalling

2017-03-23 Thread Timothy Arceri
On 23/03/17 23:51, Nicolai Hähnle wrote: On 23.03.2017 13:41, Timothy Arceri wrote: On 23/03/17 23:19, Nicolai Hähnle wrote: On 23.03.2017 13:06, Timothy Arceri wrote: On 23/03/17 22:52, Nicolai Hähnle wrote: On 23.03.2017 07:32, Timothy Arceri wrote: +void GLAPIENTRY +_mesa_marshal_Bu

Re: [Mesa-dev] [PATCH] mesa/marshal: add custom BufferData/BufferSubData marshalling

2017-03-23 Thread Nicolai Hähnle
On 23.03.2017 13:41, Timothy Arceri wrote: On 23/03/17 23:19, Nicolai Hähnle wrote: On 23.03.2017 13:06, Timothy Arceri wrote: On 23/03/17 22:52, Nicolai Hähnle wrote: On 23.03.2017 07:32, Timothy Arceri wrote: +void GLAPIENTRY +_mesa_marshal_BufferData(GLenum target, GLsizeiptr size, con

Re: [Mesa-dev] [PATCH] mesa/marshal: add custom BufferData/BufferSubData marshalling

2017-03-23 Thread Timothy Arceri
On 23/03/17 23:19, Nicolai Hähnle wrote: On 23.03.2017 13:06, Timothy Arceri wrote: On 23/03/17 22:52, Nicolai Hähnle wrote: On 23.03.2017 07:32, Timothy Arceri wrote: GL_AMD_pinned_memory requires memory to be aligned correctly, so we skip marshalling in this case. Also copying the data d

Re: [Mesa-dev] [PATCH] mesa/marshal: add custom BufferData/BufferSubData marshalling

2017-03-23 Thread Nicolai Hähnle
On 23.03.2017 13:06, Timothy Arceri wrote: On 23/03/17 22:52, Nicolai Hähnle wrote: On 23.03.2017 07:32, Timothy Arceri wrote: GL_AMD_pinned_memory requires memory to be aligned correctly, so we skip marshalling in this case. Also copying the data defeats the purpose of EXTERNAL_VIRTUAL_MEMOR

Re: [Mesa-dev] [PATCH] mesa/marshal: add custom BufferData/BufferSubData marshalling

2017-03-23 Thread Timothy Arceri
On 23/03/17 22:52, Nicolai Hähnle wrote: On 23.03.2017 07:32, Timothy Arceri wrote: GL_AMD_pinned_memory requires memory to be aligned correctly, so we skip marshalling in this case. Also copying the data defeats the purpose of EXTERNAL_VIRTUAL_MEMORY_BUFFER_AMD. Fixes GL_AMD_pinned_memory pi

Re: [Mesa-dev] [PATCH] mesa/marshal: add custom BufferData/BufferSubData marshalling

2017-03-23 Thread Nicolai Hähnle
On 23.03.2017 07:32, Timothy Arceri wrote: GL_AMD_pinned_memory requires memory to be aligned correctly, so we skip marshalling in this case. Also copying the data defeats the purpose of EXTERNAL_VIRTUAL_MEMORY_BUFFER_AMD. Fixes GL_AMD_pinned_memory piglit tests when glthread is enabled. --- sr

Re: [Mesa-dev] [PATCH] mesa/marshal: add custom BufferData/BufferSubData marshalling

2017-03-22 Thread Edward O'Callaghan
Acked-by: Edward O'Callaghan On 03/23/2017 05:32 PM, Timothy Arceri wrote: > GL_AMD_pinned_memory requires memory to be aligned correctly, so > we skip marshalling in this case. Also copying the data defeats > the purpose of EXTERNAL_VIRTUAL_MEMORY_BUFFER_AMD. > > Fixes GL_AMD_pinned_memory pigl

[Mesa-dev] [PATCH] mesa/marshal: add custom BufferData/BufferSubData marshalling

2017-03-22 Thread Timothy Arceri
GL_AMD_pinned_memory requires memory to be aligned correctly, so we skip marshalling in this case. Also copying the data defeats the purpose of EXTERNAL_VIRTUAL_MEMORY_BUFFER_AMD. Fixes GL_AMD_pinned_memory piglit tests when glthread is enabled. --- src/mapi/glapi/gen/gl_API.xml | 4 +- src/mes