Re: [Mesa-dev] [PATCH] intel/aubinator: Use int to store getopt_long flags.

2018-06-12 Thread Ian Romanick
Reviewed-by: Ian Romanick On 06/12/2018 12:23 PM, Rafael Antognolli wrote: > getopt_long flag parameter is an int pointer, so if we use bool to store > those values, when getopt_long writes to one of them, it might end up > overwriting the next one. > --- > src/intel/tools/aubinator.c | 4 ++-- >

Re: [Mesa-dev] [PATCH] intel/aubinator: Use int to store getopt_long flags.

2018-06-12 Thread Rafael Antognolli
On Tue, Jun 12, 2018 at 12:23:17PM -0700, Rafael Antognolli wrote: > getopt_long flag parameter is an int pointer, so if we use bool to store > those values, when getopt_long writes to one of them, it might end up > overwriting the next one. I forgot to mention in the commit message that without t

[Mesa-dev] [PATCH] intel/aubinator: Use int to store getopt_long flags.

2018-06-12 Thread Rafael Antognolli
getopt_long flag parameter is an int pointer, so if we use bool to store those values, when getopt_long writes to one of them, it might end up overwriting the next one. --- src/intel/tools/aubinator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator