>-Original Message-
>From: Matt Turner [mailto:matts...@gmail.com]
>
>On Tue, Sep 12, 2017 at 10:19 AM, Ian Romanick wrote:
>> On 09/12/2017 02:40 AM, Marathe, Yogesh wrote:
>>> Hi Jason,
>>>
>>>
>>>
>>> On the asserts you’ve mentioned below, I assume we need to add them
>>> after ‘bufmgr-
On Tue, Sep 12, 2017 at 10:19 AM, Ian Romanick wrote:
> On 09/12/2017 02:40 AM, Marathe, Yogesh wrote:
>> Hi Jason,
>>
>>
>>
>> On the asserts you’ve mentioned below, I assume we need to add them
>> after ‘bufmgr->num_buckets++’ in add_bucket() as num_buckets could be 0
>> initially. Another clari
:09 PM
> *To:* Muthukumar, Aravindan
> *Cc:* mesa-dev@lists.freedesktop.org; J Karanje, Kedar
>
> *Subject:* Re: [Mesa-dev] [PATCH] i965 : optimized bucket index calculation
>
>
>
> In general, I'm very concerned about how this handles rounding
> behavior. Alm
On 09/08/2017 08:38 AM, Jason Ekstrand wrote:
> In general, I'm very concerned about how this handles rounding
> behavior. Almost everywhere, you round down when what you want to do is
> round up. Also, as I said on IRC, I'd like to see some asserts in
> add_bucket so that we are sure this calcul
er 8, 2017 9:09 PM
> *To:* Muthukumar, Aravindan
> *Cc:* mesa-dev@lists.freedesktop.org; J Karanje, Kedar <
> kedar.j.kara...@intel.com>
> *Subject:* Re: [Mesa-dev] [PATCH] i965 : optimized bucket index
> calculation
>
>
>
> In general, I'm very concerned abou
Jason Ekstrand
Sent: Friday, September 8, 2017 9:09 PM
To: Muthukumar, Aravindan
Cc: mesa-dev@lists.freedesktop.org; J Karanje, Kedar
Subject: Re: [Mesa-dev] [PATCH] i965 : optimized bucket index calculation
In general, I'm very concerned about how this handles rounding behavior.
Almost eve
In general, I'm very concerned about how this handles rounding behavior.
Almost everywhere, you round down when what you want to do is round up.
Also, as I said on IRC, I'd like to see some asserts in add_bucket so that
we are sure this calculation is correct. In particular, I'd like to see
asser
On 8 September 2017 at 12:06, Tapani Pälli wrote:
> Hi;
>
> Won't comment on the algorithm itself but coding style should be fixed to
> follow style used in the rest of the file (some documentation on style
> available here: https://www.mesa3d.org/codingstyle.html).
>
Even without that document, t
Hi;
Won't comment on the algorithm itself but coding style should be fixed
to follow style used in the rest of the file (some documentation on
style available here: https://www.mesa3d.org/codingstyle.html).
On 09/08/2017 11:11 AM, aravindan.muthuku...@intel.com wrote:
From: Aravindan Muthuku
From: Aravindan Muthukumar
Avoiding the loop which was running with O(n) complexity.
Now the complexity has been reduced to O(1)
Tested with piglit.
Slight performance improvement (~1%) in 3d mark.
Change-Id: Id099f1cd24ad5b691a69070eda79b8f4e9be39a6
Signed-off-by: Aravindan Muthukumar
Signed-
10 matches
Mail list logo
