Re: [Mesa-dev] [PATCH] i965: Fix brw_swap_cmod() for LE/GE comparisons.

2012-06-20 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/16/2012 02:20 AM, Kenneth Graunke wrote: > The idea here is to rewrite comparisons like 2 >= x with x <= 2; we want to > simply exchange arguments, not negate > the condition. If equality was part of the original comparison, it should > remain

Re: [Mesa-dev] [PATCH] i965: Fix brw_swap_cmod() for LE/GE comparisons.

2012-06-18 Thread Eric Anholt
On Sat, 16 Jun 2012 02:20:09 -0700, Kenneth Graunke wrote: > The idea here is to rewrite comparisons like 2 >= x with x <= 2; we want > to simply exchange arguments, not negate the condition. If equality was > part of the original comparison, it should remain part of the swapped > version. > >

[Mesa-dev] [PATCH] i965: Fix brw_swap_cmod() for LE/GE comparisons.

2012-06-16 Thread Kenneth Graunke
The idea here is to rewrite comparisons like 2 >= x with x <= 2; we want to simply exchange arguments, not negate the condition. If equality was part of the original comparison, it should remain part of the swapped version. This is the true cause of bug #50298. It didn't manifest itself on Sandy