Re: [Mesa-dev] [PATCH] i965: Don't allocate uniform space for samplers

2017-05-02 Thread Samuel Pitoiset
On 05/02/2017 12:12 AM, Timothy Arceri wrote: On 01/05/17 19:57, Samuel Pitoiset wrote: Thanks for fixing this. I guess "glsl: set vector_elements to 1 for samplers" can now be applied without breaking the world? :-) Yes you should be able to push it again (although wouldn't hurt to give it

Re: [Mesa-dev] [PATCH] i965: Don't allocate uniform space for samplers

2017-05-01 Thread Timothy Arceri
On 01/05/17 19:57, Samuel Pitoiset wrote: Thanks for fixing this. I guess "glsl: set vector_elements to 1 for samplers" can now be applied without breaking the world? :-) Yes you should be able to push it again (although wouldn't hurt to give it a run in Jenkins first). I didn't realize the pa

Re: [Mesa-dev] [PATCH] i965: Don't allocate uniform space for samplers

2017-05-01 Thread Samuel Pitoiset
Thanks for fixing this. I guess "glsl: set vector_elements to 1 for samplers" can now be applied without breaking the world? :-) On 04/30/2017 08:55 AM, Timothy Arceri wrote: Samplers are encoded into the instruction word, so there's no need to make space in the uniform file. Previously matrix

Re: [Mesa-dev] [PATCH] i965: Don't allocate uniform space for samplers

2017-04-30 Thread Jason Ekstrand
Seems reasonable Reviewed-by: Jason Ekstrand On April 30, 2017 8:59:03 AM Timothy Arceri wrote: On 30/04/17 16:55, Timothy Arceri wrote: Samplers are encoded into the instruction word, so there's no need to make space in the uniform file. Previously matrix_columns and vector_elements were

Re: [Mesa-dev] [PATCH] i965: Don't allocate uniform space for samplers

2017-04-29 Thread Timothy Arceri
On 30/04/17 16:55, Timothy Arceri wrote: Samplers are encoded into the instruction word, so there's no need to make space in the uniform file. Previously matrix_columns and vector_elements were set to 0, making this else case a no-op. Commit 75a31a20af26 changed that, causing malloc corruption i

[Mesa-dev] [PATCH] i965: Don't allocate uniform space for samplers

2017-04-29 Thread Timothy Arceri
Samplers are encoded into the instruction word, so there's no need to make space in the uniform file. Previously matrix_columns and vector_elements were set to 0, making this else case a no-op. Commit 75a31a20af26 changed that, causing malloc corruption in thousands of tests on i965. Fixes: 75a31