Re: [Mesa-dev] [PATCH] i965: Delete the fabulous target_to_target() function.

2014-02-21 Thread Eric Anholt
Kenneth Graunke writes: > gl_texture_object's Target field is never a cube face enumeration, so > target_to_target is just the identity function. Aptly named, at least. > > I verified this by putting an assert(!"ZOMG, CUBES!") in the cube face > case, and running Piglit. Nothing ever hit it. B

Re: [Mesa-dev] [PATCH] i965: Delete the fabulous target_to_target() function.

2014-02-21 Thread Jordan Justen
Reviewed-by: Jordan Justen On Fri, Feb 21, 2014 at 2:00 PM, Kenneth Graunke wrote: > gl_texture_object's Target field is never a cube face enumeration, so > target_to_target is just the identity function. Aptly named, at least. > > I verified this by putting an assert(!"ZOMG, CUBES!") in the cu

[Mesa-dev] [PATCH] i965: Delete the fabulous target_to_target() function.

2014-02-21 Thread Kenneth Graunke
gl_texture_object's Target field is never a cube face enumeration, so target_to_target is just the identity function. Aptly named, at least. I verified this by putting an assert(!"ZOMG, CUBES!") in the cube face case, and running Piglit. Nothing ever hit it. Beyond that, I inspected the code in