Re: [Mesa-dev] [PATCH] glsl: use ptrdiff_t cast to silence g++ sign warning

2014-09-22 Thread Brian Paul
g++ 4.8.2 warns on this. -Brian On 09/22/2014 12:41 PM, Ian Romanick wrote: This seems fine. But I don't get a warning here, and that seems a little odd. I'm a pretty old GCC... 4.7.2. What are you on? Either way, this patch is Reviewed-by: Ian Romanick On 09/22/2014 08:44 AM, Brian Paul

Re: [Mesa-dev] [PATCH] glsl: use ptrdiff_t cast to silence g++ sign warning

2014-09-22 Thread Ian Romanick
This seems fine. But I don't get a warning here, and that seems a little odd. I'm a pretty old GCC... 4.7.2. What are you on? Either way, this patch is Reviewed-by: Ian Romanick On 09/22/2014 08:44 AM, Brian Paul wrote: > --- > src/glsl/link_uniforms.cpp |2 +- > 1 file changed, 1 inser

[Mesa-dev] [PATCH] glsl: use ptrdiff_t cast to silence g++ sign warning

2014-09-22 Thread Brian Paul
--- src/glsl/link_uniforms.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index 258d279..a6683a0 100644 --- a/src/glsl/link_uniforms.cpp +++ b/src/glsl/link_uniforms.cpp @@ -749,7 +749,7 @@ link_update_uniform_buff