Re: [Mesa-dev] [PATCH] glsl: expose textureQueryLod in GLSL 4.00+ fragment shaders

2015-08-20 Thread Marek Olšák
On Fri, Aug 21, 2015 at 1:10 AM, Ilia Mirkin wrote: > On Thu, Aug 20, 2015 at 7:08 PM, Timothy Arceri wrote: >> On Thu, 2015-08-20 at 14:06 -0400, Ilia Mirkin wrote: >>> On Thu, Aug 20, 2015 at 2:01 PM, Marek Olšák >>> wrote: >>> > On Thu, Aug 20, 2015 at 5:15 PM, Ilia Mirkin >>> > wrote: >>> >

Re: [Mesa-dev] [PATCH] glsl: expose textureQueryLod in GLSL 4.00+ fragment shaders

2015-08-20 Thread Ilia Mirkin
On Thu, Aug 20, 2015 at 7:08 PM, Timothy Arceri wrote: > On Thu, 2015-08-20 at 14:06 -0400, Ilia Mirkin wrote: >> On Thu, Aug 20, 2015 at 2:01 PM, Marek Olšák >> wrote: >> > On Thu, Aug 20, 2015 at 5:15 PM, Ilia Mirkin >> > wrote: >> > > So just stick something like >> > > >> > > """ >> > > From

Re: [Mesa-dev] [PATCH] glsl: expose textureQueryLod in GLSL 4.00+ fragment shaders

2015-08-20 Thread Timothy Arceri
On Thu, 2015-08-20 at 14:06 -0400, Ilia Mirkin wrote: > On Thu, Aug 20, 2015 at 2:01 PM, Marek Olšák > wrote: > > On Thu, Aug 20, 2015 at 5:15 PM, Ilia Mirkin > > wrote: > > > So just stick something like > > > > > > """ > > > From the ARB_texture_query_lod spec: > > > > > > (3) The core sp

Re: [Mesa-dev] [PATCH] glsl: expose textureQueryLod in GLSL 4.00+ fragment shaders

2015-08-20 Thread Ilia Mirkin
On Thu, Aug 20, 2015 at 2:01 PM, Marek Olšák wrote: > On Thu, Aug 20, 2015 at 5:15 PM, Ilia Mirkin wrote: >> So just stick something like >> >> """ >> From the ARB_texture_query_lod spec: >> >> (3) The core specification uses the "Lod" spelling, not "LOD". Should >> this extension be

Re: [Mesa-dev] [PATCH] glsl: expose textureQueryLod in GLSL 4.00+ fragment shaders

2015-08-20 Thread Marek Olšák
On Thu, Aug 20, 2015 at 5:15 PM, Ilia Mirkin wrote: > So just stick something like > > """ > From the ARB_texture_query_lod spec: > > (3) The core specification uses the "Lod" spelling, not "LOD". Should > this extension be modified to use "Lod"? > > RESOLVED: The "Lod" spelling

Re: [Mesa-dev] [PATCH] glsl: expose textureQueryLod in GLSL 4.00+ fragment shaders

2015-08-20 Thread Ilia Mirkin
So just stick something like """ From the ARB_texture_query_lod spec: (3) The core specification uses the "Lod" spelling, not "LOD". Should this extension be modified to use "Lod"? RESOLVED: The "Lod" spelling is the correct spelling for the core specification and the pre

Re: [Mesa-dev] [PATCH] glsl: expose textureQueryLod in GLSL 4.00+ fragment shaders

2015-08-20 Thread Timothy Arceri
On Wed, 2015-08-19 at 18:44 -0400, Ilia Mirkin wrote: Maybe quote or at least make mention of Issue 3 of the ARB_texture_query_lod spec in the commit message so anyone searching git history can easily discover why there are two differently named versions. Otherwise Reviewed-by: Timothy Arceri >

[Mesa-dev] [PATCH] glsl: expose textureQueryLod in GLSL 4.00+ fragment shaders

2015-08-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/glsl/builtin_functions.cpp | 119 - 1 file changed, 82 insertions(+), 37 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 04ad617..9351f71 100644 --- a/src/glsl/builtin_funct