Re: [Mesa-dev] [PATCH] glsl: binding point is a texture unit, which is a combined space

2015-06-22 Thread Timothy Arceri
This also probably explains why my max binding test for arrays of arrays was failing on the Nvidia blob. Guess I should have looked into that failure a little harder. On Tue, 2015-06-23 at 00:22 -0400, Ilia Mirkin wrote: > This fixes compilation failures in Dota 2 Reborn where a texture unit > bin

Re: [Mesa-dev] [PATCH] glsl: binding point is a texture unit, which is a combined space

2015-06-22 Thread Timothy Arceri
Looks good to me as well. Reviewed-by: Timothy Arceri Since you already looking around in there did you want to take a look at this patch: http://lists.freedesktop.org/archives/mesa-dev/2015-June/086925.html I submitted it earlier this month but no one seems to keen to review it. On Tue, 2015

[Mesa-dev] [PATCH] glsl: binding point is a texture unit, which is a combined space

2015-06-22 Thread Ilia Mirkin
This fixes compilation failures in Dota 2 Reborn where a texture unit binding point was used that was numerically higher than the max per stage. Signed-off-by: Ilia Mirkin Reviewed-by: Chris Forbes Tested-by: Nick Sarnie Cc: "10.5 10.6" --- src/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 in