Re: [Mesa-dev] [PATCH] glsl: Respect std430 layout in lower_buffer_access

2018-01-07 Thread Timothy Arceri
Ccing stable. I've pushed this patch and the piglit test. Thanks for the patches :) On 06/01/18 01:33, Florian Will wrote: Respect the std430 rules for determining offset and size of struct members when using a std430 buffer. std140 rules lead to wrong buffer offsets in that case. Fixes my tes

Re: [Mesa-dev] [PATCH] glsl: Respect std430 layout in lower_buffer_access

2018-01-07 Thread Anonymer Kommentator
Hi Timothy, Thanks for taking a look. > These changes seem reasonable. Are you able to create a piglit test that > exercises the bug also? Thanks to your pointer to the basic.shader_test for SSBOs in piglit, I was able to create a new piglit test for this bug. Its result changes from fail to pas

Re: [Mesa-dev] [PATCH] glsl: Respect std430 layout in lower_buffer_access

2018-01-05 Thread Timothy Arceri
These changes seem reasonable. Are you able to create a piglit test that exercises the bug also? See the basic ssbo test as an example [1]. After building piglit you can run these shader runner tests from the piglit dir like so: ./bin/shader_runner tests/spec/arb_shader_storage_buffer_object

[Mesa-dev] [PATCH] glsl: Respect std430 layout in lower_buffer_access

2018-01-05 Thread Florian Will
Respect the std430 rules for determining offset and size of struct members when using a std430 buffer. std140 rules lead to wrong buffer offsets in that case. Fixes my test case attached in Bugzilla. No piglit changes. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104492 --- src/compile