Re: [Mesa-dev] [PATCH] glsl: Remove unreachable error message

2013-12-05 Thread Ian Romanick
On 12/04/2013 10:32 PM, Timothy Arceri wrote: > On Wed, 2013-12-04 at 14:32 -0800, Ian Romanick wrote: >> On 11/20/2013 03:41 AM, Timothy Arceri wrote: >>> Left over from bug #34376. >> >> I think this shader hits this error message: >> >> #version 120 >> >> int x[]; >> >> void foo() {

Re: [Mesa-dev] [PATCH] glsl: Remove unreachable error message

2013-12-04 Thread Timothy Arceri
On Wed, 2013-12-04 at 14:32 -0800, Ian Romanick wrote: > On 11/20/2013 03:41 AM, Timothy Arceri wrote: > > Left over from bug #34376. > > I think this shader hits this error message: > > #version 120 > > int x[]; > > void foo() { x[3] = 2; } > > int x[] = int[2](1,2); > > do_a

Re: [Mesa-dev] [PATCH] glsl: Remove unreachable error message

2013-12-04 Thread Ian Romanick
On 11/20/2013 03:41 AM, Timothy Arceri wrote: > Left over from bug #34376. I think this shader hits this error message: #version 120 int x[]; void foo() { x[3] = 2; } int x[] = int[2](1,2); do_assignment is also used for initializers. Initializers can be used to (explicitly)

Re: [Mesa-dev] [PATCH] glsl: Remove unreachable error message

2013-12-04 Thread Timothy Arceri
Ping. Just to clarify unsized arrays cannot be assigned so var->max_array_access will always be 0 as redecorations are already handled before this point by get_variable_being_redeclared() This patch is needed as a cleanup for ARB_arrays_of_arrays work. I have run all glsl piglit tests without reg

Re: [Mesa-dev] [PATCH] glsl: Remove unreachable error message

2013-11-23 Thread Timothy Arceri
Just to clarify unsized arrays cannot be assigned so var->max_array_access will always be 0 as redecorations are already handled before this point by get_variable_being_redeclared() On Wed, 2013-11-20 at 22:41 +1100, Timothy Arceri wrote: > Left over from bug #34376. > > Signed-off-by: Timothy

[Mesa-dev] [PATCH] glsl: Remove unreachable error message

2013-11-20 Thread Timothy Arceri
Left over from bug #34376. Signed-off-by: Timothy Arceri --- src/glsl/ast_to_hir.cpp | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 76b256c..adf10a0 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -813,13 +8