Re: [Mesa-dev] [PATCH] glsl: Fix pi/2 constant in acos built-in function

On 6 June 2012 10:31, Kenneth Graunke wrote: > On 06/06/2012 05:16 AM, Olivier Galibert wrote: > > On Tue, Jun 05, 2012 at 04:51:54PM -0700, Paul Berry wrote: > >> The best idea I've got so far would be a shader_runner test with a > fragment > >> shader that computes dFdx(asin(x)), compares it to

Re: [Mesa-dev] [PATCH] glsl: Fix pi/2 constant in acos built-in function

On 06/06/2012 05:16 AM, Olivier Galibert wrote: > On Tue, Jun 05, 2012 at 04:51:54PM -0700, Paul Berry wrote: >> The best idea I've got so far would be a shader_runner test with a fragment >> shader that computes dFdx(asin(x)), compares it to the theoretical closed >> form derivative of asin(x) (wh

Re: [Mesa-dev] [PATCH] glsl: Fix pi/2 constant in acos built-in function

On Tue, Jun 05, 2012 at 04:51:54PM -0700, Paul Berry wrote: > The best idea I've got so far would be a shader_runner test with a fragment > shader that computes dFdx(asin(x)), compares it to the theoretical closed > form derivative of asin(x) (which is 1/sqrt(1-x^2)), and draws red pixels > if the

Re: [Mesa-dev] [PATCH] glsl: Fix pi/2 constant in acos built-in function

On 5 June 2012 14:42, Ian Romanick wrote: > On 06/04/2012 03:23 PM, Paul Berry wrote: > >> On 4 June 2012 14:50, Ian Romanick > > wrote: >> >>On 06/04/2012 01:31 PM, Olivier Galibert wrote: >> >>On Mon, Jun 04, 2012 at 01:11:13PM -0700, Ian Romanick wrote:

Re: [Mesa-dev] [PATCH] glsl: Fix pi/2 constant in acos built-in function

On 06/04/2012 03:23 PM, Paul Berry wrote: On 4 June 2012 14:50, Ian Romanick mailto:i...@freedesktop.org>> wrote: On 06/04/2012 01:31 PM, Olivier Galibert wrote: On Mon, Jun 04, 2012 at 01:11:13PM -0700, Ian Romanick wrote: From: Ian Romanickmailto:ian.d.roman...@intel.

Re: [Mesa-dev] [PATCH] glsl: Fix pi/2 constant in acos built-in function

On Mon, Jun 04, 2012 at 03:23:34PM -0700, Paul Berry wrote: > I'm not even kidding--I love this > stuff and I'm jealous that I don't have time to work on it right now Do you have a favorite method for Vandermonde matrix inversion? OG. ___ mesa-dev mai

Re: [Mesa-dev] [PATCH] glsl: Fix pi/2 constant in acos built-in function

On 4 June 2012 14:50, Ian Romanick wrote: > On 06/04/2012 01:31 PM, Olivier Galibert wrote: > >> On Mon, Jun 04, 2012 at 01:11:13PM -0700, Ian Romanick wrote: >> >>> From: Ian Romanick >>> > >>> >>> In single precision, 1.5707963 becomes 1.5707962513 which is too >>> small. However, 1.5707964 be

Re: [Mesa-dev] [PATCH] glsl: Fix pi/2 constant in acos built-in function

On 06/04/2012 01:31 PM, Olivier Galibert wrote: On Mon, Jun 04, 2012 at 01:11:13PM -0700, Ian Romanick wrote: From: Ian Romanick In single precision, 1.5707963 becomes 1.5707962513 which is too small. However, 1.5707964 becomes 1.5707963705 which is just right. The value 1.5707964 is already u

Re: [Mesa-dev] [PATCH] glsl: Fix pi/2 constant in acos built-in function

On Mon, Jun 04, 2012 at 01:11:13PM -0700, Ian Romanick wrote: > From: Ian Romanick > > In single precision, 1.5707963 becomes 1.5707962513 which is too > small. However, 1.5707964 becomes 1.5707963705 which is just right. > The value 1.5707964 is already used in asin.ir. > > NOTE: This is a can

Re: [Mesa-dev] [PATCH] glsl: Fix pi/2 constant in acos built-in function

On 4 June 2012 13:11, Ian Romanick wrote: > From: Ian Romanick > > In single precision, 1.5707963 becomes 1.5707962513 which is too > small. However, 1.5707964 becomes 1.5707963705 which is just right. > The value 1.5707964 is already used in asin.ir. > > NOTE: This is a candidate for stable re

[Mesa-dev] [PATCH] glsl: Fix pi/2 constant in acos built-in function

From: Ian Romanick In single precision, 1.5707963 becomes 1.5707962513 which is too small. However, 1.5707964 becomes 1.5707963705 which is just right. The value 1.5707964 is already used in asin.ir. NOTE: This is a candidate for stable release branches. Signed-off-by: Ian Romanick Cc: Olivie