Kenneth Graunke writes:
> I'm pretty tempted by ralloc_rewrite_tail & ralloc_strn_rewrite_tail.
I still don't like the lack of symmetry here. Maybe bite the bullet and
make the first one ralloc_str_rewrite_tail?
But that "rewrite_tail" keeps feeling so awkward. I think the real
problem is that i
From: Carl Worth
Previously, we were only supporting line-continuation backslash characters
within lines of pre-processor directives, (as per the specification). With
OpenGL 4.2 and GLES3, line continuations are now supported anywhere within a
shader.
While changing this, also fix a bug where th
On 11/30/2012 03:20 PM, Carl Worth wrote:
Kenneth Graunke writes:
Other than than, looks good to me...thanks Carl!
Reviewed-by: Kenneth Graunke
Thanks, Ken. Pushed now.
Someday we may want to use ralloc's rewrite_tail functions to avoid the
extra strlen() overhead. But that can be done s
Kenneth Graunke writes:
> Other than than, looks good to me...thanks Carl!
>
> Reviewed-by: Kenneth Graunke
Thanks, Ken. Pushed now.
> Someday we may want to use ralloc's rewrite_tail functions to avoid the
> extra strlen() overhead. But that can be done separately.
I took a look at this now
On 11/30/2012 02:29 PM, Kenneth Graunke wrote:
On 11/29/2012 03:44 PM, Carl Worth wrote:
Previously, we were only supporting line-continuation backslash
characters
within lines of pre-processor directives, (as per the specification).
With
OpenGL 4.3, line continuations are now supported anywhere
On 11/29/2012 03:44 PM, Carl Worth wrote:
Previously, we were only supporting line-continuation backslash characters
within lines of pre-processor directives, (as per the specification). With
OpenGL 4.3, line continuations are now supported anywhere within a shader.
OpenGL 4.2, actually.
I'm a
Previously, we were only supporting line-continuation backslash characters
within lines of pre-processor directives, (as per the specification). With
OpenGL 4.3, line continuations are now supported anywhere within a shader.
While changing this, also fix a bug where the preprocessor was ignoring l
