Re: [Mesa-dev] [PATCH] glcpp: Do not remove spaces to preserve locations.

2014-03-08 Thread Kenneth Graunke
On 02/05/2014 06:15 AM, Sir Anthony wrote: > After preprocessing by glcpp all adjacent spaces were replaced by > single one and glsl parser received column-shifted shader source. > It negatively affected ast location set up and produced wrong error > messages for heavily-spaced shaders. Pushed!

Re: [Mesa-dev] [PATCH] glcpp: Do not remove spaces to preserve locations.

2014-02-05 Thread Carl Worth
Sir Anthony writes: > After preprocessing by glcpp all adjacent spaces were replaced by > single one and glsl parser received column-shifted shader source. > It negatively affected ast location set up and produced wrong error > messages for heavily-spaced shaders. Thanks! This commit message a

[Mesa-dev] [PATCH] glcpp: Do not remove spaces to preserve locations.

2014-02-05 Thread Sir Anthony
After preprocessing by glcpp all adjacent spaces were replaced by single one and glsl parser received column-shifted shader source. It negatively affected ast location set up and produced wrong error messages for heavily-spaced shaders. --- src/glsl/glcpp/glcpp-lex.l