Re: [Mesa-dev] [PATCH] anv: turn on samplerAnisotropy in VkPhysicalDeviceFeatures

2016-10-07 Thread Jason Ekstrand
On Fri, Oct 7, 2016 at 9:59 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > I should mentioned that in the commit message, but as far as I can tell, > looking at the CTS, it doesn't seem to ever set the anisotropy value on the > sampler to something other than 1.0f. > I just did a

Re: [Mesa-dev] [PATCH] anv: turn on samplerAnisotropy in VkPhysicalDeviceFeatures

2016-10-07 Thread Lionel Landwerlin
I should mentioned that in the commit message, but as far as I can tell, looking at the CTS, it doesn't seem to ever set the anisotropy value on the sampler to something other than 1.0f. I really need to get the details from Mark about the CI... On 07/10/16 17:52, Jason Ekstrand wrote: Does

Re: [Mesa-dev] [PATCH] anv: turn on samplerAnisotropy in VkPhysicalDeviceFeatures

2016-10-07 Thread Jason Ekstrand
Does this enable more tests? If so, do we pass them? On Oct 7, 2016 9:50 AM, "Lionel Landwerlin" wrote: > According to the Vulkan spec 5.63.4 : > > samplerAnisotropy indicates whether anisotropic filtering is supported. > If > this feature is not enabled, the maxAnisotropy member of the >

[Mesa-dev] [PATCH] anv: turn on samplerAnisotropy in VkPhysicalDeviceFeatures

2016-10-07 Thread Lionel Landwerlin
According to the Vulkan spec 5.63.4 : samplerAnisotropy indicates whether anisotropic filtering is supported. If this feature is not enabled, the maxAnisotropy member of the VkSamplerCreateInfo structure must be 1.0. Since we already set maxAnisotropy to 16 and program the hardware accordin