Does this enable more tests? If so, do we pass them? On Oct 7, 2016 9:50 AM, "Lionel Landwerlin" <llandwer...@gmail.com> wrote:
> According to the Vulkan spec 5.63.4 : > > samplerAnisotropy indicates whether anisotropic filtering is supported. > If > this feature is not enabled, the maxAnisotropy member of the > VkSamplerCreateInfo structure must be 1.0. > > Since we already set maxAnisotropy to 16 and program the hardware according > to the VkSamplerCreateInfo.maxAnisotropy, it seems we can turn this on. > > Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> > --- > src/intel/vulkan/TODO | 1 - > src/intel/vulkan/anv_device.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO > index 8fac370..dad9fc8 100644 > --- a/src/intel/vulkan/TODO > +++ b/src/intel/vulkan/TODO > @@ -5,7 +5,6 @@ Missing Features: > - FP64 > - Tessellation > - Cull and Clip Distance > - - Sampler anisotropy (Is there anything to do here?) > - Image Gather Extended > - Storage Image Without Format > - Investigate CTS failures on HSW > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index c7b9979..502955c 100644 > --- a/src/intel/vulkan/anv_device.c > +++ b/src/intel/vulkan/anv_device.c > @@ -418,7 +418,7 @@ void anv_GetPhysicalDeviceFeatures( > .largePoints = true, > .alphaToOne = true, > .multiViewport = true, > - .samplerAnisotropy = false, /* FINISHME */ > + .samplerAnisotropy = true, > .textureCompressionETC2 = pdevice->info.gen >= 8 > || > > pdevice->info.is_baytrail, > .textureCompressionASTC_LDR = pdevice->info.gen >= 9, > /* FINISHME CHV */ > -- > 2.9.3 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev