Re: [Mesa-dev] [PATCH] anv: image: report correct depthPicth for 3d images

2016-12-03 Thread Lionel Landwerlin
On 3 Dec 2016 4:40 pm, "Jason Ekstrand" wrote: On Dec 3, 2016 8:27 AM, "Lionel Landwerlin" wrote: That's on Haswell. I'm not sure whether a 3d image with multiple layers makes sense, but if it does, it should probably return different depth/layer pitch values? It does not. You can't have 3

Re: [Mesa-dev] [PATCH] anv: image: report correct depthPicth for 3d images

2016-12-03 Thread Jason Ekstrand
On Dec 3, 2016 8:27 AM, "Lionel Landwerlin" wrote: That's on Haswell. I'm not sure whether a 3d image with multiple layers makes sense, but if it does, it should probably return different depth/layer pitch values? It does not. You can't have 3D arrays. Haswell should probably return 0 for bot

Re: [Mesa-dev] [PATCH] anv: image: report correct depthPicth for 3d images

2016-12-03 Thread Lionel Landwerlin
That's on Haswell. I'm not sure whether a 3d image with multiple layers makes sense, but if it does, it should probably return different depth/layer pitch values? On Sat, 2016-12-03 at 08:22 -0800, Jason Ekstrand wrote: > What hardware are you running on?  Prior to sky lake, depth pitch > makes so

Re: [Mesa-dev] [PATCH] anv: image: report correct depthPicth for 3d images

2016-12-03 Thread Jason Ekstrand
What hardware are you running on? Prior to sky lake, depth pitch makes so sense for us. On sky lake and above it should be exactly the same as array pitch. One thing we should do is not report array pitch for 3D and maybe report a depth pitch of zero on broadwell and earlier. On Dec 3, 2016 7:5

[Mesa-dev] [PATCH] anv: image: report correct depthPicth for 3d images

2016-12-03 Thread Lionel Landwerlin
With a 3d image of 2x2x3, vkGetImageSubresourceLayout currently reports : VkSubresourceLayout = { offset = 0, size = 160, rowPitch = 16, arrayPitch = 96, depthPitch = 96 } depthPitch should be 32. Sig