Re: [Mesa-dev] [PATCH] Util: fix msvc build

2018-07-05 Thread Emil Velikov
On 5 July 2018 at 08:49, Benedikt Schemmer wrote: > The MSVC preprocessor doesnt understand #warning > Fixes: 2e1e6511f76 ("util: extract get_process_name from xmlconfig.c") Reviewed-by: Emil Velikov and pushed to master. Thanks Emil ___ mesa-dev mail

Re: [Mesa-dev] [PATCH] Util: fix msvc build

2018-07-05 Thread Roland Scheidegger
Am 05.07.2018 um 09:49 schrieb Benedikt Schemmer: > The MSVC preprocessor doesnt understand #warning > > --- > src/util/process.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/process.c b/src/util/process.c > index 449c7fa77c2..6e6376986f3 100644 > --- a/src/u

[Mesa-dev] [PATCH] Util: fix msvc build

2018-07-05 Thread Benedikt Schemmer
The MSVC preprocessor doesnt understand #warning --- src/util/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/process.c b/src/util/process.c index 449c7fa77c2..6e6376986f3 100644 --- a/src/util/process.c +++ b/src/util/process.c @@ -107,7 +107,7 @@ __getProg

Re: [Mesa-dev] [PATCH] util: fix MSVC build issue in disk_cache.h

2017-02-21 Thread Brian Paul
On 02/21/2017 05:48 PM, Timothy Arceri wrote: On 22/02/17 09:59, Brian Paul wrote: On 02/21/2017 03:57 PM, Brian Paul wrote: Windows doesn't have dlfcn.h. Protect the code in question with #if ENABLE_SHADER_CACHE test. --- src/util/disk_cache.h | 26 -- 1 file chan

Re: [Mesa-dev] [PATCH] util: fix MSVC build issue in disk_cache.h

2017-02-21 Thread Timothy Arceri
On 22/02/17 09:59, Brian Paul wrote: On 02/21/2017 03:57 PM, Brian Paul wrote: Windows doesn't have dlfcn.h. Protect the code in question with #if ENABLE_SHADER_CACHE test. --- src/util/disk_cache.h | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --

Re: [Mesa-dev] [PATCH] util: fix MSVC build issue in disk_cache.h

2017-02-21 Thread Roland Scheidegger
Looks good to me. I guess ideally there'd be some os abstraction so the cache stuff could actually build/work on windows but that's another story... Roland Am 21.02.2017 um 23:57 schrieb Brian Paul: > Windows doesn't have dlfcn.h. Protect the code in question > with #if ENABLE_SHADER_CACHE test.

Re: [Mesa-dev] [PATCH] util: fix MSVC build issue in disk_cache.h

2017-02-21 Thread Brian Paul
On 02/21/2017 03:57 PM, Brian Paul wrote: Windows doesn't have dlfcn.h. Protect the code in question with #if ENABLE_SHADER_CACHE test. --- src/util/disk_cache.h | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/src/util/disk_cache.h b/src/util/d

[Mesa-dev] [PATCH] util: fix MSVC build issue in disk_cache.h

2017-02-21 Thread Brian Paul
Windows doesn't have dlfcn.h. Protect the code in question with #if ENABLE_SHADER_CACHE test. --- src/util/disk_cache.h | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/src/util/disk_cache.h b/src/util/disk_cache.h index 8b6fc0d..7f4da80 100644 ---