Re: [Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-28 Thread Brian Paul
On 11/26/2011 08:13 PM, Anuj Phogat wrote: Hi Brian, This is an updated patch to allow glTexImage2D with a depth component cube map. Patch was producing an expected ouput with depth-cube-map test (posted on piglit mailing list). But i'm getting an incorrect output since i updated my mesa branch

Re: [Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-26 Thread Anuj Phogat
Hi Brian, >> This is an updated patch to allow glTexImage2D with a depth component >> cube map. Patch >> was producing an expected ouput with depth-cube-map test (posted on >> piglit mailing list). >> But i'm getting an incorrect output since i updated my mesa branch >> with git://anongit.freedesk

Re: [Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-26 Thread Brian Paul
On 11/23/2011 05:14 PM, Anuj Phogat wrote: From: Anuj Phogat This is an updated patch to allow glTexImage2D with a depth component cube map. Patch was producing an expected ouput with depth-cube-map test (posted on piglit mailing list). But i'm getting an incorrect output since i updated my me

[Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-23 Thread Anuj Phogat
From: Anuj Phogat This is an updated patch to allow glTexImage2D with a depth component cube map. Patch was producing an expected ouput with depth-cube-map test (posted on piglit mailing list). But i'm getting an incorrect output since i updated my mesa branch with git://anongit.freedesktop.or

Re: [Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-22 Thread Kenneth Graunke
On 11/22/2011 03:34 PM, Anuj Phogat wrote: > On Tue 22 Nov 2011 12:21:09 PM PST, Kenneth Graunke wrote: >> On 11/22/2011 11:42 AM, Anuj Phogat wrote: >> [snip] >>> I agree. This is simpler to read and _mesa_is_cube_map_face() can >>> be reused >>> in mesa. Posting an updated patch with your sug

Re: [Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-22 Thread Anuj Phogat
On Tue 22 Nov 2011 12:21:09 PM PST, Kenneth Graunke wrote: On 11/22/2011 11:42 AM, Anuj Phogat wrote: [snip] I agree. This is simpler to read and _mesa_is_cube_map_face() can be reused in mesa. Posting an updated patch with your suggestions. > I haven't tested this so the logic might be

Re: [Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-22 Thread Brian Paul
On 11/22/2011 01:21 PM, Kenneth Graunke wrote: On 11/22/2011 11:42 AM, Anuj Phogat wrote: [snip] I agree. This is simpler to read and _mesa_is_cube_map_face() can be reused in mesa. Posting an updated patch with your suggestions. > I haven't tested this so the logic might be incorrect.

Re: [Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-22 Thread Kenneth Graunke
On 11/22/2011 11:42 AM, Anuj Phogat wrote: [snip] > I agree. This is simpler to read and _mesa_is_cube_map_face() can be reused > in mesa. Posting an updated patch with your suggestions. > > > I haven't tested this so the logic might be incorrect. > It worked as it is. Just defined a new funct

[Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-22 Thread Anuj Phogat
From: Anuj Phogat Hi Brian, >I think something like this would be simpler: > > @@ -1629,7 +1629,9 @@ texture_error_check( struct gl_context *ctx, > target != GL_TEXTURE_2D_ARRAY && > target != GL_PROXY_TEXTURE_2D_ARRAY && > target != GL_TEXTURE_RECTANGLE_ARB && > - target != GL_PROXY_TEXT

Re: [Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-21 Thread Brian Paul
On 11/21/2011 03:45 PM, anuj.pho...@gmail.com wrote: From: Anuj Phogat Thanks for the review comments. Here is the updated patch to allow depth component cube maps in GL 3.0. I'll post the piglit testcase for this patch in a separate e-mail. Anuj Signed-off-by: Anuj Phogat --- src/mesa/main

[Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-21 Thread anuj . phogat
From: Anuj Phogat Thanks for the review comments. Here is the updated patch to allow depth component cube maps in GL 3.0. I'll post the piglit testcase for this patch in a separate e-mail. Anuj Signed-off-by: Anuj Phogat --- src/mesa/main/teximage.c | 27 +-- 1 file

Re: [Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-18 Thread Ian Romanick
On 11/16/2011 07:56 PM, Anuj Phogat wrote: From: Anuj Phogat Hi, Here is a patch to allow glTexImage2D and glCopyTexImage2D with depth component cubemap. It is listed in mesa work queue with a label "CUBE1". I've tested the patch and output looks visually correct. Please review the fix and le

Re: [Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-18 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/16/2011 07:56 PM, Anuj Phogat wrote: > From: Anuj Phogat > > Hi, > > Here is a patch to allow glTexImage2D and glCopyTexImage2D with depth > component cubemap. > It is listed in mesa work queue with a label "CUBE1". I've tested the patch > a

[Mesa-dev] [PATCH] Allow glTexImage2D with a depth component cube map

2011-11-16 Thread Anuj Phogat
From: Anuj Phogat Hi, Here is a patch to allow glTexImage2D and glCopyTexImage2D with depth component cubemap. It is listed in mesa work queue with a label "CUBE1". I've tested the patch and output looks visually correct. Please review the fix and let me know if i'm missing something. Thanks