; > for those cases which put the CCS after each main surface at some
> > > fixed calculation offset based on width, height, and stride. Then the
> > > one modifier would apply independently to the three different planes.
> > >
> > > --Jason
> &
The Problem: For a given 3-tuple (multi-planar format, DRM format modifier,
chipset), we need Intel ABI that decides (a) the value of
VkDrmFormatModifierPropertiesEXT::drmFormatModifierPlaneCount and (b) the
content of each "modifier" plane.
For example, suppose drmFormatModifierPlaneCount is 2
el Landwerlin
> > Fixes: 20de7f9f226401 ("egl/dri2: support for creating images out of dma
> > buffers")
>
> That matches the spec, so:
> Reviewed-by: Eric Engestrom
>
> That said, Topi specifically wrote this, in his commit (20de7f9f226401):
> > v4 (Cha
So the future Vulkan driver can share it.
I tested Meson, but not Autotools nor Android.mk.
Signed-off-by: Chad Versace
---
Makefile.am| 1 +
.../drivers/freedreno/drm => include/drm-uapi}/msm_drm.h | 0
src/gallium/drivers/freedr
The warning is emitted when building without INLINE_SSE41.
---
src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c
b/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c
index 836f83d4a43..f
On Thu 08 Nov 2018, Chad Versace wrote:
> On Wed 31 Oct 2018, Aditya Swarup wrote:
> > For Intel platforms, we support external textures only for EGLImages
> > created with EGL_EXT_image_dma_buf_import. This restriction seems to
> > be Intel specific and not presen
ES_EGL_image_external to only dma_buf-imported EGLImages. The
pivotal comment below is mine, according git-blame, from 2015-04-09.
> - /* We support external textures only for EGLImages created with
> -* EGL_EXT_image_dma_buf_import. We may lift that restriction in the
> future.
&g
s much more involved.
>
> Signed-off-by: Daniel Stone
> Cc: mesa-sta...@lists.freedesktop.org
> Cc: Chad Versace
> Cc: Jason Ekstrand
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108540
Reviewed-by: Chad Versace
On Mon 01 Oct 2018, Jason Ekstrand wrote:
> The DRM format modifiers extension adds a TILING_DRM_FORMAT_MODIFIER
> which will be used for modifiers so we can no longer use OPTIMAL to
> indicate tiled inside the driver.
> ---
> src/intel/vulkan/anv_formats.c | 2 +-
> src/intel/vulkan/anv_image
d memory"
> ---
> src/intel/vulkan/anv_device.c | 7 +++
> 1 file changed, 7 insertions(+)
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
tl;dr VK_EXT_image_drm_format_modifier will be in the next weekly
release of the Vulkan spec. But only in the git repo (asciidoc + xml)
not the official html spec nor headers. It should be enabled in the html
and headers in the following week.
...
Hi everyone, VK_EXT_image_drm_format_modifier is
On Fri 31 Aug 2018, Jason Ekstrand wrote:
> On Fri, Aug 31, 2018 at 4:35 PM Nanley Chery <[1]nanleych...@gmail.com> wrote:
>
> If that doesn't fix it, I think it'd be good to comment that we've
> observed this pipecontrol be necessary for 3DSTATE_WM_HZ_OP.
>
>
> I'm happy to add some co
form a hiz clear op, does the hw require the
WA before the second one? After all, no true "rendering operations"
occurred between the two.
Ahh! Why does the specification fail to specify???
Anyway, I convinced myself that genX(blorp_exec) emits the requested
bits before the problemati
On Tue 14 Aug 2018, Tapani Pälli wrote:
> Hi Chad;
>
> On 08/08/2018 06:53 PM, Tapani Pälli wrote:
> >
> >
> > On 07.08.2018 21:16, Chad Versace wrote:
> > > On Mon 06 Aug 2018, Chad Versace wrote:
> > > > On Fri 03 Aug 2018, Tapani Pälli wrote:
On Wed 08 Aug 2018, Bas Nieuwenhuizen wrote:
> ---
> src/vulkan/Makefile.am| 3 +
> src/vulkan/util/meson.build | 2 +
> src/vulkan/util/vk_entrypoints_gen.py | 515 ++
> src/vulkan/util/vk_extensions.py | 92 +
> src/vulkan/util/vk_e
On Wed 08 Aug 2018, Bas Nieuwenhuizen wrote:
> radv was always just mirroring a derived version of the anv
> version, sometimes hacked together and sometimes very behind.
>
> As we grow more vulkan drivers this repetition makes even less
> sense, so lets merge them. I took the anv generators as th
On Wed 08 Aug 2018, Bas Nieuwenhuizen wrote:
> This became kind of messy as python imports cannot really look up
> parent/sibling directories. I saw some scripts use sys.path but
> that became even more messy due to import locations.
>
> I also move the selections of the dispatch table out of the
On Tue 07 Aug 2018, Dylan Baker wrote:
> Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33)
>
>
>
Ignore this in favor of jasuarez's patch.
On Tue 07 Aug 2018, Chad Versace wrote:
> Fixes dEQP-EGL.functional.color_clears.single_context.gles2.rgb565_window.
>
> After initializing _EGLSurface::Width and ::Height to 0, Mesa did not
> update the width and height again unt
On Mon 06 Aug 2018, Chad Versace wrote:
> On Fri 03 Aug 2018, Tapani Pälli wrote:
> > One tiny nit below but for patches 3,4 and 5:
> >
> > Reviewed-by: Tapani Pälli
> >
> > Special thanks for the documentation. I want to go through rest of changes
>
> CC: Brendan King
> CC: mesa-sta...@lists.freedesktop.org
> Tested-by: Eric Engestrom
> ---
> src/egl/drivers/dri2/platform_wayland.c | 3 +++
> 1 file changed, 3 insertions(+)
Hah. I just sent an equivalent patch to the list. I'll drop my patch.
Just for patch 1,
Review
Fixes dEQP-EGL.functional.color_clears.single_context.gles2.rgb565_window.
After initializing _EGLSurface::Width and ::Height to 0, Mesa did not
update the width and height again until the DRI driver fetched its
buffers. This produced weird behavior:
* Immediately after surface creation, eglQue
th the
> image building. I'm hoping to resolve those soon and get back to business.
>
> On 07/31/2018 09:18 PM, Chad Versace wrote:
> > Define extensions DRI_MutableRenderBufferDriver and
> > DRI_MutableRenderBufferLoader. These are the two halves for
> > EGL_KHR_mutabl
On Tue 17 Jul 2018, Eric Engestrom wrote:
> On Thursday, 2018-07-12 16:13:55 -0700, David Riley wrote:
> > Allow platform_surfaceless to use swrast even if DRM is not available.
> > To be used to allow a fuzzer for virgl to be run on a jailed VM without
> > hardware GL or DRM support.
> >
> > Sign
If set, then the config will have __DRI_ATTRIB_MUTABLE_RENDER_BUFFER,
which translates to EGL_MUTABLE_RENDER_BUFFER_BIT_KHR.
Not used yet.
---
src/gallium/state_trackers/dri/dri_screen.c | 4 ++--
src/mesa/drivers/dri/common/utils.c | 9 +++--
src/mesa/drivers/dri/common/utils.h
Specifically, implement the extension DRI_MutableRenderBufferLoader.
However, the loader enables EGL_KHR_mutable_render_buffer only if the
DRI driver implements its half of the extension,
DRI_MutableRenderBufferDriver.
---
src/egl/drivers/dri2/egl_dri2.c | 38 +-
src/egl/drivers/dri2/
There exist *two* queryable EGL_RENDER_BUFFER states in EGL:
eglQuerySurface(EGL_RENDER_BUFFER) and
eglQueryContext(EGL_RENDER_BUFFER).
These changes eliminate potentially very fragile code in the upcoming
EGL_KHR_mutable_render_buffer implementation.
* eglQuerySurface(EGL_RENDER_BUFFER)
The i
If set, then the config will have __DRI_ATTRIB_MUTABLE_RENDER_BUFFER,
which translates to EGL_MUTABLE_RENDER_BUFFER_BIT_KHR.
Not used yet.
---
src/gallium/state_trackers/dri/dri_screen.c | 4 ++--
src/mesa/drivers/dri/common/utils.c | 9 +++--
src/mesa/drivers/dri/common/utils.h
Define extensions DRI_MutableRenderBufferDriver and
DRI_MutableRenderBufferLoader. These are the two halves for
EGL_KHR_mutable_render_buffer.
Outside the DRI code there is one additional change. Add
gl_config::mutableRenderBuffer to match
__DRI_ATTRIB_MUTABLE_RENDER_BUFFER. Neither are used yet.
A follow-up patch enables EGL_KHR_mutable_render_buffer for Android.
This patch is separate from the Android patch because I think it's
easier to review the platform-independent bits separately.
---
src/egl/main/eglapi.c | 1 +
src/egl/main/eglconfig.c | 3 ++
src/egl/main/egldisplay.h | 1
Tested with a low-latency handwriting application on Android Nougat on
the Chrome OS Pixelbook (codename Eve) with Kabylake.
---
src/mesa/drivers/dri/i965/brw_context.c | 86 +++-
src/mesa/drivers/dri/i965/brw_context.h | 12
src/mesa/drivers/dri/i965/intel_screen.c | 13
Specifically, implement the extension DRI_MutableRenderBufferLoader.
However, the loader enables EGL_KHR_mutable_render_buffer only if the
DRI driver implements its half of the extension,
DRI_MutableRenderBufferDriver.
---
src/egl/drivers/dri2/egl_dri2.c | 38 +-
src/egl/drivers/dri2/
This pulls an 'else' block into the function's main body, making the
code easier to follow.
Without this change, the upcoming EGL_KHR_mutable_render_buffer patch
transforms dri2_make_current() into spaghetti.
---
src/egl/drivers/dri2/egl_dri2.c | 29 +++--
1 file changed,
droid EGL.
* Patch 7 implements DRI_MutableRenderBufferDriver for i965.
This series is tagged at:
http://git.kiwitree.net/cgit/~chadv/mesa/log/?h=refs/tags/chadv/review/i965-mutable-render-buffer-v01
Chad Versace (7):
egl: Simplify queries for EGL_RENDER_BUFFER
egl/dri2: In dri2_make_curr
Ignore this series. It's incomplete. It seems mesa-dev had hiccups last
night.
I'll resend now.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Tested with a low-latency handwriting application on Android Nougat on
the Chrome OS Pixelbook (codename Eve) with Kabylake.
---
src/mesa/drivers/dri/i965/brw_context.c | 86 +++-
src/mesa/drivers/dri/i965/brw_context.h | 12
src/mesa/drivers/dri/i965/intel_screen.c | 13
In commit cf54bd5e8, dri_sw_winsys.c began using to support
the new functions putImageShm, getImageShm in DRI_SWRastLoader. But
Android began supporting System V shared memory only in Oreo. Nougat has
no shm headers.
Fix the build by ifdef'ing out the shm code on Nougat.
Fixes: cf54bd5e8 "drisw:
droid EGL.
* Patch 7 implements DRI_MutableRenderBufferDriver for i965.
This series is tagged at:
http://git.kiwitree.net/cgit/~chadv/mesa/log/?h=refs/tags/chadv/review/i965-mutable-render-buffer-v01
Chad Versace (7):
egl: Simplify queries for EGL_RENDER_BUFFER
egl/dri2: In dri2_make_curr
There exist *two* queryable EGL_RENDER_BUFFER states in EGL:
eglQuerySurface(EGL_RENDER_BUFFER) and
eglQueryContext(EGL_RENDER_BUFFER).
These changes eliminate potentially very fragile code in the upcoming
EGL_KHR_mutable_render_buffer implementation.
* eglQuerySurface(EGL_RENDER_BUFFER)
The i
Define extensions DRI_MutableRenderBufferDriver and
DRI_MutableRenderBufferLoader. These are the two halves for
EGL_KHR_mutable_render_buffer.
Outside the DRI code there is one additional change. Add
gl_config::mutableRenderBuffer to match
__DRI_ATTRIB_MUTABLE_RENDER_BUFFER. Neither are used yet.
This pulls an 'else' block into the function's main body, making the
code easier to follow.
Without this change, the upcoming EGL_KHR_mutable_render_buffer patch
transforms dri2_make_current() into spaghetti.
---
src/egl/drivers/dri2/egl_dri2.c | 29 +++--
1 file changed,
A follow-up patch enables EGL_KHR_mutable_render_buffer for Android.
This patch is separate from the Android patch because I think it's
easier to review the platform-independent bits separately.
---
src/egl/main/eglapi.c | 1 +
src/egl/main/eglconfig.c | 3 ++
src/egl/main/egldisplay.h | 1
On Thu 26 Jul 2018, Eric Engestrom wrote:
> On Thursday, 2018-07-26 02:03:58 -0700, Jason Ekstrand wrote:
> > On Thu, Jul 26, 2018 at 1:50 AM Eric Engestrom
> > wrote:
> >
> > > On Wednesday, 2018-07-25 14:00:29 -0700, Dylan Baker wrote:
> > > > Quoting Eric Engestrom (2018-07-25 11:45:56)
> > >
, 11 insertions(+), 5 deletions(-)
>
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Fri 27 Jul 2018, Brian Paul wrote:
> We need to pass the new flip_y argument.
> ---
> src/mesa/drivers/x11/xm_buffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks Brian.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http
2 +-
> 9 files changed, 43 insertions(+), 45 deletions(-)
For the series,
Reviewed-by: Chad Versace
I'll push soon.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Wed 25 Jul 2018, Tomasz Figa wrote:
> Hi Chad,
>
> On Wed, Jul 25, 2018 at 10:11 AM Chad Versace
> wrote:
> >
> > Problem 1: u_debug_stack_android.cpp transitively included
> > "pipe/p_compiler.h", but src/gallium/include was missing from the C++
>
Problem 1: u_debug_stack_android.cpp transitively included
"pipe/p_compiler.h", but src/gallium/include was missing from the C++
include path.
Problem 2: Add -std=c++11 to AM_CXXFLAGS. Android's libbacktrace headers
require C++11, but the Android toolchain (at least in the Chrome OS SDK)
does not
u_debug_stack_android.cpp transitively included "pipe/p_compiler.h", but
src/gallium/include was missing from the C++ include path.
Cc: Gurchetan Singh
Cc: Eric Engestrom
---
src/gallium/auxiliary/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxili
ping for review
On Wed 18 Jul 2018, Chad Versace wrote:
> In commit cf54bd5e8, dri_sw_winsys.c began using to support
> the new functions putImageShm, getImageShm in DRI_SWRastLoader. But
> Android began supporting System V shared memory only in Oreo. Nougat has
> no shm headers.
In commit cf54bd5e8, dri_sw_winsys.c began using to support
the new functions putImageShm, getImageShm in DRI_SWRastLoader. But
Android began supporting System V shared memory only in Oreo. Nougat has
no shm headers.
Fix the build by ifdef'ing out the shm code on Nougat.
Fixes: cf54bd5e8 "drisw:
The two patches look correct to me.
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Thu 12 Jul 2018, Jason Ekstrand wrote:
> On Wed, Jun 27, 2018 at 5:55 PM Chad Versace <[1]chadvers...@chromium.org>
> wrote:
>
> On Tue 26 Jun 2018, Jason Ekstrand wrote:
> > At the moment, this is entirely internal but we'll expose it to clients
>
On Wed 11 Jul 2018, Chad Versace wrote:
> +Ken, I had a question about GLboolean. I call you by name in the
> comments below.
>
> On Fri 29 Jun 2018, Fritz Koenig wrote:
> > Adds an extension to glFramebufferParameteri
> > that will specify if the framebuffer i
docs/specs/MESA_framebuffer_flip_y.spec
> b/docs/specs/MESA_framebuffer_flip_y.spec
> new file mode 100644
> index 00..dca77a9541
> --- /dev/null
> +++ b/docs/specs/MESA_framebuffer_flip_y.spec
> @@ -0,0 +1,84 @@
> +Name
> +
> +MESA_framebuffer_flip_y
> +
&
In a single call to vk_errorf() in the Android code, the arguments were
swapped. The bug has existed since day one. Chrome OS used to forgive
the warning, but it is now a compilation error.
Fixes: 053d4c32 "anv: Implement VK_ANDROID_native_buffer (v9)"
Cc: Tapani Pälli
Cc: Tomasz Figa
---
src/i
Changes to vk.xml and anv_entrypoints_gen.py broke the Autotools build
on Android. The changes undef'd the VK_ANDROID_native_buffer entrypoints in
anv_entrypoints.h.
Fix it with CPPFLAGS += -DVK_USE_PLATFORM_ANDROID_KHR.
See-Also: 63525ba7 "android: enable VK_ANDROID_native_buffer"
Cc: Tapani Päl
"If the source and destination dimensions are identical, no
> + *filtering is applied."
> + *
> + * Using BLORP_FILTER_NONE will also handle the upsample case by
> + * replicating the one value in the source to all values in the
> +
On Tue 26 Jun 2018, Jason Ekstrand wrote:
> At the moment, this is entirely internal but we'll expose it to clients
> of the BLORP API in the next commit.
> ---
> src/intel/blorp/blorp.h | 8 ++
> src/intel/blorp/blorp_blit.c | 212 +++
> src/intel/blorp/blor
On Wed 27 Jun 2018, Chad Versace wrote:
> On Fri 15 Jun 2018, Fritz Koenig wrote:
> > On Tue, Jun 12, 2018 at 12:28 PM Chad Versace
> > wrote:
> > >
> > > On Thu 07 Jun 2018, Fritz Koenig wrote:
>
> > > > --- a/src/mesa/main/extensions_table.
On Fri 15 Jun 2018, Fritz Koenig wrote:
> On Tue, Jun 12, 2018 at 12:28 PM Chad Versace
> wrote:
> >
> > On Thu 07 Jun 2018, Fritz Koenig wrote:
> > > --- a/src/mesa/main/extensions_table.h
> > > +++ b/src/mesa/main/extensions_t
Chromium OS uses Autotools and pkg-config when building Mesa for
Android. The gallium drivers were failing to find the headers and
libraries for zlib and Android's libbacktrace.
v2:
- Don't add a check for zlib.pc. configure.ac already checks for
zlib.pc elsewhere. [for tfiga]
- Check for
Chromium OS uses Autotools and pkg-config when building Mesa for
Android. The gallium drivers were failing to find the headers and
libraries for zlib and Android's libbacktrace.
---
configure.ac | 6 +-
src/gallium/Automake.inc | 5 +
src/gallium/auxiliary/Mak
On Thu 07 Jun 2018, Fritz Koenig wrote:
> Adds an extension to glFramebufferParameteri
> that will specify if the framebuffer is vertically
> flipped. Historically system framebuffers are
> vertically flipped and user framebuffers are not.
> Checking to see the state was done by looking at
> the na
On Thu 07 Jun 2018, Jason Ekstrand wrote:
> There are also a pile of places where we look at rb->Name == 0 to determine if
> it's a window-system framebuffer
For the public record, Fritz and I discussed this in person.
I recommend that the patches replace each checking on rb->Name == 0 to
instead
On Mon 07 May 2018, Miguel Casas wrote:
> This patch adds {X,A}BGR2101010 entries to the list of supported
> 'intel_image_formats'.
>
> Bug: https://crbug.com/776093
> ---
> src/mesa/drivers/dri/i965/intel_screen.c | 6 ++
> 1 file changed, 6 insertions(+)
Rev
t; 1 file changed, 8 insertions(+)
Reviewed-by: Chad Versace
We should drop the space in "{A, X}" before committing,
but the committer can apply that fix. No need to resend.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freede
On Wed 02 May 2018, Miguel Casas wrote:
> This patch adds {X,A}BGR2101010 entries to the list of supported
> |intel_image_formats|.
>
> BUG=https://crbug.com/776093
> TEST=Compile and deploy mesa this patch, then playback
> a VP9 Profile 2 video with sw decoder using crrev.com/c/897894.
> ---
> s
Thanks for the patches. The code looks good. All my suggestions are
merely nitpicks to make the patches follow Mesa conventions.
In general, if you have questions about commit message style, examine
the git log for previous patches that touched the same files and
directories as yours. Sometimes, d
On Wed 21 Feb 2018, Daniel Vetter wrote:
> On Tue, Feb 20, 2018 at 10:14:47PM -0800, Chad Versace wrote:
> > On Thu 21 Dec 2017, Daniel Vetter wrote:
> > > On Thu, Dec 21, 2017 at 12:22 AM, Kristian Kristensen
> > > wrote:
> > >> On Wed, Dec 20, 2017 at 12:
On Wed 24 Jan 2018, Jason Ekstrand wrote:
> Cc: Chad Versace
> ---
> src/intel/isl/isl.h | 24
> 1 file changed, 20 insertions(+), 4 deletions(-)
>
> diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
> index e3acb0e..cf53b5a 100644
> -
On Tue 20 Feb 2018, Jason Ekstrand wrote:
> On Mon, Feb 19, 2018 at 10:01 AM, Chad Versace <[1]chadvers...@chromium.org>
> wrote:
>
> On Wed 24 Jan 2018, Jason Ekstrand wrote:
> > We're about to start letting the intel_obj->_Format be the "real"
As many of you know, I've been writing a Vulkan extension for DRM format
modifiers, named VK_EXT_image_drm_format_modifier.
The extension is very close to completion. I've submitted a branch to
Khronos for review. It's receiving active review inside Khronos from
some non-Mesa closed-source window-
On Thu 21 Dec 2017, Daniel Vetter wrote:
> On Thu, Dec 21, 2017 at 12:22 AM, Kristian Kristensen
> wrote:
>> On Wed, Dec 20, 2017 at 12:41 PM, Miguel Angel Vico
>> wrote:
>>> On Wed, 20 Dec 2017 11:54:10 -0800 Kristian Høgsberg
>>> wrote:
I'd like to see concrete examples of actual displ
_image_mt(brw, texImage, internal_format, mt->format,
> mt);
I was unsure whether this hunk should've used mt->format or image->format.
After digging, I discovered that for EGLImages, image->format should ==
mt->format except
(1) for depth-stencil formats, which we don't care about and (2) when
intel_miptree_create_for_dri_image() does a rgbx->rgba fallback, in
which case we definitely want mt->format instead of image->format.
The hunk looks correct to me.
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Wed 24 Jan 2018, Jason Ekstrand wrote:
> We're about to start letting the intel_obj->_Format be the "real"
> texture format. For depth/stencil textures, this may be a combined
> depth stencil format. For ETC2 on gen7 and earlier, this will be the
> actual ETC2 format. This makes a bit more GL
On Wed 24 Jan 2018, Jason Ekstrand wrote:
> ---
> include/vulkan/vulkan.h| 54 ---
> src/vulkan/registry/vk.xml | 91
> +-
> 2 files changed, 130 insertions(+), 15 deletions(-)
Acked-b
On Wed 29 Nov 2017, Jason Ekstrand wrote:
> On Wed, Nov 29, 2017 at 2:24 PM, Chad Versace <[1]chadvers...@chromium.org>
> wrote:
>
> On Tue 28 Nov 2017, Jason Ekstrand wrote:
> > This lets us set the BO tiling when we allocate the memory. This is
> > re
or finished this off and making it more presentable,
>
> You might want to wait for Daniel or Chad to look some of it over, but
> I'm happy to
> give
>
> Reviewed-by: Dave Airlie
>
> for the whole series, it really makes the WSI and prime into a contained
> space,
ns(+)
Reviewed-by: Chad Versace
This is the end of the series, but I've left a few patches unreviewed.
I'll revisit them now.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
fails if either of x11 or
wayland initialization fails, even if the user requested only one of
VK_KHR_{xcb,xlib,wayland}_surface.
I filed https://bugs.freedesktop.org/show_bug.cgi?id=104039 .
But this patch is just a refactor patch, and it preserves the existing
(and possibly buggy) behavior. With the commit messag
.c | 77
> +
> src/vulkan/wsi/wsi_common.h | 72 +-
> src/vulkan/wsi/wsi_common_private.h | 34
> 5 files changed, 192 insertions(+), 83 deletions(-)
Patches 28 & 2
hanged, 47 insertions(+), 45 deletions(-)
Yay. It's becoming more layer-like.
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
an/radv_wsi.c | 15 ++-
> src/intel/vulkan/anv_wsi.c | 19 +++
> src/vulkan/wsi/wsi_common.c | 14 ++
> src/vulkan/wsi/wsi_common.h | 8
> 4 files changed, 43 insertions(+), 13 deletions(-)
Patch
aiting to see DestroyFence here since patch 17.
> for (uint32_t i = 0; i < chain->wsi->queue_family_count; i++) {
>chain->wsi->DestroyCommandPool(chain->device, chain->cmd_pools[i],
> &chain
+
> 6 files changed, 40 insertions(+), 57 deletions(-)
Patches 22 and 23 are
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Fri 01 Dec 2017, Chad Versace wrote:
> On Tue 28 Nov 2017, Jason Ekstrand wrote:
> > Neither mesa driver really cares, but we should set it none the less for
> > the sake of correctness.
> > ---
> > src/vulkan/wsi/wsi_common.c | 17 +
> &g
On Fri 01 Dec 2017, Chad Versace wrote:
> On Tue 28 Nov 2017, Jason Ekstrand wrote:
> > Neither mesa driver really cares, but we should set it none the less for
> > the sake of correctness.
> > ---
> > src/vulkan/wsi/wsi_common.c | 17 +
> &g
On Tue 28 Nov 2017, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_wsi.c | 63
> +-
> 1 file changed, 6 insertions(+), 57 deletions(-)
Reviewed-by: Chad Versace
___
mesa-dev mailing l
stage_flags;
Since VkSwapchain is required to be externally synchronized, you could
embed stage_flags directly in struct wsi_swapchain, doubling its size
when needed. But meh.
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tue 28 Nov 2017, Jason Ekstrand wrote:
> ---
> src/vulkan/wsi/wsi_common.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Smart. I was expecting a patch like this after reading patch 17.
Reviewed-by: Chad Versace
___
sentInfo)
> {
> - VkResult result = VK_SUCCESS;
> + VkResult final_result = VK_SUCCESS;
Yes please. The goto improves this code.
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
fence creation to the common code, the fence
destruction should also be moved from (anv|radv)_DestroySwapchainKHR to
wsi_swapchain_finish(). But, since that migration doesn't affect the
correctness of the patch, this patch is
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Patches 15 and 16 are
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
ns(+), 303 deletions(-)
This patch is
Reviewed-by: Chad Versace
This series is a good improvement over the old code :)
But I found some nits:
- The Vulkan spec, iirc, requires that vkCreateFoo not modify its
output parameter on failure. The memset in this patch breaks that
requireme
On Tue 28 Nov 2017, Jason Ekstrand wrote:
> We need it to happen after memory type setup so that we can query memory
> types in wsi_device_init.
> ---
> src/amd/vulkan/radv_device.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
Patches 10-12 are
Reviewed-b
si-prime branch, patches 6 & 7 are
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tue 28 Nov 2017, Jason Ekstrand wrote:
> ---
> src/vulkan/wsi/wsi_common.h | 18 ++
> 1 file changed, 18 insertions(+)
Patches 1-5 are
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.
int32_t
> +anv_wsi_queue_get_family_index(VkQueue _queue)
This function should have the 'radv' prefix, not 'anv'.
Other than that, this patch is
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
p://git.kiwitree.net/cgit/~chadv/vk-gl-cts/log/?h=pu
fwiw, this series is
Tested-by: Chad Versace
btw, if you'd like to see the branch where I'm integrating this into
ARC++, it's
http://git.kiwitree.net/cgit/~chadv/mesa/log/?h
1 - 100 of 2820 matches
Mail list logo
