On Wed 14 Nov 2018, Eric Engestrom wrote:
> On Tuesday, 2018-11-13 14:10:45 +0000, Lionel Landwerlin wrote:
> > According to the EGL_EXT_image_dma_buf_import spec, creating an EGL
> > image with a DRM format not supported should yield the BAD_MATCH
> > error :
> >
> > "
> > * If <target> is EGL_LINUX_DMA_BUF_EXT, and the
> > EGL_LINUX_DRM_FOURCC_EXT
> > attribute is set to a format not supported by the EGL,
> > EGL_BAD_MATCH
> > is generated.
> > "
> >
> > Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com>
> > Fixes: 20de7f9f226401 ("egl/dri2: support for creating images out of dma
> > buffers")
>
> That matches the spec, so:
> Reviewed-by: Eric Engestrom <eric.engest...@intel.com>
>
> That said, Topi specifically wrote this, in his commit (20de7f9f226401):
> > v4 (Chad):
> > - in case of invalid format report EGL_BAD_ATTRIBUTE instead
> > of EGL_BAD_MATCH
>
> So cc'ing them both so they can mention if they had a need for this?
Huh... I don't recall why I suggested EGL_BAD_ATTRIBUTE. But this patch
matches the spec.
Reviewed-by: Chad Versace <chadvers...@chromium.org>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
