Re: [Mesa-dev] [PATCH] glsl: Add gl_MaxViewports to available builtin constants

2014-12-14 Thread Maxence Le Doré
ll shaders. The actual values used are implementation dependent, but must be at least the value shown. Some are deprecated, as indicated in comments." Follows a list where gl_MaxViewports is. 2014-12-12 22:12 GMT+01:00 Maxence Le Doré : > > I had exactly the same feeling while adding

[Mesa-dev] [PATCH] glsl: Add gl_MaxViewports to available builtin constants

2014-12-09 Thread Maxence Le Doré
It seems to have been forgotten during viewports array implementation time. --- src/glsl/builtin_variables.cpp | 4 src/glsl/glsl_parser_extras.cpp | 3 +++ src/glsl/glsl_parser_extras.h | 3 +++ 3 files changed, 10 insertions(+) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/buil

[Mesa-dev] [PATCH] mesa: remove duplicated init of MaxViewports

2014-01-26 Thread Maxence Le Doré
From: Maxence Le Doré Already declared 5 lines before. --- src/mesa/main/context.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index b7cd568..98025bc 100644 --- a/src/mesa/main/context.c +++ b/src/mesa/main/context.c @@ -595,9 +595,6

Re: [Mesa-dev] mesa-dev Digest, Vol 46, Issue 190

2014-01-16 Thread Maxence Le Doré
Those of Fredrik of course, since his implementation is better, I no more work on multi bind. 2014/1/16 : > Send mesa-dev mailing list submissions to > mesa-dev@lists.freedesktop.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://lists.freedesktop.org/mailm

Re: [Mesa-dev] [PATCH 5/9] tgsi: implement micro_fma() in tgsi exec machine

2014-01-07 Thread Maxence Le Doré
: > On Tue, Jan 7, 2014 at 6:46 PM, Maxence Le Doré > wrote: >> Indeed, this patch compiles on linux but may break complilation at >> least on MSVC version < 1400. >> I'm planing to install visual studio 2005 on a ms xp or seven virtual >> machine to check

Re: [Mesa-dev] [PATCH 4/9] gallium-tgsi: add TGSI_OPCODE_{FMA-POPCNT-MSB-LSB} description

2014-01-07 Thread Maxence Le Doré
For this reason, GLSL 4.0 introduces the 'precise' qualifier. I invite you to take a look at this article. 2014/1/6 Roland Scheidegger : > Am 05.01.2014 01:34, schrieb Maxence Le Doré: >> FMA(a,b,c) keeps extra precision (usually 1 more bit of mantissa, >> afaik) for th

Re: [Mesa-dev] [PATCH 4/9] gallium-tgsi: add TGSI_OPCODE_{FMA-POPCNT-MSB-LSB} description

2014-01-07 Thread Maxence Le Doré
I forgot the link : http://www.geeks3d.com/20120106/precise-qualifier-in-glsl-and-nvidia-geforce-cards/ 2014/1/7 Maxence Le Doré : > For this reason, GLSL 4.0 introduces the 'precise' qualifier. I invite > you to take a look at this article. > > 2014/1/6 Roland Scheidegger

[Mesa-dev] [PATCH] glsl: rename min(), max() functions to fix MSVC build

2014-01-07 Thread Maxence Le Doré
Thanks Brian. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/9] tgsi: implement micro_fma() in tgsi exec machine

2014-01-07 Thread Maxence Le Doré
5, 2014 at 12:42 AM, Maxence Le Doré > wrote: >> From: Maxence Le Doré > > Huh, user.email not configured properly? > >> static void >> +micro_fma(union tgsi_exec_channel *dst, >> + const union tgsi_exec_channel *src0, >> + const uni

Re: [Mesa-dev] [PATCH 1/7] intel: support factors for min/max blending

2014-01-07 Thread Maxence Le Doré
Thanks Ian, I got this after a rebase. Didn't know were it comes from. 2014/1/6 Ian Romanick : > On 01/02/2014 05:18 PM, Maxence Le Doré wrote: >> --- >> src/mesa/drivers/dri/i915/i830_state.c | 12 >> src/mesa/drivers/dri/i965/brw_util.c | 24 ++

Re: [Mesa-dev] [PATCH 3/7] mesa: implement glBindTextures()

2014-01-07 Thread Maxence Le Doré
Thanks Fredrik, I was nearly sure this was ok from what I read of the specs. And you're also right again : I totally forget a case where a texture has never been bound ! 2014/1/7 Maxence Le Doré : > Thanks Fredrik, > I was nearly sure this was ok from what I read of the specs. And &g

Re: [Mesa-dev] [PATCH 1/7] mesa: implement glBindBuffersBase() and gl BindBuffersRange()

2014-01-07 Thread Maxence Le Doré
You are absolutly right. I followed the way specification illustrate implementation for simplicity reasons but had always in mind that this was not the way to get any performance benefit and hoped that I are somebody else could improve this later. That's a great thing you already did this and don't

Re: [Mesa-dev] [PATCH 4/9] gallium-tgsi: add TGSI_OPCODE_{FMA-POPCNT-MSB-LSB} description

2014-01-04 Thread Maxence Le Doré
something very appreciate. 2014/1/5 Marek Olšák : > How is FMA different from MAD? > > Please document the new opcodes in src/gallium/docs/source/tgsi.rst. > > Marek > > On Sun, Jan 5, 2014 at 12:42 AM, Maxence Le Doré > wrote: >> From: Maxence Le Doré >> &

[Mesa-dev] [PATCH 9/9] st-glsl: handle more glsl IR in glsl_to_tgsi_visitor::visit()

2014-01-04 Thread Maxence Le Doré
From: Maxence Le Doré --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 726b574..7c1f4e2 100644 --- a/src

[Mesa-dev] [PATCH 7/9] tgsi: implement micro_ilsb() and micro_ulsb()

2014-01-04 Thread Maxence Le Doré
From: Maxence Le Doré --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c index ddff409..aa1b140 100644 --- a/src/gallium/auxiliary

[Mesa-dev] [PATCH 8/9] tgsi: implement micro_imsb() and micro_umsb()

2014-01-04 Thread Maxence Le Doré
From: Maxence Le Doré --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 44 ++ 1 file changed, 44 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c index aa1b140..10bce5e 100644 --- a/src/gallium/auxiliary

[Mesa-dev] [PATCH 5/9] tgsi: implement micro_fma() in tgsi exec machine

2014-01-04 Thread Maxence Le Doré
From: Maxence Le Doré --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c index b614907..25d3373 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_exec.c

[Mesa-dev] [PATCH 6/9] tgsi: implement micro_popcnt() in tgsi exec machine

2014-01-04 Thread Maxence Le Doré
From: Maxence Le Doré --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c index 25d3373..ddff409 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_exec.c +++ b

[Mesa-dev] [PATCH 4/9] gallium-tgsi: add TGSI_OPCODE_{FMA-POPCNT-MSB-LSB} description

2014-01-04 Thread Maxence Le Doré
From: Maxence Le Doré --- src/gallium/auxiliary/tgsi/tgsi_info.c | 16 src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h | 6 ++ src/gallium/include/pipe/p_shader_tokens.h | 9 - 3 files changed, 30 insertions(+), 1 deletion(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 3/9] util: add fma3 or fma4 capable cpu detection

2014-01-04 Thread Maxence Le Doré
From: Maxence Le Doré --- src/gallium/auxiliary/util/u_cpu_detect.c | 5 + src/gallium/auxiliary/util/u_cpu_detect.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/src/gallium/auxiliary/util/u_cpu_detect.c b/src/gallium/auxiliary/util/u_cpu_detect.c index d2d1313..19ad4fa 100644

[Mesa-dev] [PATCH 1/9] gallivm: add a lp_build_intrinsic_map_trinary() function

2014-01-04 Thread Maxence Le Doré
From: Maxence Le Doré --- src/gallium/auxiliary/gallivm/lp_bld_intr.c | 16 src/gallium/auxiliary/gallivm/lp_bld_intr.h | 9 + 2 files changed, 25 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_intr.c b/src/gallium/auxiliary/gallivm/lp_bld_intr.c

[Mesa-dev] [PATCH 2/9] gallivm: add a lp_build_intrinsic_trinary() function

2014-01-04 Thread Maxence Le Doré
From: Maxence Le Doré --- src/gallium/auxiliary/gallivm/lp_bld_intr.c | 18 ++ src/gallium/auxiliary/gallivm/lp_bld_intr.h | 9 + 2 files changed, 27 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_intr.c b/src/gallium/auxiliary/gallivm/lp_bld_intr.c

Re: [Mesa-dev] [PATCH 5/7] mesa: add support for AMD_blend_minmax_factor

2014-01-03 Thread Maxence Le Doré
base : tests/general/blendminmax.c tests/general/blendsquare.c 2014/1/3 Roland Scheidegger : > Am 03.01.2014 02:18, schrieb Maxence Le Doré: >> --- >> src/mesa/main/blend.c | 3 +++ >> src/mesa/main/extensions.c | 1 + >> src/mesa/main/mtypes.h | 1 + >>

[Mesa-dev] [PATCH 6/7] mesa: enable ARB_blend_minmax_factor

2014-01-02 Thread Maxence Le Doré
... where it can be. --- src/mesa/drivers/dri/i915/intel_extensions.c | 1 + src/mesa/drivers/dri/i965/intel_extensions.c | 1 + src/mesa/drivers/dri/r200/r200_context.c | 1 + src/mesa/main/extensions.c | 1 + src/mesa/state_tracker/st_extensions.c | 1 + 5 files chang

[Mesa-dev] [PATCH 3/7] swrast: support factors for min/max blending

2014-01-02 Thread Maxence Le Doré
--- src/mesa/swrast/s_blend.c | 16 1 file changed, 16 insertions(+) diff --git a/src/mesa/swrast/s_blend.c b/src/mesa/swrast/s_blend.c index 1037b62..59ffa7a 100644 --- a/src/mesa/swrast/s_blend.c +++ b/src/mesa/swrast/s_blend.c @@ -767,6 +767,16 @@ blend_general_float(struct gl

[Mesa-dev] [PATCH 2/7] r200: support factors for min/max blending

2014-01-02 Thread Maxence Le Doré
--- src/mesa/drivers/dri/r200/r200_state.c | 16 1 file changed, 16 insertions(+) diff --git a/src/mesa/drivers/dri/r200/r200_state.c b/src/mesa/drivers/dri/r200/r200_state.c index ee7b945..db232f6 100644 --- a/src/mesa/drivers/dri/r200/r200_state.c +++ b/src/mesa/drivers/dri/r2

[Mesa-dev] [PATCH 7/7] nouveau: allow blend_minmax_factor

2014-01-02 Thread Maxence Le Doré
Sound strange if nvidia would had chosen a different implementation of min/max blending (where even intel i830 allow factors with min/max blending). Indeed, the driver doesn't set src and dst factors to ONE when GL_MIN or GL_MAX are set as blend equation. Maybe Francisco Jerez (going to ask him) si

[Mesa-dev] [PATCH 5/7] mesa: add support for AMD_blend_minmax_factor

2014-01-02 Thread Maxence Le Doré
--- src/mesa/main/blend.c | 3 +++ src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 3 files changed, 5 insertions(+) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 9e11ca7..4995143 100644 --- a/src/mesa/main/blend.c +++ b/src/mesa/main/blend.c @@ -326,6 +

[Mesa-dev] [PATCH 4/7] st: add blend states from AMD_blend_minmax_factor

2014-01-02 Thread Maxence Le Doré
--- src/mesa/state_tracker/st_atom_blend.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/state_tracker/st_atom_blend.c b/src/mesa/state_tracker/st_atom_blend.c index dea50af..7453053 100644 --- a/src/mesa/state_tracker/st_atom_blend.c +++ b/src/mesa/state_tracker/st_atom_blen

[Mesa-dev] [PATCH 1/7] intel: support factors for min/max blending

2014-01-02 Thread Maxence Le Doré
--- src/mesa/drivers/dri/i915/i830_state.c | 12 src/mesa/drivers/dri/i965/brw_util.c | 24 +--- 2 files changed, 25 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i915/i830_state.c b/src/mesa/drivers/dri/i915/i830_state.c index bbf0cef..6a5db

[Mesa-dev] [PATCH 5/7] mesa: implement glBindSamplers()

2014-01-02 Thread Maxence Le Doré
--- src/mesa/main/samplerobj.c | 36 src/mesa/main/samplerobj.h | 2 ++ 2 files changed, 38 insertions(+) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index 7285ef5..a219630 100644 --- a/src/mesa/main/samplerobj.c +++ b/src/mesa/main/s

[Mesa-dev] [PATCH 4/7] mesa: implement glBindVertexBuffers()

2014-01-02 Thread Maxence Le Doré
--- src/mesa/main/varray.c | 53 ++ src/mesa/main/varray.h | 3 +++ 2 files changed, 56 insertions(+) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index 0f38270..cf21770 100644 --- a/src/mesa/main/varray.c +++ b/src/mesa/main/varray

[Mesa-dev] [PATCH 7/7] mesa: enable ARB_multi_bind

2014-01-02 Thread Maxence Le Doré
--- src/mesa/main/extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index f0e1858..968b88d 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -112,6 +112,7 @@ static const struct extension extension_tab

[Mesa-dev] [PATCH 6/7] mesa: dispatch ARB_multi_bind API

2014-01-02 Thread Maxence Le Doré
--- src/mapi/glapi/gen/ARB_multi_bind.xml | 57 + src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml | 2 ++ src/mesa/main/tests/dispatch_sanity.cpp | 8 + 4 files changed, 68 insertions(+) create mode 100644 src/mapi/gl

[Mesa-dev] [PATCH 2/7] mesa: add an index_to_target_enum() function

2014-01-02 Thread Maxence Le Doré
From: Maxence Le Doré --- src/mesa/main/texobj.c | 40 1 file changed, 40 insertions(+) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index d6510fe..bddbc50 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -1218,6

[Mesa-dev] [PATCH 3/7] mesa: implement glBindTextures()

2014-01-02 Thread Maxence Le Doré
--- src/mesa/main/texobj.c | 52 ++ src/mesa/main/texobj.h | 3 +++ 2 files changed, 55 insertions(+) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index bddbc50..66e2fb0 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj

[Mesa-dev] [PATCH 1/7] mesa: implement glBindBuffersBase() and gl BindBuffersRange()

2014-01-02 Thread Maxence Le Doré
--- src/mesa/main/bufferobj.c | 158 ++ src/mesa/main/bufferobj.h | 9 ++- 2 files changed, 165 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index a3d8f24..bad8f90 100644 --- a/src/mesa/main/bufferob

[Mesa-dev] AMD_shader_trinary_minmax V2 changes

2014-01-02 Thread Maxence Le Doré
- Correct typo in predicate function - Split the patch that introduces ir_builder changes - Drop trivial min3_expr(), max3_expr(), mid3_expr() - Thanks to Roland Scheidegger and Mario Rugiero, catch all cases for evaluation of mid3 - Squash trivial patches. Tried something to fix my weird mail ad

Re: [Mesa-dev] More projects for newbies

2013-11-23 Thread Maxence Le Doré
I have initial work on ARB_clear buffer_object for swrast there : https://github.com/maxenceledore/mesa/commit/64e74a37118950d396392e38d6246d559049753f Untested. And this is a ugly single patch implementation. Gonna split it shortly. AMD_shader_trinary_minmax : I have "played" with AMD_shader_tr

[Mesa-dev] enable ARB_seamless_cubemap_per_texture

2013-08-21 Thread Maxence Le Doré
As ARB_seamless_cubemap_per_texture is word-to-word same as AMD_seamless_cubemap_per_texture and this last already implemented we can enable the ARB extension. This patch is a candidate for it : >From eb2cf312a7c7ba70f22f8eb8d66aab8a1d78b6d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maxence=20Le=20

[Mesa-dev] (no subject)

2013-08-21 Thread Maxence Le Doré
As ARB_seamless_cubemap_per_texture is word-to-word same as AMD_seamless_cubemap_per_texture and this last already implemented we can enable the ARB extension. This patch is a candidate for it : >From eb2cf312a7c7ba70f22f8eb8d66aab8a1d78b6d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maxence=20Le=20

Re: [Mesa-dev] Another Take on the S3TC issue

2013-08-13 Thread Maxence Le Doré
Maybe it's time let S3TC go away and think about something else. Like BPTC. I've started something. Currently, this is very dirty. Please, take a quick look at this : https://docs.google.com/file/d/0B1BiksMm0x0GVjZPZHgyNm0xLVE/edit?usp=sharing Yeah, I know. Ugly. But it basically works. I can n

[Mesa-dev] [PATCH] gallivm/util: implement requested ubyte to float lookup function

2013-03-10 Thread Maxence Le Doré
This was a suggested rework as a todo. The only thing that annoy me is that the table is initialized in math init function with logarithm and exponential tables. And ubyte_to_float is not a math function in a way comparable to exp and log. Feel free to suggest me or do by yourself a modificatio

[Mesa-dev] [PATCH] util: fix wrong shift val for a cpu feature detect

2013-03-06 Thread Maxence Le Doré
While I was trying to understand how cpu features detection works, I noticed that every was coherent except for the TSC ( Time Stamp Counter). I found many pages on the net that suggest that the right value for the corresponding shift would be 4 and not 8. Even the commented bitfields that repr

[Mesa-dev] [MESA][PATCH] tgsi: fix mis-matching AOS instruction emission

2013-02-27 Thread Maxence Le Doré
Catched this that morning >From e50374e62254e7532c695bebb3e608242638bb73 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maxence=20Le=20Dor=C3=A9?= Date: Wed, 27 Feb 2013 10:24:10 +0100 Subject: [PATCH] tgsi: fix mis-matching instruction emission --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c |

[Mesa-dev] [PATCH] r600: silent warnings

2012-12-12 Thread Maxence Le Doré
GCC complains about mixed code and declarations and unhandled enum cases when compiling r600. This patch correct it : >From 25b5d12eec732ed582a8a3e146c0285819806ba8 Mon Sep 17 00:00:00 2001 From: Maxence Le Dore Date: Thu, 13 Dec 2012 05:17:35 +0100 Subject: [PATCH] r600: silent warnings --- sr

[Mesa-dev] mesa : ARB_texture_gather implementation - WIP[PATCH1/1] but need advice !

2012-11-12 Thread Maxence Le Doré
Here is a patch against master branch that takes a good way to implement ARB_texture_gather over softpipe but I have the regret to announce that I can't find what i'm doing wrong at a point : At compilation time, more precisely glsl code compilation, a file "builtin_function.cpp" is generated by p

[Mesa-dev] [PATCH 1/1] mesa : OpenGL ES 3 support improvement regarding seamless cubemap state

2012-11-08 Thread Maxence Le Doré
Hi everyone, I took a look at OpenGl ES 3.0 this summer and noticed a little something than seems to still lack to the current implementation in mesa. It's about the support of seamless cube maps. The spec seems to suggest that linearly flltered cube maps should always be seamless, regarless of an