Reviewed-by: Juha-Pekka Heikkila
:)
/Juha-Pekka
22. maaliskuuta 2017 18.58.13 GMT+02:00 Emil Velikov
kirjoitti:
>From: Emil Velikov
>
>No longer needed as of commit ac257f1070a ("glsl: calculate
>TOP_LEVEL_ARRAY_SIZE and STRIDE when adding resources")
>
>Cc: Juha-Pekka Heikkila
>Reported-b
Hi Iago,
I know there are lot of places where there is malloc unchecked still
-- and then there is ralloc which is a story of its own. Reason why I
think checking these would be remotely useful in windows only (or
other way around, not under linux kernel) is on Windows one can get
the null pointer
perjantai 8. toukokuuta 2015 Ian Romanick kirjoitti:
> On 05/07/2015 05:21 AM, Pohjolainen, Topi wrote:
> > On Tue, May 05, 2015 at 02:25:29PM +0300, Juha-Pekka Heikkila wrote:
> >> Stop context creation if something failed. If something errored
> >> during context creation we'd segfault. Now wil
On Wed, Sep 3, 2014 at 7:31 PM, Brian Paul wrote:
> On 08/28/2014 06:51 AM, Juha-Pekka Heikkila wrote:
>>
>> Here is new version of my patch set for using Pixman in Mesa
>> for texture format conversions, mostly complete rewrite after recent
>> changes in src/mesa/main/texstore.c. This set does no
this set 1..5 are
Reviewed-by: Juha-Pekka Heikkila
On Sun, Jun 1, 2014 at 10:58 PM, Matt Turner wrote:
> From: Ian Romanick
>
> This has the added perk that if you forget to set ir_type in the
> constructor of a new subclass (or a new constructor of an existing
> subclass) the compiler will te
Reviewed-by: Juha-Pekka Heikkila
On Fri, May 30, 2014 at 10:11 AM, Tapani Pälli wrote:
> to have _mesa_error_no_memory function available
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79440
> Signed-off-by: Tapani Pälli
> ---
> src/glsl/SConscript | 2 +-
> 1 file changed, 1 inser
Reviewed-by: Juha-Pekka Heikkila
On Fri, May 30, 2014 at 7:47 AM, Tapani Pälli wrote:
> So that prog_hash_table can use _mesa_error_no_memory function.
>
> Signed-off-by: Tapani Pälli
> ---
> src/glsl/Makefile.am | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/glsl/Makefile.am b/s
On Mon, May 19, 2014 at 9:55 PM, Matt Turner wrote:
> ---
> src/mesa/drivers/dri/i965/brw_vec4.h | 4 +-
> src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 109
> +--
> 2 files changed, 66 insertions(+), 47 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i9
On Mon, May 19, 2014 at 9:55 PM, Matt Turner wrote:
> ---
> src/mesa/drivers/dri/i965/brw_fs.h | 4 +-
> src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 156
> -
> 2 files changed, 77 insertions(+), 83 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965
Reviewed-by: Juha-Pekka Heikkila
On Mon, May 19, 2014 at 9:55 PM, Matt Turner wrote:
> ... to tell us whether it emitted any code. Will be used to determine
> whether we need to skip an annotation for it.
> ---
> src/mesa/drivers/dri/i965/brw_fs.h | 4 ++--
> src/mesa/drivers/dri/i
Reviewed-by: Juha-Pekka Heikkila
On Mon, May 19, 2014 at 9:55 PM, Matt Turner wrote:
> Were used by the blorp unit test programs.
> ---
> src/mesa/drivers/dri/i965/brw_blorp_blit.cpp| 20
> src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 4 ++--
> src/mesa/drivers/dr
On Tue, May 6, 2014 at 7:37 PM, Matt Turner wrote:
> On Tue, May 6, 2014 at 3:53 AM, Juha-Pekka Heikkila
> wrote:
>> Signed-off-by: Juha-Pekka Heikkila
>> ---
>> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 15 ++-
>> 1 file changed, 10 insertions(+), 5 deletions(-)
>>
>> diff --g
On Tue, May 6, 2014 at 7:32 PM, Eric Anholt wrote:
> Juha-Pekka Heikkila writes:
>
>> These patches allow MAD opcode to be used with pre gen6 hardware.
>> Instead of failing on emitting MAD there will be emitted MUL and ADD
>> to simulate MAD.
>>
>> I tried this with piglit on ILK (gen5) and did
o it or is there some more convenient way?
On Thu, Apr 10, 2014 at 3:48 PM, Juha-Pekka Heikkilä
wrote:
> Hi Matt,
>
> the changed set looks good to me, I did side by side comparison on
> what had changed but did not try to run it today. I realized
> immediately when seeing your com
On Thu, Apr 10, 2014 at 1:18 AM, Kenneth Graunke wrote:
> On 04/09/2014 01:47 PM, Matt Turner wrote:
>> From: Juha-Pekka Heikkila
>>
>> Our hardware has an "accumulator" register, which can be used to store
>> intermediate results across multiple instructions. Many instructions
>> can implicitly
Hi Matt,
the changed set looks good to me, I did side by side comparison on
what had changed but did not try to run it today. I realized
immediately when seeing your comment I had not understood to consider
the "WAR" vs. "RAW" comments in the scheduler. I was thinking when I
made the latest set th
On Mon, Apr 7, 2014 at 11:21 PM, Emil Velikov wrote:
> On 07/04/14 21:06, Juha-Pekka Heikkilä wrote:
>> Hmm... Wonder where my patches 9..12 vanished. They show in git
>> send-email as "Result: 250 ok: Message ### accepted". If they don't
>> magically s
Hmm... Wonder where my patches 9..12 vanished. They show in git
send-email as "Result: 250 ok: Message ### accepted". If they don't
magically show up here I will resend entire set tomorrow from better
connection.
/Juha-Pekka
On Mon, Apr 7, 2014 at 10:48 PM, Juha-Pekka Heikkila
wrote:
> Set of p
On Tue, Mar 25, 2014 at 7:46 PM, Matt Turner wrote:
> On Tue, Mar 25, 2014 at 5:40 AM, Juha-Pekka Heikkila
> wrote:
>> Again fixed my Klocwork set. I reworked Ian's patch because my set depend on
>> it and Ian's patch seem to have vanished in the void. It needed a small
>> update
>> because it w
I think I would need some hints here, I don't know how to test my
changes now properly.
On Sat, Mar 22, 2014 at 8:26 AM, Matt Turner wrote:
> On Fri, Mar 21, 2014 at 11:17 PM, Matt Turner wrote:
>> On Fri, Mar 21, 2014 at 7:33 AM, Juha-Pekka Heikkila
>> wrote:
>>> Our hardware has an "accumulat
lcpp_LDADD =\
libglcpp.la \
-lm
I did not see anything that would have changed to affect this from my
earlier rebases thus I am puzzled how make check did work earlier for
me. :/
/Juha-Pekka
On Tue, Mar 4, 2014 at 4:04 PM,
On Tue, Mar 4, 2014 at 3:41 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> This can be called from locations that don't have a context pointer
> handy. This patch also adds enough infrastructure so that the unit
> tests for the GLSL compiler and the stand-alone compiler will build and
> functi
On Mon, Feb 17, 2014 at 11:03 PM, Ian Romanick wrote:
> On 02/17/2014 08:21 AM, Juha-Pekka Heikkila wrote:
>> Resend of the earlier glx patches with the issue pointed out by Petri fixed.
>>
>> Patch number five is a bit special. hash_table_insert() and
>> hash_table_replace() don't really have a w
On Wed, Feb 19, 2014 at 4:35 AM, Ian Romanick wrote:
> On 02/09/2014 01:50 AM, Juha-Pekka Heikkilä wrote:
>> The place which cause Klocwork to highlight this is at
>> src/mesa/main/ff_fragment_shader.cpp around line 897 where it says:
>>
>> ...
>> float con
On Tue, Feb 18, 2014 at 9:40 AM, Chia-I Wu wrote:
> On Tue, Feb 18, 2014 at 12:21 AM, Juha-Pekka Heikkila
> wrote:
>> _eglInitResource() was used to memset entire _EGLSync by
>> writing more than size of pointed target. This does work
>> as long as Resource is the first element in _EGLSync,
>> th
Ah, you're correct. I'll fix that.
/Juha-Pekka
On Tue, Feb 11, 2014 at 4:18 PM, Petri Latvala wrote:
> On 02/11/2014 04:07 PM, Juha-Pekka Heikkila wrote:
>>
>> Signed-off-by: Juha-Pekka Heikkila
>> ---
>> src/glx/indirect_glx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> d
The place which cause Klocwork to highlight this is at
src/mesa/main/ff_fragment_shader.cpp around line 897 where it says:
...
float const_data[4] = {
float(1 << rgb_shift),
float(1 << rgb_shift),
float(1 << rgb_shift),
float(1 << alpha_shift)
};
shif
On Thu, Jan 16, 2014 at 8:48 PM, Matt Turner wrote:
> On Thu, Jan 16, 2014 at 2:59 AM, Juha-Pekka Heikkila
> wrote:
>> Signed-off-by: Juha-Pekka Heikkila
>> ---
>> src/glsl/builtin_variables.cpp | 24
>> 1 file changed, 20 insertions(+), 4 deletions(-)
>>
>> diff --git
On Thu, Dec 12, 2013 at 3:14 AM, Brian Paul wrote:
> On 12/11/2013 02:05 AM, Juha-Pekka Heikkila wrote:
>>
>> Change save_attrib_data() to return true/false depending on success.
>>
>> Signed-off-by: Juha-Pekka Heikkila
>
>
> I'd like to reconsider these changes from scratch.
>
> The basic issue
On Tue, Dec 3, 2013 at 6:42 PM, Brian Paul wrote:
> On 12/02/2013 02:39 AM, Juha-Pekka Heikkila wrote:
>>
>> Check if any of the callocs fail and report it with _mesa_error
>> if needed.
>>
>> Signed-off-by: Juha-Pekka Heikkila
>> ---
>> src/mesa/main/attrib.c | 34 +
On Tue, Dec 3, 2013 at 6:51 PM, Ian Romanick wrote:
> On 12/02/2013 01:39 AM, Juha-Pekka Heikkila wrote:
>> Check if any of the callocs fail and report it with _mesa_error
>> if needed.
>>
>> Signed-off-by: Juha-Pekka Heikkila
>> ---
>> src/mesa/main/attrib.c | 106
>> ++
On Tue, Dec 3, 2013 at 6:39 PM, Brian Paul wrote:
> On 12/02/2013 02:39 AM, Juha-Pekka Heikkila wrote:
>>
>> Signed-off-by: Juha-Pekka Heikkila
>> ---
>> src/glx/clientattrib.c | 5 +
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/src/glx/clientattrib.c b/src/glx/clientattrib.c
>> i
On Mon, Nov 25, 2013 at 7:12 PM, Ian Romanick wrote:
> On 11/25/2013 07:23 AM, Juha-Pekka Heikkila wrote:
> > Extra null check before accessing user given context pointer.
>
> oldGC can never be NULL. If there is no current context, it will point
> to dummyContext.
>
Ah, ok. I was just going thr
33 matches
Mail list logo
