Re: [Mesa-dev] [PATCH] mesa: Avoid C99 indexed initializers.

2012-10-10 Thread Imre Deak
On Wed, 2012-10-10 at 12:25 +0100, jfons...@vmware.com wrote: > From: José Fonseca > > Not supported by MSVC. > > Just compiled tested. > --- My mistake, I wasn't aware of such limitations and I haven't checked whether things work with MSVC. In any case it looks

[Mesa-dev] [PATCH v3 8/8] mesa: glGet: remove the unused TYPE_API_MASK flags

2012-10-01 Thread Imre Deak
Since we generate the hash tables in build time, these flags aren't used any more, remove them. Signed-off-by: Imre Deak Reviewed-by: Brian Paul --- src/mesa/main/get.c |6 -- 1 file changed, 6 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index c5ccd66..b9

[Mesa-dev] [PATCH v3 7/8] mesa: glGet: use the build time generated hash tables

2012-10-01 Thread Imre Deak
Signed-off-by: Imre Deak Reviewed-by: Brian Paul --- src/mesa/main/get.c| 1026 +--- src/mesa/main/mtypes.h |2 - 2 files changed, 13 insertions(+), 1015 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 6c32f81

[Mesa-dev] [PATCH v3 5/8] scons/android: add flag to check for enabled GL APIs

2012-10-01 Thread Imre Deak
Needed by the next patch. Signed-off-by: Imre Deak Reviewed-by: Brian Paul --- src/mesa/Android.mk |9 - src/mesa/SConscript |9 + 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/Android.mk b/src/mesa/Android.mk index 4b62b81..c32b1c0 100644

[Mesa-dev] [PATCH v3 4/8] mesa: glGet: rename *{_EXT, _ARB} enums missing from the XML spec

2012-10-01 Thread Imre Deak
SOURCE_EXT GL_FRAGMENT_SHADER_DERIVATIVE_HINT_ARB GL_PACK_IMAGE_HEIGHT_EXT GL_PACK_SKIP_IMAGES_EXT GL_SECONDARY_COLOR_ARRAY_EXT GL_SECONDARY_COLOR_ARRAY_SIZE_EXT GL_SECONDARY_COLOR_ARRAY_STRIDE_EXT GL_SECONDARY_COLOR_ARRAY_TYPE_EXT GL_UNPACK_IMAGE_HEIGHT_EXT GL_UNPACK_SKIP_IMAGES_EXT Signed-off-by:

[Mesa-dev] [PATCH v3 3/8] mesa: glGet: simplify the 'enum not found' condition

2012-10-01 Thread Imre Deak
x27;s enough to check for its index being 0 without looking at its type. Later in this patchset, when we generate the hash tables during build time, this will allow us to remove the TYPE_API_MASK and related flags completly. Signed-off-by: Imre Deak Reviewed-by: Brian Paul --- src/mesa/main/

[Mesa-dev] [PATCH v3 2/8] mesa: glGet: fix parameter lookup for apps using multiple APIs

2012-10-01 Thread Imre Deak
separate hash table for each API. Signed-off-by: Imre Deak Reviewed-by: Brian Paul --- src/mesa/main/context.c |5 ++--- src/mesa/main/get.c | 44 +--- src/mesa/main/mtypes.h |2 ++ 3 files changed, 33 insertions(+), 18 deletions(-) diff --git a

[Mesa-dev] [PATCH v3 1/8] glapi: rename/move GL_POLYGON_OFFSET_BIAS to its extension section

2012-10-01 Thread Imre Deak
This should be named GL_POLYGON_OFFSET_BIAS_EXT and listed under the EXT_polygon_offset section. (Solution by Ian Romanick) Signed-off-by: Imre Deak Reviewed-by: Brian Paul --- src/mapi/glapi/gen/gl_API.xml |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi

[Mesa-dev] [PATCH v3 0/8] mesa: glGet: fix lookup for apps using multiple APIs

2012-10-01 Thread Imre Deak
In v3 I addressed the last comments from Brian and Ian. Before committing the patchset would need another Reviewed-by besides Brian's. This is also a candidate for the 9.0 branch. I've also pushed it to the g...@github.com:ideak/mesa.git dev branch. --Imre Imre Deak (8): glapi: r

Re: [Mesa-dev] [PATCH v2 01/12] mesa: glGet: fix indentation of _mesa_init_get_hash

2012-09-13 Thread Imre Deak
On Tue, 2012-09-11 at 17:10 -0600, Brian Paul wrote: > On 09/11/2012 03:55 PM, Imre Deak wrote: > > On Tue, 2012-09-11 at 09:30 -0600, Brian Paul wrote: > >> On 09/10/2012 12:41 AM, Imre Deak wrote: > >>> No functional change. > >>> > >>> Sig

Re: [Mesa-dev] [PATCH v2 07/12] mesa: glGet: simplify the 'enum not found' condition

2012-09-11 Thread Imre Deak
On Tue, 2012-09-11 at 09:47 -0600, Brian Paul wrote: > On 09/10/2012 12:41 AM, Imre Deak wrote: > > When traversing the hash table looking up an enum that is invalid we > > eventually reach the first element in the descriptor array. By looking > > at the type of that ele

Re: [Mesa-dev] [PATCH v2 06/12] mesa: glGet: fix parameter lookup for apps using multiple APIs

2012-09-11 Thread Imre Deak
On Tue, 2012-09-11 at 09:40 -0600, Brian Paul wrote: > On 09/10/2012 12:41 AM, Imre Deak wrote: > > The glGet hash was initialized only once for a single GL API, even if > > the application later created a context for a different API. This > > resulted in glGet failin

Re: [Mesa-dev] [PATCH v2 04/12] mesa: glGet: fix API check for EGL_image_external enums

2012-09-11 Thread Imre Deak
On Tue, 2012-09-11 at 09:32 -0600, Brian Paul wrote: > On 09/10/2012 12:41 AM, Imre Deak wrote: > > These enums are valid only in ES1 and ES2. So far they were marked valid > > incorrectly, depending on the previous API mask in the enum list. > > > > Signed-off-by: Imre

Re: [Mesa-dev] [PATCH v2 01/12] mesa: glGet: fix indentation of _mesa_init_get_hash

2012-09-11 Thread Imre Deak
On Tue, 2012-09-11 at 09:30 -0600, Brian Paul wrote: > On 09/10/2012 12:41 AM, Imre Deak wrote: > > No functional change. > > > > Signed-off-by: Imre Deak > > --- > > src/mesa/main/get.c | 18 +- > > 1 file changed, 9 insertions(+), 9 del

Re: [Mesa-dev] [PATCH v2 09/12] mesa: glGet: rename *{_EXT, _ARB} enums missing from the XML spec

2012-09-10 Thread Imre Deak
On Mon, 2012-09-10 at 10:12 +0300, Ian Romanick wrote: > On 09/10/2012 09:41 AM, Imre Deak wrote: > > The following enums used to be extensions but later became part of the > > core specification. The _EXT/_ARB versions of these are not present in > > in the current XML spec f

Re: [Mesa-dev] [PATCH v2 05/12] mesa: add API_NUM

2012-09-10 Thread Imre Deak
On Mon, 2012-09-10 at 10:10 +0300, Ian Romanick wrote: > On 09/10/2012 09:41 AM, Imre Deak wrote: > > Needed by the next patch. > > > > Signed-off-by: Imre Deak > > --- > > src/mesa/main/context.c |2 ++ > > src/mesa/main/mtypes.h |2 ++ > >

Re: [Mesa-dev] [PATCH v2 08/12] gl.h: add missing GL_POLYGON_OFFSET_BIAS definition

2012-09-10 Thread Imre Deak
On Mon, 2012-09-10 at 10:07 +0300, Ian Romanick wrote: > On 09/10/2012 09:41 AM, Imre Deak wrote: > > Signed-off-by: Imre Deak > > --- > > include/GL/gl.h |1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/GL/gl.h b/include/GL

[Mesa-dev] [PATCH v2 12/12] mesa: glGet: remove the unused TYPE_API_MASK flags

2012-09-09 Thread Imre Deak
Since we generate the hash tables in build time, these flags aren't used any more, remove them. Signed-off-by: Imre Deak --- src/mesa/main/get.c |6 -- 1 file changed, 6 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index a9dc68e..0110fcf 100644 --- a/src

[Mesa-dev] [PATCH v2 11/12] mesa: glGet: use the build time generated hash tables

2012-09-09 Thread Imre Deak
Signed-off-by: Imre Deak --- src/mesa/main/get.c | 1022 +-- 1 file changed, 6 insertions(+), 1016 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 2e154bf..a9dc68e 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main

[Mesa-dev] [PATCH v2 09/12] mesa: glGet: rename *{_EXT, _ARB} enums missing from the XML spec

2012-09-09 Thread Imre Deak
T_EXT GL_PACK_SKIP_IMAGES_EXT GL_POLYGON_OFFSET_BIAS_EXT GL_SECONDARY_COLOR_ARRAY_EXT GL_SECONDARY_COLOR_ARRAY_SIZE_EXT GL_SECONDARY_COLOR_ARRAY_STRIDE_EXT GL_SECONDARY_COLOR_ARRAY_TYPE_EXT GL_UNPACK_IMAGE_HEIGHT_EXT GL_UNPACK_SKIP_IMAGES_EXT Signed-off-by: Imre Deak --- src/mesa/main/get.c |

[Mesa-dev] [PATCH v2 08/12] gl.h: add missing GL_POLYGON_OFFSET_BIAS definition

2012-09-09 Thread Imre Deak
Signed-off-by: Imre Deak --- include/GL/gl.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/GL/gl.h b/include/GL/gl.h index e65e1bc..850fe4b 100644 --- a/include/GL/gl.h +++ b/include/GL/gl.h @@ -276,6 +276,7 @@ typedef double GLclampd; /* double precision

[Mesa-dev] [PATCH v2 07/12] mesa: glGet: simplify the 'enum not found' condition

2012-09-09 Thread Imre Deak
x27;s enough to check for its index being 0 without looking at its type. Later in this patchset, when we generate the hash tables during build time, this will allow us to remove the TYPE_API_MASK and related flags completly. Signed-off-by: Imre Deak --- src/mesa/main/get.c |8 +--- 1

[Mesa-dev] [PATCH v2 06/12] mesa: glGet: fix parameter lookup for apps using multiple APIs

2012-09-09 Thread Imre Deak
separate hash table for each API. Signed-off-by: Imre Deak --- src/mesa/main/context.c |5 ++--- src/mesa/main/get.c | 50 ++- 2 files changed, 38 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index

[Mesa-dev] [PATCH v2 05/12] mesa: add API_NUM

2012-09-09 Thread Imre Deak
Needed by the next patch. Signed-off-by: Imre Deak --- src/mesa/main/context.c |2 ++ src/mesa/main/mtypes.h |2 ++ src/mesa/main/version.c |3 +++ 3 files changed, 7 insertions(+) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index 6b28690..1167ea5 100644 --- a

[Mesa-dev] [PATCH v2 04/12] mesa: glGet: fix API check for EGL_image_external enums

2012-09-09 Thread Imre Deak
These enums are valid only in ES1 and ES2. So far they were marked valid incorrectly, depending on the previous API mask in the enum list. Signed-off-by: Imre Deak --- src/mesa/main/get.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/get.c b

[Mesa-dev] [PATCH v2 03/12] mesa: glGet: fix indentation of print_table_stats

2012-09-09 Thread Imre Deak
No functional change. Signed-off-by: Imre Deak --- src/mesa/main/get.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index bb0b619..ce5af04 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@ -1398,29

[Mesa-dev] [PATCH v2 02/12] mesa: glGet: fix indentation of find_value

2012-09-09 Thread Imre Deak
No functional change. Signed-off-by: Imre Deak --- src/mesa/main/get.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 57457ef..bb0b619 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@ -1992,13 +1992,13

[Mesa-dev] [PATCH v2 01/12] mesa: glGet: fix indentation of _mesa_init_get_hash

2012-09-09 Thread Imre Deak
No functional change. Signed-off-by: Imre Deak --- src/mesa/main/get.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 24d2a18..57457ef 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@ -1442,20

[Mesa-dev] [PATCH v2 00/12] mesa: glGet: fix lookup for apps using multiple APIs

2012-09-09 Thread Imre Deak
build hash tables during build time (Eric) - use seperate API specific hash tables (Eric) - run piglit tests w/o regressions (Brian) - fix EGL_image_external enums' API mask Imre Deak (12): mesa: glGet: fix indentation of _mesa_init_get_hash mesa: glGet: fix indentation of find_value m

Re: [Mesa-dev] [PATCH 3/3] mesa: glGet: fix parameter lookup for apps using multiple APIs

2012-08-24 Thread Imre Deak
On Fri, 2012-08-24 at 11:21 -0700, Eric Anholt wrote: > Imre Deak writes: > > -if (values[table[hash & mask]].pname == d->pname) > > - break; > > -hash += prime_step; > > -j++; > > +if (values[TABLE_IDX(table[hash & mask

Re: [Mesa-dev] [PATCH 3/3] mesa: glGet: fix parameter lookup for apps using multiple APIs

2012-08-23 Thread Imre Deak
On Thu, 2012-08-23 at 09:13 -0600, Brian Paul wrote: > On 08/23/2012 08:55 AM, Imre Deak wrote: > > The glGet hash was initialized only once for a single GL API, even if > > the application later created a context for a different API. This > > resulted in glGet failin

[Mesa-dev] [PATCH 3/3] mesa: glGet: fix parameter lookup for apps using multiple APIs

2012-08-23 Thread Imre Deak
meter. Signed-off-by: Imre Deak --- src/mesa/main/context.c |5 ++--- src/mesa/main/get.c | 41 - 2 files changed, 34 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index b78bcee..9831a5f 100644 ---

[Mesa-dev] [PATCH 2/3] mesa: glGet: fix indentation of find_value

2012-08-23 Thread Imre Deak
No functional change. Signed-off-by: Imre Deak --- src/mesa/main/get.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 8d0195f..38d6cc3 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@ -1990,13 +1990,13

[Mesa-dev] [PATCH 1/3] mesa: glGet: fix indentation of _mesa_init_get_hash

2012-08-23 Thread Imre Deak
No functional change. Signed-off-by: Imre Deak --- src/mesa/main/get.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 332dfaf..8d0195f 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@ -1440,20