On Tue, 25 Jun 2019 at 22:31, Alyssa Rosenzweig
wrote:
>
> "Collabora, Ltd." should be listed in lieu of simply "Collabora"
>
> Signed-off-by: Alyssa Rosenzweig
> Suggested-by: Daniel Stone
> ---
> src/gallium/drivers/panfrost/include/panfrost-job.h| 2 +-
> src/gallium/drivers/panfrost
On 25/06/2019 16:22, Roland Scheidegger wrote:
> Looks good to me, albeit it's potentially minimally slower, so I'm
> wondering if the higher precision is actually useful?
It gets you an extra bit, and is necessary if you want to reach 0.5 ULP
(otherwise it never gets there.)
Anyway, it's still
On Wed, 26 Jun 2019 14:03:45 -0700
Alyssa Rosenzweig wrote:
> > The symptom is, black areas around the damage rect when the rendering
> > area (the area you define in mali_payload_fragment) is not
> > 32x32-aligned. If you want to test it, remove the "* 2" in the code and
> > run weston+desktop-s
R-b
On Wed, Jun 26, 2019, 4:32 PM Samuel Pitoiset
wrote:
> The only exception is the GS copy shader which emits them
> unconditionally.
>
> Totals from affected shaders:
> SGPRS: 71320 -> 71008 (-0.44 %)
> VGPRS: 54372 -> 54240 (-0.24 %)
> Code Size: 2952628 -> 2941368 (-0.38 %) bytes
> Max Wave
R-b
On Wed, Jun 26, 2019, 4:20 PM Samuel Pitoiset
wrote:
> This doesn't fix anything known, but it's likely going to
> break if layerCount is ~0U.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_meta_fmask_expand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
> The symptom is, black areas around the damage rect when the rendering
> area (the area you define in mali_payload_fragment) is not
> 32x32-aligned. If you want to test it, remove the "* 2" in the code and
> run weston+desktop-shell (the partial_update() logic has been merged
> earlier today, so y
Hi list,
Due to a major regression in 19.0.7 rendering some drivers unusable I've made a
new 19.0.8 release which includes a fix. Anyone using 19.0.7 is encouraged to
update to 19.0.8 or 19.1.1 ASAP.
Dylan
shortlog:
Dylan Baker (4):
docs: Add SHA256 sums for 19.0.7
version: bump to
https://bugs.freedesktop.org/show_bug.cgi?id=111008
--- Comment #2 from Ilia Mirkin ---
If you can make this happen, it's definitely a bug. And bugs do happen, but I
suspect the conditions have to be more subtle than a plain clear with nothing
else around it.
--
You are receiving this mail beca
https://bugs.freedesktop.org/show_bug.cgi?id=111008
--- Comment #1 from nmr ---
Looks like maybe I am just hallucinating bugs, I can no longer reproduce this
:(
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug._
On Wed, 26 Jun 2019 12:19:28 -0700
Alyssa Rosenzweig wrote:
> > > > +/* We set the damage extent to the full resource size but keep
> > > > the
> > > > + * damage box empty so that the FB content is reloaded by
> > > > default.
> > > > + */
> > >
> > > English,
https://bugs.freedesktop.org/show_bug.cgi?id=111008
Bug ID: 111008
Summary: glClear requires GL_DEPTH_TEST enabled to clear depth
buffer
Product: Mesa
Version: 18.3
Hardware: Other
OS: Linux (All)
> > > +/* We set the damage extent to the full resource size but keep
> > > the
> > > + * damage box empty so that the FB content is reloaded by
> > > default.
> > > + */
> >
> > English, please? Francais, s'il te plait? I'm not too familiar with
> > winsys or the e
> There's no need to intersect the partial_update region with the
> scissor, since rendering outside of the partial_update area is
> explicitly undefined.
I think the idea is less about need and more about an extra
optimization. *Because* that outside rendering is explicitly undefined,
it's valid
On Wed, 26 Jun 2019 10:51:23 -0700
Alyssa Rosenzweig wrote:
> Overall, I'm quite happy with how this turns out; I was fearful it would
> be a lot more complicated, though there's always time for that ;)
Same here. I thought it would be more complicated than that, but it
turned out to be pretty s
Hi,
To be honest, I haven't been able to look too closely at this one. I
wasn't able to easily reason about the twists and turns, so had to run
away to reviews elsewhere. But as long as we reload every single
region passed in - be it individually or just lazily pulling in the
extents, it's correct.
Overall, I'm quite happy with how this turns out; I was fearful it would
be a lot more complicated, though there's always time for that ;)
Some specific comments follow: (mostly minor):
---
> +panfrost_blit_wallpaper(struct panfrost_context *ctx, struct
Ah-ha, now we're into parts of the stack I can claim to understand! >:)
Reviewed-by: Alyssa Rosenzweig
On Tue, Jun 25, 2019 at 06:37:48PM +0200, Boris Brezillon wrote:
> From: Daniel Stone
>
> Add a pipe_screen->set_damage_region() hook to propagate
> set-damage-region requests to the driver,
Also A-b :)
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Also A-b, should have batched these, heh.
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Acked-by: Alyssa Rosenzweig
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
https://bugs.freedesktop.org/show_bug.cgi?id=111006
Bug ID: 111006
Summary: Adding a uniform-dependent if-statement in shader
renders a different image
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS:
R-b, thank you
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
The only exception is the GS copy shader which emits them
unconditionally.
Totals from affected shaders:
SGPRS: 71320 -> 71008 (-0.44 %)
VGPRS: 54372 -> 54240 (-0.24 %)
Code Size: 2952628 -> 2941368 (-0.38 %) bytes
Max Waves: 9689 -> 9723 (0.35 %)
This helps Dota2, Doom, GTAV and Hitman 2.
Signe
This doesn't fix anything known, but it's likely going to
break if layerCount is ~0U.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta_fmask_expand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_meta_fmask_expand.c
b/src/amd/vulkan/radv_meta
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_shader_info.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/src/amd/vulkan/radv_shader_info.c
b/src/amd/vulkan/radv_shader_info.c
index e771ad79878..dcf8d395374 100644
--- a/src/amd/vulkan/radv_shade
Just a cleanup, it shouldn't change anything.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_nir_to_llvm.c | 22
src/amd/vulkan/radv_shader.c | 34 ---
src/amd/vulkan/radv_shader.h | 1 -
3 files changed, 31 insertions(+), 26 de
Just move around the switch case. GFX9+ is handled below.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_shader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c
index 3c50471c63b..5205dc1bfc5 100644
--- a/sr
We only need to 2.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_shader.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c
index c8dc9daf1bc..3c50471c63b 100644
--- a/src/amd/vulkan/radv_shader
Fixes: d19fe5e67a39 ("st/glsl: support clamping color outputs in compat for
gs/tes")
---
src/mesa/state_tracker/st_program.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_program.c
b/src/mesa/state_tracker/st_program.c
index 3c99721a8a7..faada1621c
https://bugs.freedesktop.org/show_bug.cgi?id=111001
Jason Ekstrand changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=111001
--- Comment #2 from Rafał ---
Oh, nevermind
I found that this bug is over six year old -
https://www.phoronix.com/scan.php?page=news_item&px=MTQzNjk
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Conta
https://bugs.freedesktop.org/show_bug.cgi?id=111001
--- Comment #1 from Rafał ---
This error probably also doesn't occur on Fedora 27 with RX580 Mesa - 17.2.4 -
https://github.com/godotengine/godot/issues/16214#issuecomment-361773504
--
You are receiving this mail because:
You are the assignee
https://bugs.freedesktop.org/show_bug.cgi?id=111001
Bug ID: 111001
Summary: Valgrind show a lot of invalid read/write when running
Godot Engine
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (
The ss local var is guaranteed to be != NULL. Get rid of this useless
check.
Signed-off-by: Boris Brezillon
---
src/gallium/drivers/panfrost/pan_context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
b/src/gallium/drivers/panfros
On 19-06-25 10:02:55, Daniel Stone wrote:
> Hi,
>
> On Tue, 25 Jun 2019 at 07:26, Simon Ser wrote:
> > > I noticed that original patch (v1) for gbm_bo_create_with_modifiers did
> > > have usage at first but it was removed during the review. I'm having
> > > trouble digging what was the reason for
On Tue, Jun 25, 2019 at 11:54 AM Alyssa Rosenzweig
wrote:
Hi Alyssa,
> Rather than using a magic lookup table with no explanations, let's add
> liberal comments to the code to explain what this tiling scheme is and
> how to encode/decode it efficiently.
>
> It's not so mysterious after all -- ju
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 34 +++-
1 file changed, 25 insertions(+), 9 deletions(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 61ef19bcaf2..7b3c39217fa 100644
--- a/src/amd/vulkan/
37 matches
Mail list logo
