[Mesa-dev] [PATCH 2/5] tgsi: add support for geometry shader streams.

2019-03-28 Thread Dave Airlie
This adds support to retrieve the primitive counts for each stream, along with the offset for each primitive into the output array. It also adds support for parsing the stream argument to the emit and end instructions. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/draw/draw_gs.c | 6 +

[Mesa-dev] [PATCH 5/5] softpipe: add support for vertex streams

2019-03-28 Thread Dave Airlie
This enables the ARB_gpu_shader5 vertex streams on softpipe. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index 4385

[Mesa-dev] softpipe/draw: add support for vertex streams

2019-03-28 Thread Dave Airlie
This adds support for an ARB_gpu_shader5 feature, multiple vertex streams, I initially wrote this a few years ago, and decided to revisit it since virglrenderer is using softpipe in it's CI and it might be nice to get closer to GLES3.1 This doesn't give use ARB_gpu_shader5 yet, but I think it migh

[Mesa-dev] [PATCH 1/5] draw: add stream member to stats callback

2019-03-28 Thread Dave Airlie
This just adds space for the member to the callback, doesn't change anything else. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/draw/draw_pt_so_emit.c | 2 +- src/gallium/auxiliary/draw/draw_vbuf.h | 1 + src/gallium/drivers/llvmpipe/lp_setup_vbuf.c | 2 +- src/gallium/drivers/soft

[Mesa-dev] [PATCH 4/5] draw: add support to tgsi paths for geometry streams. (v2)

2019-03-28 Thread Dave Airlie
This hooks up the geometry shader processing to the TGSI support added in the previous commits. It doesn't change the llvm interface other than to keep things building. v2: fix some regressions caused by primitiveoffsets Signed-off-by: Dave Airlie --- src/gallium/auxiliary/draw/draw_gs.c

[Mesa-dev] [PATCH 3/5] softpipe: add support for indexed queries.

2019-03-28 Thread Dave Airlie
We need indexed queries to retrieve the geom shader info. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_context.h | 2 +- src/gallium/drivers/softpipe/sp_prim_vbuf.c | 4 ++-- src/gallium/drivers/softpipe/sp_query.c | 23 +++-- src/gallium/include/pipe/p_

Re: [Mesa-dev] [PATCH 2/4] ac: add ac_build_frex_exp() helper ans 16-bit/32-bit support

2019-03-28 Thread Timothy Arceri
This change broke radeonsi for: tests/spec/arb_gpu_shader_fp64/execution/built-in-functions/fs-frexp-dvec4.shader_test LLVM ERROR: Cannot select: intrinsic %llvm.amdgcn.frexp.exp On 23/3/19 12:52 am, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c |

[Mesa-dev] [PATCH] ddebug: add compute functions to help hang detection

2019-03-28 Thread Dave Airlie
From: Dave Airlie --- .../auxiliary/driver_ddebug/dd_context.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/driver_ddebug/dd_context.c b/src/gallium/auxiliary/driver_ddebug/dd_context.c index 15efeccf879..4ea0b16de6f 100644

[Mesa-dev] [PATCH 9/9] panfrost: Implement missing texture formats

2019-03-28 Thread Alyssa Rosenzweig
- Implements RGB565/RGBA5551 formats - Don't advertise support for flipped RGBA5551 and ETC Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_format.c | 12 src/gallium/drivers/panfrost/pan_screen.c | 6 +- 2 files changed, 17 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 5/9] panfrost: Include all cubemap faces in bitmap list

2019-03-28 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c index 253328f3694..b4a26f71dd3 100644 --- a/src

[Mesa-dev] [PATCH 3/9] panfrost: Preliminary work for cubemaps

2019-03-28 Thread Alyssa Rosenzweig
Again, not yet functional, but this sets up the memory management for cube maps. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 3 --- src/gallium/drivers/panfrost/pan_resource.c | 8 ++-- src/gallium/drivers/panfrost/pan_resource.h | 5 - 3 files chan

[Mesa-dev] [PATCH 2/9] panfrost/midgard: Add L/S op for writing cubemap coordinates

2019-03-28 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/drivers/panfrost/midgard/midgard.h b/src/gallium/drivers/panfrost/midgard/midgard.h index 59957c1b566..b2849aa0fee 100644 --- a/src/gallium

[Mesa-dev] [PATCH 6/9] panfrost/midgard: Emit cubemap coordinates

2019-03-28 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/midgard/helpers.h| 7 - .../panfrost/midgard/midgard_compile.c| 30 --- 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/helpers.h b/src/gallium/driv

[Mesa-dev] [PATCH 1/9] panfrost/midgard: Disassemble `cube` texture op

2019-03-28 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/disassemble.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/panfrost/midgard/disassemble.c b/src/gallium/drivers/panfrost/midgard/disassemble.c index 66d32d942c4..376c8f46956 100644 --- a/src/gall

[Mesa-dev] [PATCH 7/9] panfrost: Implement command stream for linear cubemaps

2019-03-28 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 12 +++- src/gallium/drivers/panfrost/pan_resource.c | 2 +- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_co

[Mesa-dev] [PATCH 8/9] panfrost: Extend tiling for cubemaps

2019-03-28 Thread Alyssa Rosenzweig
transfer_unmap now tiles for any tiled resource, not just TEXTURE_2D, which should more than just cubemaps! Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_resource.c | 28 ++--- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/gallium/dri

[Mesa-dev] [PATCH 0/9] Implement cubemaps

2019-03-28 Thread Alyssa Rosenzweig
This series implements support for decoding cubemaps in the command streams and disassembly cubemap instructions in shaders. It then implements support for generating these respective cube maps in the command stream and emitting the corresponding instructions in the shader. Additionally, the last

[Mesa-dev] [PATCH 4/9] panfrost/decode: Decode all cubemap faces

2019-03-28 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pandecode/decode.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/pandecode/decode.c b/src/gallium/drivers/panfrost/pandecode/decode.c index 86fb968e334..966bce6ebd7 100644

[Mesa-dev] [PATCH 01/10] panfrost: Fix vertex buffer corruption

2019-03-28 Thread Alyssa Rosenzweig
Fixes crash in dEQP-GLES2.functional.buffer.* Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c in

[Mesa-dev] [AppVeyor] mesa master #10582 failed

2019-03-28 Thread AppVeyor
Build mesa 10582 failed Commit 7832fb7889 by Ian Romanick on 5/23/2018 1:56 AM: intel/compiler: Use partial redundancy elimination for compares\n\nAlmost all of the hurt shaders are repeated instances of the same shader\nin synmark's compilation speed tests.\n\

[Mesa-dev] [PATCH] gallium/osmesa: Fix the inability to set no context as current.

2019-03-28 Thread zegentzy
https://www.mesa3d.org/submittingpatches.html says just send a link, so: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/533 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radv: do not always initialize HTILE in compressed state

2019-03-28 Thread Bas Nieuwenhuizen
r-b On Thu, Mar 28, 2019 at 4:00 PM Samuel Pitoiset wrote: > > Especially when performing a transtion from UNDEFINED->GENERAL, > the driver shouldn't initialize HTILE metadata in compressed > state because it doesn't decompress when the src layout is > GENERAL. > > Bugzilla: https://bugs.freedesk

Re: [Mesa-dev] [PATCH] radv: do not lower UBO/SSBO access to offsets

2019-03-28 Thread Samuel Pitoiset
On 3/28/19 4:45 PM, Jason Ekstrand wrote: On Thu, Mar 28, 2019 at 10:27 AM Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: Calling it after the first call of radv_optimize_nir() is worse. Ugh Do we know why?  I mean, it does emit the offset calculations in a slightly diffe

Re: [Mesa-dev] [PATCH] radv: skip updating clear/color metadata for conditional rendering

2019-03-28 Thread Samuel Pitoiset
On 3/28/19 12:31 PM, Bas Nieuwenhuizen wrote: r-b, though technically you may want something older for the fixes tag. Pushed with a "cc 19.0" tag instead. On Thu, Mar 28, 2019 at 12:20 PM Samuel Pitoiset wrote: I don't think we should update metadata when conditional rendering is enabled.

Re: [Mesa-dev] [PATCH] radeon/vcn/vp9: search the render target from the whole list

2019-03-28 Thread James Zhu
This Patch is  Tested-by: James Zhu On 2019-03-28 9:08 a.m., Liu, Leo wrote: > The number of render targets could be more than max of references, > so we search the full list of the render pictures for the current > render target index > > https://bugs.freedesktop.org/show_bug.cgi?id=109648 > > S

[Mesa-dev] [Bug 110261] Segmentation fault when using vulkaninfo on Radeon

2019-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110261 --- Comment #2 from Kenneth Endfinger --- I am also running an AMD eGPU over ThunderBolt: Section "Device" Identifier "AMD" Driver "amdgpu" BusID "PCI:61:0:0" Option "AllowEmptyInitialConfiguration" Option "AllowExternalGpus" EndSecti

Re: [Mesa-dev] [PATCH] radv: do not lower UBO/SSBO access to offsets

2019-03-28 Thread Jason Ekstrand
On Thu, Mar 28, 2019 at 10:27 AM Samuel Pitoiset wrote: > Calling it after the first call of radv_optimize_nir() is worse. > Ugh Do we know why? I mean, it does emit the offset calculations in a slightly different order but I wouldn't expect it to hurt this bad. :-/ > 27747 shaders in 143

[Mesa-dev] [Bug 110261] Segmentation fault when using vulkaninfo on Radeon

2019-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110261 Samuel Pitoiset changed: What|Removed |Added CC||airl...@freedesktop.org,

Re: [Mesa-dev] [PATCH] radv: do not lower UBO/SSBO access to offsets

2019-03-28 Thread Samuel Pitoiset
Calling it after the first call of radv_optimize_nir() is worse. 27747 shaders in 14347 tests Totals: SGPRS: 1248039 -> 1248031 (-0.00 %) VGPRS: 868360 -> 868772 (0.05 %) Spilled SGPRs: 24108 -> 24134 (0.11 %) Spilled VGPRs: 122 -> 122 (0.00 %) Private memory VGPRs: 0 -> 0 (0.00 %) Scratch size:

Re: [Mesa-dev] [PATCH] radv: do not lower UBO/SSBO access to offsets

2019-03-28 Thread Samuel Pitoiset
On 3/28/19 3:08 PM, Jason Ekstrand wrote: On Wed, Mar 27, 2019 at 4:13 AM Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: This helps few compute shaders, mostly for F12017. 27670 shaders in 14347 tests Totals: SGPRS: 1231173 -> 1231173 (0.00 %) VGPRS: 866056 -> 8

Re: [Mesa-dev] [PATCH 2/2] radv: write availability status vkGetQueryPoolResults() when the data is not available

2019-03-28 Thread Samuel Pitoiset
On 3/25/19 8:16 AM, Samuel Iglesias Gonsálvez wrote: On Fri, 2019-03-22 at 17:21 +0100, Samuel Pitoiset wrote: Does this fix anything known? I am writing CTS tests for VK_EXT_host_query_reset extension and I found this bug while testing them on RADV. Does that rule also apply for CmdCopyQue

[Mesa-dev] [PATCH] radv: do not always initialize HTILE in compressed state

2019-03-28 Thread Samuel Pitoiset
Especially when performing a transtion from UNDEFINED->GENERAL, the driver shouldn't initialize HTILE metadata in compressed state because it doesn't decompress when the src layout is GENERAL. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110259 Fixes: 3a2e93147f7 ("radv: always initializ

Re: [Mesa-dev] [PATCH] radv: do not lower UBO/SSBO access to offsets

2019-03-28 Thread Jason Ekstrand
On Thu, Mar 28, 2019 at 9:29 AM Jason Ekstrand wrote: > I did some benchmarking of Assassin's Creed Odyssey today on ANV. > Disabling the SSBO optimization possibilities in ANV that moving to derefs > unlocks (I just moved the lowering super-early; moving back to index/offset > would be insane) d

Re: [Mesa-dev] [PATCH] radv: do not lower UBO/SSBO access to offsets

2019-03-28 Thread Jason Ekstrand
I did some benchmarking of Assassin's Creed Odyssey today on ANV. Disabling the SSBO optimization possibilities in ANV that moving to derefs unlocks (I just moved the lowering super-early; moving back to index/offset would be insane) drops the perf of ACO by 20%. You want SSBO derefs. :D On Thu,

Re: [Mesa-dev] [PATCH] radv: do not lower UBO/SSBO access to offsets

2019-03-28 Thread Jason Ekstrand
On Wed, Mar 27, 2019 at 4:13 AM Samuel Pitoiset wrote: > This helps few compute shaders, mostly for F12017. > > 27670 shaders in 14347 tests > Totals: > SGPRS: 1231173 -> 1231173 (0.00 %) > VGPRS: 866056 -> 865928 (-0.01 %) > Spilled SGPRs: 24201 -> 24201 (0.00 %) > Code Size: 46137040 -> 4614486

[Mesa-dev] [PATCH] radeon/vcn/vp9: search the render target from the whole list

2019-03-28 Thread Liu, Leo
The number of render targets could be more than max of references, so we search the full list of the render pictures for the current render target index https://bugs.freedesktop.org/show_bug.cgi?id=109648 Signed-off-by: Leo Liu Cc: --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 2 +- 1 file

[Mesa-dev] [Bug 107991] RX580 ~ ring gfx timeout ~ particular shaders created by a dolphin-emu game can crash AMDGPU, with both RadeonSI and RADV ~ attached apitrace for RadeonSI

2019-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107991 glencoesm...@hotmail.com changed: What|Removed |Added CC||glencoesm...@hotmail.com --

Re: [Mesa-dev] [PATCH] radv: skip updating clear/color metadata for conditional rendering

2019-03-28 Thread Bas Nieuwenhuizen
r-b, though technically you may want something older for the fixes tag. On Thu, Mar 28, 2019 at 12:20 PM Samuel Pitoiset wrote: > > I don't think we should update metadata when conditional rendering > is enabled. For some reasons, some CTS breaks only on SI. > > This fixes the following CTS on SI

[Mesa-dev] [PATCH] radv: skip updating clear/color metadata for conditional rendering

2019-03-28 Thread Samuel Pitoiset
I don't think we should update metadata when conditional rendering is enabled. For some reasons, some CTS breaks only on SI. This fixes the following CTS on SI: dEQP-VK.conditional_rendering.draw_clear.clear.depth.* Fixes: a777c3d7cb0 ("radv: Use correct image view comparison for fast clears.") S

Re: [Mesa-dev] [PATCH 4/4] radv: enable VK_AMD_gpu_shader_int16

2019-03-28 Thread Bas Nieuwenhuizen
r-b For series On Fri, Mar 22, 2019, 2:49 PM Samuel Pitoiset wrote: > This extension allows 16-bit support to Frexp/FrexpStruct. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_extensions.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/amd/vulkan/radv_extensions

Re: [Mesa-dev] [PATCH] radv: do not lower UBO/SSBO access to offsets

2019-03-28 Thread Samuel Pitoiset
On 3/28/19 10:18 AM, Bas Nieuwenhuizen wrote: R-b Though not sure it really helps given code size increase? I haven't benchmarked F12017 yet. The code size increases seems to be LLVM related but that shouldn't matter much. On Wed, Mar 27, 2019, 10:13 AM Samuel Pitoiset mailto:samuel.pitoi..

Re: [Mesa-dev] [PATCH v2] ac: allow to use vec3 for typed/untyped buffer stores/loads with LLVM 9+

2019-03-28 Thread Bas Nieuwenhuizen
r-b On Tue, Mar 26, 2019, 10:13 AM Samuel Pitoiset wrote: > 27670 shaders in 14347 tests > Totals: > SGPRS: 1231173 -> 1236757 (0.45 %) > VGPRS: 866056 -> 867488 (0.17 %) > Spilled SGPRs: 24201 -> 24169 (-0.13 %) > Code Size: 46134836 -> 46115944 (-0.04 %) bytes > Max Waves: 232287 -> 232070 (-0

Re: [Mesa-dev] [PATCH] radv: do not lower UBO/SSBO access to offsets

2019-03-28 Thread Bas Nieuwenhuizen
R-b Though not sure it really helps given code size increase? On Wed, Mar 27, 2019, 10:13 AM Samuel Pitoiset wrote: > This helps few compute shaders, mostly for F12017. > > 27670 shaders in 14347 tests > Totals: > SGPRS: 1231173 -> 1231173 (0.00 %) > VGPRS: 866056 -> 865928 (-0.01 %) > Spilled

[Mesa-dev] [Bug 110268] enable storageBuffer16BitAccess feature in radv for SI and CIK

2019-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110268 --- Comment #2 from nihui --- (In reply to Samuel Pitoiset from comment #1) > Where can I find this benchmark? Hi The benchmark is the benchncnn program in repo https://github.com/Tencent/ncnn -- You are receiving this mail because: You are

[Mesa-dev] [Bug 110268] enable storageBuffer16BitAccess feature in radv for SI and CIK

2019-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110268 --- Comment #1 from Samuel Pitoiset --- Where can I find this benchmark? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mail

[Mesa-dev] [Bug 110266] gpu error

2019-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110266 Christian König changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop. | |org