r-b
On Thu, Mar 28, 2019 at 4:00 PM Samuel Pitoiset <samuel.pitoi...@gmail.com> wrote: > > Especially when performing a transtion from UNDEFINED->GENERAL, > the driver shouldn't initialize HTILE metadata in compressed > state because it doesn't decompress when the src layout is > GENERAL. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110259 > Fixes: 3a2e93147f7 ("radv: always initialize HTILE when the src layout is > UNDEFINED") > Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> > --- > src/amd/vulkan/radv_cmd_buffer.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c > b/src/amd/vulkan/radv_cmd_buffer.c > index bed899d686e..7ee5a5ca7dc 100644 > --- a/src/amd/vulkan/radv_cmd_buffer.c > +++ b/src/amd/vulkan/radv_cmd_buffer.c > @@ -4478,8 +4478,14 @@ static void radv_handle_depth_image_transition(struct > radv_cmd_buffer *cmd_buffe > return; > > if (src_layout == VK_IMAGE_LAYOUT_UNDEFINED) { > - /* TODO: merge with the clear if applicable */ > - radv_initialize_htile(cmd_buffer, image, range, 0); > + uint32_t clear_value = vk_format_is_stencil(image->vk_format) > ? 0xfffff30f : 0xfffc000f; > + > + if (radv_layout_is_htile_compressed(image, dst_layout, > + dst_queue_mask)) { > + clear_value = 0; > + } > + > + radv_initialize_htile(cmd_buffer, image, range, clear_value); > } else if (!radv_layout_is_htile_compressed(image, src_layout, > src_queue_mask) && > radv_layout_is_htile_compressed(image, dst_layout, > dst_queue_mask)) { > uint32_t clear_value = vk_format_is_stencil(image->vk_format) > ? 0xfffff30f : 0xfffc000f; > -- > 2.21.0 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
