Re: [Mesa-dev] [PATCH v3 0/6] support config for third-party DRI driver load

Thanks Emil. > - missing include (for PATH_MAX) in patch 1 Although I can compile without , I agree to add it explicitly. > - added HAVE_LIBDRM guard for __driConfigOptionsLoader and > loader_get_dri_config_driver My thoughts are: 1. __driConfigOptionsLoader and loader_get_dri_config_driver don'

Re: [Mesa-dev] [PATCH] docs: Python 2.7 or later is required.

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/4] nir: mark *prev_block as MAYBE_UNUSED in opt_peel_loop_initial_if

On 18/08/18 10:28, Timothy Arceri wrote: Thanks I'd been meaning to do this too. Reviewed-by: Timothy Arceri Do you have commit access? Nevermind I should have read the cover letter. I'll push the first 3, I'll leave patch 4 for someone at AMD to comment on. I think all that code gets impo

Re: [Mesa-dev] [PATCH 2/4] nir: mark *prev_block as MAYBE_UNUSED in opt_peel_loop_initial_if

Thanks I'd been meaning to do this too. Reviewed-by: Timothy Arceri Do you have commit access? On 18/08/18 00:32, Kai Wasserbäch wrote: Only used, when asserts are enabled. Fixes an unused-variable warning with gcc-8: ../../../src/compiler/nir/nir_opt_if.c: In function 'opt_peel_loop_init

[Mesa-dev] [PATCH] anv/icl: Allow headerless sampler messages for pre-emptable contexts

It fixes simulator warnings in vulkancts tests complaining about missing support for headerless sampler messages for pre-emptable contexts. Bit 5 in SAMPLER MODE register is newly introduced for ICLLP. Signed-off-by: Anuj Phogat --- src/intel/genxml/gen11.xml| 5 + src/intel/vulkan/genX

[Mesa-dev] [PATCH] anv/icl: Disable binding table prefetching

Gen 11 workarounds table #2056 WABTPPrefetchDisable suggests to disable prefetching of binding tables for ICLLP A0 and B0 steppings. We have a similar patch for i965 driver in Mesa commit a5889d70. Signed-off-by: Anuj Phogat --- src/intel/vulkan/genX_pipeline.c | 21 +++-- 1 fil

[Mesa-dev] [PATCH] i965/icl: Allow headerless sampler messages for pre-emptable contexts

It fixes simulator warnings in piglit tests complaining about missing support for headerless sampler messages for pre-emptable contexts. Bit 5 in SAMPLER MODE register is newly introduced for ICLLP. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_defines.h | 4 src/mesa/d

Re: [Mesa-dev] [PATCH 09/13] nir: Add floating point atomic min, max, and compare-swap instrinsics

On Fri, Jun 22, 2018 at 10:03:54PM -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/compiler/glsl/glsl_to_nir.cpp| 32 > ++-- > src/compiler/nir/nir_intrinsics.py | 11 +- > src/compiler/nir/nir_lo

Re: [Mesa-dev] [PATCH 12/13] i965: Sort Gen9+ extension enables

This patch is Reviewed-by: Caio Marcelo de Oliveira Filho On Fri, Jun 22, 2018 at 10:03:57PM -0700, Ian Romanick wrote: > From: Ian Romanick > > This is a strictly alphabetic sort, as is done in extensions_table.h > There are other options. We should pick one and document it. Right > now,

Re: [Mesa-dev] [PATCH 10/13] intel/compiler: Silence unused parameter warnings

You've fixed the warnings in "generate_*" functions in another patch that landed. I guess this commit also fixed and the rebase was clean, but the commit message remained. With that update to the commit message, this patch is Reviewed-by: Caio Marcelo de Oliveira Filho On Fri, Jun 22, 2018 at

Re: [Mesa-dev] [PATCH 11/13] intel/compiler: Implement untyped atomic float min, max, and compare-swap dataport messages

On Fri, Jun 22, 2018 at 10:03:56PM -0700, Ian Romanick wrote: > From: Ian Romanick > > Also expand the message type field by a single bit. This is necessary > for this Gen9 message type, but there are also Gen8 message types that > need the extra bit (mostly for bindless). I'd consider splittin

[Mesa-dev] [PATCH] docs: Python 2.7 or later is required.

Signed-off-by: Vinson Lee --- docs/install.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/install.html b/docs/install.html index 08081944cfcc..f6094671cf9f 100644 --- a/docs/install.html +++ b/docs/install.html @@ -72,7 +72,7 @@ you think you've spotted a bug let de

Re: [Mesa-dev] [PATCH v2 7/8] nir: add loop unroll support for wrapper loops

On 18/08/18 07:14, Jason Ekstrand wrote: On Mon, Jul 23, 2018 at 3:02 AM Timothy Arceri > wrote: This adds support for unrolling the classic     do {         // ...     } while (false) that is used to wrap multi-line macros. GLSL IR also wra

Re: [Mesa-dev] [PATCH 01/22] nir/algebraic: Be more careful converting ushr to extract_u8/16

On Fri, Aug 17, 2018 at 5:27 PM Bas Nieuwenhuizen wrote: > On Fri, Aug 17, 2018 at 10:06 PM, Jason Ekstrand > wrote: > > If it's not the right bit-size, it may not actually be the correct > > extraction. For now, we'll only worry about 32-bit versions. > > > > Fixes: 905ff8619824 "nir: Recogniz

Re: [Mesa-dev] [PATCH 03/22] nir/algebraic: Add some max/min optimizations

Reviewed-by: Bas Nieuwenhuizen On Fri, Aug 17, 2018 at 10:06 PM, Jason Ekstrand wrote: > Found by inspection. This doesn't help much now but we'll see this > pattern with images if you load UNORM and then store UNORM. > > Shader-db results on Kaby Lake: > > total instructions in shared prog

Re: [Mesa-dev] [PATCH 02/22] nir/algebraic: Add more extract_[iu](8|16) optimizations

On Fri, Aug 17, 2018 at 10:06 PM, Jason Ekstrand wrote: > This adds the "(a << N) >> M" family of mask or sign-extensions. Not a > huge win right now but this pattern will soon be generated by NIR format > lowering code. > > Shader-db results on Kaby Lake: > > total instructions in shared pro

Re: [Mesa-dev] [PATCH 01/22] nir/algebraic: Be more careful converting ushr to extract_u8/16

On Fri, Aug 17, 2018 at 10:06 PM, Jason Ekstrand wrote: > If it's not the right bit-size, it may not actually be the correct > extraction. For now, we'll only worry about 32-bit versions. > > Fixes: 905ff8619824 "nir: Recognize open-coded extract_u16" > Fixes: 76289fbfa84a "nir: Recognize open-co

Re: [Mesa-dev] [PATCH 09/22] nir/format_convert: Rename pack_r11g11b10f to pack_11f11f10f

On Fri, Aug 17, 2018 at 4:26 PM Roland Scheidegger wrote: > Am 17.08.2018 um 22:06 schrieb Jason Ekstrand: > > This matches the unpack function. > > --- > > src/compiler/nir/nir_format_convert.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/compiler/nir/nir_f

Re: [Mesa-dev] [PATCH 09/22] nir/format_convert: Rename pack_r11g11b10f to pack_11f11f10f

Am 17.08.2018 um 22:06 schrieb Jason Ekstrand: > This matches the unpack function. > --- > src/compiler/nir/nir_format_convert.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/nir/nir_format_convert.h > b/src/compiler/nir/nir_format_convert.h > index 757937

Re: [Mesa-dev] [PATCH v2 7/8] nir: add loop unroll support for wrapper loops

On Mon, Jul 23, 2018 at 3:02 AM Timothy Arceri wrote: > This adds support for unrolling the classic > > do { > // ... > } while (false) > > that is used to wrap multi-line macros. GLSL IR also wraps switch > statements in a loop like this. > > shader-db results IVB: > > total loop

Re: [Mesa-dev] [PATCH v2 5/8] nir: add complex_loop bool to loop info

4 and 5 are Reviewed-by: Jason Ekstrand On Mon, Jul 23, 2018 at 3:03 AM Timothy Arceri wrote: > In order to be sure loop_terminator_list is an accurate > representation of all the jumps in the loop we need to be sure we > didn't encounter any other complex behaviour such as continues, > nested

[Mesa-dev] [PATCH 16/22] intel/compiler: Use two components for 1D array image sizes

Having the array length component stored in .z was a small convenience for the ISL image param filling code and an annoyance in the NIR lowering code. The only convenience of treating 1D arrays like 2D arrays in the lowering code is in the address calculation code so let's put all the complexity t

[Mesa-dev] [PATCH 20/22] nir: Add handle/index-based image intrinsics

--- src/compiler/nir/nir.h | 30 +-- src/compiler/nir/nir_intrinsics.py | 48 +++--- src/compiler/nir/nir_print.c | 22 ++ 3 files changed, 81 insertions(+), 19 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/ni

[Mesa-dev] [PATCH 19/22] nir: Use a bitfield for image access qualifiers

This commit expands the current memory access enum to contain the extra two bits provided for images. We choose to follow the SPIR-V convention of NonReadable and NonWriteable because readonly implies that you *can* read so readonly + writeonly doesn't make as much sense as NonReadable + NonWritea

[Mesa-dev] [PATCH 09/22] nir/format_convert: Rename pack_r11g11b10f to pack_11f11f10f

This matches the unpack function. --- src/compiler/nir/nir_format_convert.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_format_convert.h b/src/compiler/nir/nir_format_convert.h index 75793733ea6..c79001a50aa 100644 --- a/src/compiler/nir/nir_format_con

[Mesa-dev] [PATCH 21/22] anv, i965: Lower away image derefs in the driver

Previously, the back-end compiler turn image access into magic uniform reads and there was a complex contract between back-end compiler and driver about setting up and filling out those params. As of this commit, both drivers now lower image_deref_load_param_intel intrinsics to load_uniform intrin

[Mesa-dev] [PATCH 18/22] intel: Use TXQ for image_size when we have a typed surface

--- src/intel/compiler/brw_eu_defines.h | 3 +++ src/intel/compiler/brw_fs.cpp | 8 ++ src/intel/compiler/brw_fs_generator.cpp | 26 --- src/intel/compiler/brw_fs_nir.cpp | 26 +++ .../compiler/brw_nir_lower_image_lo

[Mesa-dev] [PATCH 22/22] intel/compiler: Remove surface_idx from brw_image_param

Now that the drivers are lowering to surface indices themselves, we no longer need to push the surface index into the shader. --- src/intel/compiler/brw_compiler.h| 16 ++-- .../compiler/brw_nir_lower_image_load_store.c| 3 --- src/intel/vulkan/anv_nir_apply_pipeli

[Mesa-dev] [PATCH 13/22] nir/types: Add a wrapper for coordinate_components

--- src/compiler/nir_types.cpp | 7 +++ src/compiler/nir_types.h | 1 + 2 files changed, 8 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index c8a29404969..c00712f48b6 100644 --- a/src/compiler/nir_types.cpp +++ b/src/compiler/nir_types.cpp @@ -163,6 +16

[Mesa-dev] [PATCH 17/22] glsl/link, i965: Make ImageAccess four-state

The GLSL spec allows you to set both the "readonly" and "writeonly" qualifiers on images to indicate that it can only be used with imageSize. However, we had no way of representing this int he linked shader and flagged it as GL_READ_ONLY. This is good from a "does it use this buffer?" perspective

[Mesa-dev] [PATCH 12/22] anv/pipeline: Remove dead image loads in lower_input_attacnments

Dead code will get rid of them eventually but it's better if they're just gone so we guarantee they won't trip up later passes. --- src/intel/vulkan/anv_nir_lower_input_attachments.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_nir_lower_input_attach

[Mesa-dev] [PATCH 10/22] nir/format_convert: Fix a bitmask in unpack_11f11f10f

Fixes: 4e337b42f9a2 "nir/format_convert: Add pack/unpack for R11F_G11F_B10F" --- src/compiler/nir/nir_format_convert.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_format_convert.h b/src/compiler/nir/nir_format_convert.h index c79001a50aa..27a8ac08d49 1

[Mesa-dev] [PATCH 14/22] intel/compiler: Do image load/store lowering to NIR

This commit moves our storage image format conversion codegen into NIR instead of doing it in the back-end. This has the advantage of letting us run it through NIR's optimizer which is pretty effective at shrinking things down. In the common case of rgba8, the number of instructions emitted after

[Mesa-dev] [PATCH 05/22] nir/format_convert: Add support for unpacking signed integers

--- src/compiler/nir/nir_format_convert.h | 37 +-- 1 file changed, 29 insertions(+), 8 deletions(-) diff --git a/src/compiler/nir/nir_format_convert.h b/src/compiler/nir/nir_format_convert.h index 45532b74884..b1345f7263b 100644 --- a/src/compiler/nir/nir_format_convert.

[Mesa-dev] [PATCH 08/22] nir/format_convert: Add [us]norm conversion helpers

--- src/compiler/nir/nir_format_convert.h | 56 +++ 1 file changed, 56 insertions(+) diff --git a/src/compiler/nir/nir_format_convert.h b/src/compiler/nir/nir_format_convert.h index f2eafcbf5b4..75793733ea6 100644 --- a/src/compiler/nir/nir_format_convert.h +++ b/src/comp

[Mesa-dev] [PATCH 07/22] nir/format_convert: Rename nir_format_bitcast_uint_vec

We have a name for that, it's called a uvec. This just makes the function name a bit shorter. While we're here, we also add an assert for one of the assumptions this function makes. --- src/compiler/nir/nir_format_convert.h | 5 +++-- src/intel/blorp/blorp_blit.c | 2 +- 2 files changed

[Mesa-dev] [PATCH 15/22] isl: Use the view array length for the image size

--- src/intel/isl/isl_storage_image.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/intel/isl/isl_storage_image.c b/src/intel/isl/isl_storage_image.c index e2bd4ddebad..43398e8a020 100644 --- a/src/intel/isl/isl_storage_image.c +++ b/src/intel/isl/isl_storage_imag

[Mesa-dev] [PATCH 04/22] nir/opcodes: Make unpack_half_2x16_split_* variable-width

There is nothing inherent about these opcodes that requires them to only take scalars. It's very convenient if we let them take vectors as well. --- src/compiler/nir/nir_opcodes.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir_opcodes.py b/src/co

[Mesa-dev] [PATCH 11/22] nir: Make image load/store intrinsics variable-width

Instead of requiring 4 components, this allows them to potentially use fewer. Both the SPIR-V and GLSL paths still generate vec4 intrinsics so drivers which assume 4 components should be safe. However, we want to be able to shrink them for i965. --- src/compiler/glsl/glsl_to_nir.cpp | 9 +++

[Mesa-dev] [PATCH 03/22] nir/algebraic: Add some max/min optimizations

Found by inspection. This doesn't help much now but we'll see this pattern with images if you load UNORM and then store UNORM. Shader-db results on Kaby Lake: total instructions in shared programs: 15166916 -> 15166910 (<.01%) instructions in affected programs: 761 -> 755 (-0.79%) he

[Mesa-dev] [PATCH 02/22] nir/algebraic: Add more extract_[iu](8|16) optimizations

This adds the "(a << N) >> M" family of mask or sign-extensions. Not a huge win right now but this pattern will soon be generated by NIR format lowering code. Shader-db results on Kaby Lake: total instructions in shared programs: 15166918 -> 15166916 (<.01%) instructions in affected prog

[Mesa-dev] [PATCH 06/22] nir/format_convert: Add vec mask and sign-extend helpers

--- src/compiler/nir/nir_format_convert.h | 35 +-- 1 file changed, 27 insertions(+), 8 deletions(-) diff --git a/src/compiler/nir/nir_format_convert.h b/src/compiler/nir/nir_format_convert.h index b1345f7263b..305273cdfdd 100644 --- a/src/compiler/nir/nir_format_convert.

[Mesa-dev] [PATCH 01/22] nir/algebraic: Be more careful converting ushr to extract_u8/16

If it's not the right bit-size, it may not actually be the correct extraction. For now, we'll only worry about 32-bit versions. Fixes: 905ff8619824 "nir: Recognize open-coded extract_u16" Fixes: 76289fbfa84a "nir: Recognize open-coded extract_u8" --- src/compiler/nir/nir_opt_algebraic.py | 4 ++-

[Mesa-dev] [PATCH 00/22] intel: Do storage image lowering in NIR

This patch series has been on my mind to write for a very long time now. It moves the storage image lowering we have to do for Intel hardware into NIR. This series makes several improvements: 1) The NIR optimizer can go to town on it and we can just improve the optimizer instead of spending

Re: [Mesa-dev] [PATCH 3/3] meson: Run the test with Python 3

On Fri, 2018-08-17 at 12:54 -0700, Dylan Baker wrote: > Quoting Mathieu Bridon (2018-08-17 12:32:18) > > --- > > src/compiler/glsl/glcpp/meson.build | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/src/compiler/glsl/glcpp/meson.build > > b/src/compiler/glsl/glcpp/m

Re: [Mesa-dev] [PATCH 3/3] meson: Run the test with Python 3

Quoting Mathieu Bridon (2018-08-17 12:32:18) > --- > src/compiler/glsl/glcpp/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/compiler/glsl/glcpp/meson.build > b/src/compiler/glsl/glcpp/meson.build > index 09d44ddd687..769406f5331 100644 > --- a/src/comp

Re: [Mesa-dev] [PATCH 1/3] python: difflib prefers unicode strings

for the series: Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-08-17 12:32:16) > Python 3 does not automatically convert from bytes to unicode strings > like Python 2 used to do. > > This commit makes sure we pass unicode strings to difflib.unified_diff, > so that the script works on both

Re: [Mesa-dev] [PATCH v2 2/8] nir: propagates if condition evaluation down some alu chains

Ugh... Now that I think about it more, my suggestions on the previous patch conflict quite a bit. :( Let me think some more. On Fri, Aug 17, 2018 at 2:27 PM Jason Ekstrand wrote: > It took me a while to figure out what you're doing here but, once I've > grokked it, I like it. That said, I'd li

Re: [Mesa-dev] [PATCH v2 3/8] nir: allow more nested loops to be unrolled

Thanks for the explanation and fixing the boolean mess Reviewed-by: Jason Ekstrand On Mon, Jul 23, 2018 at 3:02 AM Timothy Arceri wrote: > The innermost check was added to stop us from unrolling multiple > loops in a single pass, and to stop outer loops from unrolling. > > When we successfully

[Mesa-dev] [PATCH 3/3] meson: Run the test with Python 3

--- src/compiler/glsl/glcpp/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/glcpp/meson.build b/src/compiler/glsl/glcpp/meson.build index 09d44ddd687..769406f5331 100644 --- a/src/compiler/glsl/glcpp/meson.build +++ b/src/compiler/glsl/glcpp/mes

[Mesa-dev] [PATCH 2/3] python: Disable universal newlines

We are testing the behaviour of a tool, for different input files, each one using a different newline sequence. ('\n' on UNIX, '\r\n' on Windows, …) Unfortunately, when opening a file in text mode, Python 3 will by default enable the "universal newlines" mode, which means it replaces all the known

[Mesa-dev] [PATCH 1/3] python: difflib prefers unicode strings

Python 3 does not automatically convert from bytes to unicode strings like Python 2 used to do. This commit makes sure we pass unicode strings to difflib.unified_diff, so that the script works on both Python 2 and 3. --- src/compiler/glsl/glcpp/tests/glcpp_test.py | 3 ++- 1 file changed, 2 inser

Re: [Mesa-dev] [PATCH v2 2/8] nir: propagates if condition evaluation down some alu chains

It took me a while to figure out what you're doing here but, once I've grokked it, I like it. That said, I'd like to see your response to my comments on patch 1 as that would cause this to get restructured a good bit. (I think it will be much improved for it.) --Jason On Mon, Jul 23, 2018 at 3:

Re: [Mesa-dev] [PATCH v3] anv: add VK_EXT_sampler_filter_minmax support

Thanks for your review, Lionel. The reduction mode in Intel bspec has the 4th option (COMPARISON), in addition to 3 options in Vulkan spec: standard/min/max sampling. I disabled reduction mode when compare mode in sampler state is enabled. It looks like the hardware can set appropriate reductio

Re: [Mesa-dev] [PATCH v2 1/8] nir: evaluate if condition uses inside the if branches

On Mon, Jul 23, 2018 at 3:03 AM Timothy Arceri wrote: > Since we know what side of the branch we ended up on we can just > replace the use with a constant. > > All the spill changes in shader-db are from Dolphin uber shaders, > despite some small regressions the change is clearly positive. > > sh

Re: [Mesa-dev] [PATCH mesa] util/xmlpool: make indentation coherent

Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-08-16 08:03:23) > Signed-off-by: Eric Engestrom > --- > src/util/xmlpool/t_options.h | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/src/util/xmlpool/t_options.h b/src/util/xmlpool/t_opt

Re: [Mesa-dev] [PATCH] docs: update required mako version

Reviewed-by: Dylan Baker Quoting Emil Velikov (2018-08-16 09:58:53) > From: Emil Velikov > > The requirement was bumped a while back, but we forgot to update the > docs. > > Fixes: ed871af91c2 ("configure.ac: raise Mako required version to > 0.8.0") > Cc: Eric Engestrom > Signed-off-by: Emil

Re: [Mesa-dev] [PATCH 1/2] compiler/glsl/tests: Make tests python3 safe

Quoting Mathieu Bridon (2018-08-17 11:01:23) > On Fri, 2018-08-17 at 10:45 -0700, Dylan Baker wrote: > > Quoting Mathieu Bridon (2018-08-16 15:00:39) > > > On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote: > > > > --- > > > > > > > > I didn't see any patches from anyone else, so I wrote some r

[Mesa-dev] [PATCH v3 2/2] meson: Use python3 to run glsl tests

--- src/compiler/glsl/tests/meson.build | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.build index fc7b863a278..2a41e30a28d 100644 --- a/src/compiler/glsl/tests/meson.build +++ b/src/compiler/glsl

[Mesa-dev] [PATCH v3 1/2] compiler/glsl/tests: Make tests python3 safe

v2: - explicitly decode the output of subprocesses - handle bytes and string types consistently rather than relying on python 2's coercion for bytes and ignoring them in python 3 v3: - explicitly set encode as well as decode - python 2.7 and 3.x `bytes` instead of defining an alias --

Re: [Mesa-dev] [PATCH 3/7] dri: Define DRI_MutableRenderBuffer extensions

On Tue 14 Aug 2018, Tapani Pälli wrote: > Hi Chad; > > On 08/08/2018 06:53 PM, Tapani Pälli wrote: > > > > > > On 07.08.2018 21:16, Chad Versace wrote: > > > On Mon 06 Aug 2018, Chad Versace wrote: > > > > On Fri 03 Aug 2018, Tapani Pälli wrote: > > > > > One tiny nit below but for patches 3,4 a

Re: [Mesa-dev] [PATCH v2 1/2] compiler/glsl/tests: Make tests python3 safe

Quoting Mathieu Bridon (2018-08-17 10:58:38) > On Fri, 2018-08-17 at 10:51 -0700, Dylan Baker wrote: > > diff --git a/src/compiler/glsl/tests/optimization_test.py > > b/src/compiler/glsl/tests/optimization_test.py > > index 577d2dfc20f..65bac676963 100755 > > --- a/src/compiler/glsl/tests/optimizat

Re: [Mesa-dev] [PATCH 1/2] compiler/glsl/tests: Make tests python3 safe

On Fri, 2018-08-17 at 10:45 -0700, Dylan Baker wrote: > Quoting Mathieu Bridon (2018-08-16 15:00:39) > > On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote: > > > --- > > > > > > I didn't see any patches from anyone else, so I wrote some real > > > quick. Please > > > point to them if other patc

Re: [Mesa-dev] [PATCHv2 1/2] meson: Use python to run glsl tests

Quoting Emil Velikov (2018-08-17 04:11:32) > From: Dylan Baker > > There are multiple reasons why the python scripts are executed > explicitly via $PYTHON or equivalent. In random order: > > - env is rarely a thing on Windows windows does something completely different based on file extensions

Re: [Mesa-dev] [PATCH v2 1/2] compiler/glsl/tests: Make tests python3 safe

On Fri, 2018-08-17 at 10:51 -0700, Dylan Baker wrote: > diff --git a/src/compiler/glsl/tests/optimization_test.py > b/src/compiler/glsl/tests/optimization_test.py > index 577d2dfc20f..65bac676963 100755 > --- a/src/compiler/glsl/tests/optimization_test.py > +++ b/src/compiler/glsl/tests/optimizatio

[Mesa-dev] [PATCH v4] anv: add VK_EXT_sampler_filter_minmax support

This extension can be supported on SKL+. With this patch, all corresponding tests (6K+) in CTS can pass. No test fails. I verified CTS with the command below: deqp-vk --deqp-case=dEQP-VK.pipeline.sampler.view_type.*reduce* v2: 1) support all depth formats, not depth-only formats, 2) fix a wrong i

Re: [Mesa-dev] [PATCH 2/2] glsl: remove execute bit and shebang from python tests

I don't care one way or the other on this, but it needs to wait for the series I have to make two of the test cases py 3 ready, and for a patch from Mathieu to make another py 3 ready. Just for reference, it is convention (though I don't care to keep it) to use such a shebang to mark whether a scr

[Mesa-dev] [PATCH v2 2/2] meson: Use python3 to run glsl tests

--- src/compiler/glsl/tests/meson.build | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.build index fc7b863a278..2a41e30a28d 100644 --- a/src/compiler/glsl/tests/meson.build +++ b/src/compiler/glsl

[Mesa-dev] [PATCH v2 1/2] compiler/glsl/tests: Make tests python3 safe

v2: - explicitly decode the output of subprocesses - handle bytes and string types consistently rather than relying on python 2's coercion for bytes and ignoring them in python 3 --- src/compiler/glsl/tests/lower_jump_cases.py | 2 +- src/compiler/glsl/tests/optimization_test.py | 6 +

Re: [Mesa-dev] [PATCH 1/2] compiler/glsl/tests: Make tests python3 safe

Quoting Mathieu Bridon (2018-08-16 15:00:39) > On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote: > > --- > > > > I didn't see any patches from anyone else, so I wrote some real > > quick. Please > > point to them if other patches already exist. > > I was about to send mine, but you were faste

Re: [Mesa-dev] [PATCH 1/2] compiler/glsl/tests: Make tests python3 safe

Quoting Mathieu Bridon (2018-08-16 15:00:39) > On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote: > > --- > > > > I didn't see any patches from anyone else, so I wrote some real > > quick. Please > > point to them if other patches already exist. > > I was about to send mine, but you were faste

Re: [Mesa-dev] [PATCH 1/2] configure: use AM_PATH_PYTHON to look for the python version

Quoting Emil Velikov (2018-08-17 03:12:56) > On 16 August 2018 at 21:28, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-08-16 09:52:05) > >> On Thursday, 2018-08-16 17:18:56 +0100, Emil Velikov wrote: > >> > From: Emil Velikov > >> > > >> > Currently we use AC_CHECK_PROGS looking for python2

[Mesa-dev] [Bug 107098] Segfault after munmap(kms_sw_dt->ro_mapped)

https://bugs.freedesktop.org/show_bug.cgi?id=107098 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH v3 0/6] support config for third-party DRI driver load

On 15 August 2018 at 13:29, Emil Velikov wrote: > On 6 August 2018 at 04:19, Qiang Yu wrote: >> This patch series is discussed in thread: >> https://lists.freedesktop.org/archives/mesa-dev/2018-July/201348.html >> >> amdgpu-pro driver can use drirc config to override the mesa radeonsi >> dri driv

[Mesa-dev] [AppVeyor] mesa master #8635 completed

Build mesa 8635 completed Commit d9ea015ced by Jason Ekstrand on 8/7/2018 10:47 PM: anv/pipeline: Lower pipeline layouts etc. after linking\n\nThis allows us to use the link-optimized shader for determining binding\ntable layouts and, more importantly, URB layo

[Mesa-dev] [AppVeyor] mesa appveyor #8634 failed

Build mesa 8634 failed Commit 0a8cf88172 by Jose Fonseca on 8/17/2018 3:39 PM: Debug git CRLF Configure your notification preferences ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.f

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On 08/17/2018 09:32 AM, Jose Fonseca wrote: On 17/08/18 16:08, Jose Fonseca wrote: On 17/08/18 15:49, Mathieu Bridon wrote: On Fri, 2018-08-17 at 15:30 +0100, Jose Fonseca wrote: On 17/08/18 15:26, Mathieu Bridon wrote: On Fri, 2018-08-17 at 15:08 +0100, Jose Fonseca wrote: On 17/08/18 15:06

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On 17/08/18 16:08, Jose Fonseca wrote: On 17/08/18 15:49, Mathieu Bridon wrote: On Fri, 2018-08-17 at 15:30 +0100, Jose Fonseca wrote: On 17/08/18 15:26, Mathieu Bridon wrote: On Fri, 2018-08-17 at 15:08 +0100, Jose Fonseca wrote: On 17/08/18 15:06, Jose Fonseca wrote: On 17/08/18 14:52, Jos

Re: [Mesa-dev] Fix the build on Windows

On Fri, 2018-08-17 at 09:23 -0600, Brian Paul wrote: > On 08/17/2018 09:16 AM, Mathieu Bridon wrote: > > This is follow up to my recent patches which made the Python build > > scripts compatible with both Python 2 and 3, then moved the Meson > > build > > system to using Python 3 for them. > > > >

Re: [Mesa-dev] Fix the build on Windows

On 08/17/2018 09:16 AM, Mathieu Bridon wrote: This is follow up to my recent patches which made the Python build scripts compatible with both Python 2 and 3, then moved the Meson build system to using Python 3 for them. Unfortunately, one thing I hadn't tested was running them on Windows, where

Re: [Mesa-dev] [PATCH 3/5] anv/pipeline: Use more fields from stage in compile_cs

Reviewed-by: Lionel Landwerlin On 08/08/18 09:12, Jason Ekstrand wrote: --- src/intel/vulkan/anv_pipeline.c | 37 +++-- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c index 23af0f1c

Re: [Mesa-dev] [PATCH 2/5] anv/apply_pipeline_layout: Add to the bind map instead of replacing it

On 08/08/18 09:12, Jason Ekstrand wrote: This commit makes three changes. One is to only walk the descriptors once and set bind map sizes at the same time as filling out the entries. The second is to make the pass additive so that we can put stuff in the bind map before applying the pipeline la

Re: [Mesa-dev] [PATCH 1/5] anv/lower_ycbcr: Use the binding array size for bounds checks

On 08/08/18 09:12, Jason Ekstrand wrote: Because lower_ycbcr gets called before apply_pipeline_layout, the indices are all logical and the binding layout HW size is actually too big for the bounds check. We should just use the regular logical array size instead. Fixes: f3e91e78a33 "anv: add nir

[Mesa-dev] [PATCH 1/2] python: Help Python 2 print the line

Reviewed-by: Jose Fonseca --- src/util/xmlpool/gen_xmlpool.py | 5 + 1 file changed, 5 insertions(+) diff --git a/src/util/xmlpool/gen_xmlpool.py b/src/util/xmlpool/gen_xmlpool.py index 327709c7f8d..12177dc50f5 100644 --- a/src/util/xmlpool/gen_xmlpool.py +++ b/src/util/xmlpool/gen_xmlpool.p

[Mesa-dev] [PATCH 2/2] python: Open the template as text, with an explicit encoding

In commit bd27203f4d808763ac24ac94eb677cacf3e7cb99 we changed this to open in binary mode, to then explicitly decode the lines with the right encoding. Unfortunately, that broke the build on Windows, where the template file can have '\r\n' as line terminators: opening in binary mode would keep tho

[Mesa-dev] Fix the build on Windows

This is follow up to my recent patches which made the Python build scripts compatible with both Python 2 and 3, then moved the Meson build system to using Python 3 for them. Unfortunately, one thing I hadn't tested was running them on Windows, where the changes broke the build. See the exchange w

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On 17/08/18 15:49, Mathieu Bridon wrote: On Fri, 2018-08-17 at 15:30 +0100, Jose Fonseca wrote: On 17/08/18 15:26, Mathieu Bridon wrote: On Fri, 2018-08-17 at 15:08 +0100, Jose Fonseca wrote: On 17/08/18 15:06, Jose Fonseca wrote: On 17/08/18 14:52, Jose Fonseca wrote: On 17/08/18 14:30, Jos

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On Fri, 2018-08-17 at 15:30 +0100, Jose Fonseca wrote: > On 17/08/18 15:26, Mathieu Bridon wrote: > > On Fri, 2018-08-17 at 15:08 +0100, Jose Fonseca wrote: > > > On 17/08/18 15:06, Jose Fonseca wrote: > > > > On 17/08/18 14:52, Jose Fonseca wrote: > > > > > On 17/08/18 14:30, Jose Fonseca wrote: >

Re: [Mesa-dev] [PATCH 3/4] vulkan/wsi: initialise image_index to 0 in x11_manage_fifo_queues

Reviewed-by: Bas Nieuwenhuizen for this patch. On Fri, Aug 17, 2018 at 4:32 PM, Kai Wasserbäch wrote: > Supresses a maybe-uninitialized warning with GCC 8. > > Note: image_index should always be initialised due to the result check, > but the compiler doesn't see that. > Signed-off-by: Kai

[Mesa-dev] [PATCH 4/4] amd/addrlib: mark returnCode as MAYBE_UNUSED in ElemGetExportNorm

Only used, when asserts are enabled. Fixes an unused-but-set-variable warning with GCC 8: ../../../src/amd/addrlib/addrinterface.cpp: In function 'int ElemGetExportNorm(ADDR_HANDLE, const ELEM_GETEXPORTNORM_INPUT*)': ../../../src/amd/addrlib/addrinterface.cpp:835:23: warning: variable 'returnC

[Mesa-dev] [PATCH 2/4] nir: mark *prev_block as MAYBE_UNUSED in opt_peel_loop_initial_if

Only used, when asserts are enabled. Fixes an unused-variable warning with gcc-8: ../../../src/compiler/nir/nir_opt_if.c: In function 'opt_peel_loop_initial_if': ../../../src/compiler/nir/nir_opt_if.c:109:15: warning: unused variable 'prev_block' [-Wunused-variable] nir_block *prev_block =

[Mesa-dev] [PATCH 1/4] util: mark s as MAYBE_UNUSED in _mesa_half_to_unorm8

Only used, when asserts are enabled. Fixes an unused-variable warning with gcc-8: ../../../src/util/half_float.c: In function '_mesa_half_to_unorm8': ../../../src/util/half_float.c:189:14: warning: unused variable 's' [-Wunused-variable] const int s = (val >> 15) & 0x1; ^ S

[Mesa-dev] [PATCH 3/4] vulkan/wsi: initialise image_index to 0 in x11_manage_fifo_queues

Supresses a maybe-uninitialized warning with GCC 8. Note: image_index should always be initialised due to the result check, but the compiler doesn't see that. Signed-off-by: Kai Wasserbäch --- src/vulkan/wsi/wsi_common_x11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 0/4] Fix some compile warnings

Hey, while building Mesa I saw several warnings scroll by and this series addresses the first four I saw in my build log. The changes have been compile-tested in a clean chroot (pbuilder) environment. If you accept the patches, please apply them for me, as I don't have commit access for Mesa. The

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On 17/08/18 15:26, Mathieu Bridon wrote: On Fri, 2018-08-17 at 15:08 +0100, Jose Fonseca wrote: On 17/08/18 15:06, Jose Fonseca wrote: On 17/08/18 14:52, Jose Fonseca wrote: On 17/08/18 14:30, Jose Fonseca wrote: On 17/08/18 14:22, Mathieu Bridon wrote: --- Jose, can you test whether this pa

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On Fri, 2018-08-17 at 15:08 +0100, Jose Fonseca wrote: > On 17/08/18 15:06, Jose Fonseca wrote: > > On 17/08/18 14:52, Jose Fonseca wrote: > > > On 17/08/18 14:30, Jose Fonseca wrote: > > > > On 17/08/18 14:22, Mathieu Bridon wrote: > > > > > --- > > > > > Jose, can you test whether this patch fixe

Re: [Mesa-dev] [PATCH 08/13] radeon/uvd: remove get mjpeg slice header

These 3 patches are: Reviewed-by: Leo Liu On 2018-08-16 04:56 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Move the previous get_mjpeg_slice_heaeder function and eoi from "radeon/vcn" to "st/va". Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_uvd.c | 147 ---

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On 17/08/18 15:06, Jose Fonseca wrote: On 17/08/18 14:52, Jose Fonseca wrote: On 17/08/18 14:30, Jose Fonseca wrote: On 17/08/18 14:22, Mathieu Bridon wrote: --- Jose, can you test whether this patch fixes your build issues? I don't have access to a Windows machine, and I can't reproduce your

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On 17/08/18 14:52, Jose Fonseca wrote: On 17/08/18 14:30, Jose Fonseca wrote: On 17/08/18 14:22, Mathieu Bridon wrote: --- Jose, can you test whether this patch fixes your build issues? I don't have access to a Windows machine, and I can't reproduce your problem on Linux.   src/util/xmlpool/g

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On 17/08/18 14:30, Jose Fonseca wrote: On 17/08/18 14:22, Mathieu Bridon wrote: --- Jose, can you test whether this patch fixes your build issues? I don't have access to a Windows machine, and I can't reproduce your problem on Linux.   src/util/xmlpool/gen_xmlpool.py | 5 +   1 file changed

  1   2   >