Thanks Emil. > - missing include <limits.h> (for PATH_MAX) in patch 1 Although I can compile without <limits.h>, I agree to add it explicitly.
> - added HAVE_LIBDRM guard for __driConfigOptionsLoader and > loader_get_dri_config_driver My thoughts are: 1. __driConfigOptionsLoader and loader_get_dri_config_driver don't have code depend on HAVE_LIBDRM (loader_get_kernel_driver_name does but already has HAVE_LIBDRM), so it's OK to drop HAVE_LIBDRM 2. if drop HAVE_LIBDRM, user can still use dri_driver option to change dri driver to load even on non-libdrm env (although I'm not clear if this kind of env need this functionality) Regards, Qiang _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
