[Mesa-dev] [PATCH 2/2] util: add drirc workarounds for RAGE

This allows the game to run on wine (tested on radeonsi where we have compat profile support). --- src/util/drirc | 8 1 file changed, 8 insertions(+) diff --git a/src/util/drirc b/src/util/drirc index c4f9e060f3a..ad59efba50b 100644 --- a/src/util/drirc +++ b/src/util/drirc @@ -100,6 +1

[Mesa-dev] [PATCH 1/2] util: better handle program names from wine

For some reason wine will sometimes give us a windows style path for an application. For example when running the 64bit version of Rage wine gives a Unix style path, but when running the 32bit version is gives a windows style path. If we detect no '/' in the path at all it should be safe to assume

Re: [Mesa-dev] [PATCH 1/9] util/dynarray: add a clone function

2018-08-15 23:56 GMT+02:00 Caio Marcelo de Oliveira Filho : > --- > src/util/u_dynarray.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/util/u_dynarray.h b/src/util/u_dynarray.h > index dcbbc06d161..4920fe04b67 100644 > --- a/src/util/u_dynarray.h > +++ b/src/util/u_dynarra

[Mesa-dev] [Bug 106955] Mesa 18.1.2 not tagged in git

https://bugs.freedesktop.org/show_bug.cgi?id=106955 --- Comment #3 from Daniel Stone --- The tag is there: https://cgit.freedesktop.org/mesa/mesa/refs/tags We were failing to push tags for a while but it was fixed some time ago. -- You are receiving this mail because: You are the assignee for

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

On 08/16/2018 02:21 AM, Andres Gomez wrote: Danylo, should we also include this in the stable queues ? Yep makes sense, it's simple and fixes a crasher. On Mon, 2018-08-13 at 18:57 +0300, Danylo Piliaiev wrote: Accessing scalar constant as an array in function call or initializer list tri

Re: [Mesa-dev] [PATCH] radv: Possible demand compilation fix.

Thanks fixes steamvr for me :) Tested-by: Timothy Arceri Reviewed-by: Timothy Arceri On 16/08/18 00:25, Bas Nieuwenhuizen wrote: Seems that in a single case we use the renderpass before checking the pipeline, so check the renderpass before we use it. Fixes: fbcd1673144 "radv: Add on-demand c

Re: [Mesa-dev] [PATCH 1/3] freedreno: Fix warnings

The remaining two patches are stuck in moderation for being too big. They update the generated headers and adds the a6xx backend. They're in this branch: https://gitlab.freedesktop.org/krh/mesa/commits/wip/a6xx-rebase-3 for reference. Kristian On Wed, Aug 15, 2018 at 9:18 AM Kristian H. Krist

Re: [Mesa-dev] [PATCH] meson: fix build for egl platform_x11

On Wed, Aug 15, 2018 at 1:54 PM Alexander Tsoy wrote: > > platform_x11 needs inc_loader: > > ../mesa-18.2.0-rc2/src/egl/drivers/dri2/platform_x11.c:48:10: fatal > error: loader.h: No such file or directory > #include "loader.h" > ^~ > --- Thank you. I know this patch is to fix

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

Danylo, should we also include this in the stable queues ? On Mon, 2018-08-13 at 18:57 +0300, Danylo Piliaiev wrote: > Accessing scalar constant as an array in function call or > initializer list triggered assert in get_array_element. > Examples: >func(0[0]); >vec2 t = { 0[0], 0 }; > > B

Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

On Wed, Aug 15, 2018 at 5:36 PM Timothy Arceri wrote: > On 16/08/18 02:10, Jason Ekstrand wrote: > > On Tue, Aug 14, 2018 at 7:25 PM Timothy Arceri > > wrote: > > > > On 09/08/18 05:05, Jason Ekstrand wrote: > > > Commit 4434591bf56a6b0 caused substantially

Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

This corrects all of the performance regressions that I can see on our perf CI. Please make sure to add the fixes tag before pushing. Tested-by: Mark Janes Jason Ekstrand writes: > Commit 4434591bf56a6b0 caused substantially more URB messages in > geometry and tessellation shaders. Before we

Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

On 16/08/18 02:10, Jason Ekstrand wrote: On Tue, Aug 14, 2018 at 7:25 PM Timothy Arceri > wrote: On 09/08/18 05:05, Jason Ekstrand wrote: > Commit 4434591bf56a6b0 caused substantially more URB messages in > geometry and tessellation shaders.  Before we

[Mesa-dev] [PATCH 4/9] nir: Give end_block its own index

Since there's no particular reason for the index to be 0, choose an index that is not used by other block. This is convenient when we store "per-block" data in an array AND look for the successors data (e.g. any kind of backwards data-flow analysis). --- src/compiler/nir/nir.c | 2 +- 1 file chan

[Mesa-dev] [PATCH 5/9] nir: Add a local dead write vars removal pass

Instead of doing this as part of the existing (local) copy prop vars pass. This is an intermediate step before changing both the dead write and the copy prop vars to act on the whole program instead of on local blocks. The nature of data we store and the way we iterate is different enough that wo

[Mesa-dev] [PATCH 8/9] freedreno/ir3: Use the new dead write vars pass

--- src/gallium/drivers/freedreno/ir3/ir3_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/freedreno/ir3/ir3_nir.c b/src/gallium/drivers/freedreno/ir3/ir3_nir.c index db1d74fdee7..d5f42f2a231 100644 --- a/src/gallium/drivers/freedreno/ir3/ir3_nir.c +++ b/src/gallium/d

[Mesa-dev] [PATCH 9/9] nir: Remove handling of dead writes from copy_prop_vars

These are handled by a separate pass now. --- src/compiler/nir/nir_opt_copy_prop_vars.c | 67 +-- 1 file changed, 3 insertions(+), 64 deletions(-) diff --git a/src/compiler/nir/nir_opt_copy_prop_vars.c b/src/compiler/nir/nir_opt_copy_prop_vars.c index 9fecaf0eeec..b6a5b9c2bb4

[Mesa-dev] [PATCH 6/9] nir: Make dead_write_vars pass global

The pass will remove not only writes that are proven to be dead in block, but also writes that can only be considered dead by looking at multiple blocks. Such global analysis is necessary to remove dead writes such as the one marked below: int total = gl_VertexIndex * 10; float r = gl_Ver

[Mesa-dev] [PATCH 7/9] intel/nir: Use the new dead write vars pass

--- src/intel/compiler/brw_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c index 31ffbe613ec..afc73e58c71 100644 --- a/src/intel/compiler/brw_nir.c +++ b/src/intel/compiler/brw_nir.c @@ -543,6 +543,7 @@ brw_nir_optimize(nir_shad

[Mesa-dev] [PATCH 1/9] util/dynarray: add a clone function

--- src/util/u_dynarray.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/util/u_dynarray.h b/src/util/u_dynarray.h index dcbbc06d161..4920fe04b67 100644 --- a/src/util/u_dynarray.h +++ b/src/util/u_dynarray.h @@ -102,6 +102,15 @@ util_dynarray_resize(struct util_dynarray *buf, un

[Mesa-dev] [PATCH 3/9] nir: Skip common instructions when comparing deref paths

Deref paths may share the same deref instructions in their chains, e.g. ssa_100 = deref_var A ssa_101 = deref_struct "array_field" of ssa_100 ssa_102 = deref_array "[1]" of ssa_101 ssa_103 = deref_struct "field_a" of ssa_102 ssa_104 = deref_struct "field_a" of ssa_103 when com

[Mesa-dev] [PATCH 0/9] Global dead write vars removal pass

Our code currently only remove dead writes to vars for each block, but doesn't tackle cases that involve multiple blocks. This series will add a pass that use an iterative data-flow analysis to cover those cases. Commit message for patch 6 has a detailed example. I'm working on a subsequent seri

[Mesa-dev] [PATCH 2/9] nir: Export deref comparison functions

Reviewed-by: Timothy Arceri --- src/compiler/nir/nir_deref.c | 109 src/compiler/nir/nir_deref.h | 10 ++ src/compiler/nir/nir_opt_copy_prop_vars.c | 145 ++ 3 files changed, 132 insertions(+), 132 deletions(-) diff --git a/src/comp

[Mesa-dev] [Bug 107565] TypeError: __init__() got an unexpected keyword argument 'future_imports'

https://bugs.freedesktop.org/show_bug.cgi?id=107565 Dylan Baker changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |baker.dyla...@gmail.com

[Mesa-dev] [Bug 107502] Newest libdrm is required by amdgpu, but drm_intel error is emitted

https://bugs.freedesktop.org/show_bug.cgi?id=107502 Dylan Baker changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |baker.dyla...@gmail.com

[Mesa-dev] [Bug 107478] Regression: Mesa compile broken (snprintf) with Visual Studio 2013 (vs2013)

https://bugs.freedesktop.org/show_bug.cgi?id=107478 Dylan Baker changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |baker.dyla...@gmail.com

[Mesa-dev] [Bug 107478] Regression: Mesa compile broken (snprintf) with Visual Studio 2013 (vs2013)

https://bugs.freedesktop.org/show_bug.cgi?id=107478 Dylan Baker changed: What|Removed |Added Version|unspecified |18.1 CC|

[Mesa-dev] [Bug 106411] Invalid gl_InstanceID value with combination of gl_DrawIDARB under OpenGL

https://bugs.freedesktop.org/show_bug.cgi?id=106411 Dylan Baker changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/8] radv: don't flush src stages when dstStageMask == BOTTOM_OF_PIPE

On Thursday 09 August 2018, Andres Gomez wrote: > Fredrik, which is the status of this series? Several patches got R-b > but nothing has landed so far. Are you in need of more reviews for the > rest of the patches in the series? The master branch has diverged quite a bit as a result of the VK_KHR_

[Mesa-dev] [Bug 107313] Meson instructions on web site are non-optimal

https://bugs.freedesktop.org/show_bug.cgi?id=107313 Dylan Baker changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |baker.dyla...@gmail.com

Re: [Mesa-dev] [PATCH 2/2] nir: Add a global dead write var removal pass

Disregard this patch. I'm sending a replacement for it. For the record: > The pass works by walking through the control flow nodes, and traverse > the instructions keeping track of the write instructions whose > destination were not overwritten by other instructions (called "live > writes"). Read

[Mesa-dev] [Bug 107275] NIR segfaults after spirv-opt

https://bugs.freedesktop.org/show_bug.cgi?id=107275 Dylan Baker changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [PATCH v3] anv: add VK_EXT_sampler_filter_minmax support

This extension can be supported on SKL+. With this patch, all corresponding tests (6K+) in CTS can pass. No test fails. I verified CTS with the command below: deqp-vk --deqp-case=dEQP-VK.pipeline.sampler.view_type.*reduce* v2: 1) support all depth formats, not depth-only formats, 2) fix a wrong i

[Mesa-dev] [Bug 106976] Compilation failure due to missing xcb_randr_lease_t

https://bugs.freedesktop.org/show_bug.cgi?id=106976 Dylan Baker changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] intel/eu: print bytes instead of 32 bit hex value

INTEL_DEBUG=hex prints 32 bit hex value and due to endianness of CPU byte order is reversed. In order to disassemble binary files, print each byte instead of 32 bit hex value. Signed-off-by: Sagar Ghuge --- src/intel/compiler/brw_eu.c | 24 1 file changed, 16 insertions(

[Mesa-dev] [Bug 106955] Mesa 18.1.2 not tagged in git

https://bugs.freedesktop.org/show_bug.cgi?id=106955 Dylan Baker changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] meson: fix build for egl platform_x11

platform_x11 needs inc_loader: ../mesa-18.2.0-rc2/src/egl/drivers/dri2/platform_x11.c:48:10: fatal error: loader.h: No such file or directory #include "loader.h" ^~ --- src/egl/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/meson.build b

Re: [Mesa-dev] [PATCH v2 5/5] scons: Check for mako 0.8.0

On 15/08/18 17:18, Dylan Baker wrote: v2: - Use distutils to do the version checking Bugzilla: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.freedesktop.org%2Fshow_bug.cgi%3Fid%3D107565&data=02%7C01%7Cjfonseca%40vmware.com%7C49a58211ac9747678b9608d602cad13d%7Cb39138ca3ce

[Mesa-dev] [Bug 83785] Shader branches excluded by uniform values are not optimized out

https://bugs.freedesktop.org/show_bug.cgi?id=83785 Dylan Baker changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 103078] MATLAB broken with mesa software rendering

https://bugs.freedesktop.org/show_bug.cgi?id=103078 Dylan Baker changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|NEW

Re: [Mesa-dev] [PATCH v2] anv: add VK_EXT_sampler_filter_minmax support

On August 15, 2018 14:43:08 Lionel Landwerlin wrote: Hey there, Just a few nits below. Thanks! - Lionel On 15/08/18 18:42, Yunchao He wrote: This extension can be supported on SKL+. With this patch, all corresponding tests (6K+) in CTS can pass. No test fails. I verified CTS with the com

Re: [Mesa-dev] [PATCH] mesa/st: fix array indices off-by-one error in remapping

Reviewed-by: Dave Airlie On Thu, 16 Aug 2018 at 03:31, Gert Wollny wrote: > > When moving the array sizes from the old list to the new one it was > not taken into account that the array indices start with one, but the > array_size array started at index zero, which resulted in incorrect array > s

[Mesa-dev] [Bug 107457] [Tracker] Mesa 18.2 release tracker

https://bugs.freedesktop.org/show_bug.cgi?id=107457 Mark Janes changed: What|Removed |Added Depends on||107359 Referenced Bugs: https://bugs.fre

Re: [Mesa-dev] [PATCH v2] anv: add VK_EXT_sampler_filter_minmax support

Hey there, Just a few nits below. Thanks! - Lionel On 15/08/18 18:42, Yunchao He wrote: This extension can be supported on SKL+. With this patch, all corresponding tests (6K+) in CTS can pass. No test fails. I verified CTS with the command below: deqp-vk --deqp-case=dEQP-VK.pipeline.sampler.

[Mesa-dev] [Bug 107563] [RADV] Broken rendering in Unity demos

https://bugs.freedesktop.org/show_bug.cgi?id=107563 --- Comment #6 from Alexander Tsoy --- Not sure if I did it right: https://www.dropbox.com/s/glc70mfzirow9c5/CorridorLightingExample.rdc.xz?dl=0 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact f

Re: [Mesa-dev] [PATCH 3/8] mesa: expose AMD_multi_draw_indirect

This patch is Reviewed-by: Ian Romanick On 08/08/2018 07:12 PM, Marek Olšák wrote: > From: Marek Olšák > > because the closed driver exposes it. > This is equivalent to the ARB extension. > --- > docs/relnotes/18.3.0.html| 1 + > src/mapi/glapi/gen/ARB_draw_indirect.xml | 20

Re: [Mesa-dev] [PATCH 4/8] mesa: expose AMD_query_buffer_object

This patch is Reviewed-by: Ian Romanick On 08/08/2018 07:12 PM, Marek Olšák wrote: > From: Marek Olšák > > it's a subset of the ARB extension. > --- > docs/relnotes/18.3.0.html| 1 + > src/mesa/main/extensions_table.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/docs/re

Re: [Mesa-dev] [PATCH 5/8] mesa: expose AMD_texture_texture4

On 08/08/2018 07:12 PM, Marek Olšák wrote: > From: Marek Olšák > > because the closed driver exposes it. Aside from AMD_texture_texture4 being really, really under-specified, there is one big difference between the two extensions. 7) Can both texture *AND* texture4 built-in functions s

Re: [Mesa-dev] [PATCH 6/8] mesa: expose EXT_vertex_attrib_64bit

This patch is Reviewed-by: Ian Romanick On 08/08/2018 07:12 PM, Marek Olšák wrote: > From: Marek Olšák > > because the closed driver exposes it. > It's the same as the ARB extension. > --- > docs/relnotes/18.3.0.html | 1 + > .../glapi/gen/EXT_vertex_attrib_64bit.xml

Re: [Mesa-dev] [PATCH 15/21] mesa: move legacy dri config option texture_units

This patch is Reviewed-by: Ian Romanick I think that's the last one that I'm going to do right now. If nobody beats me to it, I'll try to look at the others later. On 08/15/2018 03:13 AM, Timothy Arceri wrote: > --- > src/mesa/drivers/dri/radeon/radeon_screen.c | 5 + > src/util/xmlpool/c

Re: [Mesa-dev] [PATCH 14/21] mesa: remove unused dri config option texture_heaps

This patch is Reviewed-by: Ian Romanick On 08/15/2018 03:13 AM, Timothy Arceri wrote: > This seems to have only been used by DRI1 drivers which were > removed with e4344161bde2. > --- > src/util/xmlpool/ca.po | 16 > src/util/xmlpool/de.po | 16 > s

Re: [Mesa-dev] [PATCH 13/21] mesa: move legacy dri config option texture_blend_quality

This patch is Reviewed-by: Ian Romanick On 08/15/2018 03:13 AM, Timothy Arceri wrote: > --- > src/mesa/drivers/dri/radeon/radeon_screen.c | 6 ++ > src/util/xmlpool/ca.po | 6 -- > src/util/xmlpool/de.po | 6 -- > src/util/xmlpool/es.po

Re: [Mesa-dev] [PATCH 12/21] util: remove unused S3TC translation for dri config

This patch is Reviewed-by: Ian Romanick On 08/15/2018 03:13 AM, Timothy Arceri wrote: > --- > src/util/xmlpool/ca.po | 7 --- > src/util/xmlpool/de.po | 7 --- > src/util/xmlpool/es.po | 7 --- > src/util/xmlpool/fr.po | 6 -- > src/util/xmlpool/nl.po | 7 --- > src/util/xml

Re: [Mesa-dev] [PATCH 09/21] mesa: remove legacy TCL dri config options

On 08/15/2018 04:09 AM, Timothy Arceri wrote: > On 15/08/18 20:26, Michel Dänzer wrote: >> On 2018-08-15 12:13 PM, Timothy Arceri wrote: >>> Use enviroment var overrides in legacy drivers instead. >> >> This could break existing user configurations using the driconf tcl_mode >> option. >> >> Apart

Re: [Mesa-dev] [PATCH] anv: add VK_EXT_sampler_filter_minmax support

Thanks for your review, Jason. I submitted a new patch set accordingly. PTAL when you have time. -Original Message- From: Jason Ekstrand [mailto:ja...@jlekstrand.net] Sent: Monday, August 13, 2018 6:00 PM To: He, Yunchao ; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] a

Re: [Mesa-dev] [PATCH 07/21] mesa: remove dri configs unused software-fallback options

I could have sworn that the nouveau_viex drivers used this, but I guess not. Weird. This patch is Reviewed-by: Ian Romanick On 08/15/2018 03:13 AM, Timothy Arceri wrote: > These seems to have only been used by DRI1 drivers which were > removed with e4344161bde2. > --- > src/util/xmlpool/ca.po

Re: [Mesa-dev] [PATCH 06/21] mesa: remove unused dri config option excess_mipmap

This patch is Reviewed-by: Ian Romanick On 08/15/2018 03:13 AM, Timothy Arceri wrote: > This seems to have only been used by DRI1 drivers which were > removed with e4344161bde2. > --- > src/util/xmlpool/t_options.h | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/src/util/xmlpool/t

[Mesa-dev] [PATCH v2] anv: add VK_EXT_sampler_filter_minmax support

This extension can be supported on SKL+. With this patch, all corresponding tests (6K+) in CTS can pass. No test fails. I verified CTS with the command below: deqp-vk --deqp-case=dEQP-VK.pipeline.sampler.view_type.*reduce* v2: 1) support all depth formats, not depth-only formats, 2) fix a wrong i

Re: [Mesa-dev] [PATCH 04/21] mesa: remove unused dri config option performance_boxes

This patch is Reviewed-by: Ian Romanick On 08/15/2018 03:13 AM, Timothy Arceri wrote: > This seems to have only been used by DRI1 drivers which were > removed with e4344161bde2. > --- > src/util/xmlpool/ca.po | 4 > src/util/xmlpool/de.po | 4 > src/util/xmlpool/es.po

Re: [Mesa-dev] [PATCH 2/8] mesa: expose AMD_gpu_shader_int64

On 08/08/2018 07:12 PM, Marek Olšák wrote: > From: Marek Olšák > > because the closed driver exposes it. > > It's equivalent to ARB_gpu_shader_int64. > In this patch, I did everything the same as we do for ARB_gpu_shader_int64. The closed driver only exposes this on core profile? That's unexpe

Re: [Mesa-dev] [PATCH 1/8] mesa: expose ARB_post_depth_coverage in the Compatibility profile

On 08/08/2018 07:12 PM, Marek Olšák wrote: > From: Marek Olšák > > It only contains GLSL changes. This will probably need some other changes. This extension requires the use of the layout keyword, and we only enable that in early GLSL versions when certain extensions are enabled. > --- > src/

Re: [Mesa-dev] [PATCH v4 13/15] mesa/st/glsl_to_tgsi: Expose array live range tracking and merging

Am Mittwoch, den 15.08.2018, 12:58 +1000 schrieb Dave Airlie: > On Wed, 6 Jun 2018 at 06:30, Gert Wollny > wrote: > > > > This patch ties in the array split, merge, and interleave code. > > > > shader-db changes in the TGSI code are: > > This regresses > tests/spec/glsl-1.50/execution/variable-

[Mesa-dev] [PATCH] mesa/st: fix array indices off-by-one error in remapping

When moving the array sizes from the old list to the new one it was not taken into account that the array indices start with one, but the array_size array started at index zero, which resulted in incorrect array sizes when arrays were merged. Correct this by copying the array_size values of the ret

Re: [Mesa-dev] [PATCH 2/2] virgl: report actual max-texture sizes

Reviewed-by: Jakob Bornecrantz On Tue, Aug 14, 2018 at 2:02 PM, Erik Faye-Lund wrote: > Instead of doing conservative guesses, we should report the max levels > based on the max sizes we get from GL on the host. > > Signed-off-by: Erik Faye-Lund > --- > src/gallium/drivers/virgl/virgl_hw.h

[Mesa-dev] [Bug 105371] r600_shader_from_tgsi - GPR limit exceeded - shader requires 360 registers

https://bugs.freedesktop.org/show_bug.cgi?id=105371 --- Comment #11 from MWATTT --- Hello, Many thanks for this series. It fix a lot of bugs. Animated leaders in Civ5 and Civ6 now works fine. It also solves a lot of Minecraft shaderpack's issues. Dolphin-emu's ubershader still however cause prob

Re: [Mesa-dev] [PATCH 1/2] virgl: do not use SP_MAX_TEXTURE_*_LEVELS defines

Reviewed-by: Jakob Bornecrantz On Tue, Aug 14, 2018 at 2:02 PM, Erik Faye-Lund wrote: > These macro-names are also used for softpipe, so let's avoid confusion > by avoiding them. Besides, they are just used in one place in virgl, so > let's just inline them into the place they are used instead.

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Fix missing Android platform define.

Quoting Bas Nieuwenhuizen (2018-08-15 09:34:41) > On Wed, Aug 15, 2018 at 6:08 PM, Dylan Baker wrote: > > Quoting Bas Nieuwenhuizen (2018-08-09 17:27:46) > >> CC: > >> --- > >> src/amd/vulkan/Android.mk | 2 ++ > >> src/amd/vulkan/Makefile.am | 2 +- > >> 2 files changed, 3 insertions(+), 1 del

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Fix missing Android platform define.

On Wed, Aug 15, 2018 at 6:08 PM, Dylan Baker wrote: > Quoting Bas Nieuwenhuizen (2018-08-09 17:27:46) >> CC: >> --- >> src/amd/vulkan/Android.mk | 2 ++ >> src/amd/vulkan/Makefile.am | 2 +- >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/src/amd/vulkan/Android.mk b/src/am

[Mesa-dev] [PATCH v2 2/5] meson: use python3 module to find python3

This handy helper is nice for OSes that are not linux or BSD like (mac and windows) as it knows how to find python3 in odd places. --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5dc9b45eb42..c8bac35659f 100644 --- a/meson.build +

[Mesa-dev] [PATCH v2 1/5] meson: Ensure that mako is >= 0.8.0

It's what autotools has required for a long time. --- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 7436164946b..5dc9b45eb42 100644 --- a/meson.build +++ b/meson.build @@ -698,9 +698,9 @@ if with_platform_haiku endif prog_py

[Mesa-dev] [PATCH v2 5/5] scons: Check for mako 0.8.0

v2: - Use distutils to do the version checking Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107565 --- scons/gallium.py | 13 + 1 file changed, 13 insertions(+) diff --git a/scons/gallium.py b/scons/gallium.py index 659da72c1c3..aa7201a9715 100755 --- a/scons/gallium.py +++

[Mesa-dev] [PATCH v2 3/5] configure: Enforce python 2.7.x

We don't want to support older versions of python 2 anymore, and we don't support python 3.x in autotools currently. --- configure.ac | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure.ac b/configure.ac index c2155a541b0..78672734d06 100644 --- a/configure.ac +++ b/configure.ac @

[Mesa-dev] [PATCH v2 4/5] scons: Require python 2.7

less than 2.7 is not supported. v2: - Remove check for python >= 2.0, since we've already enforced 2.7 --- SConstruct | 1 + scons/gallium.py | 4 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/SConstruct b/SConstruct index 6e034fb968f..51dc301a9a8 100644 --- a/SConstruc

[Mesa-dev] [PATCH 1/3] freedreno: Fix warnings

From: "Kristian H. Kristensen" Signed-off-by: Kristian H. Kristensen --- src/gallium/drivers/freedreno/a5xx/fd5_compute.c | 2 +- src/gallium/drivers/freedreno/freedreno_resource.c | 8 src/gallium/drivers/freedreno/ir3/ir3.h| 8 ++-- src/gallium/drivers/freedreno/ir3

Re: [Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

On Tue, Aug 14, 2018 at 7:25 PM Timothy Arceri wrote: > On 09/08/18 05:05, Jason Ekstrand wrote: > > Commit 4434591bf56a6b0 caused substantially more URB messages in > > geometry and tessellation shaders. Before we can really enable this > > sort of optimization, We either need some way of comb

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Fix missing Android platform define.

Quoting Bas Nieuwenhuizen (2018-08-09 17:27:46) > CC: > --- > src/amd/vulkan/Android.mk | 2 ++ > src/amd/vulkan/Makefile.am | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/Android.mk b/src/amd/vulkan/Android.mk > index cee3744f40b..51b03561fa7 100644 >

Re: [Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

Hi all, This workaround just helps me to avoid the graphical corruption on SNB but I not sure is it good idea. Regards, Andrii. On Wed, Aug 15, 2018 at 6:20 PM, wrote: > From: Andrii Simiklit > > When the SVBI Payload Enable is false I guess the register R1.4 > which contains the Maximum Stre

[Mesa-dev] [Bug 107509] corrupted Box in top Right corner in some games

https://bugs.freedesktop.org/show_bug.cgi?id=107509 Michel Dänzer changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop

[Mesa-dev] [Bug 107509] corrupted Box in top Right corner in some games

https://bugs.freedesktop.org/show_bug.cgi?id=107509 Michel Dänzer changed: What|Removed |Added Attachment #140998|text/x-log |text/plain mime type|

[Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

From: Andrii Simiklit When the SVBI Payload Enable is false I guess the register R1.4 which contains the Maximum Streamed Vertex Buffer Index is filled by zero and GS stops to write transform feedback when the transform feedback is not active. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi

Re: [Mesa-dev] [PATCH] radv: Update to new VK_EXT_vertex_attribute_divisor to version 2.

On August 15, 2018 09:28:36 Bas Nieuwenhuizen wrote: On Wed, Aug 15, 2018 at 11:49 AM, Jason Ekstrand wrote: On Tue, Aug 14, 2018 at 7:20 AM Samuel Pitoiset wrote: Reviewed-by: Samuel Pitoiset On 7/23/18 4:24 PM, Bas Nieuwenhuizen wrote: Behavior wrt firstInstance got changed, and a div

[Mesa-dev] [PATCH v4 2/4] gm107/ir: add support for OP_XMAD on GM107+

v4: make the immediate field 16 bits Signed-off-by: Rhys Perry --- .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 65 ++ .../nouveau/codegen/nv50_ir_target_gm107.cpp | 6 +- .../nouveau/codegen/nv50_ir_target_nvc0.cpp| 1 + 3 files changed, 71 insertions

[Mesa-dev] [PATCH v4 0/4] nv50/ir: Improve Performance of Integer Multiplication

Changes in v4: - remove uint16_t(...) in nv50_ir.h - change XMAD immediate size from signed 20 bit to unsigned 16 bit - rework the 4th patch Changes in v3: - stylistic changes - simplify createMulMethod2() - update shader-db statistics - use util_bitcount64 and util_next_power_of_two64 instead of

[Mesa-dev] [PATCH v4 1/4] nv50/ir: add preliminary support for OP_XMAD

v4: remove uint16_t(...) v4: don't allow immediates outside [0,65535] in insnCanLoad() Signed-off-by: Rhys Perry Reviewed-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 26 ++ .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 18 +--

[Mesa-dev] [PATCH v4 3/4] nv50/ir: optimize imul/imad to xmads

This hits the shader-db numbers a good bit, though a few xmads is way faster than an imul or imad and the cost is mitigated by the next commit, which optimizes many multiplications by immediates into shorter and less register heavy instructions than the xmads. total instructions in shared programs

[Mesa-dev] [PATCH v4 4/4] nv50/ir: further optimize multiplication by immediates

Strongly mitigates the harm from the previous commit, which made many integer multiplications much more heavy on the register and instruction count. total instructions in shared programs : 5820882 -> 5788434 (-0.56%) total gprs used in shared programs: 670595 -> 669996 (-0.09%) total shared us

Re: [Mesa-dev] [PATCH v5 1/2] intel/ppgtt: memory address alignment

On 15/08/18 12:23, Sergii Romantsov wrote: Kernel (for ppgtt) requires memory address to be aligned to page size (4096). -v2: added marking that also fixes initial commit 01058a552294. -v3: numbers replaced by PAGE_SIZE; buffer-object size is aligned instead of alignment of offsets (Chris Wilson

Re: [Mesa-dev] [PATCH] radv: Revert divisor = 0 case for vertex attribute extension.

Reviewed-by: Samuel Pitoiset On 8/15/18 4:30 PM, Bas Nieuwenhuizen wrote: Seems like DXVK depends on that and it might get reverted upstream. Since apps are not supposed to use 0 in v2 anyway, we should be safe implementing the old behavior there. Fixes: 66e12451ac4 "radv: Update to new VK_EXT

[Mesa-dev] [PATCH] radv: Revert divisor = 0 case for vertex attribute extension.

Seems like DXVK depends on that and it might get reverted upstream. Since apps are not supposed to use 0 in v2 anyway, we should be safe implementing the old behavior there. Fixes: 66e12451ac4 "radv: Update to new VK_EXT_vertex_attribute_divisor to version 2." CC: 18.2 --- src/amd/vulkan/radv_n

Re: [Mesa-dev] [PATCH] radv: Update to new VK_EXT_vertex_attribute_divisor to version 2.

On Wed, Aug 15, 2018 at 11:49 AM, Jason Ekstrand wrote: > On Tue, Aug 14, 2018 at 7:20 AM Samuel Pitoiset > wrote: >> >> Reviewed-by: Samuel Pitoiset >> >> On 7/23/18 4:24 PM, Bas Nieuwenhuizen wrote: >> > Behavior wrt firstInstance got changed, and a divisor of 0 has been >> > disallowed. >> >

[Mesa-dev] [PATCH] radv: Possible demand compilation fix.

Seems that in a single case we use the renderpass before checking the pipeline, so check the renderpass before we use it. Fixes: fbcd1673144 "radv: Add on-demand compilation of built-in shaders." --- src/amd/vulkan/radv_meta_resolve_fs.c | 8 1 file changed, 8 insertions(+) diff --git a

[Mesa-dev] [Bug 107460] radv: OpControlBarrier does not always work correctly (bisected)

https://bugs.freedesktop.org/show_bug.cgi?id=107460 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH v1] i965: Emitting 3DSTATE_SO_BUFFER of 0-size.

Hello, that patch is according to remark: > > "Additionally, we probably ought to fix the callers to stop allocating 0 > size BOs. > It looks like most of them come from the 3DSTATE_SO_BUFFER code, > where one stream has valid transform feedback info, and the other > 3 are empty. " And seems add

[Mesa-dev] [PATCH v1] i965/bo/perf: 0-sized-bo allocation log

Added debug-log in case of bo-allocation with 0 size. Potentially we may not need to allocate such buffers and each case could be analyzed to improve behaviour. Signed-off-by: Sergii Romantsov --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/m

Re: [Mesa-dev] [PATCH] radv: fix memory leaks in radv_load_meta_pipeline()

Reviewed-by: Bas Nieuwenhuizen On Wed, Aug 15, 2018 at 3:28 PM, Samuel Pitoiset wrote: > Reported by Coverity. > > Fixes: fbcd167314 ("radv: Add on-demand compilation of built-in shaders.") > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta.c | 5 +++-- > 1 file changed, 3 inser

Re: [Mesa-dev] [PATCH] radv: drop wrong initialization of COMPUTE_RESOURCE_LIMITS

On 8/15/18 3:34 PM, Bas Nieuwenhuizen wrote: On Wed, Aug 15, 2018 at 2:13 PM, Samuel Pitoiset wrote: On 8/14/18 9:15 PM, Bas Nieuwenhuizen wrote: On Tue, Aug 14, 2018 at 6:11 PM, Samuel Pitoiset wrote: The last parameter of radeon_set_sh_reg_seq() is the number of dwords to emit. We we

Re: [Mesa-dev] [PATCH] radv: disable the auto-waitcnt-before-barrier LLVM option

On 8/15/18 3:33 PM, Bas Nieuwenhuizen wrote: Reviewed-by: Bas Nieuwenhuizen On Wed, Aug 15, 2018 at 3:09 PM, Samuel Pitoiset wrote: This option allows us to remove additional s_waitcnt instructions because s_barrier internally does s_waitcnt 0. Though, apparently there is a problem with LD

Re: [Mesa-dev] [PATCH] radv: drop wrong initialization of COMPUTE_RESOURCE_LIMITS

On Wed, Aug 15, 2018 at 2:13 PM, Samuel Pitoiset wrote: > > > On 8/14/18 9:15 PM, Bas Nieuwenhuizen wrote: >> >> On Tue, Aug 14, 2018 at 6:11 PM, Samuel Pitoiset >> wrote: >>> >>> The last parameter of radeon_set_sh_reg_seq() is the number of >>> dwords to emit. We were lucky because WAVES_PER_SH

Re: [Mesa-dev] [PATCH] radv: disable the auto-waitcnt-before-barrier LLVM option

Reviewed-by: Bas Nieuwenhuizen On Wed, Aug 15, 2018 at 3:09 PM, Samuel Pitoiset wrote: > This option allows us to remove additional s_waitcnt instructions > because s_barrier internally does s_waitcnt 0. > > Though, apparently there is a problem with LDS accesses that > causes rendering issues w

Re: [Mesa-dev] [PATCH v3 0/6] support config for third-party DRI driver load

> Pardon for the delay, Qiang Yu Series looks good and is > Reviewed-by: Emil Velikov > > The series has been on the list for a while, Michel seems happy with > it, so I'm inclined to merge this late today/early tomorrow. > Please keep an eye open for any bug reports - just a gut feeling. Thank

[Mesa-dev] [PATCH] radv: fix memory leaks in radv_load_meta_pipeline()

Reported by Coverity. Fixes: fbcd167314 ("radv: Add on-demand compilation of built-in shaders.") Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_meta.c b/src/amd/vulkan/radv_meta.c index cc

  1   2   >