Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com>
On 8/15/18 4:30 PM, Bas Nieuwenhuizen wrote:
Seems like DXVK depends on that and it might get reverted upstream. Since apps are not supposed to use 0 in v2 anyway, we should be safe implementing the old behavior there. Fixes: 66e12451ac4 "radv: Update to new VK_EXT_vertex_attribute_divisor to version 2." CC: 18.2 <mesa-sta...@lists.freedesktop.org> --- src/amd/vulkan/radv_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index bfd8b562e5c..8bf3ae0f150 100644 --- a/src/amd/vulkan/radv_nir_to_llvm.c +++ b/src/amd/vulkan/radv_nir_to_llvm.c @@ -2006,7 +2006,7 @@ handle_vs_input_decl(struct radv_shader_context *ctx, MAX2(1, ctx->shader_info->vs.vgpr_comp_cnt); } } else { - unreachable("Invalid vertex attribute divisor of 0."); + buffer_index = ctx->ac.i32_0; }buffer_index = LLVMBuildAdd(ctx->ac.builder, ctx->abi.start_instance, buffer_index, "");
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
