Re: [Mesa-dev] [PATCH 07/13] nir: Transform expressions of b2f(a) and b2f(b) to a || b

2018-08-02 Thread Thomas Helland
With the correction of the fmin/fmax pattern in this one and patch 10, and the inot version of the pattern in patch 9 and 11, patch 7, and 9-11 are: Reviewed-by: Thomas Helland I think that should be the whole series. 2018-08-03 1:38 GMT+02:00 Ian Romanick : > On 08/02/2018 02:10 PM, Thomas Hel

Re: [Mesa-dev] [PATCH] [rfc] r600: set vpm bit for loop start clause

2018-08-02 Thread Dave Airlie
On 3 August 2018 at 14:02, Roland Scheidegger wrote: > Am 03.08.2018 um 05:10 schrieb Dave Airlie: >> From: Dave Airlie >> >> This fixes some hangs with the arb_shader_image_load_store-atomicity tests >> on evergreen/cayman GPUs. >> >> I'm not 100% sure why (VPM hurts my brain), I'm running some

Re: [Mesa-dev] [PATCH] anv/pipeline: Disable FS dispatch for pointless fragment shaders

2018-08-02 Thread Kenneth Graunke
On Thursday, August 2, 2018 10:31:19 AM PDT Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_pipeline.c | 37 + > 1 file changed, 33 insertions(+), 4 deletions(-) > > diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c > index 85f38da60

Re: [Mesa-dev] [PATCH] [rfc] r600: set vpm bit for loop start clause

2018-08-02 Thread Roland Scheidegger
Am 03.08.2018 um 05:10 schrieb Dave Airlie: > From: Dave Airlie > > This fixes some hangs with the arb_shader_image_load_store-atomicity tests > on evergreen/cayman GPUs. > > I'm not 100% sure why (VPM hurts my brain), I'm running some piglit > runs to see if it has any bad side effects. > --- >

Re: [Mesa-dev] [PATCH] util: return 0 for NaNs in float_to_ubyte

2018-08-02 Thread Brian Paul
On 08/02/2018 09:36 PM, srol...@vmware.com wrote: From: Roland Scheidegger d3d10 requires NaNs to get converted to 0 for float->unorm conversions (and float->int etc.). GL spec probably doesn't care in general, but it would make sense to have reasonable behavior in any case imho - the old code

[Mesa-dev] [PATCH] util: return 0 for NaNs in float_to_ubyte

2018-08-02 Thread sroland
From: Roland Scheidegger d3d10 requires NaNs to get converted to 0 for float->unorm conversions (and float->int etc.). GL spec probably doesn't care in general, but it would make sense to have reasonable behavior in any case imho - the old code was converting negative NaNs to 0, and positive NaNs

[Mesa-dev] [PATCH] [rfc] r600: set vpm bit for loop start clause

2018-08-02 Thread Dave Airlie
From: Dave Airlie This fixes some hangs with the arb_shader_image_load_store-atomicity tests on evergreen/cayman GPUs. I'm not 100% sure why (VPM hurts my brain), I'm running some piglit runs to see if it has any bad side effects. --- src/gallium/drivers/r600/r600_shader.c | 2 +- 1 file change

Re: [Mesa-dev] [PATCH 2/2] intel: Fix SIMD16 unaligned payload GRF reads on Gen4-5.

2018-08-02 Thread Jason Ekstrand
On Thu, Aug 2, 2018 at 6:52 PM Kenneth Graunke wrote: > When the SIMD16 Gen4-5 fragment shader payload contains source depth > (g2-3), destination stencil (g4), and destination depth (g5-6), the > single register of stencil makes the destination depth unaligned. > > We were generating this instru

Re: [Mesa-dev] [PATCH 1/2] xmlconfig: read more config files from drirc.d/

2018-08-02 Thread Yu, Qiang
OK, I'll move /etc/drirc to /usr/share/drirc.d. For /etc/drirc and /etc/drirc.d, I agree to keep /etc/drirc for keeping user convention of the previously usage of this file. As newly added /etc/drirc.d, just for admin's flexibility, I can drop it if no clear needs for now. Regards, Qiang ___

[Mesa-dev] [PATCH 1/2] i965: Only enable depth IZ signals if there's an actual depthbuffer.

2018-08-02 Thread Kenneth Graunke
According to the G45 PRM Volume 2 Page 265 we're supposed to only set these signals when there is an actual depth buffer. Note that we already do this for the stencil buffer by virtue of brw->stencil_enabled invoking _mesa_is_stencil_enabled(ctx) which checks whether the current drawbuffer's visua

[Mesa-dev] [PATCH 2/2] intel: Fix SIMD16 unaligned payload GRF reads on Gen4-5.

2018-08-02 Thread Kenneth Graunke
When the SIMD16 Gen4-5 fragment shader payload contains source depth (g2-3), destination stencil (g4), and destination depth (g5-6), the single register of stencil makes the destination depth unaligned. We were generating this instruction in the RT write payload setup: mov(16) m14<1>F g5<8

Re: [Mesa-dev] [PATCH 2/2] loader: add dri_driver drirc option to override dri driver to load

2018-08-02 Thread Yu, Qiang
My thoughts is "driver" and "kernel_driver" don't need to appear at the same time, so "driver" can be reused for simplicity. If you guys still prefer adding "kernel_driver" for clean/clear, I'd also suggest to make this new attribute only affect loader device. Regards, Qiang __

Re: [Mesa-dev] [PATCH v3 1/8] nir: evaluate if condition uses inside the if branches

2018-08-02 Thread Timothy Arceri
On 03/08/18 10:52, Dieter Nützel wrote: Am 02.08.2018 05:14, schrieb Marek Olšák: On Wed, Aug 1, 2018 at 5:02 PM, Dieter Nützel wrote: Am 01.08.2018 19:53, schrieb Marek Olšák: On Wed, Aug 1, 2018 at 12:02 PM, Dieter Nützel wrote: Am 01.08.2018 17:53, schrieb Marek Olšák: On Wed, Aug 1

Re: [Mesa-dev] [PATCH v3 1/8] nir: evaluate if condition uses inside the if branches

2018-08-02 Thread Dieter Nützel
Am 02.08.2018 05:14, schrieb Marek Olšák: On Wed, Aug 1, 2018 at 5:02 PM, Dieter Nützel wrote: Am 01.08.2018 19:53, schrieb Marek Olšák: On Wed, Aug 1, 2018 at 12:02 PM, Dieter Nützel wrote: Am 01.08.2018 17:53, schrieb Marek Olšák: On Wed, Aug 1, 2018 at 2:39 AM, Dieter Nützel wrote

Re: [Mesa-dev] [PATCH 04/13] nir: Collapse more repeated bcsels on the same argument

2018-08-02 Thread Timothy Arceri
I thought you were trying to move these type of opts to your new pass? Or should I be splitting out and resending some of the bcsel opts in my dirt showdown patch [1]? And trying again to get the other patches from the series reviewed. [1] https://lists.freedesktop.org/archives/mesa-dev/2018-

Re: [Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-02 Thread Jason Ekstrand
Hooray for less GLvoid. Acked-by: Jason Ekstrand On August 2, 2018 04:16:23 Marek Olšák wrote: From: Marek Olšák --- include/GL/glcorearb.h | 68 -- include/GL/glext.h | 77 +--- include/GL/glxext.h| 22 -- include/GLES2/gl2.h| 8 +-- includ

Re: [Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-02 Thread Jason Ekstrand
On August 2, 2018 16:45:55 Ian Romanick wrote: On 08/02/2018 04:40 PM, Ilia Mirkin wrote: On Thu, Aug 2, 2018 at 7:34 PM, Ian Romanick wrote: On 08/02/2018 02:26 PM, Sagar Ghuge wrote: I have few comments below, I might be wrong about those but except that this patch looks good to me. I c

Re: [Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-02 Thread Ian Romanick
On 08/02/2018 04:40 PM, Ilia Mirkin wrote: > On Thu, Aug 2, 2018 at 7:34 PM, Ian Romanick wrote: >> On 08/02/2018 02:26 PM, Sagar Ghuge wrote: >>> I have few comments below, I might be wrong about those but except that >>> this patch looks good to me. I checked it against Khronos headers. >>> >>>

Re: [Mesa-dev] [PATCH] gallium/u_vbuf: handle indirect multidraws correctly and efficiently (v3)

2018-08-02 Thread Eric Anholt
Marek Olšák writes: > On Thu, Aug 2, 2018 at 1:54 PM, Eric Anholt wrote: >> Marek Olšák writes: >> >>> From: Marek Olšák >>> >>> v2: need to do MAX{start+count} instead of MAX{count} >>> added piglit tests >>> v3: use malloc >>> --- >>> src/gallium/auxiliary/util/u_vbuf.c | 204 ++

Re: [Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-02 Thread Ilia Mirkin
On Thu, Aug 2, 2018 at 7:34 PM, Ian Romanick wrote: > On 08/02/2018 02:26 PM, Sagar Ghuge wrote: >> I have few comments below, I might be wrong about those but except that >> this patch looks good to me. I checked it against Khronos headers. >> >> On 08/01/2018 11:34 AM, Marek Olšák wrote: >>> +

Re: [Mesa-dev] [PATCH 07/13] nir: Transform expressions of b2f(a) and b2f(b) to a || b

2018-08-02 Thread Ian Romanick
On 08/02/2018 02:10 PM, Thomas Helland wrote: > 2018-08-02 20:19 GMT+02:00 Ian Romanick : >> From: Ian Romanick >> >> All Gen6+ platforms had pretty similar results. (Skylake shown) >> total instructions in shared programs: 14277184 -> 14276964 (<.01%) >> instructions in affected programs: 10082 -

Re: [Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-02 Thread Ian Romanick
On 08/02/2018 02:26 PM, Sagar Ghuge wrote: > I have few comments below, I might be wrong about those but except that > this patch looks good to me. I checked it against Khronos headers. > > On 08/01/2018 11:34 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >>   include/GL/glcorearb.h |  68

Re: [Mesa-dev] [PATCH 04/13] nir: Collapse more repeated bcsels on the same argument

2018-08-02 Thread Jason Ekstrand
Crazy... R-b On August 2, 2018 11:19:44 "Ian Romanick" wrote: From: Ian Romanick All Gen platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14277230 -> 14277220 (<.01%) instructions in affected programs: 751 -> 741 (-1.33%) helped: 4 HURT: 0 helped s

Re: [Mesa-dev] [PATCH 02/13] nir: Remove f2i(i2f(x)) conversions

2018-08-02 Thread Jason Ekstrand
This one bothers me a bit. People don't usually expect integer calculations so be modified at all so to replace an expression that takes in an internet and sometimes returns a different one with a no-op seems rather unexpected. Then again, GLSL doesn't actually specify precision or range of anyt

Re: [Mesa-dev] [PATCH 2/3 v3] Android.common.mk: define HAVE_TIMESPEC_GET

2018-08-02 Thread Rob Herring
On Thu, Aug 2, 2018 at 9:55 AM Emil Velikov wrote: > > On 2 August 2018 at 00:20, John Stultz wrote: > > From: Sumit Semwal > > > > This is a forward port of a patch from the AOSP/master tree: > > https://android.googlesource.com/platform/external/mesa3d/+/bd30b663f55f8af73a0be4446349c5a2d4c641b

Re: [Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-02 Thread Sagar Ghuge
I have few comments below, I might be wrong about those but except that this patch looks good to me. I checked it against Khronos headers. On 08/01/2018 11:34 AM, Marek Olšák wrote: From: Marek Olšák --- include/GL/glcorearb.h | 68 -- include/GL/glext.h | 77

Re: [Mesa-dev] [RFC][PATCH 2/5] glapi: define AMD_depth_clamp_separate

2018-08-02 Thread Sagar Ghuge
Okay, I will take care of that. Thanks for reviewing my patches Ian. On 08/02/2018 11:33 AM, Ian Romanick wrote: > This patch should go first in the series. With that changed, this patch is > > Reviewed-by: Ian Romanick > > On 08/01/2018 08:31 PM, Sagar Ghuge wrote: >> Signed-off-by: Sagar Gh

Re: [Mesa-dev] vulkan.radv build trouble w/ AOSP

2018-08-02 Thread Rob Herring
On Thu, Aug 2, 2018 at 12:47 AM Mauro Rossi wrote: > > Hi, > > Il giorno gio 2 ago 2018 alle ore 02:06 John Stultz > ha scritto: >> >> Just as a heads up, with mesa3d master (plus my other build fixups I >> just sent out), I'm seeing a new build failure when building under >> AOSP/master: >> >>

Re: [Mesa-dev] [PATCH 06/13] nir: Transform -fabs(a) < 0 to a != 0

2018-08-02 Thread Thomas Helland
2018-08-02 23:05 GMT+02:00 Thomas Helland : > 2018-08-02 20:19 GMT+02:00 Ian Romanick : >> From: Ian Romanick >> >> Unlike the much older -abs(a) >= 0.0 transformation, this is not >> precise. The behavior changes if a is NaN. >> >> All Gen platforms had pretty similar results. (Skylake shown) >>

Re: [Mesa-dev] [PATCH 13/13] nir: Transform expressions of b2f(a) and b2f(b) to a == b

2018-08-02 Thread Thomas Helland
Patches 12 and 13 are: Reviewed-by: Thomas Helland 2018-08-02 20:19 GMT+02:00 Ian Romanick : > From: Ian Romanick > > All Gen7+ platforms had similar results. (Skylake shown) > total instructions in shared programs: 14276886 -> 14276838 (<.01%) > instructions in affected programs: 312 -> 264 (-1

Re: [Mesa-dev] [PATCH 08/13] nir: Transform -fabs(a) >= 0 to a == 0

2018-08-02 Thread Thomas Helland
This patch is: Reviewed-by: Thomas Helland 2018-08-02 20:19 GMT+02:00 Ian Romanick : > From: Ian Romanick > > All Gen platforms had pretty similar results. (Skylake shown) > total instructions in shared programs: 14276964 -> 14276961 (<.01%) > instructions in affected programs: 411 -> 408 (-0.73

Re: [Mesa-dev] [PATCH 07/13] nir: Transform expressions of b2f(a) and b2f(b) to a || b

2018-08-02 Thread Thomas Helland
2018-08-02 20:19 GMT+02:00 Ian Romanick : > From: Ian Romanick > > All Gen6+ platforms had pretty similar results. (Skylake shown) > total instructions in shared programs: 14277184 -> 14276964 (<.01%) > instructions in affected programs: 10082 -> 9862 (-2.18%) > helped: 37 > HURT: 1 > helped stats

Re: [Mesa-dev] [PATCH 06/13] nir: Transform -fabs(a) < 0 to a != 0

2018-08-02 Thread Thomas Helland
2018-08-02 20:19 GMT+02:00 Ian Romanick : > From: Ian Romanick > > Unlike the much older -abs(a) >= 0.0 transformation, this is not > precise. The behavior changes if a is NaN. > > All Gen platforms had pretty similar results. (Skylake shown) > total instructions in shared programs: 14277216 -> 1

Re: [Mesa-dev] [PATCH] meson: use correct keyword to fix a meson warning

2018-08-02 Thread Erik Faye-Lund
On 02. aug. 2018 15:58, Jon Turney wrote: With a sufficently recent meson, the following warning is produced: WARNING: Passed invalid keyword argument "extra_args". WARNING: This will become a hard error in the future. It seems that compiler.links(args:) is meant here. Signed-off-by: Jon Turne

[Mesa-dev] [Bug 107460] radv: OpControlBarrier does not always work correctly (bisected)

2018-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107460 Bug ID: 107460 Summary: radv: OpControlBarrier does not always work correctly (bisected) Product: Mesa Version: git Hardware: Other OS: All Sta

[Mesa-dev] [PATCH 09/10] radeonsi: add vcn jpeg decoder

2018-08-02 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeonsi/si_uvd.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_uvd.c b/src/gallium/drivers/radeonsi/si_uvd.c index b6cb4cb..f0abc36 100644 --- a/src/gallium/driv

[Mesa-dev] [PATCH 07/10] amd/common: add vcn jpeg ip info query

2018-08-02 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/amd/common/ac_gpu_info.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index 73fc362..a1db3b9 100644 --- a/src/amd/common/ac_gpu_info.c +++ b/

[Mesa-dev] [PATCH 06/10] radeon/vcn: implement jpeg target buffer cmd

2018-08-02 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_jpeg.c | 73 +++- 1 file changed, 72 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_jpeg.c b/src/gallium/drivers/radeon/radeon_vcn_jpeg.c index f71

[Mesa-dev] [PATCH 10/10] radeonsi: enable vcn jpeg decode for raven

2018-08-02 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeonsi/si_get.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index fc2be33..de587bb 100644 --- a/src/gallium/drivers/radeonsi/si_get.c

[Mesa-dev] [PATCH 02/10] radeon/winsys: add vcn jpeg ring type

2018-08-02 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_winsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeon/radeon_winsys.h b/src/gallium/drivers/radeon/radeon_winsys.h index 0a56539..6290eef 100644 --- a/src/gallium/drivers/rade

[Mesa-dev] [PATCH 08/10] winsys/amdgpu: add vcn jpeg cs support

2018-08-02 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c index a3feeb9..5092f49 100644 --- a/src/gallium/w

[Mesa-dev] [PATCH 03/10] radeon/vcn: add jpeg decoder creation

2018-08-02 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/Makefile.sources | 1 + src/gallium/drivers/radeon/meson.build | 1 + src/gallium/drivers/radeon/radeon_vcn_jpeg.c | 212 +++ 3 files changed, 214 insertions(+) create mode 100644 s

[Mesa-dev] [PATCH 04/10] radeon/vcn: implement jpeg decode functions

2018-08-02 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_jpeg.c | 286 ++- 1 file changed, 281 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_jpeg.c b/src/gallium/drivers/radeon/radeon_vcn_jpeg.c index c

[Mesa-dev] [PATCH 01/10] radeon/vcn: add vcn jpeg decode interface

2018-08-02 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/Makefile.sources | 1 + src/gallium/drivers/radeon/meson.build | 1 + src/gallium/drivers/radeon/radeon_vcn_jpeg.h | 116 +++ 3 files changed, 118 insertions(+) create mode 100644 s

[Mesa-dev] [PATCH 05/10] radeon/vcn: implement jpeg bitstream buffer cmd

2018-08-02 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_jpeg.c | 41 ++-- 1 file changed, 39 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_jpeg.c b/src/gallium/drivers/radeon/radeon_vcn_jpeg.c index 72

[Mesa-dev] [PATCH] android: radv: build vulkan.radv conditionally to radeonsi

2018-08-02 Thread Mauro Rossi
A problem was reported with arm,arm64 targets build due to missing libLLVM shared library dependency with AOSP; to avoid this issue vulkan.radv is built conditionally only when radeonsi is in BOARD_GPU_DRIVERS Fixes: 0ca153f869 ("android: radv: enable build of vulkan.radv HAL module") Reported-by

Re: [Mesa-dev] [PATCH 2/2] intel/compiler: Add brw_get_compiler_config_value for disk cache

2018-08-02 Thread Jordan Justen
On 2018-08-02 11:27:57, Dylan Baker wrote: > Quoting Jordan Justen (2018-07-25 17:12:20) > > During code review, Jason pointed out that: > > > > 2b3064c0731 "i965, anv: Use INTEL_DEBUG for disk_cache driver flags" > > > > Didn't account for INTEL_SCALER_* environment variables. > > > > To fix th

Re: [Mesa-dev] [RFC][PATCH 0/5] mesa: Add types for AMD_depth_clamp_separate.

2018-08-02 Thread Ian Romanick
On 08/02/2018 11:30 AM, Ian Romanick wrote: > On 08/01/2018 08:31 PM, Sagar Ghuge wrote: >> Add some basic types and storage for the >> AMD_depth_clamp_separate extension. I mentioned this on patch 5, but you should word wrap the commit message to 70 or 72 columns. More substantive comments are b

Re: [Mesa-dev] [PATCH] gallium/u_vbuf: handle indirect multidraws correctly and efficiently (v3)

2018-08-02 Thread Marek Olšák
On Thu, Aug 2, 2018 at 1:54 PM, Eric Anholt wrote: > Marek Olšák writes: > >> From: Marek Olšák >> >> v2: need to do MAX{start+count} instead of MAX{count} >> added piglit tests >> v3: use malloc >> --- >> src/gallium/auxiliary/util/u_vbuf.c | 204 >> 1 file cha

Re: [Mesa-dev] [RFC][PATCH 5/5] i965: add functional changes for AMD_depth_clamp_separate

2018-08-02 Thread Ian Romanick
On 08/01/2018 08:31 PM, Sagar Ghuge wrote: > Gen >= 9 have ability to control clamping of depth values > separately at near and far plane. > > z_w is clamped to the range [min(n,f), 0] if clamping > at near plane is enabled, [0, max(n,f)] if clamping at > far plane is enabled and [min(n,f) max(n,f

Re: [Mesa-dev] [RFC][PATCH 4/5] mesa: implement glGet for AMD_depth_clamp_separate

2018-08-02 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 08/01/2018 08:31 PM, Sagar Ghuge wrote: > Signed-off-by: Sagar Ghuge > --- > src/mesa/main/get.c | 1 + > src/mesa/main/get_hash_params.py | 5 + > 2 files changed, 6 insertions(+) > > diff --git a/src/mesa/main/get.c b/src/mesa/main

Re: [Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-02 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 08/01/2018 08:31 PM, Sagar Ghuge wrote: > enable _mesa_PushAttrib() and _mesa_PopAttrib() > to handle GL_DEPTH_CLAMP_NEAR_AMD and > GL_DEPTH_CLAMP_FAR_AMD tokens. > > Signed-off-by: Sagar Ghuge > --- > src/mesa/main/attrib.c | 16 >

Re: [Mesa-dev] [RFC][PATCH 2/5] glapi: define AMD_depth_clamp_separate

2018-08-02 Thread Ian Romanick
This patch should go first in the series. With that changed, this patch is Reviewed-by: Ian Romanick On 08/01/2018 08:31 PM, Sagar Ghuge wrote: > Signed-off-by: Sagar Ghuge > --- > src/mapi/glapi/gen/AMD_depth_clamp_separate.xml | 15 +++ > src/mapi/glapi/gen/Makefile.am

Re: [Mesa-dev] [RFC][PATCH 0/5] mesa: Add types for AMD_depth_clamp_separate.

2018-08-02 Thread Ian Romanick
On 08/01/2018 08:31 PM, Sagar Ghuge wrote: > Add some basic types and storage for the > AMD_depth_clamp_separate extension. > > Signed-off-by: Sagar Ghuge > --- > include/GL/glcorearb.h | 2 ++ > src/mesa/main/extensions_table.h | 1 + > src/mesa/main/mtypes.h | 9 + >

Re: [Mesa-dev] [PATCH 2/2] intel/compiler: Add brw_get_compiler_config_value for disk cache

2018-08-02 Thread Dylan Baker
Quoting Jordan Justen (2018-07-25 17:12:20) > During code review, Jason pointed out that: > > 2b3064c0731 "i965, anv: Use INTEL_DEBUG for disk_cache driver flags" > > Didn't account for INTEL_SCALER_* environment variables. > > To fix this, let the compiler return the disk_cache driver flags. >

[Mesa-dev] [PATCH 12/13] nir: Transform expressions of b2f(a) and b2f(b) to a ^^ b

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14276892 -> 14276886 (<.01%) instructions in affected programs: 484 -> 478 (-1.24%) helped: 2 HURT: 0 total cycles in shared programs: 532578397 -> 532578395 (<.01%) cycles in

[Mesa-dev] [PATCH 09/13] nir: Transform expressions of b2f(a) and b2f(b) to !(a || b)

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen6+ platforms had similar results. (Skylake shown) total instructions in shared programs: 14276961 -> 14276892 (<.01%) instructions in affected programs: 3215 -> 3146 (-2.15%) helped: 28 HURT: 0 helped stats (abs) min: 1 max: 6 x̄: 2.46 x̃: 2 helped stats (rel) min: 0.47%

[Mesa-dev] [PATCH 10/13] nir: Transform expressions of b2f(a) and b2f(b) to a && b

2018-08-02 Thread Ian Romanick
From: Ian Romanick No changes on any Gen platform. Signed-off-by: Ian Romanick --- src/compiler/nir/nir_opt_algebraic.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index 64400f92ddc..629cae5f381 100644 -

[Mesa-dev] [PATCH 06/13] nir: Transform -fabs(a) < 0 to a != 0

2018-08-02 Thread Ian Romanick
From: Ian Romanick Unlike the much older -abs(a) >= 0.0 transformation, this is not precise. The behavior changes if a is NaN. All Gen platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14277216 -> 14277184 (<.01%) instructions in affected programs: 230

[Mesa-dev] [PATCH 13/13] nir: Transform expressions of b2f(a) and b2f(b) to a == b

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen7+ platforms had similar results. (Skylake shown) total instructions in shared programs: 14276886 -> 14276838 (<.01%) instructions in affected programs: 312 -> 264 (-15.38%) helped: 2 HURT: 0 total cycles in shared programs: 532578395 -> 532570985 (<.01%) cycles in affe

[Mesa-dev] [PATCH 11/13] nir: Transform expressions of b2f(a) and b2f(b) to !(a && b)

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen platforms had pretty similar results. (Skylake shown) total cycles in shared programs: 532578400 -> 532578397 (<.01%) cycles in affected programs: 2784 -> 2781 (-0.11%) helped: 1 HURT: 1 helped stats (abs) min: 4 max: 4 x̄: 4.00 x̃: 4 helped stats (rel) min: 0.26% max:

[Mesa-dev] [PATCH 08/13] nir: Transform -fabs(a) >= 0 to a == 0

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14276964 -> 14276961 (<.01%) instructions in affected programs: 411 -> 408 (-0.73%) helped: 3 HURT: 0 helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 helped stats (rel) min: 0.4

[Mesa-dev] [PATCH 04/13] nir: Collapse more repeated bcsels on the same argument

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14277230 -> 14277220 (<.01%) instructions in affected programs: 751 -> 741 (-1.33%) helped: 4 HURT: 0 helped stats (abs) min: 2 max: 3 x̄: 2.50 x̃: 2 helped stats (rel) min: 1.2

[Mesa-dev] [PATCH 07/13] nir: Transform expressions of b2f(a) and b2f(b) to a || b

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen6+ platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14277184 -> 14276964 (<.01%) instructions in affected programs: 10082 -> 9862 (-2.18%) helped: 37 HURT: 1 helped stats (abs) min: 1 max: 30 x̄: 5.97 x̃: 4 helped stats (rel) m

[Mesa-dev] [PATCH 01/13] nir: Mark the 0.0 < abs(a) transformation as imprecise

2018-08-02 Thread Ian Romanick
From: Ian Romanick Unlike the much older -abs(a) >= 0.0 transformation, this is not precise. The behavior changes if the source is NaN. No shader-db changes on any platform. Signed-off-by: Ian Romanick --- src/compiler/nir/nir_opt_algebraic.py | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[Mesa-dev] [PATCH 05/13] nir: Rearrange bcsel with two bcsel sources

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14277220 -> 14277216 (<.01%) instructions in affected programs: 422 -> 418 (-0.95%) helped: 2 HURT: 0 total cycles in shared programs: 532577908 -> 532577848 (<.01%) cycles in

[Mesa-dev] [PATCH 03/13] nir: Don't compare i2f or u2i with zero

2018-08-02 Thread Ian Romanick
From: Ian Romanick Broadwell and Skylake had similar results. (Skylake shown) total instructions in shared programs: 14277620 -> 14277230 (<.01%) instructions in affected programs: 36905 -> 36515 (-1.06%) helped: 101 HURT: 6 helped stats (abs) min: 1 max: 6 x̄: 4.46 x̃: 6 helped stats (rel) min:

[Mesa-dev] [PATCH 02/13] nir: Remove f2i(i2f(x)) conversions

2018-08-02 Thread Ian Romanick
From: Ian Romanick Broadwell and Skylake had similar results. (Skylake shown) total instructions in shared programs: 14277978 -> 14277620 (<.01%) instructions in affected programs: 36957 -> 36599 (-0.97%) helped: 76 HURT: 1 helped stats (abs) min: 2 max: 90 x̄: 4.89 x̃: 4 helped stats (rel) min:

Re: [Mesa-dev] [PATCH] mesa: add switch case for GL 2.0 in _mesa_compute_version()

2018-08-02 Thread Ian Romanick
Reviewed-by: Ian Romanick On 08/02/2018 08:45 AM, Brian Paul wrote: > Previously, I added a switch case for GL 2.1 (ed7a0770b881791dd697f3). > I don't know of any driver which only supports GL 2.0, but adding > this switch case avoids a failure if the app queries > GL_SHADING_LANGUAGE_VERSION. >

Re: [Mesa-dev] [PATCH] gallium/u_vbuf: handle indirect multidraws correctly and efficiently (v3)

2018-08-02 Thread Eric Anholt
Marek Olšák writes: > From: Marek Olšák > > v2: need to do MAX{start+count} instead of MAX{count} > added piglit tests > v3: use malloc > --- > src/gallium/auxiliary/util/u_vbuf.c | 204 > 1 file changed, 180 insertions(+), 24 deletions(-) > > diff --git a/src/g

Re: [Mesa-dev] [PATCH] mesa: add switch case for GL 2.0 in _mesa_compute_version()

2018-08-02 Thread Eric Anholt
Brian Paul writes: > Previously, I added a switch case for GL 2.1 (ed7a0770b881791dd697f3). > I don't know of any driver which only supports GL 2.0, but adding > this switch case avoids a failure if the app queries > GL_SHADING_LANGUAGE_VERSION. Reviewed-by: Eric Anholt signature.asc Descript

Re: [Mesa-dev] vulkan.radv build trouble w/ AOSP

2018-08-02 Thread John Stultz
On Thu, Aug 2, 2018 at 10:25 AM, Mauro Rossi wrote: > Hi, > > > Il giorno gio 2 ago 2018 alle ore 17:51 Emil Velikov > ha scritto: >> >> On 2 August 2018 at 07:47, Mauro Rossi wrote: >> > Hi, >> > >> > Il giorno gio 2 ago 2018 alle ore 02:06 John Stultz >> > >> > ha scritto: >> >> >> >> Just as

Re: [Mesa-dev] meas master branch build failure related with vulkan

2018-08-02 Thread Bai, Guang
Please ignore this mail - I posted before joining the "mesa-dev" mailing list. There is already a new email loop to address my questions. Thanks, Guang -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Guang Bai Sent: Wednesday, August 01, 2018

[Mesa-dev] [PATCH] anv/pipeline: Disable FS dispatch for pointless fragment shaders

2018-08-02 Thread Jason Ekstrand
--- src/intel/vulkan/anv_pipeline.c | 37 + 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c index 85f38da60ff..86e0211a29d 100644 --- a/src/intel/vulkan/anv_pipeline.c +++ b/src/intel/v

Re: [Mesa-dev] [PATCH] intel/tools: add error2aub creation into autotools

2018-08-02 Thread Dylan Baker
Quoting Lionel Landwerlin (2018-08-02 09:46:59) > On 02/08/18 17:39, Andres Gomez wrote: > > Tarball distribution is done through "make distcheck". We include the > > meson targets also into autotools so they won't fail when building > > from the tarball. > > > > Fixes: 6a60beba408 ("intel/tools: A

[Mesa-dev] meas master branch build failure related with vulkan

2018-08-02 Thread Guang Bai
All, Is there any fix expected for mesa/master branch build failures related with vulkan? And the "xcb-randr" 1.13+ has to be installed to build the mesa/master branch? Where can I download the xcb-randr 1.13 - I can only find the 1.12 package now. Regards, Guang _

Re: [Mesa-dev] [PATCH] intel/tools: add error2aub creation into autotools

2018-08-02 Thread Dylan Baker
This seems like a fine thing to do, I don't know how many people actually build tools from the tarball, but making them work seems useful. Reviewed-by: Dylan Baker Quoting Andres Gomez (2018-08-02 09:39:06) > Tarball distribution is done through "make distcheck". We include the > meson targets a

Re: [Mesa-dev] vulkan.radv build trouble w/ AOSP

2018-08-02 Thread Mauro Rossi
Hi, Il giorno gio 2 ago 2018 alle ore 17:51 Emil Velikov < emil.l.veli...@gmail.com> ha scritto: > On 2 August 2018 at 07:47, Mauro Rossi wrote: > > Hi, > > > > Il giorno gio 2 ago 2018 alle ore 02:06 John Stultz < > john.stu...@linaro.org> > > ha scritto: > >> > >> Just as a heads up, with mes

Re: [Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc1

2018-08-02 Thread Andres Gomez
Forgot to mention that, in the path to 18.2.0, there is now a tracker bug for the regressions found since 18.1: https://bugs.freedesktop.org/show_bug.cgi?id=107457 On Thu, 2018-08-02 at 19:05 +0300, Andres Gomez wrote: > The subject was obviously wrong 😕 > > On Thu, 2018-08-02 at 18:52 +0300, An

[Mesa-dev] [Bug 106156] [TRACKER] Mesa 18.2 feature tracker

2018-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106156 Andrés Gómez García changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Mike Lothian
That's packaged for bionic, might be worth creating your own PPA and base the pkgbuild on that - apologies if I'm getting the lingo wrong - I don't use Ubuntu myself Alternatively maybe check for other PPAs that might have them already packaged for you, I think Padoka and Oibaf might have what you

[Mesa-dev] [Bug 107457] [Tracker] Mesa 18.2 release tracker

2018-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107457 Bug ID: 107457 Summary: [Tracker] Mesa 18.2 release tracker Product: Mesa Version: 18.2 Hardware: Other OS: All Status: NEW Severity: normal Pr

Re: [Mesa-dev] [PATCH v2 6/6] mesa: replace binary constants with hexadecimal constants

2018-08-02 Thread Andres Gomez
On Thu, 2018-08-02 at 12:55 -0400, Marek Olšák wrote: > > > On Thu, Aug 2, 2018, 2:42 AM Andres Gomez wrote: > > On Wed, 2018-08-01 at 19:54 -0400, Marek Olšák wrote: > > > For patches 5 & 6: > > > > > > Reviewed-by: Marek Olšák > > > > Thanks, Marek! > > > > > I can't see patches 3 & 4 on t

Re: [Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Guang Bai
On Thu, 2 Aug 2018 17:55:21 +0100 Mike Lothian wrote: > Which distro are you using? uBuntu-14.045 & uBuntu-16.04 Thanks, Guang > > On Thu, 2 Aug 2018 at 17:35 Guang Bai wrote: > > > This is the reason for me to look for helps from our mesa-dev > > community. Thanks, > > Guang > > > > On Thu,

Re: [Mesa-dev] [PATCH v2 6/6] mesa: replace binary constants with hexadecimal constants

2018-08-02 Thread Marek Olšák
On Thu, Aug 2, 2018, 2:42 AM Andres Gomez wrote: > On Wed, 2018-08-01 at 19:54 -0400, Marek Olšák wrote: > > For patches 5 & 6: > > > > Reviewed-by: Marek Olšák > > Thanks, Marek! > > > I can't see patches 3 & 4 on the list. > > The list has been having some troubles in the last hours. I will re

Re: [Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Mike Lothian
Which distro are you using? On Thu, 2 Aug 2018 at 17:35 Guang Bai wrote: > This is the reason for me to look for helps from our mesa-dev community. > Thanks, > Guang > > On Thu, 2 Aug 2018 17:10:16 +0100 > Mike Lothian wrote: > > > Yeah the lease stuff was added in the newer version of xcb-prot

[Mesa-dev] [Bug 107455] [TRACKER] Mesa 18.3 feature tracker

2018-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107455 Bug ID: 107455 Summary: [TRACKER] Mesa 18.3 feature tracker Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Pri

Re: [Mesa-dev] [PATCH] meson: use correct keyword to fix a meson warning

2018-08-02 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Jon Turney (2018-08-02 06:58:07) > With a sufficently recent meson, the following warning is produced: > > WARNING: Passed invalid keyword argument "extra_args". > WARNING: This will become a hard error in the future. > > It seems that compiler.links(args:) is m

Re: [Mesa-dev] [PATCH] intel/tools: add error2aub creation into autotools

2018-08-02 Thread Lionel Landwerlin
On 02/08/18 17:39, Andres Gomez wrote: Tarball distribution is done through "make distcheck". We include the meson targets also into autotools so they won't fail when building from the tarball. Fixes: 6a60beba408 ("intel/tools: Add an error state to aub translator") Cc: Jason Ekstrand Cc: Lione

[Mesa-dev] [PATCH] intel/tools: add error2aub creation into autotools

2018-08-02 Thread Andres Gomez
Tarball distribution is done through "make distcheck". We include the meson targets also into autotools so they won't fail when building from the tarball. Fixes: 6a60beba408 ("intel/tools: Add an error state to aub translator") Cc: Jason Ekstrand Cc: Lionel Landwerlin Cc: Dylan Baker Signed-off

Re: [Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc1

2018-08-02 Thread Andres Gomez
The subject was obviously wrong 😕 On Thu, 2018-08-02 at 18:52 +0300, Andres Gomez wrote: > The first release candidate for Mesa 18.2.0 is now available. > > The plan is to have one release candidate every Wednesday, until the > anticipated final release on 22nd August 2018. > > The expectation i

Re: [Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Mike Lothian
Hi It would be helpful if you posted the failure output, without it its difficult to diagnose I'm not seeing any issues with the master branch on the meson build Is this your first time building mesa, or has something suddenly stopped working? Cheers Mike On Thu, 2 Aug 2018 at 16:46 Guang Bai

Re: [Mesa-dev] [PATCH 2/3 v3] Android.common.mk: define HAVE_TIMESPEC_GET

2018-08-02 Thread Emil Velikov
On 2 August 2018 at 00:20, John Stultz wrote: > From: Sumit Semwal > > This is a forward port of a patch from the AOSP/master tree: > https://android.googlesource.com/platform/external/mesa3d/+/bd30b663f55f8af73a0be4446349c5a2d4c641b0%5E%21/ > > Since https://android-review.googlesource.com/c/718

[Mesa-dev] [ANNOUNCE] mesa 18.0-0-rc1

2018-08-02 Thread Andres Gomez
The first release candidate for Mesa 18.2.0 is now available. The plan is to have one release candidate every Wednesday, until the anticipated final release on 22nd August 2018. The expectation is that the 18.1 branch will remain alive with bi- weekly releases until the 18.2.1 release. NOTE: Bui

Re: [Mesa-dev] vulkan.radv build trouble w/ AOSP

2018-08-02 Thread Emil Velikov
On 2 August 2018 at 07:47, Mauro Rossi wrote: > Hi, > > Il giorno gio 2 ago 2018 alle ore 02:06 John Stultz > ha scritto: >> >> Just as a heads up, with mesa3d master (plus my other build fixups I >> just sent out), I'm seeing a new build failure when building under >> AOSP/master: >> >> external

Re: [Mesa-dev] [PATCH 1/2] loader: add loader_open_name(..)

2018-08-02 Thread Emil Velikov
On 1 August 2018 at 22:07, Christian Gmeiner wrote: > Add an improved drmOpenWithType(..) clone which fixes some serious > flaws. Some highlights: > - using busid works only with PCI devices > - open() w/o O_CLOEXEC > - when build w/o udev - it creates a node: mkdir, chown(root), chmod, mknod >

[Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Guang Bai
All, I'm seeing build failures on mesa 18.2 & master branches with "--with-vulkan-drivers=intel" And also notice some web-posting that libxcb-xrandr 1.13 would be needed to get the build successful. What's the correct solution for my build issue? (I'm still new to mesa) Thanks! Guang __

[Mesa-dev] [PATCH] mesa: add switch case for GL 2.0 in _mesa_compute_version()

2018-08-02 Thread Brian Paul
Previously, I added a switch case for GL 2.1 (ed7a0770b881791dd697f3). I don't know of any driver which only supports GL 2.0, but adding this switch case avoids a failure if the app queries GL_SHADING_LANGUAGE_VERSION. --- src/mesa/main/version.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 1/2] loader: add loader_open_name(..)

2018-08-02 Thread Christian Gmeiner
Hi Eric Thanks for you code review! Am Do., 2. Aug. 2018 um 13:09 Uhr schrieb Eric Engestrom : > > On Wednesday, 2018-08-01 23:07:02 +0200, Christian Gmeiner wrote: > > Add an improved drmOpenWithType(..) clone which fixes some serious > > flaws. Some highlights: > > - using busid works only wit

Re: [Mesa-dev] [PATCH 0/8] GL_AMD_framebuffer_multisample_advanced for RadeonSI

2018-08-02 Thread Brian Paul
On 08/01/2018 05:25 PM, Marek Olšák wrote: Hi, This implements GL_AMD_framebuffer_multisample_advanced, which is AMD EQAA. I have also sent out a piglit test that tests the new API. Please review. I did a quick read-through and it looks OK to me. Reviewed-by: Brian Paul ___

  1   2   >