Re: [Mesa-dev] [PATCH 0/3] Make use of VAO information in i965.

2018-06-01 Thread Mathias Fröhlich
Hi, I know, that one of the third patch is intrusive, but I was finally running out of ideas how to split the third patch into sensible smaller chunks. So can somebody take a look? Thanks! best Mathias > From: Mathias Fröhlich > > Hi all, > > This change finally makes use of the binding/attr

[Mesa-dev] [PATCH 1/3] vbo: Reestablish VAO limit checking on imm VAOs.

2018-06-01 Thread Mathias . Froehlich
From: Mathias Fröhlich Bail out with out of memory, when the required stride exceeds the maximum possible stride as stored in Const.MaxVertexAttribStride. Etnaviv can only handle less than the OpenGL standard mandated minimum of 2048. For this one, at least give some 'resource exhaustion error' t

[Mesa-dev] [PATCH 3/3] mesa: Update comments at Const.MaxVertexAttribStride.

2018-06-01 Thread Mathias . Froehlich
From: Mathias Fröhlich Mention how this is supposed to work where the constant is declared. Signed-off-by: Mathias Fröhlich --- src/mesa/main/mtypes.h | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 4

[Mesa-dev] [PATCH 2/3] vbo: Reestablish VAO limit checking on dlist VAOs.

2018-06-01 Thread Mathias . Froehlich
From: Mathias Fröhlich Bail out with out of memory, when the required stride exceeds the maximum possible stride as stored in Const.MaxVertexAttribStride. Etnaviv can only handle less than the OpenGL standard mandated minimum of 2048. For this one, at least give some 'resource exhaustion error' t

[Mesa-dev] [PATCH 0/3] More gently check for driver limits and lack thereof.

2018-06-01 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi, Turns out that the MaxVertexAttribStride constant value is not set by all drivers as I expected to be set. Expecially virgl may run on top of an OpenGL stack that is too old to allow the query of GL_MAX_VERTEX_ATTRIB_STRIDE. So, allow setting that MaxVertexAttribStride

[Mesa-dev] [PATCH] mesa: Make sure that imm draws are flushed before other draws execute.

2018-06-01 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi all, The below patch fixes a recently introduced failure of my VAO rework. I could finally reproduce the problem using the provided apitrace (thanks Kai for the hint with the lower left corner). The change is slightly different than what I put initially into the bugrepo

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-01 Thread Matt Turner
On Fri, Jun 1, 2018 at 3:21 PM, Plamena Manolova wrote: > This patch adds the implentation of ARB_compute_variable_group_size > for i965. We do this by storing the group size in a buffer surface, > similarly to the work group number. > > Signed-off-by: Plamena Manolova > --- > docs/features.txt

[Mesa-dev] [Bug 106779] Files missing from tarball - u_debug_stack_android.cpp

2018-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106779 Bug ID: 106779 Summary: Files missing from tarball - u_debug_stack_android.cpp Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity: nor

[Mesa-dev] [Bug 106778] Files missing from tarball - intel_sanitize_gpu.*

2018-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106778 Bug ID: 106778 Summary: Files missing from tarball - intel_sanitize_gpu.* Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH v2 006.1/129] FIXUP! Don't reach through casts in get_variable

2018-06-01 Thread Jason Ekstrand
If something uses get_variable, it's likely that it doesn't know what to do with casts. If there are any casts in the chain, just return NULL. --- src/compiler/nir/nir.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index

Re: [Mesa-dev] [PATCH v4 000/129] nir: Move to using instructions for derefs

2018-06-01 Thread Rob Clark
On Fri, Jun 1, 2018 at 1:01 AM, Jason Ekstrand wrote: > This is something that Connor and I have been talking about for some time > now. The basic idea is to replace the current singly linked nir_deref list > with deref instructions. This is similar to what LLVM does and it offers > quite a bit

[Mesa-dev] [PATCH] radeonsi/gfx9: fix si_get_buffer_from_descriptors for 48-bit pointers

2018-06-01 Thread Marek Olšák
From: Marek Olšák This fixes: GL45-CTS.pipeline_statistics_query_tests_ARB.functional_compute_shader_invocations Cc: 18.0 18.1 --- src/gallium/drivers/radeonsi/si_descriptors.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c

[Mesa-dev] [Bug 106776] vma_random unrecognized command line option "-std=c++11"

2018-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106776 --- Comment #1 from Scott D Phillips --- Created attachment 139959 --> https://bugs.freedesktop.org/attachment.cgi?id=139959&action=edit 0001-util-tests-vma-test-depends-on-C-11-support.patch I think this should do it. It looks like in the me

[Mesa-dev] [Bug 61417] Clover doesn't export the OPENCL_1.0 Symbol

2018-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61417 Jan Vesely changed: What|Removed |Added Blocks||99553 Referenced Bugs: https://bugs.freed

[Mesa-dev] [PATCH 2/3] anv: Refactor reloc handling in execbuf_add_bo

2018-06-01 Thread Jason Ekstrand
This just separates the reloc list vs. BO set cases and lets us avoid an allocation if relocs->deps->entries == 0. --- src/intel/vulkan/anv_batch_chain.c | 78 -- 1 file changed, 42 insertions(+), 36 deletions(-) diff --git a/src/intel/vulkan/anv_batch_chain.c

[Mesa-dev] [PATCH 3/3] anv: Don't even bother processing relocs if we have softpin

2018-06-01 Thread Jason Ekstrand
--- src/intel/vulkan/anv_batch_chain.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_batch_chain.c b/src/intel/vulkan/anv_batch_chain.c index de629c1..c47a81c 100644 --- a/src/intel/vulkan/anv_batch_chain.c +++ b/src/intel/vulkan/anv_

[Mesa-dev] [PATCH 1/3] anv: Assert that the kernel leaves pinned BO addresses alone

2018-06-01 Thread Jason Ekstrand
--- src/intel/vulkan/anv_queue.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_queue.c b/src/intel/vulkan/anv_queue.c index 80dddeb..a0cbc34 100644 --- a/src/intel/vulkan/anv_queue.c +++ b/src/intel/vulkan/anv_queue.c @@ -49,8 +49,11 @@ anv_device_exe

[Mesa-dev] [Bug 106776] vma_random unrecognized command line option "-std=c++11"

2018-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106776 Bug ID: 106776 Summary: vma_random unrecognized command line option "-std=c++11" Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-01 Thread Jordan Justen
On 2018-06-01 15:21:34, Plamena Manolova wrote: > This patch adds the implentation of ARB_compute_variable_group_size > for i965. We do this by storing the group size in a buffer surface, > similarly to the work group number. > > Signed-off-by: Plamena Manolova > --- > docs/features.txt

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-01 Thread Ilia Mirkin
On Fri, Jun 1, 2018 at 6:21 PM, Plamena Manolova wrote: > This patch adds the implentation of ARB_compute_variable_group_size > for i965. We do this by storing the group size in a buffer surface, > similarly to the work group number. > > Signed-off-by: Plamena Manolova > --- > docs/features.txt

Re: [Mesa-dev] [PATCH 1/2] nir: Add global invocation id intrinsic.

2018-06-01 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2018-06-01 15:21:33, Plamena Manolova wrote: > Add the missing nir intrinsic for the gl_GlobalInvocationID > compute shader variable. > > Signed-off-by: Plamena Manolova > --- > src/compiler/nir/nir.c | 4 > src/compiler/nir/nir_intrinsics.py | 1

[Mesa-dev] [PATCH v2 006.1/129] FIXUP! Don't reach through casts in get_variable

2018-06-01 Thread Jason Ekstrand
If something uses get_variable, it's likely that it doesn't know what to do with casts. If there are any casts in the chain, just return NULL. --- src/compiler/nir/nir.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index

[Mesa-dev] [Bug 61417] Clover doesn't export the OPENCL_1.0 Symbol

2018-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61417 Dennis Schridde changed: What|Removed |Added CC||devuran...@gmx.net -- You are receivi

[Mesa-dev] [PATCH 2/2] i965: Implement ARB_compute_variable_group_size.

2018-06-01 Thread Plamena Manolova
This patch adds the implentation of ARB_compute_variable_group_size for i965. We do this by storing the group size in a buffer surface, similarly to the work group number. Signed-off-by: Plamena Manolova --- docs/features.txt| 2 +- docs/relnotes/18.2.0.html

[Mesa-dev] [PATCH 1/2] nir: Add global invocation id intrinsic.

2018-06-01 Thread Plamena Manolova
Add the missing nir intrinsic for the gl_GlobalInvocationID compute shader variable. Signed-off-by: Plamena Manolova --- src/compiler/nir/nir.c | 4 src/compiler/nir/nir_intrinsics.py | 1 + 2 files changed, 5 insertions(+) diff --git a/src/compiler/nir/nir.c b/src/compiler/nir

[Mesa-dev] [PATCH 0/2] Implement ARB_compute_variable_group_size for i965

2018-06-01 Thread Plamena Manolova
These patches add support for ARB_compute_variable_group_size for i965. Plamena Manolova (2): nir: Add global invocation id intrinsic. i965: Implement ARB_compute_variable_group_size. docs/features.txt| 2 +- docs/relnotes/18.2.0.html|

Re: [Mesa-dev] [PATCH 2/2] nir: implement the GLSL equivalent of if simplication in nir_opt_if

2018-06-01 Thread Ian Romanick
With Tim's nits addressed, this patch is Reviewed-by: Ian Romanick On 05/30/2018 05:21 AM, Samuel Pitoiset wrote: > This pass turns: > >if (cond) { >} else { > do_work(); >} > > into: > >if (!cond) { > do_work(); >} else { >} > > Here's the vkpipeline-db s

Re: [Mesa-dev] [PATCH 0/2] Prevent regression with changes to nir_opt_if

2018-06-01 Thread Ian Romanick
On 06/01/2018 01:33 AM, Samuel Pitoiset wrote: > Thanks! I guess you are now okay with my nir_opt_if changes? Yeah, it should be fine. > I have one minor regression with one shader of RoTR but that shouldn't > matter. > > Series is: > > Reviewed-by: Samuel Pitoiset > > On 06/01/2018 02:21 AM,

Re: [Mesa-dev] [PATCH 006.1/129] FIXUP! Don't reach through casts in get_variable

2018-06-01 Thread Jason Ekstrand
On Fri, Jun 1, 2018 at 1:34 PM, Rob Clark wrote: > On Fri, Jun 1, 2018 at 3:39 PM, Jason Ekstrand > wrote: > > If something uses get_variable, it's likely that it doesn't know what to > > do with casts. If there are any casts in the chain, just return NULL. > > --- > > src/compiler/nir/nir.h |

Re: [Mesa-dev] [PATCH 3/3] scons: Fix MinGW cross compilation with LLVM 5.0.

2018-06-01 Thread Roland Scheidegger
Looks good to me. Reviewed-by: Roland Scheidegger Am 01.06.2018 um 20:58 schrieb Jose Fonseca: > LLVM 5.0 requires additional Win32 libraries, and MinGW with pthreads. > --- > scons/llvm.py | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/scons/llvm.py b/scons/ll

Re: [Mesa-dev] [PATCH 2/3] trace: Fix parsing of recent traces.

2018-06-01 Thread Roland Scheidegger
That code is really not my area of expertise... But I suppose makes sense (although I'm still really confused by the buffer_subdata issues)... Reviewed-by: Roland Scheidegger Am 01.06.2018 um 20:58 schrieb Jose Fonseca: > --- > src/gallium/tools/trace/dump_state.py | 31 ++---

Re: [Mesa-dev] [PATCH 1/3] trace: Fix trace_context_transfer_unmap methods.

2018-06-01 Thread Roland Scheidegger
I am a bit confused by this, so by the looks of it you only dump things (unchanged) for textures, so did it match there? Also, I don't really understand why it doesn't work for buffers neither, even if some parameters don't make sense there, but if it's a transfer this should still be correct? Rol

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

2018-06-01 Thread Dylan Baker
Quoting Samuel Pitoiset (2018-06-01 08:58:42) > > > On 06/01/2018 05:48 PM, Dylan Baker wrote: > > Quoting Alex Smith (2018-06-01 07:56:38) > >> On 1 June 2018 at 15:48, Dylan Baker wrote: > >> > >> Quoting Alex Smith (2018-05-31 08:44:18) > >> > With GFX9 merged shaders, active_stages

[Mesa-dev] [PATCH] anv/icl: Don't set float blend optimization bit in CACHE_MODE_SS

2018-06-01 Thread Anuj Phogat
CACHE_MODE_SS is not listed in gfxspecs table for user mode non-privileged registers. So, making any changes from Mesa will do nothing. Kernel is already setting this bit in CACHE_MODE_SS register which is saved/restored to/from the HW context image. Signed-off-by: Anuj Phogat Cc: Lionel Landwerl

[Mesa-dev] [PATCH] i965/icl: Don't set float blend optimization bit in CACHE_MODE_SS

2018-06-01 Thread Anuj Phogat
CACHE_MODE_SS is not listed in gfxspecs table for user mode non-privileged registers. So, making any changes from Mesa will do nothing. Kernel is already setting this bit in CACHE_MODE_SS register which is saved/restored to/from the HW context image. Signed-off-by: Anuj Phogat Cc: Lionel Landwerl

[Mesa-dev] [PATCH] meson: only build vl_winsys_dri.c when x11 platform is used

2018-06-01 Thread Lukas Rusak
This seems to have been missed in the move from autotools This fixes the following build issue: ../src/gallium/auxiliary/vl/vl_winsys_dri.c:34:10: fatal error: X11/Xlib-xcb.h: No such file or directory #include ^~~~ --- src/gallium/auxiliary/meson.build | 2 +- 1 file ch

Re: [Mesa-dev] [PATCH 006.1/129] FIXUP! Don't reach through casts in get_variable

2018-06-01 Thread Rob Clark
On Fri, Jun 1, 2018 at 3:39 PM, Jason Ekstrand wrote: > If something uses get_variable, it's likely that it doesn't know what to > do with casts. If there are any casts in the chain, just return NULL. > --- > src/compiler/nir/nir.h | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > >

[Mesa-dev] [Bug 106774] NIR "copy propagates" loads of SSBOs

2018-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106774 Bug ID: 106774 Summary: NIR "copy propagates" loads of SSBOs Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Pr

[Mesa-dev] [PATCH 054.1/129] FIXUP! spirv: Use the right storage class for image pointers

2018-06-01 Thread Jason Ekstrand
The special case in load_param_pointer is for images and samplers which are definitely in the UniformConstant storage class. --- src/compiler/spirv/vtn_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c index 6c411c

[Mesa-dev] [PATCH 006.1/129] FIXUP! Don't reach through casts in get_variable

2018-06-01 Thread Jason Ekstrand
If something uses get_variable, it's likely that it doesn't know what to do with casts. If there are any casts in the chain, just return NULL. --- src/compiler/nir/nir.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index

[Mesa-dev] [PATCH 002.1/129] FIXUP! Check the deref type first in is_trivial_deref_cast

2018-06-01 Thread Jason Ekstrand
--- src/compiler/nir/nir_opt_copy_propagate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compiler/nir/nir_opt_copy_propagate.c b/src/compiler/nir/nir_opt_copy_propagate.c index c35e8e1..c8821c3 100644 --- a/src/compiler/nir/nir_opt_copy_propagate.c +++ b/src/com

[Mesa-dev] [PATCH v4.1 18/23] anv/allocator: Support softpin in the BO cache

2018-06-01 Thread Jason Ekstrand
--- src/intel/vulkan/anv_allocator.c | 51 +++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_allocator.c b/src/intel/vulkan/anv_allocator.c index 697da5f..117851f 100644 --- a/src/intel/vulkan/anv_allocator.c +++ b/src/intel

[Mesa-dev] [PATCH 3/3] scons: Fix MinGW cross compilation with LLVM 5.0.

2018-06-01 Thread Jose Fonseca
LLVM 5.0 requires additional Win32 libraries, and MinGW with pthreads. --- scons/llvm.py | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scons/llvm.py b/scons/llvm.py index 79118be371d..a34edfb4b67 100644 --- a/scons/llvm.py +++ b/scons/llvm.py @@ -123,6 +123,10 @@ def

[Mesa-dev] [PATCH 1/3] trace: Fix trace_context_transfer_unmap methods.

2018-06-01 Thread Jose Fonseca
The emitted buffer_subdata/texture_subdata call didn't match the respective signatures. --- .../auxiliary/driver_trace/tr_context.c | 38 +-- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/gallium/auxiliary/driver_trace/tr_context.c b/src/gallium/auxilia

[Mesa-dev] [PATCH 2/3] trace: Fix parsing of recent traces.

2018-06-01 Thread Jose Fonseca
--- src/gallium/tools/trace/dump_state.py | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/src/gallium/tools/trace/dump_state.py b/src/gallium/tools/trace/dump_state.py index 4531843279e..2622d130bf8 100755 --- a/src/gallium/tools/trace/dump_state.p

Re: [Mesa-dev] [PATCH mesa 3/5] bin: rewrite get_reviewers as opt-in only

2018-06-01 Thread Dylan Baker
Quoting Eric Engestrom (2018-06-01 09:50:34) > On Thursday, 2018-05-31 10:04:25 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-05-31 07:04:33) > > > Some people have mentioned they don't like the current get_reviewers.pl > > > script (the one from the kernel) because it is way too greed

Re: [Mesa-dev] [PATCH 2/2] nir: add opt_if_loop_terminator()

2018-06-01 Thread Ian Romanick
On 05/31/2018 10:37 PM, Timothy Arceri wrote: > This pass detects potential loop terminators and moves intructions > from the non breaking branch after the if. > > This enables both the new opt_if_simplification() pass and loop > unrolling to potentially progress further. > > Unexpectedly this ch

Re: [Mesa-dev] [PATCH 1/2] nir: optimize min(min(a, b), c) to min3(a, b, c) under an option

2018-06-01 Thread Ian Romanick
On 06/01/2018 10:17 AM, Eric Anholt wrote: > Samuel Pitoiset writes: > >> On 06/01/2018 02:17 AM, Ian Romanick wrote: >>> On 05/30/2018 10:06 AM, Samuel Pitoiset wrote: Similar for max(). Signed-off-by: Samuel Pitoiset --- src/compiler/nir/nir.h| 3 +++

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-06-01 Thread Jason Ekstrand
On Fri, Jun 1, 2018 at 9:57 AM, Laura Ekstrand wrote: > Daniel, > > I literally just followed the example: > > https://docs.gitlab.com/ee/ci/yaml/#pages > > As I recall, there's a recursive loop if you don't use .public. > Ah, I see what's going on. The glob character "*" will list all director

Re: [Mesa-dev] [PATCH 1/2] nir: optimize min(min(a, b), c) to min3(a, b, c) under an option

2018-06-01 Thread Eric Anholt
Samuel Pitoiset writes: > On 06/01/2018 02:17 AM, Ian Romanick wrote: >> On 05/30/2018 10:06 AM, Samuel Pitoiset wrote: >>> Similar for max(). >>> >>> Signed-off-by: Samuel Pitoiset >>> --- >>> src/compiler/nir/nir.h| 3 +++ >>> src/compiler/nir/nir_opt_algebraic.py | 8 ++

[Mesa-dev] [PATCH] glx: Fix number of property values to read in glXImportContextEXT

2018-06-01 Thread Michel Dänzer
From: Michel Dänzer We were trying to read twice as many as the X server sent us, which upset XCB: [xcb] Too much data requested from _XRead [xcb] This is most likely caused by a broken X extension library [xcb] Aborting, sorry about that. glx-free-context: ../../src/xcb_io.c:732: _XRead: Assert

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

2018-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #6 from Giovanni ongaro --- I did build with BUILD_SHARED_LIBS=on and 64 bits is required Inviato da smartphone Samsung Galaxy. Messaggio originale Da: bugzilla-dae...@freedesktop.org Data: 01/06/18 15:37 (GMT+01

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-06-01 Thread Laura Ekstrand
Daniel, I literally just followed the example: https://docs.gitlab.com/ee/ci/yaml/#pages As I recall, there's a recursive loop if you don't use .public. On Fri, Jun 1, 2018, 4:17 AM Daniel Stone wrote: > Hi, > > On 1 June 2018 at 11:23, Eric Engestrom wrote: > > On Friday, 2018-06-01 11:16:2

Re: [Mesa-dev] [PATCH v4 006/129] nir: Add helpers for working with deref instructions

2018-06-01 Thread Jason Ekstrand
On Fri, Jun 1, 2018 at 6:03 AM, Bas Nieuwenhuizen wrote: > On Fri, Jun 1, 2018 at 7:01 AM, Jason Ekstrand > wrote: > > This commit adds a pass for lowering deref instructions to deref chains > > as well as some smaller helpers to ease the transition. > > > > Reviewed-by: Caio Marcelo de Oliveira

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

2018-06-01 Thread Samuel Pitoiset
On 06/01/2018 06:28 PM, Alex Smith wrote: On 1 June 2018 at 16:58, Samuel Pitoiset > wrote: On 06/01/2018 05:48 PM, Dylan Baker wrote: Quoting Alex Smith (2018-06-01 07:56:38) On 1 June 2018 at 15:48, Dylan Baker mailto:dy...@pnwbak

Re: [Mesa-dev] [PATCH 1/2] nir: optimize min(min(a, b), c) to min3(a, b, c) under an option

2018-06-01 Thread Matt Turner
On Fri, Jun 1, 2018 at 9:50 AM, Samuel Pitoiset wrote: > On 06/01/2018 06:47 PM, Matt Turner wrote: >> On Wed, May 30, 2018 at 10:06 AM, Samuel Pitoiset >> wrote: >>> >>> Similar for max(). >>> >>> Signed-off-by: Samuel Pitoiset >> >> >> What are the shader-db results? That should be in the comm

Re: [Mesa-dev] [PATCH mesa 3/5] bin: rewrite get_reviewers as opt-in only

2018-06-01 Thread Eric Engestrom
On Thursday, 2018-05-31 10:04:25 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-05-31 07:04:33) > > Some people have mentioned they don't like the current get_reviewers.pl > > script (the one from the kernel) because it is way too greedy in its > > search for reviewers. > > > > I tried t

Re: [Mesa-dev] [PATCH 1/2] nir: optimize min(min(a, b), c) to min3(a, b, c) under an option

2018-06-01 Thread Samuel Pitoiset
On 06/01/2018 06:47 PM, Matt Turner wrote: On Wed, May 30, 2018 at 10:06 AM, Samuel Pitoiset wrote: Similar for max(). Signed-off-by: Samuel Pitoiset What are the shader-db results? That should be in the commit message. In the second one?

Re: [Mesa-dev] [PATCH 1/2] nir: optimize min(min(a, b), c) to min3(a, b, c) under an option

2018-06-01 Thread Matt Turner
On Wed, May 30, 2018 at 10:06 AM, Samuel Pitoiset wrote: > Similar for max(). > > Signed-off-by: Samuel Pitoiset What are the shader-db results? That should be in the commit message. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://list

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

2018-06-01 Thread Alex Smith
On 1 June 2018 at 16:58, Samuel Pitoiset wrote: > > > On 06/01/2018 05:48 PM, Dylan Baker wrote: > >> Quoting Alex Smith (2018-06-01 07:56:38) >> >>> On 1 June 2018 at 15:48, Dylan Baker wrote: >>> >>> Quoting Alex Smith (2018-05-31 08:44:18) >>> > With GFX9 merged shaders, active_stag

Re: [Mesa-dev] [PATCH v4 120/129] ac/nir: Remove deref chain support.

2018-06-01 Thread Jason Ekstrand
On Fri, Jun 1, 2018 at 3:57 AM, Bas Nieuwenhuizen wrote: > On Fri, Jun 1, 2018 at 7:07 AM, Jason Ekstrand > wrote: > > From: Bas Nieuwenhuizen > > > > --- > > src/amd/common/ac_nir_to_llvm.c | 404 +- > -- > > 1 file changed, 50 insertions(+), 354 deletions(

Re: [Mesa-dev] [ANNOUNCE] mesa 18.1.1

2018-06-01 Thread Juan A. Suarez Romero
On Fri, 2018-06-01 at 08:33 -0700, Dylan Baker wrote: > Hi List, > > 18.1.1 is now available. > A couple of points about the announcement :) - It doesn't contain the author list (like in git short log) - You didn't send the required pre-announcement, that should happen 48h before the final rel

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

2018-06-01 Thread Samuel Pitoiset
On 06/01/2018 05:48 PM, Dylan Baker wrote: Quoting Alex Smith (2018-06-01 07:56:38) On 1 June 2018 at 15:48, Dylan Baker wrote: Quoting Alex Smith (2018-05-31 08:44:18) > With GFX9 merged shaders, active_stages would be set to the original > stages specified if shaders were no

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

2018-06-01 Thread Dylan Baker
Quoting Alex Smith (2018-06-01 07:56:38) > On 1 June 2018 at 15:48, Dylan Baker wrote: > > Quoting Alex Smith (2018-05-31 08:44:18) > > With GFX9 merged shaders, active_stages would be set to the original > > stages specified if shaders were not cached, but to the stages still > >

[Mesa-dev] [ANNOUNCE] mesa 18.1.1

2018-06-01 Thread Dylan Baker
Hi List, 18.1.1 is now available. In this release we have: Numerous fixes for radv, a few fixes for i965, tegra, amd/addrlib, dri3, virgl, tgsi, nv30, opencl, core mesa, core vulkan, st/mesa, etnaviv and spirv all got fixes. A few specifically: Radv fixed one extension and several features on

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-01 Thread Daniel Stone
Hi, On 1 June 2018 at 15:35, Brendan King wrote: > IMG has a similar patch to the one you describe, but without the changes to > the resize_callback, so just this bit: > > @@ -255,6 +257,12 @@ dri2_wl_create_window_surface(_EGLDriver *drv, > _EGLDisplay *disp, >goto cleanup_surf; > }

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-01 Thread Brendan King
On 01/06/18 12:09, Juan A. Suarez Romero wrote: On Fri, 2018-06-01 at 11:23 +0100, Daniel Stone wrote: Hi, On 1 June 2018 at 09:47, Juan A. Suarez Romero wrote: My question then: is mandatory to call eglSwapBuffers() to ensure wl_egl_window_get_attached_size() returns the right window size?

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-01 Thread Brendan King
On 01/06/18 12:09, Juan A. Suarez Romero wrote: On Fri, 2018-06-01 at 11:23 +0100, Daniel Stone wrote: Hi, On 1 June 2018 at 09:47, Juan A. Suarez Romero wrote: My question then: is mandatory to call eglSwapBuffers() to ensure wl_egl_window_get_attached_size() returns the right window size? B

Re: [Mesa-dev] [PATCH] compiler/spirv: reject invalid shader code properly

2018-06-01 Thread Jason Ekstrand
And pushed. On Fri, Jun 1, 2018 at 8:04 AM, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > > On Fri, Jun 1, 2018 at 5:27 AM, Martin Pelikán wrote: > >> After bebe3d626e5, b->fail_jump is prepared after vtn_create_builder >> which can longjmp(3) to it through its vtx_assert()s. This cor

[Mesa-dev] [PATCH v3 4/5] nvc0: add support for programmable sample locations

2018-06-01 Thread Rhys Perry
Signed-off-by: Rhys Perry --- .../drivers/nouveau/codegen/nv50_ir_driver.h | 2 + .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 7 + .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 102 -- .../nouveau/codegen/nv50_ir_lowering_nvc0.h| 2 + src/gallium/dr

[Mesa-dev] [PATCH v3 5/5] docs: document addition of GL_ARB_sample_locations for nvc0

2018-06-01 Thread Rhys Perry
Signed-off-by: Rhys Perry Reviewed-by: Brian Paul (v2) --- docs/features.txt | 2 +- docs/relnotes/18.2.0.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index e786bbecf4..2eac14fb32 100644 --- a/docs/features.txt +++ b/do

[Mesa-dev] [PATCH v3 3/5] st/mesa: add support for ARB_sample_locations

2018-06-01 Thread Rhys Perry
Signed-off-by: Rhys Perry Reviewed-by: Brian Paul (v2) Reviewed-by: Marek Olšák (v2) --- src/mesa/state_tracker/st_atom.h | 2 +- src/mesa/state_tracker/st_atom_list.h | 2 +- src/mesa/state_tracker/st_atom_msaa.c | 77 +- src/mesa/state_tracker/st_cb_f

[Mesa-dev] [PATCH v3 1/5] mesa: add support for ARB_sample_locations

2018-06-01 Thread Rhys Perry
Signed-off-by: Rhys Perry Reviewed-by: Brian Paul (v2) Reviewed-by: Marek Olšák (v2) --- src/mapi/glapi/gen/gl_API.xml | 104 + src/mesa/main/config.h | 9 ++ src/mesa/main/dd.h | 8 + src/mesa/main/extensions_table.h| 2

[Mesa-dev] [PATCH v3 2/5] gallium: add support for programmable sample locations

2018-06-01 Thread Rhys Perry
Signed-off-by: Rhys Perry Reviewed-by: Brian Paul (v2) Reviewed-by: Marek Olšák (v2) --- src/gallium/auxiliary/util/u_framebuffer.c | 30 + src/gallium/auxiliary/util/u_framebuffer.h | 5 +++ src/gallium/docs/source/context.rst | 14 src/galliu

[Mesa-dev] [PATCH v3 0/5] Implement ARB_sample_locations for nvc0

2018-06-01 Thread Rhys Perry
This patch set adds support for GL_ARB_sample_locations in mesa core, gallium, the mesa OpenGL state tracker and the nvc0 driver. Changes in v3: - Fix non-althabetical order of new extensions in extensions_table.h - Implement glEvaluateDepthValuesARB()/glResolveDepthValuesNV() - Stylistic changes

Re: [Mesa-dev] [PATCH] compiler/spirv: reject invalid shader code properly

2018-06-01 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Fri, Jun 1, 2018 at 5:27 AM, Martin Pelikán wrote: > After bebe3d626e5, b->fail_jump is prepared after vtn_create_builder > which can longjmp(3) to it through its vtx_assert()s. This corrupts > the stack and creates confusing core dumps, so we need to avoid it. >

Re: [Mesa-dev] [PATCH v4 054/129] nir,spirv: Rework function calls

2018-06-01 Thread Bas Nieuwenhuizen
On Fri, Jun 1, 2018 at 4:51 PM, Jason Ekstrand wrote: > Can you give me an exact CI test name? I ran exactly this branch through > our CI prior to sending it out and everything passed which is really weird > given that this is happening at a fairly high level in NIR. I think I have > some notion

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

2018-06-01 Thread Alex Smith
On 1 June 2018 at 15:48, Dylan Baker wrote: > Quoting Alex Smith (2018-05-31 08:44:18) > > With GFX9 merged shaders, active_stages would be set to the original > > stages specified if shaders were not cached, but to the stages still > > present after merging if they were. > > > > Be consistent an

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

2018-06-01 Thread Dylan Baker
Quoting Alex Smith (2018-05-31 08:44:18) > With GFX9 merged shaders, active_stages would be set to the original > stages specified if shaders were not cached, but to the stages still > present after merging if they were. > > Be consistent and use the original stages. > > Signed-off-by: Alex Smith

Re: [Mesa-dev] [PATCH] meson: only build vl_winsys_dri.c when x11 platform is used

2018-06-01 Thread Dylan Baker
Quoting Lukas Rusak (2018-06-01 00:20:10) > This seems to have been missed in the move from autotools > > This fixes the following build issue: > > ../src/gallium/auxiliary/vl/vl_winsys_dri.c:34:10: fatal error: > X11/Xlib-xcb.h: No such file or directory > #include > ^~~

Re: [Mesa-dev] [PATCH 06/16] docs: Add Sphinx configuration file.

2018-06-01 Thread Dylan Baker
Quoting Eric Engestrom (2018-06-01 02:41:36) > On Thursday, 2018-05-31 14:00:24 -0700, Dylan Baker wrote: > > Quoting Laura Ekstrand (2018-05-24 17:27:09) > > > From: Jean Hertel > > > > > > This tells Sphinx how to build our website from reStructured Text. > > > > > > Signed-off-by: Jean Hertel

[Mesa-dev] [PATCH] radv: fix a GPU hang when MRTs are sparse

2018-06-01 Thread Samuel Pitoiset
When the i-th target format is set, all previous target formats must be non-zero to avoid hangs. In other words, without this if a fragment shader exports mrt0, mrt2 and mrt3, the GPU hangs because the target format of mrt1 is zero. This fixes a GPU hang with "Seven: The Days Long Gone" with DXVK.

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

2018-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #5 from Bas Nieuwenhuizen --- To confirm, did you build your LLVM (32-bit is needed looks like?) with: BUILD_SHARED_LIBS=OFF LLVM_BUILD_LLVM_DYLIB=ON LLVM_LINK_LLVM_DYLIB=ON ? -- You are receiving this mail because: You are the a

[Mesa-dev] [Bug 106769] radv: Support VK_EXT_shader_viewport_index_layer and shaderStorageImageMultisample

2018-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106769 zefkerri...@gmail.com changed: What|Removed |Added CC||zefkerri...@gmail.com -- You ar

[Mesa-dev] [Bug 106769] radv: Support VK_EXT_shader_viewport_index_layer and shaderStorageImageMultisample

2018-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106769 --- Comment #2 from Philip Rebohle --- Ah right, my vulkaninfo returned info for the 18.0 version, sorry for the noise. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

[Mesa-dev] [Bug 106769] radv: Support VK_EXT_shader_viewport_index_layer and shaderStorageImageMultisample

2018-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106769 --- Comment #1 from Samuel Pitoiset --- VK_EXT_shader_viewport_index_layer is already supported. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

Re: [Mesa-dev] [PATCH v4 006/129] nir: Add helpers for working with deref instructions

2018-06-01 Thread Bas Nieuwenhuizen
On Fri, Jun 1, 2018 at 7:01 AM, Jason Ekstrand wrote: > This commit adds a pass for lowering deref instructions to deref chains > as well as some smaller helpers to ease the transition. > > Reviewed-by: Caio Marcelo de Oliveira Filho > --- > src/compiler/Makefile.sources | 1 + > src/compiler

[Mesa-dev] [Bug 106769] radv: Support VK_EXT_shader_viewport_index_layer and shaderStorageImageMultisample

2018-06-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106769 Bug ID: 106769 Summary: radv: Support VK_EXT_shader_viewport_index_layer and shaderStorageImageMultisample Product: Mesa Version: git Hardware: Other OS: A

Re: [Mesa-dev] [PATCH v4 054/129] nir,spirv: Rework function calls

2018-06-01 Thread Bas Nieuwenhuizen
Actually something post inlining that actually shows the problem: shader: MESA_SHADER_COMPUTE local-size: 1, 1, 1 shared-size: 1 inputs: 0 outputs: 0 uniforms: 0 shared: 0 decl_var uniform INTERP_MODE_NONE sampler2D @0 (0, 0, 0) decl_var uniform INTERP_MODE_NONE sampler @1 (0, 0, 1) decl_var syste

Re: [Mesa-dev] [PATCH v4 038/129] nir: Support deref instructions in opt_undef

2018-06-01 Thread Bas Nieuwenhuizen
On Fri, Jun 1, 2018 at 7:02 AM, Jason Ekstrand wrote: > Reviewed-by: Caio Marcelo de Oliveira Filho > --- > src/compiler/nir/nir_opt_undef.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/compiler/nir/nir_opt_undef.c > b/src/compiler/nir/nir_opt_undef.c > index b

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-06-01 Thread Daniel Stone
Hi, On 1 June 2018 at 11:23, Eric Engestrom wrote: > On Friday, 2018-06-01 11:16:29 +0100, Daniel Stone wrote: >> https://docs.gitlab.com/ee/user/project/pages/introduction.html >> > Be aware that Pages are by default branch/tag agnostic and their >> > deployment relies solely on what you specify

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-01 Thread Juan A. Suarez Romero
On Fri, 2018-06-01 at 11:23 +0100, Daniel Stone wrote: > Hi, > > On 1 June 2018 at 09:47, Juan A. Suarez Romero wrote: > > My question then: is mandatory to call eglSwapBuffers() to ensure > > wl_egl_window_get_attached_size() returns the right window size? Because I > > found nothing related abo

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-06-01 Thread Juan A. Suarez Romero
On Fri, 2018-06-01 at 10:57 +0100, Eric Engestrom wrote: > On Friday, 2018-06-01 09:43:48 +0200, Juan A. Suarez Romero wrote: > > On Thu, 2018-05-31 at 08:52 +0100, Daniel Stone wrote: > > > Hi Laura, > > > > > > On 30 May 2018 at 23:53, Laura Ekstrand wrote: > > > > @@ -0,0 +1,9 @@ > > > > +page

Re: [Mesa-dev] [PATCH v4 120/129] ac/nir: Remove deref chain support.

2018-06-01 Thread Bas Nieuwenhuizen
On Fri, Jun 1, 2018 at 7:07 AM, Jason Ekstrand wrote: > From: Bas Nieuwenhuizen > > --- > src/amd/common/ac_nir_to_llvm.c | 404 > +--- > 1 file changed, 50 insertions(+), 354 deletions(-) > > diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_n

Re: [Mesa-dev] [PATCH v4 054/129] nir,spirv: Rework function calls

2018-06-01 Thread Bas Nieuwenhuizen
The casts are not lowered away in some of the CTS tests for radv: shader: MESA_SHADER_COMPUTE local-size: 1, 1, 1 shared-size: 1 inputs: 0 outputs: 0 uniforms: 0 shared: 0 decl_var uniform INTERP_MODE_NONE sampler2D @0 (0, 0, 0) decl_var uniform INTERP_MODE_NONE sampler2D @1 (0, 0, 1) decl_var uni

Re: [Mesa-dev] [PATCH 00/53] intel/fs: SIMD32 support for fragment shaders

2018-06-01 Thread Eero Tamminen
Hi, On 30.05.2018 17:30, Jason Ekstrand wrote: On May 30, 2018 06:45:29 Eero Tamminen wrote: On 29.05.2018 18:58, Eero Tamminen wrote: On 25.05.2018 00:55, Jason Ekstrand wrote: This patch series adds back-end compiler support for SIMD32 fragment shaders.  Support is added and everything wor

Re: [Mesa-dev] [PATCH] glsl: Add ir_binop_vector_extract in NIR

2018-06-01 Thread Iago Toral
On Fri, 2018-06-01 at 12:26 +0200, Iago Toral wrote: > On Fri, 2018-06-01 at 11:25 +0200, Juan A. Suarez Romero wrote: > > On Wed, 2018-05-30 at 15:10 -0700, Eric Anholt wrote: > > > "Juan A. Suarez Romero" writes: > > > > > > > Implement ir_binop_vector_extract using NIR operations. Based > > >

Re: [Mesa-dev] [PATCH] glsl: Add ir_binop_vector_extract in NIR

2018-06-01 Thread Iago Toral
On Fri, 2018-06-01 at 11:25 +0200, Juan A. Suarez Romero wrote: > On Wed, 2018-05-30 at 15:10 -0700, Eric Anholt wrote: > > "Juan A. Suarez Romero" writes: > > > > > Implement ir_binop_vector_extract using NIR operations. Based on > > > SPIR-V > > > to NIR approach. > > > > > > This fixes: > > >

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-01 Thread Daniel Stone
Hi, On 1 June 2018 at 09:47, Juan A. Suarez Romero wrote: > My question then: is mandatory to call eglSwapBuffers() to ensure > wl_egl_window_get_attached_size() returns the right window size? Because I > found nothing related about this. If it is mandatory, then calling > eglSwapBuffers() in the

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-06-01 Thread Eric Engestrom
On Friday, 2018-06-01 11:16:29 +0100, Daniel Stone wrote: > On 1 June 2018 at 11:10, Eric Engestrom wrote: > > On Thursday, 2018-05-31 14:59:58 -0700, Jason Ekstrand wrote: > >> If you could deal with Daniel's feedback and v3 just this patch sooner > >> rather than later, that would be good. I'd

  1   2   >