[Mesa-dev] [Bug 106696] repeatable drm:amdgpu_job_timedout with vulkan toy

2018-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106696 Christian König changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW

[Mesa-dev] [PATCH] glcpp: Sync line number for macro

2018-05-28 Thread zhaowei yuan
Line number of a predefined macro should be set as where it is referenced rather than declared Signed-off-by: zhaowei yuan Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106590 --- src/compiler/glsl/glcpp/glcpp-lex.l | 1 + src/compiler/glsl/glcpp/glcpp-parse.y | 55 ++

Re: [Mesa-dev] [PATCH] compiler/spirv: reject invalid shader code properly

2018-05-28 Thread Jason Ekstrand
On Sun, May 13, 2018 at 9:01 AM, Martin Pelikán wrote: > After bebe3d626e5, b->fail_jump is prepared after vtn_create_builder > which can longjmp(3) to it through its vtx_assert()s. This corrupts > the stack and creates confusing core dumps, so we need to avoid it. > > While there, I decided to

Re: [Mesa-dev] [PATCH] egl/x11: Move dri2_format_for_depth prototype.

2018-05-28 Thread Marathe, Yogesh
Hi Vinson, Eric, > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Vinson Lee > Sent: Sunday, May 27, 2018 1:34 PM > To: Engestrom, Eric > Cc: Daniel Stone ; Emil Velikov > ; Eric Engestrom ; Marathe, > Yogesh ; ML mesa-dev d...@lists.fr

[Mesa-dev] [PATCH 8/8] glx/drisw: make the shm/non-shm loader extensions separately.

2018-05-28 Thread Dave Airlie
From: Dave Airlie I disliked removing the const here, function tables are meant to be const just to avoid having to think about them, make a second table for the shm vs non-shm paths to use. --- src/glx/drisw_glx.c | 32 1 file changed, 24 insertions(+), 8 deleti

[Mesa-dev] [PATCH 1/8] dri: add putImageShm and getImageShm to swrastLoader

2018-05-28 Thread Dave Airlie
From: Marc-André Lureau Add new API to put and get an image using shared memory. Instead of only passing the data pointer, 3 arguments are given: the shmid, the data offset and the shmaddr. Bump interface version. --- include/GL/internal/dri_interface.h | 20 +++- 1 file changed

[Mesa-dev] [PATCH 4/8] drisw/glx: use XShm if possible

2018-05-28 Thread Dave Airlie
From: Marc-André Lureau Implements putImageShm from DRIswrastLoaderExtension. If XShm extension is not available, or fails, it will fallback on regular XPutImage(). Tested on Linux only with 16bpp and 32bpp visual. (airlied: tested on 24bpp as well) --- src/glx/drisw_glx.c | 165

[Mesa-dev] [PATCH 7/8] drisw/glx: implement getImageShm

2018-05-28 Thread Dave Airlie
From: Marc-André Lureau --- src/glx/drisw_glx.c | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c index 641917361b8..3ff6a9617fc 100644 --- a/src/glx/drisw_glx.c +++ b/src/glx/drisw_glx.c @@ -313,6 +313,3

[Mesa-dev] [PATCH 5/8] drisw: learn to query shmid handle type

2018-05-28 Thread Dave Airlie
From: Marc-André Lureau --- src/gallium/include/state_tracker/drisw_api.h | 1 + src/gallium/include/state_tracker/sw_winsys.h | 3 +-- src/gallium/include/state_tracker/winsys_handle.h | 1 + src/gallium/winsys/sw/dri/dri_sw_winsys.c | 10 +- 4 files changed, 12 inser

[Mesa-dev] [PATCH 6/8] drisw: use getImageShm() if available

2018-05-28 Thread Dave Airlie
From: Marc-André Lureau --- src/gallium/state_trackers/dri/drisw.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/drisw.c b/src/gallium/state_trackers/dri/drisw.c index 40cbca54940..e24fcba3869 100644 --- a/src/gallium/

[Mesa-dev] [PATCH 3/8] drisw: use shared memory when possible

2018-05-28 Thread Dave Airlie
From: Marc-André Lureau If drisw_loader_funcs implements put_image_shm, allocates display target data with shared memory and display with put_image_shm(). --- src/gallium/winsys/sw/dri/dri_sw_winsys.c | 72 +++ 1 file changed, 60 insertions(+), 12 deletions(-) diff --git a/s

[Mesa-dev] [PATCH 2/8] drisw: use putImageShm if available

2018-05-28 Thread Dave Airlie
From: Marc-André Lureau If the DRIswrastLoaderExtension implements putImageShm, bind it to drisw_loader_funcs. --- src/gallium/include/state_tracker/drisw_api.h | 3 ++ src/gallium/state_trackers/dri/drisw.c| 37 +++ 2 files changed, 32 insertions(+), 8 deletions(-) dif

[Mesa-dev] drisw Xshm support

2018-05-28 Thread Dave Airlie
This is a rebased version of Marc-Andre's patches, I'll put my r-b on them but I thought it would be nice to have others have a look. The only difference are I added a patch on the end, and the interface version is now 4 instead of 3. I've also tested it works against an cirrus fbdev packed 24bpp

[Mesa-dev] gallium winsys handle rename (precursor to xshm patches)

2018-05-28 Thread Dave Airlie
I'd like to kick the xshm patches back into shape, and I've extracted this rename out of them first, as the new handle isn't really a DRM_API thing. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/lis

[Mesa-dev] [PATCH 2/2] gallium/winsys: rename DRM_API_HANDLE_* to WINSYS_HANDLE_*

2018-05-28 Thread Dave Airlie
From: Dave Airlie This just renames this as we want to add an shm handle which isn't really drm related. Originally by: Marc-André Lureau (airlied: I used this sed script instead) This was generated with: git grep -l 'DRM_API_' | xargs sed -i 's/DRM_API_/WINSYS_/g' --- src/gallium/auxiliary/r

[Mesa-dev] [PATCH 1/2] gallium: move winsys handle to it's own file.

2018-05-28 Thread Dave Airlie
From: Marc-André Lureau This will be used in the drisw interface later, which isn't drm specific. --- .../include/state_tracker/drm_driver.h| 49 +--- .../include/state_tracker/winsys_handle.h | 57 +++ 2 files changed, 59 insertions(+), 47 deletions(-) c

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix assertion failures with GL_UNSIGNED_INT64_ARB (v2)

2018-05-28 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin Thanks for tracking down why this wasn't working cleanly in the first place. This should make the NV int64 attrib extension much simpler. On Mon, May 28, 2018 at 9:10 PM, Marek Olšák wrote: > From: Marek Olšák > > Bindless texture handles can be passed via ve

[Mesa-dev] [PATCH 2/2] st/mesa: fix assertion failures with GL_UNSIGNED_INT64_ARB (v2)

2018-05-28 Thread Marek Olšák
From: Marek Olšák Bindless texture handles can be passed via vertex attribs using this type. They use the double codepath, so don't use st_pipe_vertex_format. Cc: 18.0 18.1 --- src/mesa/state_tracker/st_atom_array.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa

[Mesa-dev] [PATCH 1/2] mesa: handle GL_UNSIGNED_INT64_ARB properly (v2)

2018-05-28 Thread Marek Olšák
From: Marek Olšák Bindless texture handles can be passed via vertex attribs using this type. This fixes a bunch of bindless piglit tests on radeonsi. Cc: 18.0 18.1 --- src/mesa/main/glformats.c | 2 ++ src/mesa/vbo/vbo_private.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --

[Mesa-dev] [PATCH v2] nir/print: fix printing of 8/16 bit constant variables

2018-05-28 Thread Karol Herbst
v2 (Chema Casanova ): add float16 support Signed-off-by: Karol Herbst --- src/compiler/nir/nir_print.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c index 97b2d6164cd..bb2d4e52067 100644 --- a/src/

Re: [Mesa-dev] [PATCH 2/2] st/mesa: handle GL_UNSIGNED_INT64_ARB in st_pipe_vertex_format

2018-05-28 Thread Marek Olšák
On Mon, May 28, 2018 at 3:21 PM, Ilia Mirkin wrote: > On Mon, May 28, 2018 at 3:12 PM, Marek Olšák wrote: > > On Mon, May 28, 2018 at 3:05 PM, Ilia Mirkin > wrote: > >> > >> On Mon, May 28, 2018 at 2:48 PM, Marek Olšák wrote: > >> > On Mon, May 28, 2018 at 5:29 AM, Nicolai Hähnle > >> > wrote

[Mesa-dev] [Bug 106665] Account request for Mauro Rossi

2018-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106665 Kenneth Graunke changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@

[Mesa-dev] [Bug 106665] Account request for Mauro Rossi

2018-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106665 --- Comment #2 from Mauro Rossi --- >Preferred username: maurossi (also used on github) maurossi is now also used on gitlab -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

Re: [Mesa-dev] [PATCH v3] nv50/ir: add debug options for shader replacement

2018-05-28 Thread Ilia Mirkin
Hi Rhys, I really like this in general, but I have some feedback on the specific implementation: 1. The shader and its header can be closely related. Please integrate something that also loads/dumps the shader header (separate file). This should go into nvc0_program, as that's where the header is

Re: [Mesa-dev] [PATCH v2 4/5] nvc0: add support for programmable sample locations

2018-05-28 Thread Ilia Mirkin
ARB_sample_locaitons has all this stuff about a resolve of some sort when you switch around the locations. I don't see anything here about that. Thoughts? Also some more specific comments inline: On Thu, May 10, 2018 at 12:28 PM, Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > .../driver

Re: [Mesa-dev] [PATCH 2/2] st/mesa: handle GL_UNSIGNED_INT64_ARB in st_pipe_vertex_format

2018-05-28 Thread Ilia Mirkin
On Mon, May 28, 2018 at 3:12 PM, Marek Olšák wrote: > On Mon, May 28, 2018 at 3:05 PM, Ilia Mirkin wrote: >> >> On Mon, May 28, 2018 at 2:48 PM, Marek Olšák wrote: >> > On Mon, May 28, 2018 at 5:29 AM, Nicolai Hähnle >> > wrote: >> >> >> >> On 25.05.2018 23:03, Marek Olšák wrote: >> >>> >> >>>

Re: [Mesa-dev] [PATCH 2/2] st/mesa: handle GL_UNSIGNED_INT64_ARB in st_pipe_vertex_format

2018-05-28 Thread Marek Olšák
On Mon, May 28, 2018 at 3:05 PM, Ilia Mirkin wrote: > On Mon, May 28, 2018 at 2:48 PM, Marek Olšák wrote: > > On Mon, May 28, 2018 at 5:29 AM, Nicolai Hähnle > wrote: > >> > >> On 25.05.2018 23:03, Marek Olšák wrote: > >>> > >>> From: Marek Olšák > >>> > >>> Bindless texture handles can be pas

Re: [Mesa-dev] [PATCH 2/2] st/mesa: handle GL_UNSIGNED_INT64_ARB in st_pipe_vertex_format

2018-05-28 Thread Ilia Mirkin
On Mon, May 28, 2018 at 2:48 PM, Marek Olšák wrote: > On Mon, May 28, 2018 at 5:29 AM, Nicolai Hähnle wrote: >> >> On 25.05.2018 23:03, Marek Olšák wrote: >>> >>> From: Marek Olšák >>> >>> Bindless texture handles can be passed via vertex attribs using this >>> type. >>> This fixes a bunch of bi

Re: [Mesa-dev] [PATCH v2 32/53] intel/fs: Mark LINTERP opcode as writing accumulator on platforms without PLN

2018-05-28 Thread Francisco Jerez
Jason Ekstrand writes: > On Sat, May 26, 2018 at 6:33 PM, Francisco Jerez > wrote: > >> Jason Ekstrand writes: >> >> > On Sat, May 26, 2018 at 3:36 PM, Francisco Jerez >> > wrote: >> > >> >> Jason Ekstrand writes: >> >> >> >> > On Sat, May 26, 2018 at 2:03 PM, Francisco Jerez < >> curroje...@

Re: [Mesa-dev] [PATCH 2/2] st/mesa: handle GL_UNSIGNED_INT64_ARB in st_pipe_vertex_format

2018-05-28 Thread Marek Olšák
On Mon, May 28, 2018 at 5:29 AM, Nicolai Hähnle wrote: > On 25.05.2018 23:03, Marek Olšák wrote: > >> From: Marek Olšák >> >> Bindless texture handles can be passed via vertex attribs using this type. >> This fixes a bunch of bindless piglit tests on radeonsi. >> >> Cc: 18.0 18.1 >> --- >> sr

[Mesa-dev] [PATCH v2 33/53] intel/fs: Emit LINE+MAC for LINTERP with unaligned coordinates

2018-05-28 Thread Jason Ekstrand
On g4x through Sandy Bridge, src1 (the coordinates) of the PLN instruction is required to be an even register number. When it's odd (which can happen with SIMD32), we have to emit a LINE+MAC combination instead. Unfortunately, we can't just fall through to the gen4 case because the input register

Re: [Mesa-dev] [PATCH v2 32/53] intel/fs: Mark LINTERP opcode as writing accumulator on platforms without PLN

2018-05-28 Thread Jason Ekstrand
On Sat, May 26, 2018 at 6:33 PM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > On Sat, May 26, 2018 at 3:36 PM, Francisco Jerez > > wrote: > > > >> Jason Ekstrand writes: > >> > >> > On Sat, May 26, 2018 at 2:03 PM, Francisco Jerez < > curroje...@riseup.net> > >> > wrote: > >> > > >> >

[Mesa-dev] [Bug 106696] repeatable drm:amdgpu_job_timedout with vulkan toy

2018-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106696 --- Comment #2 from Dave Gilbert --- or actually the correct fix to my ray.comp is: --- a/ray.comp +++ b/ray.comp @@ -61,7 +61,7 @@ void main() { while (result <= 255.4 && !hitedge && !(hitx=hitend(pvp.x, ray.x, vsize.x)) &&

[Mesa-dev] [Bug 106696] repeatable drm:amdgpu_job_timedout with vulkan toy

2018-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106696 --- Comment #1 from Dave Gilbert --- I think there's a fair chance that it's actually getting stuck in the while loop in my ray.comp (which may well be a screwup on my part); but even so taking out everything in a non-rebootable way is a bit of

[Mesa-dev] [Bug 106696] repeatable drm:amdgpu_job_timedout with vulkan toy

2018-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106696 Bug ID: 106696 Summary: repeatable drm:amdgpu_job_timedout with vulkan toy Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severit

[Mesa-dev] [PATCH] nv30: add a couple of missed shader caps

2018-05-28 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nv30/nv30_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c b/src/gallium/drivers/nouveau/nv30/nv30_screen.c index a24176a8e94..bf561be576a 100644 --- a/src/gallium/drivers/nouv

[Mesa-dev] [PATCH] nv30: ensure that displayable formats are marked accordingly

2018-05-28 Thread Ilia Mirkin
Fixes: f7604d8af52 ("st/dri: only expose config formats that are display targets") Cc: "18.1" Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nv30/nv30_format.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv30/nv30_format

[Mesa-dev] [Bug 106687] radv: Fast color clears use incorrect format

2018-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106687 Bug ID: 106687 Summary: radv: Fast color clears use incorrect format Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH] mesa: add display listy support for glPatchParameter{i, fv}()

2018-05-28 Thread Timothy Arceri
This is required for tessellation shader Compat profile support. --- src/mesa/main/dlist.c | 78 +++ 1 file changed, 78 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index 8be223559ab..4fc451000b5 100644 --- a/src/mesa/main/dlist.

Re: [Mesa-dev] [PATCH] radv: Implement alternate GFX9 scissor workaround.

2018-05-28 Thread Nicolai Hähnle
On 28.05.2018 12:21, Bas Nieuwenhuizen wrote: On Mon, May 28, 2018 at 12:19 PM, Nicolai Hähnle wrote: On 27.05.2018 18:57, Bas Nieuwenhuizen wrote: This improves dota2 performance for me by 11% when I force the GPU DPM level to low (otherwise dota2 is CPU limited for 4k on my threadripper), w

Re: [Mesa-dev] [PATCH 3/3] radv: emit shader descriptor pointers consecutively

2018-05-28 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Fri, May 25, 2018 at 2:59 PM, Samuel Pitoiset wrote: > This reduces the number of SET_SH_REG packets which are emitted > for applications that use more than one descriptor set per stage. > > We should be able to emit more SET_SH_REG packets cons

Re: [Mesa-dev] [PATCH] radv: Implement alternate GFX9 scissor workaround.

2018-05-28 Thread Bas Nieuwenhuizen
On Mon, May 28, 2018 at 12:19 PM, Nicolai Hähnle wrote: > On 27.05.2018 18:57, Bas Nieuwenhuizen wrote: >> >> This improves dota2 performance for me by 11% when I force the >> GPU DPM level to low (otherwise dota2 is CPU limited for 4k on my >> threadripper), which should be a large part of the ra

Re: [Mesa-dev] [PATCH] radv: Implement alternate GFX9 scissor workaround.

2018-05-28 Thread Nicolai Hähnle
On 27.05.2018 18:57, Bas Nieuwenhuizen wrote: This improves dota2 performance for me by 11% when I force the GPU DPM level to low (otherwise dota2 is CPU limited for 4k on my threadripper), which should be a large part of the radv-amdvlk gap. (For me with that was radv 60.3 -> 66.6, while AMDVLK

Re: [Mesa-dev] [PATCH] radv: Implement alternate GFX9 scissor workaround.

2018-05-28 Thread Samuel Pitoiset
Nice find! Though, we can now remove the checks in radv_CmdSetScissor/radv_CmdSetViewport because they were added to reduce the number of flushes. With that, patch is: Reviewed-by: Samuel Pitoiset On 05/27/2018 06:57 PM, Bas Nieuwenhuizen wrote: This improves dota2 performance for me by 1

Re: [Mesa-dev] Gitlab migration

2018-05-28 Thread Nicolai Hähnle
On 27.05.2018 18:03, Marek Olšák wrote: On Sun, May 27, 2018 at 10:47 AM, Jason Ekstrand > wrote: On May 26, 2018 21:03:39 Marek Olšák mailto:mar...@gmail.com>> wrote: On Sat, May 26, 2018 at 11:13 AM, Jason Ekstrand mailto:ja...@jlekstrand.net>> wrote:

Re: [Mesa-dev] [PATCH 2/2] st/mesa: handle GL_UNSIGNED_INT64_ARB in st_pipe_vertex_format

2018-05-28 Thread Nicolai Hähnle
On 25.05.2018 23:03, Marek Olšák wrote: From: Marek Olšák Bindless texture handles can be passed via vertex attribs using this type. This fixes a bunch of bindless piglit tests on radeonsi. Cc: 18.0 18.1 --- src/mesa/state_tracker/st_atom_array.c | 3 +++ 1 file changed, 3 insertions(+) d

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_KHR_draw_indirect_count.

2018-05-28 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 05/26/2018 11:10 PM, Bas Nieuwenhuizen wrote: Literally the same as the AMD ext. Passes *indirect_draw_count* CTS tests. --- src/amd/vulkan/radv_cmd_buffer.c | 49 +++ src/amd/vulkan/radv_extensions.py | 1 + 2 files changed, 50

[Mesa-dev] [PATCH] radeonsi: set GLC on stores to write-only memory

2018-05-28 Thread Nicolai Hähnle
From: Nicolai Hähnle The only effect this has is that written cache lines are immediately freed in L1$. We're not going to read the data again, so it's better to leave room for other things in the cache. --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 12 +++- 1 file changed, 11

[Mesa-dev] [Bug 106677] vmwgfx: atom (electron-based app) causes corruption, hangs

2018-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106677 --- Comment #1 from David Cuthbert --- NB: I'm not sure if this belongs in the Mesa or DRI queue; neither has an exact match for the vmwgfx component. In any case, I'm referring to this tree: https://cgit.freedesktop.org/mesa/vmwgfx/ -- You ar

[Mesa-dev] [Bug 106677] vmwgfx: atom (electron-based app) causes corruption, hangs

2018-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106677 Bug ID: 106677 Summary: vmwgfx: atom (electron-based app) causes corruption, hangs Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)