Re: [Mesa-dev] [PATCH] nir/linker: Add nir_link_uniforms()

2018-04-29 Thread Alejandro Piñeiro
On 29/04/18 12:09, Timothy Arceri wrote: > On 29/04/18 19:05, Alejandro Piñeiro wrote: >> On 29/04/18 10:13, Timothy Arceri wrote: >>> On 29/04/18 16:48, Alejandro Piñeiro wrote: From: Eduardo Lima Mitev This function will be the entry point for linking the uniforms from the ni

Re: [Mesa-dev] [PATCH] dri3: Only update number of back buffers in loader_dri3_get_buffers

2018-04-29 Thread Sergii Romantsov
Hello, with my simple tests it works, but have some remarks (but don't have much experience with dri3): 1. It looks little dangerous to move logic of destroying buffers and seems in your version we are loosing some logic with 'busy' and 'num_back' 2. And also looks like buffers just will not be de

[Mesa-dev] [PATCH 3/3] anv: Plug in VK_EXT_hdr_metadata

2018-04-29 Thread Tapani Pälli
From: Ville Syrjälä The common wsi stuff for VK_EXT_hdr_metadata is in place, and we shouldn't need any hardware specifics, so let's expose the extension. Signed-off-by: Ville Syrjälä --- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_wsi.c | 9 + 2 files change

[Mesa-dev] [PATCH 2/3] vulkan/wsi: VK_EXT_hdr_metadata plumbing

2018-04-29 Thread Tapani Pälli
From: Ville Syrjälä Add the common wsi infrastructure for VK_EXT_hdr_metadata. Signed-off-by: Ville Syrjälä Signed-off-by: Tapani Pälli --- src/vulkan/wsi/wsi_common.c | 12 src/vulkan/wsi/wsi_common.h | 5 + src/vulkan/wsi/wsi_common_private.h | 2 ++ 3 fil

[Mesa-dev] [PATCH 0/3] common bits from HDR POC

2018-04-29 Thread Tapani Pälli
Hi; I took Ville's HDR POC Mesa patches, fixed some issues and removed all Wayland specific parts. Here are the bits that could be already integrated, rest will be window system specific parts. // Tapani Tapani Pälli (1): egl: implement EXT_surface_SMPTE2086_metadata and EXT_surface_CTA86

[Mesa-dev] [PATCH 1/3] egl: implement EXT_surface_SMPTE2086_metadata and EXT_surface_CTA861_3_metadata

2018-04-29 Thread Tapani Pälli
Patch implements common bits for EXT_surface_SMPTE2086_metadata and EXT_surface_CTA861_3_metadata extensions by adding new required attributes and eglQuerySurface + eglSurfaceAttrib changes. Currently none of the drivers are utilizing this data but this patch is enabler in getting there. Followin

Re: [Mesa-dev] [PATCH v3 00/13] TGSI: improved live range tracking, also including arrays

2018-04-29 Thread Gert Wollny
[...] > > $R600_DEBUG=merge ST_DEBUG=tgsi ./run wollny/ > > ATTENTION: default value of option > allow_glsl_extension_directive_midshader overridden by environment. > run: state_tracker/st_glsl_to_tgsi.cpp:5783: ureg_dst > dst_register(st_translate*, gl_register_file, unsigned int, unsigned > in

[Mesa-dev] [Bug 106246] radv: VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT and bringing down initial pipeline compile times

2018-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106246 --- Comment #7 from Timothy Arceri --- (In reply to Timothy Arceri from comment #6) > (In reply to Timothy Arceri from comment #4) > > (In reply to Nicolai Hähnle from comment #3) > > > As long as scratch buffer support is robust, removing LLVM

[Mesa-dev] [PATCH] ac/nir: expand 64-bit vec3 loads to fix shuffling.

2018-04-29 Thread Dave Airlie
From: Dave Airlie If loading 64-bit vec3 values, a 4 component load would be followed by a 2 component load and the resulting shuffle would fail as it requires 2 4 components. This just expands the second results vector out to 4 components. This fixes 100 CTS tests: dEQP-VK.spirv_assembly.type.v

[Mesa-dev] [Bug 106246] radv: VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT and bringing down initial pipeline compile times

2018-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106246 --- Comment #6 from Timothy Arceri --- (In reply to Timothy Arceri from comment #4) > (In reply to Nicolai Hähnle from comment #3) > > As long as scratch buffer support is robust, removing LLVM IR optimization > > passes is probably not a proble

Re: [Mesa-dev] [PATCH v3 00/13] TGSI: improved live range tracking, also including arrays

2018-04-29 Thread Benedikt Schemmer
Am 29.04.2018 um 21:44 schrieb Gert Wollny: > Hello Benedict, > > thanks for all the testing! thanks for all the developing ;) > > On 29.04.2018 12:12, Benedikt Schemmer wrote: >>> Which are the names of these test? I'd like to check this on r600, >>> because here I didn't see any regressions

[Mesa-dev] [Bug 106315] The witness + dxvk suffers flickering garbage

2018-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106315 Bug ID: 106315 Summary: The witness + dxvk suffers flickering garbage Product: Mesa Version: git Hardware: Other OS: Linux (All) Status: NEW Severity: no

Re: [Mesa-dev] [PATCH v3 00/13] TGSI: improved live range tracking, also including arrays

2018-04-29 Thread Gert Wollny
Hello Benedict, thanks for all the testing! On 29.04.2018 12:12, Benedikt Schemmer wrote: >> Which are the names of these test? I'd like to check this on r600, >> because here I didn't see any regressions last time I checked. >> > might of course be different on r600 (is bindless available?), >

[Mesa-dev] [Bug 106283] Shader replacements works only for limited use cases

2018-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106283 --- Comment #6 from Mark Janes --- FrameRetrace supports gl shader replacement. I'll enhance it to support glProgramString. It will be easier to debug shaders with FrameRetrace than using the environment variables. https://fosdem.org/2018/sch

[Mesa-dev] [Bug 106180] [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2)

2018-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106180 --- Comment #5 from mercuriete --- Hi I tried that patch on top of mesa-18.1.0_rc2 it fixes some issues with resizing windows and with alt+tab in csgo+opengl But it does not fix this problem. * vulkan smoketest on intel haswell is OK (now doe

Re: [Mesa-dev] [PATCH v3 00/13] TGSI: improved live range tracking, also including arrays

2018-04-29 Thread Benedikt Schemmer
sorry the last one wasnt correct: register merge vs yours Max Increase: SGPRS: 80 -> 96 (20.00 %) (in shaders/deusex_mankind/7c39f71090a9db19ac2e1542ea12804ae6c6495b_4864.shader_test) VGPRS: 64 -> 84 (31.25 %) (in shaders/dirtrally/0859b69789591d7046e211400b1edd9a7cfca734_742.shader_test) Spil

Re: [Mesa-dev] [PATCH v3 00/13] TGSI: improved live range tracking, also including arrays

2018-04-29 Thread Benedikt Schemmer
Real world (old vs new) nothing vs register merge: PERCENTAGE DELTASShaders SGPRs VGPRs SpillSGPR SpillVGPR PrivVGPR Scratch CodeSize MaxWaves Waits 0ad6 . . . . . . . . . aer

Re: [Mesa-dev] [PATCH v3 00/13] TGSI: improved live range tracking, also including arrays

2018-04-29 Thread Benedikt Schemmer
Am 29.04.2018 um 11:34 schrieb Gert Wollny: > Am Sonntag, den 29.04.2018, 10:43 +0200 schrieb Benedikt Schemmer: >> Hi Gert, >> >> couldn't resist at least to try what would happen if I enable >> register merge for radeonsi: >> >> PERCENTAGE DELTASShaders SGPRs VGPRs SpillSGPR >> Spi

Re: [Mesa-dev] [PATCH] nir/linker: Add nir_link_uniforms()

2018-04-29 Thread Timothy Arceri
On 29/04/18 19:05, Alejandro Piñeiro wrote: On 29/04/18 10:13, Timothy Arceri wrote: On 29/04/18 16:48, Alejandro Piñeiro wrote: From: Eduardo Lima Mitev This function will be the entry point for linking the uniforms from the nir_shader objects associated with the gl_linked_shaders of a progr

Re: [Mesa-dev] [PATCH v3 00/13] TGSI: improved live range tracking, also including arrays

2018-04-29 Thread Gert Wollny
Am Sonntag, den 29.04.2018, 10:43 +0200 schrieb Benedikt Schemmer: > Hi Gert, > > couldn't resist at least to try what would happen if I enable > register merge for radeonsi: > > PERCENTAGE DELTASShaders SGPRs VGPRs SpillSGPR > SpillVGPR PrivVGPR Scratch CodeSize MaxWaves Wa

Re: [Mesa-dev] [PATCH] nir/linker: Add nir_link_uniforms()

2018-04-29 Thread Alejandro Piñeiro
On 29/04/18 10:13, Timothy Arceri wrote: > > > On 29/04/18 16:48, Alejandro Piñeiro wrote: >> From: Eduardo Lima Mitev >> >> This function will be the entry point for linking the uniforms from >> the nir_shader objects associated with the gl_linked_shaders of a >> program. >> >> This patch include

Re: [Mesa-dev] [PATCH v3 00/13] TGSI: improved live range tracking, also including arrays

2018-04-29 Thread Benedikt Schemmer
Hi Gert, couldn't resist at least to try what would happen if I enable register merge for radeonsi: PERCENTAGE DELTASShaders SGPRs VGPRs SpillSGPR SpillVGPR PrivVGPR Scratch CodeSize MaxWaves Waits piglit 80732 -0.16 % -0.02 % . .0.

Re: [Mesa-dev] [PATCH 15/22] nir/linker: Set the uniform initial values

2018-04-29 Thread Timothy Arceri
This too should be moved to src/compiler/glsl/ somewhere. On 18/04/18 00:36, Alejandro Piñeiro wrote: From: Neil Roberts This is based on link_uniform_initializers.cpp. --- src/compiler/Makefile.sources| 1 + src/compiler/nir/meson.build | 1 + s

Re: [Mesa-dev] [PATCH 17/22] nir/linker: Add nir_build_program_resource_list()

2018-04-29 Thread Timothy Arceri
Again this should be moved to src/compiler/glsl/ somewhere. On 18/04/18 00:36, Alejandro Piñeiro wrote: From: Eduardo Lima Mitev This function is equivalent to the compiler/glsl build_program_resource_list() but will extract the resources from NIR shaders instead. For now, only uniforms and p

Re: [Mesa-dev] [PATCH] nir/linker: Add nir_link_uniforms()

2018-04-29 Thread Timothy Arceri
On 29/04/18 16:48, Alejandro Piñeiro wrote: From: Eduardo Lima Mitev This function will be the entry point for linking the uniforms from the nir_shader objects associated with the gl_linked_shaders of a program. This patch includes initial support for linking uniforms from NIR shaders. It is

Re: [Mesa-dev] [PATCH v3 00/13] TGSI: improved live range tracking, also including arrays

2018-04-29 Thread Gert Wollny
Hello Benedikt, Am Sonntag, den 29.04.2018, 00:06 +0200 schrieb Benedikt Schemmer: > Hi Gert > > Am 28.04.2018 um 23:51 schrieb Gert Wollny: > > Am Samstag, den 28.04.2018, 22:43 +0200 schrieb Benedikt Schemmer: > > > The patches apply cleanly, however I just did a shader-db test > > > run > > >