Hello Benedikt, Am Sonntag, den 29.04.2018, 00:06 +0200 schrieb Benedikt Schemmer: > Hi Gert > > Am 28.04.2018 um 23:51 schrieb Gert Wollny: > > Am Samstag, den 28.04.2018, 22:43 +0200 schrieb Benedikt Schemmer: > > > The patches apply cleanly, however I just did a shader-db test > > > run > > > and can't find a difference with your patch > > > applied, am I doing something wrong? > > > > AFAIK radeonsi doesn't use the register-merge optimizer in TGSI. > > > > Ah, ok. Was wondering why your debug code doesn't output anything. > Makes sense now ;) Not exactly, the reason there is no output is because -DNDEBUG is set. Without it the statistics should also be printed out on radeonsi, but thinking of it I should probably disable it when register_merge is not accessed, because without this the numbers will be inflated and don't have much meaning.
> So is this useless on radeonsi? Indeed. > Seemed interesting to me. :) it certainly helps on r600 > > > compile times went up though: > > > > This is strange, because "see above". Did you compile with debug > > information and c++11 or higher enables? ... > > > > > not intentionally: Then you should actually not run any code that this series adds to mesa. I checked again, apart from the debugging output nothing will ever be run if a drivers that report PIPE_SHADER_CAP_TGSI_SKIP_MERGE_REGISTERS != 0 (as does radeonsi). Best, Gert _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
