Re: [Mesa-dev] [PATCH] ac/nir: call glsl_get_sampler_dim() only once, where possible

Tested-by: Dieter Nützel radeonsi | + NIR and vulkan Am 20.01.2018 10:15, schrieb Kai Wasserbäch: Signed-off-by: Kai Wasserbäch --- Hey, if you accept this patch, please commit it for me – I do not have commit access. Thanks, Kai src/amd/common/ac_nir_to_llvm.c | 15 +-- 1

Re: [Mesa-dev] [PATCH v2 08/24] anv/cmd_buffer: Recurse in transition_color_buffer instead of falling through

On Sun, Jan 21, 2018 at 11:28 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Jan 19, 2018 at 03:47:25PM -0800, Jason Ekstrand wrote: > > Reviewed-by: Topi Pohjolainen > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 17 - > > 1 file changed, 8 insertions(+),

[Mesa-dev] [PATCH 1/2] ac: fix gs load inputs type

This fixes the scenario where the input is a struct. With this the Unreal engines Elemental demo now works on radeonsi. --- src/amd/common/ac_nir_to_llvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c ind

[Mesa-dev] [PATCH 2/2] ac: remove unused nir2llvmtype()

The last use of this was removed in the previous patch. --- src/amd/common/ac_nir_to_llvm.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 1b4b877205..52c1f9ee20 100644 --- a/src/amd/common/ac_nir_t

Re: [Mesa-dev] [PATCH v2 08/24] anv/cmd_buffer: Recurse in transition_color_buffer instead of falling through

On Fri, Jan 19, 2018 at 03:47:25PM -0800, Jason Ekstrand wrote: > Reviewed-by: Topi Pohjolainen > --- > src/intel/vulkan/genX_cmd_buffer.c | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/vulkan/genX_cmd_

Re: [Mesa-dev] [PATCH v2 06/24] anv/image: Add a helper for determining when fast clears are supported

On Sun, Jan 21, 2018 at 11:16 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Jan 19, 2018 at 03:47:23PM -0800, Jason Ekstrand wrote: > > v2 (Jason Ekstrand): > > - Return an enum instead of a boolean > > > > Reviewed-by: Topi Pohjolainen > > --- > > src/intel/vulkan/anv_im

Re: [Mesa-dev] [PATCH] mesa: Only require independent blending for GLES 3.2.

On 01/22/2018 08:48 AM, Ilia Mirkin wrote: What es3 does require, though, is mrt. Maybe add something that ensures that mrt is supported? I guess that would be EXT_draw_buffers? That is currently enabled with 'dummy_true'. On Jan 19, 2018 08:39, "Eric Anholt" > wro

Re: [Mesa-dev] [PATCH v2 06/24] anv/image: Add a helper for determining when fast clears are supported

On Fri, Jan 19, 2018 at 03:47:23PM -0800, Jason Ekstrand wrote: > v2 (Jason Ekstrand): > - Return an enum instead of a boolean > > Reviewed-by: Topi Pohjolainen > --- > src/intel/vulkan/anv_image.c | 70 > ++ > src/intel/vulkan/anv_private.h | 13 +

[Mesa-dev] [PATCH] ac/nir/radeonsi: add ARB_shader_ballot support

--- src/amd/common/ac_nir_to_llvm.c | 38 src/gallium/drivers/radeonsi/si_shader_nir.c | 9 +++ 2 files changed, 47 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index eabdc83f16..2c9b85bf82 100644 --- a

Re: [Mesa-dev] [PATCH 1/1] nir: Use a freelist in nir_opt_dce to avoid spamming ralloc

Thomas Helland writes: > Also, allocate worklist_elem in groups of 20, to reduce the burden of > allocation. Do not use rzalloc, as there is no need. This lets us drop > the number of calls to ralloc from aproximately 10% of all calls to > ralloc(130 000 calls), down to a mere 2000 calls to ra

[Mesa-dev] [PATCH 1/2] i965/bufmgr: Add a create_from_prime_tiled function

This new function is an import and a set tiling in one go. --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 41 ++ src/mesa/drivers/dri/i965/brw_bufmgr.h | 4 2 files changed, 36 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b

Re: [Mesa-dev] [PATCH] mesa: enable ASTC/ETC1 compressed textures

"Juan A. Suarez Romero" writes: > Enable these kind of texture when proper extensions are available. In the subject, s/textures/3D textures/ since it's surprising to hear that they're not supported yet :) > Fixes KHR-GLES2.texture_3d.* with these textures. > --- > src/mesa/main/teximage.c | 26

[Mesa-dev] [PATCH] ac/nir: add ARB_shader_group_vote support

--- src/amd/common/ac_nir_to_llvm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index ac3a949bd3..eabdc83f16 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@ -4454,6 +445

[Mesa-dev] [PATCH 3/6] radv: Fix freeing meta state if the device pipeline cache fails to allocate.

CC: --- src/amd/vulkan/radv_device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 152ae7e7ae..b5ae103239 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -1196,13 +1196,15 @@

Re: [Mesa-dev] [PATCH] mesa: enable ASTC/ETC1 compressed textures

On 01/19/2018 12:44 PM, Juan A. Suarez Romero wrote: Anyone could take a look at this patch? Can you pinpoint where the mentioned tests are located, which suite? Thanks in advance! J.A. On Thu, 2018-01-11 at 16:35 +0100, Juan A. Suarez Romero wrote: Enable these kind of texture

Re: [Mesa-dev] [PATCH] i965: make brw_context::num_samples unsigned int

Fair enough. I wasn't sure what you meant. Reviewed-by: Jason Ekstrand On January 21, 2018 08:02:44 Emil Velikov wrote: On 19 January 2018 at 16:17, Jason Ekstrand wrote: Why? I think it's probably fine but changing signedness of a variable is always a bit tricky. As said in the commi

[Mesa-dev] [PATCH 1/6] radv: Fix ordering issue in meta memory allocation failure path.

CC: --- src/amd/vulkan/radv_meta.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_meta.c b/src/amd/vulkan/radv_meta.c index e13fa928db..f022247097 100644 --- a/src/amd/vulkan/radv_meta.c +++ b/src/amd/vulkan/radv_meta.c @@ -379,9 +379,9 @@ fail_resolve

[Mesa-dev] [PATCH 6/6] radv: Init variant entry with memset.

This gets memcpy'd and written driectly, and due to alignment, this resulted in uninitialized gaps. This makes those gaps go away. CC: --- src/amd/vulkan/radv_pipeline_cache.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_pipeline_cache.c b/src/amd/vulkan/radv_pipeline

Re: [Mesa-dev] [PATCH] i965: make brw_context::num_samples unsigned int

On 19 January 2018 at 16:17, Jason Ekstrand wrote: > Why? I think it's probably fine but changing signedness of a variable is > always a bit tricky. > As said in the commit message - all the call sites already consider it as unsigned. Quick grep shows: brw_state_upload.c: const unsigned fb_sa

[Mesa-dev] [PATCH 2/2] i965: Set tiling on BOs imported with modifiers

We need this to ensure that GTT maps work on buffers we get from Vulkan on the off chance that someone does a readpixels or something. Soon, we will be removing GTT maps from i965 entirely and this can be reverted. None the less, it's needed for stable. Cc: mesa-sta...@lists.freedesktop.org Cc: K

[Mesa-dev] [Bug 104654] r600/sb: Alien Isolation GPU lock

https://bugs.freedesktop.org/show_bug.cgi?id=104654 --- Comment #6 from Gert Wollny --- The proposed patch is actually useless. Given the way the games provides saves I didn't initially test it with the specific scene that had the lockup, and I didn't see any further lockups so far. However, goin

[Mesa-dev] [PATCH 5/6] radv: Fix bufimage failure deallocation.

The inidividual init parts don't clean up their own stuff on failure. CC: --- src/amd/vulkan/radv_meta_bufimage.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_meta_bufimage.c b/src/amd/vulkan/radv_meta_bufimage.c index 5bcc1e62db..adf610a933

[Mesa-dev] [PATCH] radv: Don't allow 3d or 1d depth/stencil textures.

addrlib asserts when that happens, and supporting it is not required so lets not allow this for now. It also assert on fmask, but we don't have the number of samples here. CC: --- src/amd/vulkan/radv_formats.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_formats.c

[Mesa-dev] [PATCH 4/6] radv: Fix fragment resolve init memory allocation failure paths.

CC: --- src/amd/vulkan/radv_meta_resolve_fs.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/amd/vulkan/radv_meta_resolve_fs.c b/src/amd/vulkan/radv_meta_resolve_fs.c index 99314d94e5..08c9282bf0 100644 --- a/src/amd/vulkan/radv_meta_resolve_fs.c +++ b/src

[Mesa-dev] [Bug 104553] mat4: m[i][j] incorrect result with row_major UBO

https://bugs.freedesktop.org/show_bug.cgi?id=104553 florian.w...@googlemail.com changed: What|Removed |Added Attachment #136630|0 |1 is obsolete|

[Mesa-dev] [PATCH] radeonsi/nir: fix fs output index

Fixes the following piglit tests: arb_blend_func_extended-fbo-extended-blend arb_blend_func_extended-fbo-extended-blend-explicit arb_blend_func_extended-fbo-extended-blend-explicit_gles3 arb_blend_func_extended-fbo-extended-blend-pattern arb_blend_func_extended-fbo-extended-blend-pattern_gles2 arb

Re: [Mesa-dev] Logging infrastructure?

On Thursday, January 18, 2018 1:44:47 PM PST Chuck Atkins wrote: > Is there a logging infrastructure currently available to drivers in Mesa? > I was looking to clean up some of swr's debug / info output and have it > conditional on the MESA_DEBUG and LIBGL_DEBUG variables but then I realized > that

Re: [Mesa-dev] [PATCH] broadcom/vc5: Fix source file name.

Vinson Lee writes: > Fixes: c9b2cb78972d ("vc5: add missing files to the tarball") > Signed-off-by: Vinson Lee Reviewed and pushed these two. Thanks! (Also, we need to get automake's distcheck into Travis. I would have caught this before pushing, if so). signature.asc Description: PGP sign

Re: [Mesa-dev] [PATCH] i965: Don't try to disable render buffers for compute

On Tuesday, January 16, 2018 5:31:23 AM PST Topi Pohjolainen wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104546 > CC: xinghua@intel.com > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_draw.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions

[Mesa-dev] [PATCH 2/6] radv: Fix memory allocation failure path in compute resolve init.

CC: --- src/amd/vulkan/radv_meta_resolve_cs.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_meta_resolve_cs.c b/src/amd/vulkan/radv_meta_resolve_cs.c index 5b3bc89832..519e2a5f42 100644 --- a/src/amd/vulkan/radv_meta_resolve_cs.c +++ b/src/am

Re: [Mesa-dev] [PATCH] mesa: Only require independent blending for GLES 3.2.

What es3 does require, though, is mrt. Maybe add something that ensures that mrt is supported? On Jan 19, 2018 08:39, "Eric Anholt" wrote: > We've been requiring this since GLES 3.0 was introduced, but the GLES 3.2 > spec is the one that has "Supporting blending on a per-draw-buffer basis" > in

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #58 from ta...@outlook.com --- I can confirm this has been fixed for me, I was experiencing the browser crashes explained in 104376. -- You are receiving this mail because: You are the QA Contact for the bug.

Re: [Mesa-dev] [PATCH] etnaviv: dirty TS state when framebuffer has changed

2018-01-11 11:29 GMT+01:00 Lucas Stach : > When switching between framebuffers with and without TS, the TS state > needs to be flushed to the command stream even if the derived state > isn't changed. > > Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etna

Re: [Mesa-dev] [PATCH 3/4] mesa: Move compute_num_levels from st_gen_mipmap.c to mipmap.c.

Reviewed-by: Marek Olšák Marek On Thu, Jan 18, 2018 at 10:31 AM, Kenneth Graunke wrote: > I want to use compute_num_levels inside i965. Rather than duplicating > it, move it from mesa/st to core Mesa, and make it non-static. > --- > src/mesa/main/mipmap.c | 24

[Mesa-dev] [Bug 104654] r600/sb: Alien Isolation GPU lock

https://bugs.freedesktop.org/show_bug.cgi?id=104654 --- Comment #5 from Gert Wollny --- Created attachment 136871 --> https://bugs.freedesktop.org/attachment.cgi?id=136871&action=edit dmesg after reboot shoing the GPU lockups -- You are receiving this mail because: You are the QA Contact for

Re: [Mesa-dev] [PATCH v2 1/4] meson: fix BSD build

On 01/19/2018 16:30, Eric Engestrom wrote: On Wednesday, 2018-01-17 23:54:15 +0300, Greg V wrote: Reviewed-by: Dylan Baker A couple questions and a nit-pick for the error messages, but with that: Reviewed-by: Eric Engestrom @@ -225,7 +227,7 @@ with_platform_surfaceless = false egl_native

[Mesa-dev] [PATCH 10/21] anv/entrypoints: Add a LAYERS helper variable

--- src/intel/vulkan/anv_entrypoints_gen.py | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 1c3fda8..6c922b8 100644 --- a/src/intel/vulkan/anv_entrypoints_gen.py +++