[Mesa-dev] [PATCH v2 20/20] ac: rework ac_llvm_extract_elem()

Simplifies the logic a little and asserts index is 0. Suggested-by: Nicolai Hähnle --- src/amd/common/ac_llvm_build.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index faa08b6301c..a31f225e177 100644 --

[Mesa-dev] [PATCH v2 14/20] ac/radeonsi: add load_tess_coord() to the abi

Reviewed-by: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 20 +-- src/amd/common/ac_shader_abi.h | 4 +++ src/gallium/drivers/radeonsi/si_shader.c | 42 +++- 3 files changed, 42 insertions(+), 24 deletions(-) diff --git a/src/am

[Mesa-dev] [PATCH v2 16/20] gallium/tgsi: add patch support to tgsi_get_gl_varying_semantic()

Reviewed-by: Nicolai Hähnle --- src/gallium/auxiliary/tgsi/tgsi_from_mesa.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_from_mesa.c b/src/gallium/auxiliary/tgsi/tgsi_from_mesa.c index c014115918e..659156b5190 100644 --- a/src/ga

[Mesa-dev] [PATCH v2 18/20] radeonsi: add si_load_tess_level() helper

This will be shared by the tgsi and nir backends. Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeons

[Mesa-dev] [PATCH v2 15/20] radeonsi: add dummy implementation of si_nir_scan_tess_ctrl()

Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.h| 3 +++ src/gallium/drivers/radeonsi/si_shader_nir.c| 19 +++ src/gallium/drivers/radeonsi/si_state_shaders.c | 1 + 3 files changed, 23 insertions(+) diff --git a/src/gallium/drivers/radeonsi/

[Mesa-dev] [PATCH v2 13/20] radeonsi: make si_llvm_emit_tcs_epilogue compatible with emit_outputs abi

Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 4823da7a763..04dae8edd13 100644 --- a/src/gallium/driv

[Mesa-dev] [PATCH v2 17/20] st/glsl_to_nir/radeonsi: enable tessellation shaders

Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader_nir.c | 2 ++ src/mesa/state_tracker/st_glsl_to_nir.cpp| 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c in

[Mesa-dev] [PATCH v2 19/20] ac: add load_tess_level() to the abi

Fixes the following piglit tests in radeonsi: vs-tcs-tes-tessinner-tessouter-inputs-quads.shader_test vs-tcs-tes-tessinner-tessouter-inputs-tris.shader_test vs-tes-tessinner-tessouter-inputs-quads.shader_test vs-tes-tessinner-tessouter-inputs-tris.shader_test Reviewed-by: Nicolai Hähnle --- src

[Mesa-dev] [PATCH v2 12/20] radeonsi/nir: gather tess properties

Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader_nir.c | 29 1 file changed, 29 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 4138e04dcb5..d2760b03bca 100644 --- a/s

[Mesa-dev] [PATCH v2 10/20] radeonsi: add unpack_llvm_param() helper

This allows us to pass the llvm param directly rather than looking it up. Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drive

[Mesa-dev] [PATCH v2 09/20] ac: add {tcs,tes}_patch_id to the abi

Reviewed-by: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 22 +++--- src/amd/common/ac_shader_abi.h| 2 ++ src/gallium/drivers/radeonsi/si_shader.c | 17 - src/gallium/drivers/radeonsi/si_shader_internal.h |

[Mesa-dev] [PATCH v2 11/20] ac/radeonsi: add tcs_rel_ids to the abi

Reviewed-by: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 15 +++ src/amd/common/ac_shader_abi.h| 1 + src/gallium/drivers/radeonsi/si_shader.c | 19 ++- src/gallium/drivers/radeonsi/si_shader_internal.h | 1 - 4

[Mesa-dev] [PATCH v2 08/20] radeonsi: add nir support for tcs outputs

Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 124 +++ 1 file changed, 124 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index c5ca699ac00..a8f425b50ee 100644 --- a/src/gall

[Mesa-dev] [PATCH v2 03/20] ac: call load_tcs_input() via the abi

This also enables some code sharing with tes. V2: drop type param and just use ctx->i32 --- src/amd/common/ac_nir_to_llvm.c | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH v2 01/20] radeonsi: add si_nir_load_input_tes()

V2: drop type param and just use ctx->i32 --- src/gallium/drivers/radeonsi/si_shader.c | 48 +++ src/gallium/drivers/radeonsi/si_shader_internal.h | 11 ++ 2 files changed, 59 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drive

[Mesa-dev] [PATCH v2 04/20] radeonsi: add get_dw_address_from_generic_indices() helper

This will be used by both the tgsi and nir backends. Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 76 +++- 1 file changed, 46 insertions(+), 30 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/rad

[Mesa-dev] [PATCH v2 02/20] ac: add load_tes_inputs() to the abi

V2: drop type param and just use ctx->i32 --- src/amd/common/ac_nir_to_llvm.c | 62 src/amd/common/ac_shader_abi.h | 11 ++ src/gallium/drivers/radeonsi/si_shader.c | 1 + 3 files changed, 52 insertions(+), 22 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH v2 06/20] ac: add store_tcs_outputs() to the abi

Reviewed-by: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 63 + src/amd/common/ac_shader_abi.h | 12 2 files changed, 51 insertions(+), 24 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index f

[Mesa-dev] [PATCH v2 05/20] radeonsi: add si_nir_load_input_tcs()

V2: drop type param and just use ctx->i32 --- src/gallium/drivers/radeonsi/si_shader.c | 45 1 file changed, 45 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 5ef95589c2a..c5ca699ac00 100644 --

[Mesa-dev] [PATCH v2 07/20] ac: move some helpers to ac_llvm_build.c

We will call these from the radeonsi NIR backend. Reviewed-by: Nicolai Hähnle --- src/amd/common/ac_llvm_build.c | 24 + src/amd/common/ac_llvm_build.h | 8 ++ src/amd/common/ac_nir_to_llvm.c | 58 + 3 files changed, 50 insertions(+)

Re: [Mesa-dev] [PATCH 3/3] i965: if DEBUG_OUT_OF_BOUND_CHK is up, check that noise padding for each bo used in batchbuffer is correct

Hi, Just got confirmation that kernel does the syncing required to make sure that pread values are realiable. -Kevin -Original Message- From: Rogovin, Kevin Sent: Wednesday, December 13, 2017 8:19 AM To: 'Jason Ekstrand' Cc: mesa-dev@lists.freedesktop.org; Lahtinen, Joonas Subject:

Re: [Mesa-dev] [PATCH 3/3] i965: if DEBUG_OUT_OF_BOUND_CHK is up, check that noise padding for each bo used in batchbuffer is correct

Hi, > I think you want to do this at the end of submit_batch instead and add a > brw_bo_wait_rendering on the batch.  > Otherwise, your bounds checking is racing with the GPU. I remember being told that pread has the kernel do the required waiting, however I am not 100% sure of this (which is

Re: [Mesa-dev] [PATCH 2/3] i965: add noise padding to buffer object and function to check if noise is correct

Hi, Thankyou for reading the code and giving advice to improve upon it. Below are some thoughts: > I can't help but think that this could be a bit simpler and involve throwing > fewer pointers around. I was thinking this too; the easiest way to do this is to just have the same noise for all

Re: [Mesa-dev] [PATCH] program: Don't reset SamplersValidated when restoring from shader cache

Reviewed-by: Timothy Arceri On 13/12/17 09:20, Jordan Justen wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103988 Signed-off-by: Jordan Justen --- src/mesa/program/ir_to_mesa.cpp | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/mesa/pr

Re: [Mesa-dev] [PATCH 4/4] meson: build clover

On Tue, 2017-12-12 at 12:08 -0800, Francisco Jerez wrote: > Dylan Baker writes: > > > This has only been compile tested. > > > > cc: Curro Jerez > > Signed-off-by: Dylan Baker > > --- > > include/meson.build | 19 > > meson.build

Re: [Mesa-dev] [PATCH] gallium/docs: document behavior of set_sample_mask()

Am 13.12.2017 um 04:34 schrieb Brian Paul: > The sample mask is used even if msaa is not explicity enabled when we > have a framebuffer with multisampled surfaces. That's DX behavior and > what the Radeon drivers do. Not sure about other drivers at this point. > --- > src/gallium/docs/source/con

Re: [Mesa-dev] [PATCH 2/2] gallivm: fix an issue with NaNs with seamless cube filtering

On Tue, Dec 12, 2017 at 7:34 PM, wrote: > From: Roland Scheidegger > > Cube texture wrapping is a bit special since the values (post face > projection) always are within [0,1], so we took advantage of that and > omitted some clamps. > However, we can still get NaNs (either because the coords alr

[Mesa-dev] [PATCH] gallium/docs: document behavior of set_sample_mask()

The sample mask is used even if msaa is not explicity enabled when we have a framebuffer with multisampled surfaces. That's DX behavior and what the Radeon drivers do. Not sure about other drivers at this point. --- src/gallium/docs/source/context.rst | 5 - 1 file changed, 4 insertions(+),

[Mesa-dev] [PATCH 1/2] gallivm: implement accurate corner behavior for textureGather with cube maps

From: Roland Scheidegger The spec says the missing texel (when we wrap around both x and y axis) should be synthesized as the average of the 3 other texels. For bilinear filtering however we instead adjusted the filter weights (because, while the complexity looks similar, there would be 4 times a

[Mesa-dev] [PATCH 2/2] gallivm: fix an issue with NaNs with seamless cube filtering

From: Roland Scheidegger Cube texture wrapping is a bit special since the values (post face projection) always are within [0,1], so we took advantage of that and omitted some clamps. However, we can still get NaNs (either because the coords already had NaNs, or the face projection generated them)

[Mesa-dev] [Bug 101223] Mesa fails to build with clang

https://bugs.freedesktop.org/show_bug.cgi?id=101223 Mike Lothian changed: What|Removed |Added Resolution|--- |INVALID CC|

[Mesa-dev] [PATCH 2/4] intel/decoder: Convert the iterator to work entirely in bits

--- src/intel/common/gen_decoder.c | 17 - src/intel/common/gen_decoder.h | 4 +--- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 9f4f503..de4c506 100644 --- a/src/intel/common/gen_decoder.c ++

[Mesa-dev] [PATCH 1/4] intel/decoder: Drop gen_field_decode helper

It's unused --- src/intel/common/gen_decoder.c | 8 src/intel/common/gen_decoder.h | 3 --- 2 files changed, 11 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index b3501ae..9f4f503 100644 --- a/src/intel/common/gen_decoder.c +++ b/src/intel/com

[Mesa-dev] [PATCH 4/4] intel/decoder: Take a bit offset in gen_print_group

Previously, if a group was nested in another group such that it didn't start on a dword boundary, we would decode it as if it started at the start of its first dword. This changes things to work even more in terms of bits so that we can properly decode these structs. This affects MOCS, attribute

[Mesa-dev] [PATCH 3/4] intel/decoder: Stop rounding down to the nearest dword

--- src/intel/common/gen_decoder.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index de4c506..59c76ea 100644 --- a/src/intel/common/gen_decoder.c +++ b/src/intel/common/gen_decoder.c @

Re: [Mesa-dev] [PATCH] meson: fix glx-test race

Dylan Baker writes: > This test should rely on dispatch.h being generated, but it doesn't. Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailm

[Mesa-dev] [PATCH] radeonsi: don't use fast color clear for small images even on APUs

From: Marek Olšák Increase the limit and handle non-square images better. This makes glxgears 20% faster on APUs, and a little more on dGPUs. We all use and love glxgears. --- src/gallium/drivers/radeonsi/si_clear.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH] swr: Fix KNOB_MAX_WORKER_THREADS thread creation override.

Environment variable KNOB_MAX_WORKER_THREADS allows the user to override default thread creation and thread binding. Previous commit to adjust linux cpu topology caused setting this KNOB to bind all threads to a single core. This patch restores correct functionality of override. Cc: --- src/ga

Re: [Mesa-dev] [PATCH 4/4] meson: build clover

Quoting Jan Vesely (2017-12-12 15:00:28) > I can try to give it a go before my travels start on Thursday. Dylan, > are there any prerequisites to this series? > > Jan > Just meson 0.44.0, which came out Sunday. Dylan signature.asc Description: signature ___

Re: [Mesa-dev] [PATCH 4/4] meson: build clover

On Tue, 2017-12-12 at 12:08 -0800, Francisco Jerez wrote: > Dylan Baker writes: > > > This has only been compile tested. > > > > cc: Curro Jerez > > Signed-off-by: Dylan Baker > > --- > > include/meson.build | 19 > > meson.build

[Mesa-dev] [Bug 104233] [needs triage] Crashes XWayland when moving mouse fastly on GNOME application overview

https://bugs.freedesktop.org/show_bug.cgi?id=104233 --- Comment #1 from f4954...@opayq.com --- Note if it is not mesa, which is causing this, I am sorry. Just blindly guessing here… Any tip would be very much appreciated. -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 104233] [needs triage] Crashes XWayland when moving mouse fastly on GNOME application overview

https://bugs.freedesktop.org/show_bug.cgi?id=104233 Bug ID: 104233 Summary: [needs triage] Crashes XWayland when moving mouse fastly on GNOME application overview Product: Mesa Version: 17.2 Hardware: Other

Re: [Mesa-dev] [PATCH] mesa: Add glSpecializeShaderARB to common_desktop_functions

I fixed the copy and pasta for idr that included the r-b tag (I copied and pasted from the git log), and added the bugzilla entry that Vinson opened locally. Quoting Dylan Baker (2017-12-12 11:50:30) > CC: Nicolai Hähnle > CC: Reviewed-by: Ian Romanick > CC: Mark Janes > Fixes: 46b21b8f906 ("me

[Mesa-dev] [PATCH] program: Don't reset SamplersValidated when restoring from shader cache

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103988 Signed-off-by: Jordan Justen --- src/mesa/program/ir_to_mesa.cpp | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index 5f663b3d09f..

[Mesa-dev] [PATCH 3/3] radeonsi: don't call force_dcc_off for buffers

From: Marek Olšák This was undefined yet harmless behavior in LLVM. Not anymore - it causes a hang now. Cc: 17.3 --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c b/src/ga

[Mesa-dev] [PATCH 2/3] radeonsi: set PNT_SPRITE_ENA = point_quad_rasterization

From: Marek Olšák This is based on how nvc0 translates the state. --- src/gallium/drivers/radeonsi/si_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 5c4c383..7cf3896 100644 --- a

[Mesa-dev] [PATCH 1/3] gallium/util: add util_num_layers helper

From: Marek Olšák --- src/gallium/auxiliary/util/u_blitter.c| 4 ++-- src/gallium/auxiliary/util/u_gen_mipmap.c | 4 ++-- src/gallium/auxiliary/util/u_inlines.h| 8 +++- src/gallium/drivers/r600/r600_texture.c | 8 src/gallium/drivers/radeon/r600_texture.c | 8 sr

[Mesa-dev] [Bug 104231] DispatchSanity_test.GL30 regression

https://bugs.freedesktop.org/show_bug.cgi?id=104231 --- Comment #1 from Dylan Baker --- I submitted a patch for this already: https://patchwork.freedesktop.org/patch/192994/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 0/3] GEM BO padding to find OOB buffer writes

I really like this in principal. I left comments on patches 2 and 3 which I think make things better. My comments on 2 are a bit on the bikeshed side, but I think reasonable. On Fri, Dec 8, 2017 at 2:54 AM, wrote: > From: Kevin Rogovin > > This patch series adds a new debug option to pad each

Re: [Mesa-dev] [PATCH 3/3] i965: if DEBUG_OUT_OF_BOUND_CHK is up, check that noise padding for each bo used in batchbuffer is correct

On Fri, Dec 8, 2017 at 2:54 AM, wrote: > From: Kevin Rogovin > > Signed-off-by: Kevin Rogovin > --- > src/mesa/drivers/dri/i965/intel_batchbuffer.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c > b/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH] radv: Don't advertise VK_EXT_debug_report.

We never supported it. Missed during copy and pasting. Fixes: 17201a2eb0b "radv: port to using updated anv entrypoint/extension generator." --- src/amd/vulkan/radv_extensions.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/amd/vulkan/radv_extensions.py b/src/amd/vulkan/radv_extensions

[Mesa-dev] [Bug 104231] DispatchSanity_test.GL30 regression

https://bugs.freedesktop.org/show_bug.cgi?id=104231 Bug ID: 104231 Summary: DispatchSanity_test.GL30 regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All Status: NEW Keywords: regression

Re: [Mesa-dev] [PATCH 2/2] i965: compute scratch space size correctly for Gen9

On Tuesday, December 12, 2017 12:19:16 PM PST Rogovin, Kevin wrote: > Glad that this helped. The main lead for fixing the bug I got from > using the patch series posted earlier this week " GEM BO padding to > find OOB buffer writes" (URL: > https://lists.freedesktop.org/archives/mesa-dev/2017-Decem

Re: [Mesa-dev] [PATCH 2/3] i965: add noise padding to buffer object and function to check if noise is correct

I can't help but think that this could be a bit simpler and involve throwing fewer pointers around. On Fri, Dec 8, 2017 at 2:54 AM, wrote: > From: Kevin Rogovin > > Signed-off-by: Kevin Rogovin > --- > src/mesa/drivers/dri/i965/brw_bufmgr.c | 68 > +- > src/mes

Re: [Mesa-dev] [PATCH 4/4] meson: build clover

Dylan Baker writes: > This has only been compile tested. > > cc: Curro Jerez > Signed-off-by: Dylan Baker > --- > include/meson.build | 19 > meson.build | 27 +- > meson_options.txt | 12 +++ >

Re: [Mesa-dev] [PATCH 2/2] i965: compute scratch space size correctly for Gen9

Glad that this helped. The main lead for fixing the bug I got from using the patch series posted earlier this week " GEM BO padding to find OOB buffer writes" (URL: https://lists.freedesktop.org/archives/mesa-dev/2017-December/179658.html). I am hoping that that patch series can get reviewed an

Re: [Mesa-dev] [PATCH mesa] meson: add dep_thread to every lib that includes threads.h

Quoting Emil Velikov (2017-12-12 07:04:09) > On 11 December 2017 at 22:22, Dylan Baker wrote: > > Quoting Emil Velikov (2017-12-11 12:06:35) > >> On 7 December 2017 at 17:25, Dylan Baker wrote: > >> > Quoting Emil Velikov (2017-12-07 08:40:27) > >> >> On 7 December 2017 at 14:51, Eric Engestrom

Re: [Mesa-dev] [PATCH] intel/fs/bank_conflicts: Don't touch Gen7 MRF hack registers.

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/4] meson: set opencl flags for r600

Quoting Eric Engestrom (2017-12-12 06:15:58) > On Monday, 2017-12-11 11:50:01 -0800, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-12-11 07:55:30) > > > On Friday, 2017-12-08 16:27:21 -0800, Dylan Baker wrote: > > > > Signed-off-by: Dylan Baker > > > > > > Should come after the current 4/4,

[Mesa-dev] [PATCH] mesa: Add glSpecializeShaderARB to common_desktop_functions

CC: Nicolai Hähnle CC: Reviewed-by: Ian Romanick CC: Mark Janes Fixes: 46b21b8f906 ("mesa: add GL_ARB_gl_spirv boilerplate") Signed-off-by: Dylan Baker --- src/mesa/main/tests/dispatch_sanity.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/

[Mesa-dev] [PATCH] intel/fs/bank_conflicts: Don't touch Gen7 MRF hack registers.

Fixes: af2c320190f3c731 "intel/fs: Implement GRF bank conflict mitigation pass." Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104199 Reported-by: Darius Spitznagel --- src/intel/compiler/brw_fs.cpp| 2 +- src/intel/compiler/brw_fs.h | 2 +- src/intel/c

[Mesa-dev] [Bug 104229] radeon_icd.i686.json api_version is 1.0.3

https://bugs.freedesktop.org/show_bug.cgi?id=104229 Bug ID: 104229 Summary: radeon_icd.i686.json api_version is 1.0.3 Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 4/4] amd/common: add ac_build_waitcnt()

Reviewed-by: Bas Nieuwenhuizen for the series. On Tue, Dec 12, 2017 at 6:10 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_llvm_build.c| 9 + > src/amd/common/ac_llvm_build.h| 2 ++ > src/amd/common/ac_ni

Re: [Mesa-dev] [PATCH 2/2] i965: compute scratch space size correctly for Gen9

On Tuesday, December 12, 2017 4:17:27 AM PST kevin.rogo...@intel.com wrote: > From: Kevin Rogovin > > Signed-off-by: Kevin Rogovin > --- > src/mesa/drivers/dri/i965/brw_program.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_program

[Mesa-dev] [PATCH] meson: fix glx-test race

This test should rely on dispatch.h being generated, but it doesn't. Signed-off-by: Dylan Baker --- src/glx/tests/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/tests/meson.build b/src/glx/tests/meson.build index d81b76906da..51b2843fc90 100644 --- a/src/

Re: [Mesa-dev] [PATCH 1/2] gallium/util: add u_transfer_helper

Rob Clark writes: > Add a new helper that drivers can use to emulate various things that > need special handling in particular in transfer_map: > > 1) z32_s8x24.. gl/gallium treats this as a single buffer with depth > and stencil interleaved but hardware frequently treats this as > separ

Re: [Mesa-dev] [PATCH] mesa: remove second include of errors.h in src/mesa/main/glspirv.c

Hey Ian, Ian Romanick wrote on 12.12.2017 17:56: > Weird that this was not noticed before... *shrug* > > Reviewed-by: Ian Romanick thank you very much for the R-b! Can you push this for me? I don't have commit access. Cheers, Kai > On 12/12/2017 07:20 AM, Kai Wasserbäch wrote: >> Cc: Nicolai

[Mesa-dev] [PATCH 1/2] gallium/util: add u_transfer_helper

Add a new helper that drivers can use to emulate various things that need special handling in particular in transfer_map: 1) z32_s8x24.. gl/gallium treats this as a single buffer with depth and stencil interleaved but hardware frequently treats this as separate z32 and s8 buffers. Specia

[Mesa-dev] [PATCH 4/4] amd/common: add ac_build_waitcnt()

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c| 9 + src/amd/common/ac_llvm_build.h| 2 ++ src/amd/common/ac_nir_to_llvm.c | 14 ++ src/gallium/drivers/radeonsi/si_shader.c | 13 ++-

[Mesa-dev] [PATCH 1/4] radeonsi: make use of ac_build_fdiv()

And move the comment to amd/common. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c| 1 + src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 8 +--- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/

[Mesa-dev] [PATCH 3/4] amd/common: more use of i32_1

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 799ba83e89..189421cc4a 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/

[Mesa-dev] [PATCH 2/4] amd/common: more use of i32_0

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 663b27d265..799ba83e89 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

[Mesa-dev] [PATCH] radv: export SampleMask from pixel shaders at full rate

Use 16_ABGR instead of 32_ABGR if Z isn't written. Ported from RadeonSI. No CTS regressions on Polaris. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 65 ++--- src/amd/vulkan/radv_pipeline.c | 29 ++ 2 files changed, 7

Re: [Mesa-dev] [PATCH 4/4] mesa: enable GL_EXT_disjoint_timer_query extension

On 11/19/2017 11:18 PM, Tapani Pälli wrote: > Add GL_GPU_DISJOINT_EXT and enable extension when ARB_timer_query > is supported by the driver. > > Following dEQP cases pass: >dEQP-EGL.functional.get_proc_address.extension.gl_ext_disjoint_timer_query >dEQP-EGL.functional.client_extensions.di

Re: [Mesa-dev] [PATCH] mesa: remove second include of errors.h in src/mesa/main/glspirv.c

Weird that this was not noticed before... *shrug* Reviewed-by: Ian Romanick On 12/12/2017 07:20 AM, Kai Wasserbäch wrote: > Cc: Nicolai Hähnle > Fixes: 5bc03d2508 ("mesa: implement SPIR-V loading in glShaderBinary") > Signed-off-by: Kai Wasserbäch > --- > src/mesa/main/glspirv.c | 4 > 1

Re: [Mesa-dev] Gallium ARB_get_program_binary support

Game works fine, not sure if it's using the extension or not On Mon, 11 Dec 2017 at 23:21 Mike Lothian wrote: > I'll check that when I'm next home > > On Mon, 11 Dec 2017 at 21:19 Timothy Arceri wrote: > >> On 12/12/17 08:13, Mike Lothian wrote: >> > Tested with Dead Island, Dirt Rally and Seri

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] i965/bufmgr: Add a helper to mark a BO as external

On Tue, Dec 12, 2017 at 5:42 AM, Emil Velikov wrote: > On 11 December 2017 at 22:03, Jason Ekstrand wrote: > > On Mon, Dec 11, 2017 at 12:08 PM, Emil Velikov > > > wrote: > >> > >> On 21 November 2017 at 00:13, Andres Gomez wrote: > >> > Jason, this nominated series landed without mentioning a

[Mesa-dev] [PATCH] mesa: remove second include of errors.h in src/mesa/main/glspirv.c

Cc: Nicolai Hähnle Fixes: 5bc03d2508 ("mesa: implement SPIR-V loading in glShaderBinary") Signed-off-by: Kai Wasserbäch --- src/mesa/main/glspirv.c | 4 1 file changed, 4 deletions(-) diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c index 7eb8f906c2..81303057d0 100644 --- a/s

Re: [Mesa-dev] [PATCH mesa] meson: add dep_thread to every lib that includes threads.h

On 11 December 2017 at 22:22, Dylan Baker wrote: > Quoting Emil Velikov (2017-12-11 12:06:35) >> On 7 December 2017 at 17:25, Dylan Baker wrote: >> > Quoting Emil Velikov (2017-12-07 08:40:27) >> >> On 7 December 2017 at 14:51, Eric Engestrom >> >> wrote: >> >> > Bugzilla: https://bugs.freedesk

Re: [Mesa-dev] [PATCH 2/8] spirv: Add a prepass to set types on vtn_values

On Thu, Dec 7, 2017 at 10:12 AM, Jason Ekstrand wrote: > This autogenerated pass will automatically find and set the type field > on all vtn_values. This way we always have the type and can use it for > validation and other checks. > --- > src/compiler/Makefile.nir.am | 4 + > src/

Re: [Mesa-dev] [PATCH 2/3] glx: Lift sending the MakeCurrent request to top-level code (v2)

On 6 December 2017 at 19:25, Adam Jackson wrote: > On Wed, 2017-12-06 at 15:14 +, Emil Velikov wrote: > >> > - if (gc->vtable->bind(gc, oldGC, draw, read) != Success) { >> > + if (gc->vtable->bind(gc, gc, draw, read) != Success) { >> > __glXSetCurrentContextNull(); >> >> Th

[Mesa-dev] [PATCH 1/2] gallium/util: add u_transfer_helper

Add a new helper that drivers can use to emulate various things that need special handling in particular in transfer_map: 1) z32_s8x24.. gl/gallium treats this as a single buffer with depth and stencil interleaved but hardware frequently treats this as separate z32 and s8 buffers. Specia

Re: [Mesa-dev] [PATCH 1/3] glx: Move vertex array protocol state into the indirect backend (v2)

On 6 December 2017 at 18:12, Adam Jackson wrote: > On Wed, 2017-12-06 at 14:50 +, Emil Velikov wrote: > >> > + * have setup the context, as it needs to query server attributes. >> > + * >> > + * At the point this is called gc->currentDpy is not initialized >> > + * nor

Re: [Mesa-dev] [PATCH 0/4] enable GL_EXT_disjoint_timer_query

Hey Tapani, We had a bit of a discussion on IRC about the patch 2. Our per context timestamps are 36bits long and so roughly loop around every 90minutes on gen9. i965 already knows how to handle the counter wrapping around 36bits. And since there is no way to measure a more than ~90minutes delt

Re: [Mesa-dev] [PATCH 3/4] meson: set opencl flags for r600

On Monday, 2017-12-11 11:50:01 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2017-12-11 07:55:30) > > On Friday, 2017-12-08 16:27:21 -0800, Dylan Baker wrote: > > > Signed-off-by: Dylan Baker > > > > Should come after the current 4/4, but > > Reviewed-by: Eric Engestrom > > > > > --- > >

[Mesa-dev] [PATCH v4 06/10] mesa/st/glsl_to_tgsi: Add tracking of ifelse writes in register merging

Improve the life-time evaluation of temporary registers by also tracking writes in both if and else branches and in up to 32 nested scopes. As a result the estimated required register life-times can be further reduced enabling more registers to be merged. Signed-off-by: Gert Wollny --- .../state

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] i965/bufmgr: Add a helper to mark a BO as external

On 11 December 2017 at 22:03, Jason Ekstrand wrote: > On Mon, Dec 11, 2017 at 12:08 PM, Emil Velikov > wrote: >> >> On 21 November 2017 at 00:13, Andres Gomez wrote: >> > Jason, this nominated series landed without mentioning any specific >> > stable queue. >> > >> > From what I'm seeing, both d

[Mesa-dev] [PATCH v4 09/10] mesa/st/tests: Add tests for lifetime tracking with indirect addressing

Add a code line type that accepts one layer of indirect addressing and add tests to check that temporary register access used for indirect addressing is accounted for in the lifetime estimation. Signed-off-by: Gert Wollny --- src/mesa/state_tracker/tests/st_tests_common.cpp | 95 +++

[Mesa-dev] [PATCH v4 10/10] mesa/st/glsl_to_tgsi: remove now unneeded assert.

With the implementation of the tracking of the registers used in reladdr asserting that a driver calling merge_register() uses the address register is no longer needed. Signed-off-by: Gert Wollny --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/sr

[Mesa-dev] [PATCH v4 08/10] mesa/st/glsl_to_tgsi: Add tracking of indirect addressing registers

So far indirect addressing was not tracked to estimate the temporary life time, and it was not needed, because code to load the address registers was always emitted eliminating the reladdr* handles in the past glsl-to.tgsi stages. Now, with Mareks patch allowing any 1D register to be used for addre

[Mesa-dev] [PATCH v4 07/10] mesa/st/tests: Add tests for improved tracking of temporaries

Additional teste are added that check the tracking of access to temporaries in if-else branches. Signed-off-by: Gert Wollny --- .../tests/test_glsl_to_tgsi_lifetime.cpp | 493 - 1 file changed, 486 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/t

[Mesa-dev] [PATCH v4 05/10] mesa/st/tests: cleanup whitespace usage and correct some comments

Signed-off-by: Gert Wollny --- .../tests/test_glsl_to_tgsi_lifetime.cpp | 127 ++--- 1 file changed, 63 insertions(+), 64 deletions(-) diff --git a/src/mesa/state_tracker/tests/test_glsl_to_tgsi_lifetime.cpp b/src/mesa/state_tracker/tests/test_glsl_to_tgsi_lifetime.cpp

[Mesa-dev] [PATCH v4 04/10] mesa/st/tests: unify MockCodeLine* classes

* Merge the classes MockCodeLine and MockCodelineWithSwizzle into one, and refactor tests accordingly. * Change memory allocations to use ralloc* interface. v4: * move the test classes into a conveniance library * rename the Mock* classes to Fake* since they are not really Mocks * Bas

[Mesa-dev] [PATCH v4 01/10] mesa/program: Add missing file types to _mesa_register_file_name

This is useful for debugging in glsl_to_tgsi. Signed-off-by: Gert Wollny --- src/mesa/program/prog_print.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/mesa/program/prog_print.c b/src/mesa/program/prog_print.c index 9462510f3a..b273bbf4c8 100644 ---

[Mesa-dev] [PATCH v4 03/10] mesa/st/tests: Fix zero-byte allocation leaks

Don't allocate a zero-sized array, when no texture offsets are given. Reviewed-by: Nicolai Hähnle Signed-off-by: Gert Wollny --- .../tests/test_glsl_to_tgsi_lifetime.cpp | 23 +++--- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/

[Mesa-dev] [PATCH v4 02/10] mesa/st/glsl_to_tgsi: Add some operators for glsl_to_tgsi related classes

Add the equal operator and the "<<" stream write operator for the st_*_reg classes and the "<<" operator to the instruction class, and make use of these operators in the debugging output. Signed-off-by: Gert Wollny --- src/mesa/state_tracker/st_glsl_to_tgsi_private.cpp | 168

[Mesa-dev] [PATCH v3 00/10] glsl_to_tgsi: Further improvement of lifetime tracking for register merge

Dear all, this is another update to the patch set that adds enhanced tracking of IF/ELSE branches and tracking of reladdr* registers for the register_merge step. It cleans up the debugging output and moves the testing classes into a conveniance library. The latter is in preparation for another

Re: [Mesa-dev] [PATCH 0/2] i965: scratch space fixes (v2)

Hi, Tested-by: Eero Tamminen Fixes GPU hangs I'm seeing also with the *GL* version of CarChase on KBL GT3e (when using Ubuntu 16.04 kernel). - Eero On 12.12.2017 14:17, kevin.rogo...@intel.com wrote: From: Kevin Rogovin This patch series offers a readability improvement for progr

Re: [Mesa-dev] [PATCH 1/2] intel/fs: Implement GRF bank conflict mitigation pass.

Hi, On 11.12.2017 12:28, Eero Tamminen wrote: Thanks for finally having this handled in Mesa! This patch series, live intervals and "Don't let undefined values prevent copy propagation" commits help performance in following tests: * GfxBench CarChase (2% by live intervals) That was on SKL G

[Mesa-dev] [PATCH 2/2] i965: compute scratch space size correctly for Gen9

From: Kevin Rogovin Signed-off-by: Kevin Rogovin --- src/mesa/drivers/dri/i965/brw_program.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_program.c b/src/mesa/drivers/dri/i965/brw_program.c index 6aa4100..1ae0aa0 100644 --- a/src/mesa/d

  1   2   >